--- doc/loncapafiles/ntpcheck.piml	2011/05/31 11:27:24	1.12
+++ doc/loncapafiles/ntpcheck.piml	2018/06/19 12:26:32	1.33
@@ -3,7 +3,7 @@
 <!-- ntpcheck.piml -->
 <!-- Matthew Hall -->
 
-<!-- $Id: ntpcheck.piml,v 1.12 2011/05/31 11:27:24 raeburn Exp $ -->
+<!-- $Id: ntpcheck.piml,v 1.33 2018/06/19 12:26:32 raeburn Exp $ -->
 
 <!--
 
@@ -38,34 +38,80 @@ http://www.lon-capa.org/
 print "Checking to be sure the Network Time Protocol is running properly.\n";
 print "For more information on ntpd please see http://www.ntp.org/\n";
 my $NTPD;
-if (-e "/etc/init.d/ntpd") {
-   $NTPD = "ntpd";
-} elsif (-e "/etc/init.d/xntpd") {
-   $NTPD = "xntpd";
-} elsif (-e "/etc/init.d/ntp") {
-   $NTPD = "ntp"; 
+my $checkcmd = 'ps -ef |grep ntp |grep -v grep |grep -v ntpcheck';
+my $startntpcmd;
+my $is_running;
+if (('<DIST />' eq 'fedora15')    || ('<DIST />' eq 'fedora16') ||
+    ('<DIST />' eq 'fedora17')    || ('<DIST />' eq 'fedora18') ||
+    ('<DIST />' eq 'fedora19')    || ('<DIST />' eq 'fedora20') ||
+    ('<DIST />' eq 'fedora21')    || ('<DIST />' eq 'fedora22') ||
+    ('<DIST />' eq 'fedora23')    || ('<DIST />' eq 'fedora24') ||
+    ('<DIST />' eq 'fedora25')    || ('<DIST />' eq 'fedora26') ||
+    ('<DIST />' eq 'fedora27')    || ('<DIST />' eq 'fedora28') ||
+    ('<DIST />' eq 'centos7')     || ('<DIST />' eq 'rhes7')    ||
+    ('<DIST />' eq 'scientific7') || ('<DIST />' eq 'sles12')   ||
+    ('<DIST />' eq 'ubuntu18')) {
+    $NTPD = 'ntpd';
+    if ('<DIST />' eq 'ubuntu18') {
+        $NTPD = 'ntp'; 
+    }
+    $startntpcmd = "systemctl start $NTPD.service";
+    if (!-e "/usr/sbin/$NTPD") {
+        print "ntp is not installed.\n";
+        exit;
+    }
 } else {
-    print "ntp is not installed.\n";
-    exit;
-}
-my $value = `/etc/init.d/$NTPD status`;
-if ($value !~ /running/) {
-    print "WARNING: ntp is installed but is not currently running.\nPlease verify the configuration of ntp in /etc/ntp.conf and /etc/ntp/step-tickers\nStart ntp by executing\n /etc/init.d/$NTPD start\n";
+    if (-e "/etc/init.d/ntpd") {
+        $NTPD = "ntpd";
+    } elsif (-e "/etc/init.d/xntpd") {
+        $NTPD = "xntpd";
+    } elsif (-e "/etc/init.d/ntp") {
+        $NTPD = "ntp"; 
+    } else {
+        print "ntp is not installed.\n";
+        exit;
+    }
+    $startntpcmd = "/etc/init.d/$NTPD start";
 }
-# chkconfig barfs to stderr if the target isn't set up right.
-my $checking_bin;
-my $restartchk;
-if ('<DIST />' eq 'debian5' || '<DIST />' eq 'debian6' || '<DIST />' eq 'ubuntu6' || '<DIST />' eq 'ubuntu8' || '<DIST />' eq 'ubuntu10') {
-    $checking_bin = '/usr/sbin/sysv-rc-conf';
+
+if (open(PIPE,'-|',$checkcmd)) {
+    $is_running = &lt;PIPE&gt;;
+    chomp($is_running);
+    close(PIPE);
+    if (!$is_running) {
+        print "WARNING: ntp is installed but is not currently running.\nPlease verify the configuration of ntp in /etc/ntp.conf and /etc/ntp/step-tickers\nStart ntp by executing\n $startntpcmd\n";
+    } else {
+        print "ntp is installed and running\n";
+    }
 } else {
-    $checking_bin = '/sbin/chkconfig';
+    print "Could not determine ntp status.\n";
 }
-if ('<DIST />' eq 'fedora15') {
-    if (!-l "/etc/systemd/system/multi-user.target.wants/ntpd.service") {  
-        print "**** WARNING: ntpd is not configured to run at boot.  To correct this run:\nsystemctl enable ntpd.service\n";
+
+# chkconfig barfs to stderr if the target isn't set up right.
+if (('<DIST />' eq 'fedora15')    || ('<DIST />' eq 'fedora16') ||
+    ('<DIST />' eq 'fedora17')    || ('<DIST />' eq 'fedora18') ||
+    ('<DIST />' eq 'fedora19')    || ('<DIST />' eq 'fedora20') ||
+    ('<DIST />' eq 'fedora21')    || ('<DIST />' eq 'fedora22') ||
+    ('<DIST />' eq 'fedora23')    || ('<DIST />' eq 'fedora24') ||
+    ('<DIST />' eq 'fedora25')    || ('<DIST />' eq 'fedora26') ||
+    ('<DIST />' eq 'fedora27')    || ('<DIST />' eq 'fedora28') ||
+    ('<DIST />' eq 'centos7')     || ('<DIST />' eq 'rhes7')    ||
+    ('<DIST />' eq 'scientific7') || ('<DIST />' eq 'sles12') ||
+    ('<DIST />' eq 'ubuntu18')) {
+    if (!-l "/etc/systemd/system/multi-user.target.wants/$NTPD.service") {  
+        print "**** WARNING: $NTPD is not configured to run at boot.  To correct this run:\nsystemctl enable $NTPD.service\n";
     }
     exit;
 } else {
+    my $checking_bin;
+    my $restartchk;
+    if (('<DIST />' eq 'debian5') || ('<DIST />' eq 'debian6') || ('<DIST />' eq 'ubuntu6') || 
+        ('<DIST />' eq 'ubuntu8') || ('<DIST />' eq 'ubuntu10') || ('<DIST />' eq 'ubuntu12') || 
+        ('<DIST />' eq 'ubuntu14') || ('<DIST />' eq 'ubuntu16')) {
+        $checking_bin = '/usr/sbin/sysv-rc-conf';
+    } else {
+        $checking_bin = '/sbin/chkconfig';
+    }
     $restartchk = `$checking_bin --list $NTPD 2>/dev/null`;
     if ($restartchk eq '') {
         print "**** WARNING: ntpd is either not installed or not configured to run at boot.\n";