--- doc/loncapafiles/updatequery.piml	2006/04/17 19:46:21	1.47
+++ doc/loncapafiles/updatequery.piml	2007/05/22 23:16:47	1.58
@@ -1,6 +1,6 @@
 <!-- updatequery.piml -->
 
-<!-- $Id: updatequery.piml,v 1.47 2006/04/17 19:46:21 albertel Exp $ -->
+<!-- $Id: updatequery.piml,v 1.58 2007/05/22 23:16:47 albertel Exp $ -->
 
 <!--
 
@@ -47,7 +47,7 @@ $|=1;
 *********************************************
 
 END
-sleep(3);
+#sleep(3);
 </perlscript>
 </file>
 <file>
@@ -97,23 +97,17 @@ while (!$flag) {
   }
   elsif ($choice==4) {
     $lonCluster='existing'; $flag=1;
-    if (-e '/home/httpd/lonTabs/hosts.tab') {
-      `cp /home/httpd/lonTabs/hosts.tab ../existing_hosts.tab`;
-    }
-    else {
-      print &lt;&lt;END;
-There is no existing /home/httpd/lonTabs/hosts.tab
-END
-      die('');
-    }
-    if (-e '/home/httpd/lonTabs/domain.tab') {
-      `cp /home/httpd/lonTabs/domain.tab ../existing_domain.tab`;
-    }
-    else {
-      print &lt;&lt;END;
-There is no existing /home/httpd/lonTabs/domain.tab
+    foreach my $file ('hosts.tab','dns_hosts.tab',
+                      'domain.tab','dns_domain.tab') {
+        if (-e '/home/httpd/lonTabs/'.$file) {
+	    `cp /home/httpd/lonTabs/$file ../existing_$file`;
+        }
+        else {
+	    print &lt;&lt;END;
+There is no existing /home/httpd/lonTabs/$file
 END
-      die('');
+            die('');
+        }
     }
   }
   elsif ($choice==26) {
@@ -260,14 +254,14 @@ END
     close(OUT);
     $lonDefDomain=$choice;
     $flag=1;
-  } elsif (length($choice)>12) {
+  } elsif (length($choice)>35) {
     print "Name too long\n";
   } elsif (length($choice)<2) {
     print "Name too short\n";
   } elsif ($bad_domain_flag) {
     print "Invalid input ('$choice' conflicts with LON-CAPA namespace).\n";
     print "Please try something different than '$choice'\n";
-  } elsif ($choice!~/\_/ and $choice=~/^\w+$/) {
+  } elsif ($choice!~/\_/ and $choice=~/^[\w\-.]+$/) {
     open(OUT,'&gt;&gt;/tmp/loncapa_updatequery.out');
     print(OUT 'lonDefDomain'."\t".$choice."\n");
     close(OUT);
@@ -275,7 +269,7 @@ END
     $r='l';
     $flag=1;
   } else {
-    print "Invalid input (only alphanumeric characters supported).\n";
+    print "Invalid input (only alphanumeric characters, '-', and '.' supported).\n";
   }
 }
 
@@ -348,18 +342,18 @@ END
     close(OUT);
     $lonHostID=$choice;
     $flag=1;
-  } elsif (length($choice)>15) {
+  } elsif (length($choice)>45) {
     print "Name too long\n";
   } elsif (length($choice)<4) {
     print "Name too short\n";
-  } elsif ($choice!~/\_/ and $choice=~/^\w+$/) {
+  } elsif ($choice!~/\_/ and $choice=~/^[\w\-.]+$/) {
     open(OUT,'&gt;&gt;/tmp/loncapa_updatequery.out');
     print(OUT 'lonHostID'."\t".$choice."\n");
     close(OUT);
     $lonHostID=$choice;
     $flag=1;
   } else {
-    print "Invalid input (only alphanumeric characters supported).\n";
+    print "Invalid input (only alphanumeric characters, '-', and '.' supported).\n";
   }
 }
 
@@ -404,18 +398,18 @@ END
         print(OUT 'primaryLibServer'."\t".$choice."\n");
         close(OUT);
         $flag=1;
-    } elsif (length($choice)>15) {
+    } elsif (length($choice)>35) {
         print "Name too long\n";
     } elsif (length($choice)<4) {
         print "Name too short\n";
-    } elsif ($choice!~/\_/ and $choice=~/^\w+$/) {
+    } elsif ($choice!~/\_/ and $choice=~/^[\w\-.]+$/) {
         open(OUT,'&gt;&gt;/tmp/loncapa_updatequery.out');
         print(OUT 'primaryLibServer'."\t".$choice."\n");
         close(OUT);
         $primaryLibServer=$choice;
         $flag=1;
     } else {
-        print "Invalid input (only alphanumeric characters supported).\n";
+        print "Invalid input (only alphanumeric characters, '-', and '.' supported).\n";
     }
 }
 
@@ -427,7 +421,7 @@ my $lonAdmEMail;
 while (!$flag) {
   print(&lt;&lt;END);
 
-**** Server Administrator's E-mail ****
+**** Server Administrators E-mail ****
 E-mail address of the person who will manage this machine
 [should be in the form somebody\@somewhere]
 ENTER ADMIN E-MAIL ADDRESS:
@@ -482,8 +476,10 @@ END
 
 
 # update loncapa.conf
-my $confdir='/etc/httpd/conf/';
-#my $confdir='';
+my $confdir = '/etc/httpd/conf/';
+if ('<DIST />' eq 'sles10' || '<DIST />' eq 'suse10.1' || '<DIST />' eq 'suse10.2') {
+     $confdir = '/etc/apache2/';
+}   
 my $filename='loncapa.conf';
 my %perlvar;
     if (-e "$confdir$filename") {
@@ -524,8 +520,12 @@ my %perlvar;
       die("Cannot output to $confdir$filename\n");
     foreach my $key (keys %perlvar) {
       my $value=$perlvar{$key};
+      my $line = "PerlSetVar     $key      $value"; 
+      if ($value eq '') {
+          $line = '#'.$line;
+      }
       print(OUT &lt;&lt;END);
-PerlSetVar     $key      $value
+$line
 END
     }
     close(OUT);
@@ -533,7 +533,8 @@ END
 </perlscript>
 </file>
 <file>
-<target dist='default'>/</target>
+<target dist='default'>/etc/httpd/conf/</target>
+<target dist='sles10 suse10.1 suse10.2'>/etc/apache2/</target>
 <perlscript mode='fg'>
 sub securesetting {
     my (%perlvar)=@_;
@@ -551,7 +552,7 @@ sub securesetting {
     return ($securestatus,$securenum);
 }
 # read values from loncapa.conf
-my $confdir='/etc/httpd/conf/';
+my $confdir = "<TARGET />";
 my $filename='loncapa.conf';
 my %perlvar;
 my ($securestatus,$securenum);
@@ -605,79 +606,61 @@ my %perlvarstatic;
 	}
 	close(CONFIG);
     }
-    if (!$domainDescription && $lonCluster ne 'existing') {
-       open(IN,'&lt;../'.$lonCluster.'_domain.tab');
-       while(&lt;IN&gt;) {
-          if (/^$perlvar{'lonDefDomain'}\:/) {
-	     (undef,$domainDescription,$domainTabExtras)=split(/:/,$_,3);
-	     chomp($domainDescription);
-	     chomp($domainTabExtras);
-	     # the remianing field (primary lib server) is handled later
-	     $domainTabExtras = join(':',(split(/:/,$domainTabExtras))[0..5]);
-             last;
-          }
-       }
-       close(IN);
-    }
+
+    my (@hosts_files, @domain_files);
+    if ( $lonCluster ne 'existing') {
+	push(@domain_files,'../'.$lonCluster.'_domain.tab',
+	     '../'.$lonCluster.'_dns_domain.tab');
+	push(@hosts_files,'../'.$lonCluster.'_hosts.tab',
+	     '../'.$lonCluster.'_dns_hosts.tab');
+    }
+    push(@domain_files,'/home/httpd/lonTabs/domain.tab',
+         '/home/httpd/lonTabs/dns_domain.tab');
+    push(@hosts_files,'/home/httpd/lonTabs/hosts.tab',
+         '/home/httpd/lonTabs/dns_hosts.tab');
+
     if (!$domainDescription) {
-       open(IN,'&lt;/home/httpd/lonTabs/domain.tab');
-       while(&lt;IN&gt;) {
-          if (/^$perlvar{'lonDefDomain'}\:/) {
-	     (undef,$domainDescription,$domainTabExtras)=split(/:/,$_,3);
-	     chomp($domainDescription);
-	     chomp($domainTabExtras);
-	     # the remianing field (primary lib server) is handled later
-	     $domainTabExtras = join(':',(split(/:/,$domainTabExtras))[0-5]);
-             last;
-          }
-       }
-       close(IN);
+	foreach my $file (@domain_files) {
+	    open(IN,'&lt;'.$file);
+	    while(my $line = &lt;IN&gt;) {
+		if ($line =~ /^\Q$perlvar{'lonDefDomain'}\E\:/) {
+		    (undef,$domainDescription,$domainTabExtras)=split(/:/,$line,3);
+		    chomp($domainDescription);
+		    chomp($domainTabExtras);
+		    # the remianing field (primary lib server) is handled later
+		    $domainTabExtras = join(':',(split(/:/,$domainTabExtras))[0..5]);
+		    last;
+		}
+	    }
+	    close(IN);
+	    last if ($domainDescription);
+	}
     }
-    if (!$primaryLibServer and $lonCluster ne 'existing') {
-        open(IN,'&lt;../'.$lonCluster.'_domain.tab');
-        while(&lt;IN&gt;) {
-            if (/^$perlvar{'lonDefDomain'}\:/) {
-                (undef,undef,undef,undef,undef,undef,undef,undef,
-                                              $primaryLibServer)=split(/:/,$_);
+
+    while(!$primaryLibServ && (@hosts_file || @domain_files)) {
+	my $file = shift(@domain_files);
+        open(IN,'&lt;'.$file);
+        while(my $line = &lt;IN&gt;) {
+            if ($line =~ /^\Q$perlvar{'lonDefDomain'}\E\:/) {
+		$primaryLibServer=(split(/:/,$line))[8];
                 chomp($primaryLibServer);
             }
         }
         close(IN);
-        if (!$primaryLibServer) {
-            open(IN,'&lt;../'.$lonCluster.'_hosts.tab');
-            while(&lt;IN&gt;) {
-                if (/^([^\:]+)\:\Q$perlvar{'lonDefDomain'}\E\:library\:/) {
-                    push(@libservers,$1);
-                }
-            }
-            close(IN);
-            if (@libservers == 1) {
-                $primaryLibServer = $libservers[0];
-            }
-        }
-    }
-    if (!$primaryLibServer) {
-        open(IN,'&lt;/home/httpd/lonTabs/domain.tab');
-        while(&lt;IN&gt;) {
-            if (/^$perlvar{'lonDefDomain'}\:/) {
-                (undef,undef,undef,undef,undef,undef,undef,undef,
-                                              $primaryLibServer)=split(/:/,$_);
-                chomp($primaryLibServer);
-            }
-            close(IN);
-        }
-        if (!$primaryLibServer) {
-            open(IN,'&lt;/home/httpd/lonTabs/hosts.tab');
-            while(&lt;IN&gt;) {
-                if (/^([^\:]+)\:\Q$perlvar{'lonDefDomain'}\E\:library\:/) {
-                    push(@libservers,$1);
-                }
-            }
-            close(IN);
-            if (@libservers == 1) {
-                $primaryLibServer = $libservers[0];
-            }
-        }
+	last if ($primaryLibServer);
+	$file = shift(@hosts_files);
+	open(IN,'&lt;'.$file);
+	while(my $line = &lt;IN&gt;) {
+	    if ($line =~ /^([^\:]+)\:\Q$perlvar{'lonDefDomain'}\E\:library\:/) {
+		push(@libservers,$1);
+	    }
+	}
+	# make list unique
+	@libservers = keys(%{{ map { $_ => 1 } (@libservers) }});
+	close(IN);
+	if (@libservers == 1) {
+	    $primaryLibServer = $libservers[0];
+	}
     }
    
 # implement editing logic below, interactively
@@ -704,56 +687,58 @@ This is now the current configuration of
 12) Everything is correct up above
 END
 
-my $error='';
+my @error;
 foreach my $v ($perlvar{'lonDefDomain'},$perlvar{'lonHostID'}) {
-   if (length($v)>16) { $error.="\nName $v too long"; }		
+   if (length($v)>35) { $error.="\nName $v too long"; }		
    if (length($v)<2) { $error.="\nName $v too short"; }
    if ($v=~/capa/i) {
 	if ($v!~/^oucapa\d+$/ && 
 	    ($v!~/^capa\d+$/ && $perlvar{'lonDefDomain'} eq 'uwsp')) {
-		 $error.="\nName $v contains 'capa'"; 
+		 push(@error,"Name $v contains 'capa'");
 	}
    }
    foreach my $bad ('res','raw','userfiles','priv','adm','uploaded',
 	'editupload') {
-      $error.="\nName $v reserved." if $v eq $bad;
+      push(@error,"\nName $v reserved.") if $v eq $bad;
    }
-   if ($v=~/\W/) { $error.="\nName $v contains special characters"; }
+   if ($v=~/[^\w\-.]/) { push(@error,"Name $v contains special characters"); }
 }
-if ($domainDescription!~/^[\(\)\-\w\s,]+$/) {
-   $error.="\nDomain Description contains special characters";
+if ($domainDescription =~ /^\s*$/) {
+   push(@error,"Domain Description is blank.");
+} elsif ($domainDescription!~/^[\(\)\-\w\s,]+$/) {
+   push(@error,"Domain Description contains special characters.");
 } 
 foreach my $v ($perlvar{'lonExpire'},$perlvar{'lonLoadLim'}) {
-   unless ($v=~/^[\d+\.]+$/) { $error.="\nNumber expected instead of $v"; }
+   unless ($v=~/^[\d+\.]+$/) { push(@error,"Number expected instead of $v"); }
 }
 unless (($perlvar{'lonRole'} eq 'library') || ($perlvar{'lonRole'} eq 'access')) {
-   $error.="\nInvalid Role";
+   push(@error,"Invalid Role");
 }
 
 if (!defined($primaryLibServer)) {
    if (@libservers > 0) {
-       $error .= "No primary library server ID designated. Choose from: ".join(',',sort(@libservers));
+       push(@error,"No primary library server ID designated. Choose from: ".join(',',sort(@libservers)));
    } else {
-       $error .= "No library servers in this domain (including current server)";
+       push(@error,"No library servers in this domain (including current server)");
    }
 } else {
-   if (length($primaryLibServer)>16) { $error.="\nPrimary Library Server ID:  $primaryLibServer too long"; }
-   if (length($primaryLibServer)<2) { $error.="\nPrimary Library Server ID:  $primaryLibServer too short"; }
+   if (length($primaryLibServer)>35) { push(@error,"Primary Library Server ID:  $primaryLibServer too long"); }
+   if (length($primaryLibServer)<2) { push(@error,"Primary Library Server ID:  $primaryLibServer too short"); }
    if ($primaryLibServer =~/capa/i) {
         if ($primaryLibServer!~/^oucapa\d+$/ &&
             ($primaryLibServer!~/^capa\d+$/ && $perlvar{'lonDefDomain'} eq 'uwsp')) {
-                 $error.="\nPrimary library server ID $primaryLibServer contains 'capa'";
+                 push(@error,"Primary library server ID $primaryLibServer contains 'capa'")
         }
    }
    foreach my $bad ('res','raw','userfiles','priv','adm','uploaded',
         'editupload') {
-      $error.="\nPrimary library server ID $primaryLibServer reserved." if $primaryLibServer eq $bad;
+      push(@error,"Primary library server ID $primaryLibServer reserved.") if $primaryLibServer eq $bad;
    }
-   if ($primaryLibServer=~/\W/) { $error.="\nPrimary library server ID $primaryLibServer contains special characters"; }
+   if ($primaryLibServer=~/[^\w\-.]/) { push(@error,"Primary library server ID $primaryLibServer contains special characters"); }
 }
 
 
-if ($error) { print "\n*** ERRORS: $error\n"; }
+if (@error) { print "\n*** ERRORS: \n\t".join("\n\t",@error)."\n"; }
   print(&lt;&lt;END);
 ENTER A CHOICE OF 1-11 TO CHANGE, otherwise ENTER 12:
 END
@@ -903,8 +888,12 @@ END
       die("Cannot output to $confdir$filename\n");
     foreach my $key (keys %perlvar) {
       my $value=$perlvar{$key};
+      my $line = "PerlSetVar     $key      $value";
+      if ($value eq '') {
+          $line = '#'.$line;
+      }
       print(OUT &lt;&lt;END) unless $perlvarstatic{$key};
-PerlSetVar     $key      $value
+$line
 END
     }
     close(OUT);
@@ -917,31 +906,45 @@ unless (-l "<TARGET />") {
   my $hostname=`hostname -f`;chomp($hostname);
   $date=`date -I`; chomp($date);
   $lonHostID=$perlvar{'lonHostID'};
-  $lonHostID=~s/\W//g;
+  $lonHostID=~s/[^\w\-.]//g;
   $lineexistflag=0;
   $hostidexistflag=0;
   $line2insert=&lt;&lt;END;
 $perlvar{'lonHostID'}:$perlvar{'lonDefDomain'}:$perlvar{'lonRole'}:$hostname
 END
+  if (!$domainTabExtras) {
+	$domainTabExtras=':::::';
+  }
   $domaininsert="$perlvar{'lonDefDomain'}:$domainDescription:$domainTabExtras:$primaryLibServer\n";
   if ($lonCluster eq 'standalone') {
     open(OUT,'&gt;../'.$lonCluster.'_hosts.tab') or
       die('file generation error');
       print(OUT $line2insert);
+      print OUT ("^$hostname\n");
+    close(OUT);
+    open(OUT,'&gt;../'.$lonCluster.'_dns_hosts.tab') or
+      die('file generation error');
+      print(OUT $line2insert);
     close(OUT);
     open(OUT,'&gt;../'.$lonCluster.'_domain.tab') or
       die('file generation error');
       print(OUT $domaininsert);
     close(OUT);
+    open(OUT,'&gt;../'.$lonCluster.'_dns_domain.tab') or
+      die('file generation error');
+      print(OUT $domaininsert);
+    close(OUT);
   }
   if ($flag==1) {
     `rm -f ../hosts.tab`;
-    open(IN,'&lt;../'.$lonCluster.'_hosts.tab');
-    while(&lt;IN&gt;) {
-      if (/^$line2insert$/) {
+    `rm -f ../dns_hosts.tab`;
+    `ln -s ${lonCluster}_dns_hosts.tab ../dns_hosts.tab`;
+    open(IN,'&lt;../'.$lonCluster.'_dns_hosts.tab');
+    while(my $line = &lt;IN&gt;) {
+      if ($line =~ /^\Q$line2insert\E$/) {
         $lineexistflag=1;
       }
-      if (/^$lonHostID\:/) {
+      if ($line =~ /^\Q$lonHostID\E\:/) {
         $hostidexistflag=1;
       }
     }
@@ -949,9 +952,9 @@ END
     if ($hostidexistflag and !$lineexistflag) {
       print &lt;&lt;END;
 WARNING: $lonHostID already exists inside
-loncapa/loncom/${lonCluster}_hosts.tab.  The entry inside
-${lonCluster}_hosts.tab does not match your settings.
-The entry inside ${lonCluster}_hosts.tab is being replaced
+loncapa/loncom/${lonCluster}_dns_hosts.tab.  The entry inside
+${lonCluster}_dns_hosts.tab does not match your settings.
+An entry inside ${lonCluster}_hosts.tab will be made
 with your new values.
 END
       `grep -v "$lonHostID:" ../${lonCluster}_hosts.tab &gt; ../new_${lonCluster}_hosts.tab`;
@@ -965,9 +968,14 @@ END
     }
     elsif ($hostidexistflag and $lineexistflag) {
       print &lt;&lt;END;
-Entry exists in ${lonCluster}_hosts.tab.
+Entry exists in ${lonCluster}_dns_hosts.tab. Making duplicate entry in ${lonCluster}_hosts.tab
 END
-      `ln -s ${lonCluster}_hosts.tab ../hosts.tab`;
+      `grep -v "$lonHostID:" ../${lonCluster}_hosts.tab &gt; ../new_${lonCluster}_hosts.tab`;
+       open(OUT,'&gt;&gt;../new_'.$lonCluster.'_hosts.tab') or
+         die("cannot open loncom/${lonCluster}_hosts.tab for output\n");
+         print(OUT $line2insert);
+       close(OUT);
+      `ln -s new_${lonCluster}_hosts.tab ../hosts.tab`;
       # email appropriate message
       `echo "STABLEUPDATE:$lonCluster:$lonHostID:$date:$line2insert" | mail -s "STABLEUPDATE:$lonCluster:$lonHostID:$date" installrecord\@mail.lon-capa.org`;
     }
@@ -988,12 +996,14 @@ END
   $lineexistflag=0;
   if ($flag==1) {
     `rm -f ../domain.tab`;
-    open(IN,'&lt;../'.$lonCluster.'_domain.tab');
-    while(&lt;IN&gt;) {
-      if (/^$domaininsert$/) {
+    `rm -f ../dns_domain.tab`;
+    `ln -s ${lonCluster}_dns_domain.tab ../dns_domain.tab`;
+    open(IN,'&lt;../'.$lonCluster.'_dns_domain.tab');
+    while(my $line = &lt;IN&gt;) {
+      if ($line =~/^\Q$domaininsert\E$/) {
         $lineexistflag=1;
       }
-      if (/^$perlvar{'lonDefDomain'}\:/) {
+      if ($line =~/^\Q$perlvar{'lonDefDomain'}\E\:/) {
         $domainexistflag=1;
       }
     }
@@ -1001,9 +1011,9 @@ END
     if ($domainexistflag and !$lineexistflag) {
       print &lt;&lt;END;
 WARNING: $perlvar{'lonDefDomain'} already exists inside
-loncapa/loncom/${lonCluster}_domain.tab.  The entry inside
-${lonCluster}_domain.tab does not match your settings.
-The entry inside ${lonCluster}_domain.tab is being replaced
+loncapa/loncom/${lonCluster}_dns_domain.tab.  The entry inside
+${lonCluster}_dns_domain.tab does not match your settings.
+An entry will be made in inside ${lonCluster}_domain.tab
 with your new values.
 END
       `grep -v "$perlvar{'lonDefDomain'}:" ../${lonCluster}_domain.tab &gt; ../new_${lonCluster}_domain.tab`;
@@ -1016,10 +1026,15 @@ END
       `echo "REPLACEdom:$lonCluster:$lonHostID:$date:$domaninsert" | mail -s "REPLACEdom:$lonCluster:$lonHostID:$date" installrecord\@mail.lon-capa.org`;
     }
     elsif ($domainexistflag and $lineexistflag) {
+      `grep -v "$perlvar{'lonDefDomain'}:" ../${lonCluster}_domain.tab &gt; ../new_${lonCluster}_domain.tab`;
+       open(OUT,'&gt;&gt;../new_'.$lonCluster.'_domain.tab') or
+         die("cannot open loncom/${lonCluster}_domain.tab for output\n");
+         print(OUT $domaininsert);
+       close(OUT);
       print &lt;&lt;END;
-Entry exists in ${lonCluster}_domain.tab.
+Entry exists in ${lonCluster}_dns_domain.tab. Making duplicate entry in ${lonCluster}_domain.tab
 END
-      `ln -s ${lonCluster}_domain.tab ../domain.tab`;
+      `ln -s new_${lonCluster}_domain.tab ../domain.tab`;
       # email appropriate message
       `echo "STABLEUPDATEdom:$lonCluster:$lonHostID:$date:$domaininsert" | mail -s "STABLEUPDATEdom:$lonCluster:$lonHostID:$date" installrecord\@mail.lon-capa.org`;
     }