--- doc/loncapafiles/updatequery.piml	2007/04/03 22:13:40	1.52
+++ doc/loncapafiles/updatequery.piml	2007/04/22 16:33:28	1.56
@@ -1,6 +1,6 @@
 <!-- updatequery.piml -->
 
-<!-- $Id: updatequery.piml,v 1.52 2007/04/03 22:13:40 albertel Exp $ -->
+<!-- $Id: updatequery.piml,v 1.56 2007/04/22 16:33:28 raeburn Exp $ -->
 
 <!--
 
@@ -47,7 +47,7 @@ $|=1;
 *********************************************
 
 END
-sleep(3);
+#sleep(3);
 </perlscript>
 </file>
 <file>
@@ -421,7 +421,7 @@ my $lonAdmEMail;
 while (!$flag) {
   print(&lt;&lt;END);
 
-**** Server Administrator's E-mail ****
+**** Server Administrators E-mail ****
 E-mail address of the person who will manage this machine
 [should be in the form somebody\@somewhere]
 ENTER ADMIN E-MAIL ADDRESS:
@@ -477,7 +477,7 @@ END
 
 # update loncapa.conf
 my $confdir = '/etc/httpd/conf/';
-if ('<DIST />' eq 'sles10' || '<DIST />' eq 'suse10.1') {
+if ('<DIST />' eq 'sles10' || '<DIST />' eq 'suse10.1' || '<DIST />' eq 'suse10.2') {
      $confdir = '/etc/apache2/';
 }   
 my $filename='loncapa.conf';
@@ -534,7 +534,7 @@ END
 </file>
 <file>
 <target dist='default'>/etc/httpd/conf/</target>
-<target dist='sles10 suse10.1'>/etc/apache2/</target>
+<target dist='sles10 suse10.1 suse10.2'>/etc/apache2/</target>
 <perlscript mode='fg'>
 sub securesetting {
     my (%perlvar)=@_;
@@ -606,79 +606,59 @@ my %perlvarstatic;
 	}
 	close(CONFIG);
     }
-    if (!$domainDescription && $lonCluster ne 'existing') {
-       open(IN,'&lt;../'.$lonCluster.'_domain.tab');
-       while(&lt;IN&gt;) {
-          if (/^$perlvar{'lonDefDomain'}\:/) {
-	     (undef,$domainDescription,$domainTabExtras)=split(/:/,$_,3);
-	     chomp($domainDescription);
-	     chomp($domainTabExtras);
-	     # the remianing field (primary lib server) is handled later
-	     $domainTabExtras = join(':',(split(/:/,$domainTabExtras))[0..5]);
-             last;
-          }
-       }
-       close(IN);
-    }
+
+    my (@hosts_files, @domain_files);
+    if ( $lonCluster ne 'existing') {
+	push(@domain_files,'../'.$lonCluster.'_domain.tab',
+	     '../'.$lonCluster.'_dns_domain.tab');
+	push(@hosts_files,'../'.$lonCluster.'_hosts.tab',
+	     '../'.$lonCluster.'_dns_hosts.tab');
+    }
+    push(@domain_files,'/home/httpd/lonTabs/domain.tab',
+         '/home/httpd/lonTabs/dns_domain.tab');
+    push(@hosts_files,'/home/httpd/lonTabs/hosts.tab',
+         '/home/httpd/lonTabs/dns_hosts.tab');
+
     if (!$domainDescription) {
-       open(IN,'&lt;/home/httpd/lonTabs/domain.tab');
-       while(&lt;IN&gt;) {
-          if (/^$perlvar{'lonDefDomain'}\:/) {
-	     (undef,$domainDescription,$domainTabExtras)=split(/:/,$_,3);
-	     chomp($domainDescription);
-	     chomp($domainTabExtras);
-	     # the remianing field (primary lib server) is handled later
-	     $domainTabExtras = join(':',(split(/:/,$domainTabExtras))[0..5]);
-             last;
-          }
-       }
-       close(IN);
+	foreach my $file (@domain_files) {
+	    open(IN,'&lt;'.$file);
+	    while(my $line = &lt;IN&gt;) {
+		if ($line =~ /^\Q$perlvar{'lonDefDomain'}\E\:/) {
+		    (undef,$domainDescription,$domainTabExtras)=split(/:/,$line,3);
+		    chomp($domainDescription);
+		    chomp($domainTabExtras);
+		    # the remianing field (primary lib server) is handled later
+		    $domainTabExtras = join(':',(split(/:/,$domainTabExtras))[0..5]);
+		    last;
+		}
+	    }
+	    close(IN);
+	    last if ($domainDescription);
+	}
     }
-    if (!$primaryLibServer and $lonCluster ne 'existing') {
-        open(IN,'&lt;../'.$lonCluster.'_domain.tab');
-        while(&lt;IN&gt;) {
-            if (/^$perlvar{'lonDefDomain'}\:/) {
-                (undef,undef,undef,undef,undef,undef,undef,undef,
-                                              $primaryLibServer)=split(/:/,$_);
+
+    while(!$primaryLibServ && (@hosts_file || @domain_files)) {
+	my $file = shift(@domain_files);
+        open(IN,'&lt;'.$file);
+        while(my $line = &lt;IN&gt;) {
+            if ($line =~ /^\Q$perlvar{'lonDefDomain'}\E\:/) {
+		$primaryLibServer=(split(/:/,$line))[8];
                 chomp($primaryLibServer);
             }
         }
         close(IN);
-        if (!$primaryLibServer) {
-            open(IN,'&lt;../'.$lonCluster.'_hosts.tab');
-            while(&lt;IN&gt;) {
-                if (/^([^\:]+)\:\Q$perlvar{'lonDefDomain'}\E\:library\:/) {
-                    push(@libservers,$1);
-                }
-            }
-            close(IN);
-            if (@libservers == 1) {
-                $primaryLibServer = $libservers[0];
-            }
-        }
-    }
-    if (!$primaryLibServer) {
-        open(IN,'&lt;/home/httpd/lonTabs/domain.tab');
-        while(&lt;IN&gt;) {
-            if (/^$perlvar{'lonDefDomain'}\:/) {
-                (undef,undef,undef,undef,undef,undef,undef,undef,
-                                              $primaryLibServer)=split(/:/,$_);
-                chomp($primaryLibServer);
-            }
-            close(IN);
-        }
-        if (!$primaryLibServer) {
-            open(IN,'&lt;/home/httpd/lonTabs/hosts.tab');
-            while(&lt;IN&gt;) {
-                if (/^([^\:]+)\:\Q$perlvar{'lonDefDomain'}\E\:library\:/) {
-                    push(@libservers,$1);
-                }
-            }
-            close(IN);
-            if (@libservers == 1) {
-                $primaryLibServer = $libservers[0];
-            }
-        }
+	last if ($primaryLibServer);
+	$file = shift(@hosts_files);
+	open(IN,'&lt;'.$file);
+	while(my $line = &lt;IN&gt;) {
+	    if ($line =~ /^([^\:]+)\:\Q$perlvar{'lonDefDomain'}\E\:library\:/) {
+		push(@libservers,$1);
+	    }
+	}
+	close(IN);
+	if (@libservers == 1) {
+	    $primaryLibServer = $libservers[0];
+	}
     }
    
 # implement editing logic below, interactively
@@ -705,56 +685,58 @@ This is now the current configuration of
 12) Everything is correct up above
 END
 
-my $error='';
+my @error;
 foreach my $v ($perlvar{'lonDefDomain'},$perlvar{'lonHostID'}) {
    if (length($v)>35) { $error.="\nName $v too long"; }		
    if (length($v)<2) { $error.="\nName $v too short"; }
    if ($v=~/capa/i) {
 	if ($v!~/^oucapa\d+$/ && 
 	    ($v!~/^capa\d+$/ && $perlvar{'lonDefDomain'} eq 'uwsp')) {
-		 $error.="\nName $v contains 'capa'"; 
+		 push(@error,"Name $v contains 'capa'");
 	}
    }
    foreach my $bad ('res','raw','userfiles','priv','adm','uploaded',
 	'editupload') {
-      $error.="\nName $v reserved." if $v eq $bad;
+      push(@error,"\nName $v reserved.") if $v eq $bad;
    }
-   if ($v=~/[^\w\-.]/) { $error.="\nName $v contains special characters"; }
+   if ($v=~/[^\w\-.]/) { push(@error,"Name $v contains special characters"); }
 }
-if ($domainDescription!~/^[\(\)\-\w\s,]+$/) {
-   $error.="\nDomain Description contains special characters";
+if ($domainDescription =~ /^\s*$/) {
+   push(@error,"Domain Description is blank.");
+} elsif ($domainDescription!~/^[\(\)\-\w\s,]+$/) {
+   push(@error,"Domain Description contains special characters.");
 } 
 foreach my $v ($perlvar{'lonExpire'},$perlvar{'lonLoadLim'}) {
-   unless ($v=~/^[\d+\.]+$/) { $error.="\nNumber expected instead of $v"; }
+   unless ($v=~/^[\d+\.]+$/) { push(@error,"Number expected instead of $v"); }
 }
 unless (($perlvar{'lonRole'} eq 'library') || ($perlvar{'lonRole'} eq 'access')) {
-   $error.="\nInvalid Role";
+   push(@error,"Invalid Role");
 }
 
 if (!defined($primaryLibServer)) {
    if (@libservers > 0) {
-       $error .= "No primary library server ID designated. Choose from: ".join(',',sort(@libservers));
+       push(@error,"No primary library server ID designated. Choose from: ".join(',',sort(@libservers)));
    } else {
-       $error .= "No library servers in this domain (including current server)";
+       push(@error,"No library servers in this domain (including current server)");
    }
 } else {
-   if (length($primaryLibServer)>35) { $error.="\nPrimary Library Server ID:  $primaryLibServer too long"; }
-   if (length($primaryLibServer)<2) { $error.="\nPrimary Library Server ID:  $primaryLibServer too short"; }
+   if (length($primaryLibServer)>35) { push(@error,"Primary Library Server ID:  $primaryLibServer too long"); }
+   if (length($primaryLibServer)<2) { push(@error,"Primary Library Server ID:  $primaryLibServer too short"); }
    if ($primaryLibServer =~/capa/i) {
         if ($primaryLibServer!~/^oucapa\d+$/ &&
             ($primaryLibServer!~/^capa\d+$/ && $perlvar{'lonDefDomain'} eq 'uwsp')) {
-                 $error.="\nPrimary library server ID $primaryLibServer contains 'capa'";
+                 push(@error,"Primary library server ID $primaryLibServer contains 'capa'")
         }
    }
    foreach my $bad ('res','raw','userfiles','priv','adm','uploaded',
         'editupload') {
-      $error.="\nPrimary library server ID $primaryLibServer reserved." if $primaryLibServer eq $bad;
+      push(@error,"Primary library server ID $primaryLibServer reserved.") if $primaryLibServer eq $bad;
    }
-   if ($primaryLibServer=~/[^\w\-.]/) { $error.="\nPrimary library server ID $primaryLibServer contains special characters"; }
+   if ($primaryLibServer=~/[^\w\-.]/) { push(@error,"Primary library server ID $primaryLibServer contains special characters"); }
 }
 
 
-if ($error) { print "\n*** ERRORS: $error\n"; }
+if (@error) { print "\n*** ERRORS: \n\t".join("\n\t",@error)."\n"; }
   print(&lt;&lt;END);
 ENTER A CHOICE OF 1-11 TO CHANGE, otherwise ENTER 12:
 END