--- loncom/Attic/lonManage	2003/08/12 11:02:59	1.6
+++ loncom/Attic/lonManage	2003/08/18 10:25:46	1.9
@@ -3,9 +3,9 @@
 #
 #  lonManage supports remote management of nodes in a LonCAPA cluster.
 #
-#  $Id: lonManage,v 1.6 2003/08/12 11:02:59 foxr Exp $
+#  $Id: lonManage,v 1.9 2003/08/18 10:25:46 foxr Exp $
 #
-# $Id: lonManage,v 1.6 2003/08/12 11:02:59 foxr Exp $
+# $Id: lonManage,v 1.9 2003/08/18 10:25:46 foxr Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -50,6 +50,20 @@
 #    not the IP address of the host.
 #
 #  $Log: lonManage,v $
+#  Revision 1.9  2003/08/18 10:25:46  foxr
+#  Write ReinitProcess function in terms of ValidHost and Transact.
+#
+#  Revision 1.8  2003/08/18 10:18:21  foxr
+#  Completed PushFile function in terms of
+#  - ValidHost - Determines if target host is valid.
+#  - Transact  - Performs one of the valid transactions with the
+#                appropriate lonc<-->lond client/server pairs.
+#
+#  Revision 1.7  2003/08/18 09:56:01  foxr
+#  1. Require to be run as root.
+#  2. Catch case where no operation switch is supplied and put out usage.
+#  3. skeleton/comments for PushFile function.
+#
 #  Revision 1.6  2003/08/12 11:02:59  foxr
 #  Implement command switch dispatching.
 #
@@ -66,6 +80,8 @@
 #  Add usage and skeleton documentation.
 #
 #
+use strict;			# Because it's good practice.
+use English;			# Cause I like meaningful names.
 use Getopt::Long;
 
 sub Usage  {
@@ -80,7 +96,7 @@ sub Usage  {
     lonManage  --reinit=lonc host
            Sends a HUP signal to the remote systems's lond.
 
-    lonmanage  --reinit=lond host
+    lonManage  --reinit=lond host
           Requests the remote system's lond perform the same action as if
           it had received a HUP signal.
 
@@ -116,7 +132,7 @@ USAGE
 
 sub ParseArgs {
     my $pushing   = '';
-    my $reiniting = '';
+    my $reinitting = '';
 
     if(!GetOptions('push=s'    => \$pushing,
 	           'reinit=s'  => \$reinitting)) {
@@ -171,45 +187,124 @@ sub ParseArgs {
     
     return @result;
 }
+sub ValidHost {
+    return 1;
+}
+sub Transact {
+}
+#
+#   Called to push a file to the remote system.
+#   The only legal files to push are hosts.tab and domain.tab.
+#   Security is somewhat improved by
+#   
+#   - Requiring the user run as root.
+#   - Connecting with lonc rather than lond directly ensuring this is a loncapa
+#     host
+#   - We must appear in the remote host's hosts.tab file.
+#   - The host must appear in our hosts.tab file.
+#
+#  Parameters:
+#     tablename - must be one of hosts or domain.
+#     tablefile - name of the file containing the table to push.
+#     host      - name of the host to push this file to.     
+#
+sub PushFile {
+    my $tablename = shift;
+    my $tablefile = shift;
+    my $host      = shift;
+    
+    # Open the table file:
+
+    if(!open(TABLEFILE, "<$tablefile")) {
+	die "ENOENT - No such file or directory $tablefile";
+    }
+  
+    # Require that the host be valid:
+
+    if(!ValidHost($host)) {
+	die "EHOSTINVAL - Invalid host $host"; # Ok so I invented this 'errno'.
+    }
+    # Read in the file.  If the table name is valid, push it.
+
+    my @table = <TABLEFILE>;	#  These files are pretty small.
+    close TABLEFILE;
+
+    if( ($tablename eq "host")    ||
+	($tablename eq "domain")) {
+	Transact($host, "pushfile:$tablename:",\@table);
+    } else {
+	die "EINVAL - Invalid parameter. tablename: $tablename must be host or domain";
+    }
+}
+#
+#   This function is called to reinitialize a server in a remote host.
+#   The servers that can be reinitialized are:
+#   - lonc   - The lonc client process.
+#   - lond   - The lond daemon.
+#  NOTE:
+#    Reinitialization in this case means re-scanning the hosts table,
+#    starting new lond/lonc's as approprate and stopping existing lonc/lond's.
+#
+#  Parameters:
+#     process - The name of the process to reinit (lonc or lond).
+#     host    - The host in which this reinit will happen.
+#
+sub ReinitProcess {
+    my $process = shift;
+    my $host    = shift;
+
+    #  Ensure the host is valid:
+    
+    if(!ValidHost($host)) {
+	die "EHOSTINVAL - Invalid host $host";
+    }
+    # Ensure target process selector is valid:
 
+    if(($process eq "lonc") ||
+       ($process eq "lond")) {
+	Transact($host, "reinit:$process");
+    } else {
+	die "EINVAL -Invalid parameter. Process $process must be lonc or lond";
+    }
+}
 #--------------------------- Entry point: --------------------------
 
 #  Parse the parameters
 #  If command parsing failed, then print usage:
 
-@params = ParseArgs;
-$nparam   = @params;
+my @params   = ParseArgs;
+my $nparam   = @params;
 
 if($nparam == 0) {
     Usage;
     exit -1;
 }
-
-
-sub PushFile {
-    print "Pushing a file\n";
+#
+#   Next, ensure we are running as EID root.
+#
+if ($EUID != 0) {
+    die "ENOPRIV - No privilege for requested operation"
 }
 
-sub ReinitProcess {
-    print "Reinitializing a process\n";
-}
 
 #   Based on the operation requested invoke the appropriate function:
 
-$operation = shift @params;
+my $operation = shift @params;
 
 if($operation eq "push") {  # push tablename filename host
-    $tablename = shift @params;
-    $tablefile = shift @params;
-    $host      = shift @params;
+    my $tablename = shift @params;
+    my $tablefile = shift @params;
+    my $host      = shift @params;
     PushFile($tablename, $tablefile, $host);
 
-}
-if($operation eq "reinit") {	# reinit processname host.
-    $process   = shift @params;
-    $host      = shift @params;
+} elsif($operation eq "reinit") {	# reinit processname host.
+    my $process   = shift @params;
+    my $host      = shift @params;
     ReinitProcess($process, $host);
 }
+else {
+    Usage;
+}
 exit 0;
 
 =head1 NAME
@@ -240,7 +335,9 @@ Usage:
 
 =head1 PREREQUISITES
 
+=item strict
 =item Getopt::Long
+=item English
 
 =head1  CATEGORIES
     Command line utility