--- loncom/LondConnection.pm 2004/02/09 10:57:37 1.24 +++ loncom/LondConnection.pm 2004/03/02 22:38:07 1.29 @@ -1,7 +1,7 @@ # This module defines and implements a class that represents # a connection to a lond daemon. # -# $Id: LondConnection.pm,v 1.24 2004/02/09 10:57:37 foxr Exp $ +# $Id: LondConnection.pm,v 1.29 2004/03/02 22:38:07 albertel Exp $ # # Copyright Michigan State University Board of Trustees # @@ -279,7 +279,15 @@ sub Readable { my $self = shift; my $socket = $self->{Socket}; my $data = ''; - my $rv = $socket->recv($data, POSIX::BUFSIZ, 0); + my $rv; + if ($socket) { + eval { + $rv = $socket->recv($data, POSIX::BUFSIZ, 0); + } + } else { + $self->Transition("Disconnected"); + return -1; + } my $errno = $! + 0; # Force numeric context. unless (defined($rv) && length $data) {# Read failed, @@ -300,7 +308,7 @@ sub Readable { &Debug(9,"Received from host: ".$data); $self->{TransactionReply} .= $data; - if($self->{TransactionReply} =~ /(.*\n)/) { + if($self->{TransactionReply} =~ m/\n$/) { &Debug(8,"Readable End of line detected"); if ($self->{State} eq "Initialized") { # We received the challenge: if($self->{TransactionReply} eq "refused\n") { # Remote doesn't have @@ -317,36 +325,36 @@ sub Readable { $self->Transition("ChallengeReceived"); $self->{TimeoutRemaining} = $self->{TimeoutValue}; return 0; - } elsif ($self->{State} eq "ChallengeReplied") { - if($self->{TransactionReply} ne "ok\n") { - $self->Transition("Disconnected"); - $socket->close(); - return -1; - } - $self->Transition("RequestingVersion"); - $self->{InformReadable} = 0; - $self->{InformWritable} = 1; - $self->{TransactionRequest} = "version\n"; - return 0; - } elsif ($self->{State} eq "ReadingVersionString") { - $self->{LondVersion} = chomp($self->{TransactionReply}); - $self->Transition("SetHost"); - $self->{InformReadable} = 0; - $self->{InformWritable} = 1; - my $peer = $self->{LoncapaHim}; - $self->{TransactionRequest}= "sethost:$peer\n"; - return 0; + } elsif ($self->{State} eq "ChallengeReplied") { + if($self->{TransactionReply} ne "ok\n") { + $self->Transition("Disconnected"); + $socket->close(); + return -1; + } + $self->Transition("RequestingVersion"); + $self->{InformReadable} = 0; + $self->{InformWritable} = 1; + $self->{TransactionRequest} = "version\n"; + return 0; + } elsif ($self->{State} eq "ReadingVersionString") { + $self->{LondVersion} = chomp($self->{TransactionReply}); + $self->Transition("SetHost"); + $self->{InformReadable} = 0; + $self->{InformWritable} = 1; + my $peer = $self->{LoncapaHim}; + $self->{TransactionRequest}= "sethost:$peer\n"; + return 0; } elsif ($self->{State} eq "HostSet") { # should be ok. - if($self->{TransactionReply} ne "ok\n") { - $self->Transition("Disconnected"); - $socket->close(); - return -1; - } - $self->Transition("RequestingKey"); - $self->{InformReadable} = 0; - $self->{InformWritable} = 1; - $self->{TransactionRequest} = "ekey\n"; - return 0; + if($self->{TransactionReply} ne "ok\n") { + $self->Transition("Disconnected"); + $socket->close(); + return -1; + } + $self->Transition("RequestingKey"); + $self->{InformReadable} = 0; + $self->{InformWritable} = 1; + $self->{TransactionRequest} = "ekey\n"; + return 0; } elsif ($self->{State} eq "ReceivingKey") { my $buildkey = $self->{TransactionReply}; my $key = $self->{LoncapaHim}.$perlvar{'lonHostID'}; @@ -413,7 +421,18 @@ Returns 0 if successful, or -1 if not. sub Writable { my $self = shift; # Get reference to the object. my $socket = $self->{Socket}; - my $nwritten = $socket->send($self->{TransactionRequest}, 0); + my $nwritten; + if ($socket) { + eval { + $nwritten = $socket->send($self->{TransactionRequest}, 0); + } + } else { + # For whatever reason, there's no longer a socket left. + + + $self->Transition("Disconnected"); + return -1; + } my $errno = $! + 0; unless (defined $nwritten) { if($errno != POSIX::EINTR) {