--- loncom/auth/lonacc.pm 2013/12/13 01:41:08 1.148 +++ loncom/auth/lonacc.pm 2013/12/13 02:10:27 1.149 @@ -1,7 +1,7 @@ # The LearningOnline Network # Cookie Based Access Handler # -# $Id: lonacc.pm,v 1.148 2013/12/13 01:41:08 raeburn Exp $ +# $Id: lonacc.pm,v 1.149 2013/12/13 02:10:27 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -264,19 +264,21 @@ sub upload_size_allowed { =item sso_login() handle the case of the single sign on user, at this point $r->user - will be set and valia;d now need to find the loncapa user info, and possibly - balance them. If Apache >= 2.4, $r->user() will also have been set so - $curruser is checked, and if null, this is an SSO case. - returns OK if it was a SSO and user was handled - undef if not SSO or no means to hanle the user + will be set and valid now need to find the loncapa user info, and possibly + balance them. If $r->user() is set this means either it was either set by + SSO or by checkauthen.pm if a valid cookie was found. The latter case can + be identified by the third arg ($usename). + + returns OK if it was SSO and user was handled. + returns undef if not SSO or no means to handle the user. =cut sub sso_login { - my ($r,$handle,$curruser) = @_; + my ($r,$handle,$username) = @_; my $lonidsdir=$r->dir_config('lonIDsDir'); - if (($r->user eq '') || ($curruser ne '') || + if (($r->user eq '') || ($username ne '') || (defined($env{'user.name'}) && (defined($env{'user.domain'})) && ($handle ne ''))) { # not an SSO case or already logged in @@ -405,18 +407,19 @@ sub sso_login { sub handler { my $r = shift; my $requrl=$r->uri; - if (&Apache::lonnet::is_domainimage($requrl)) { + + if ($requrl =~ m{^/res/adm/pages/[^/]+\.(gif|png)$}) { return OK; } - if ($requrl =~ m{^/res/adm/pages/[^/]+\.(gif|png)$}) { + if (&Apache::lonnet::is_domainimage($requrl)) { return OK; } - my $curruser; - my $handle = &Apache::lonnet::check_for_valid_session($r,undef,\$curruser); + my %user; + my $handle = &Apache::lonnet::check_for_valid_session($r,undef,\%user); - my $result = &sso_login($r,$handle,$curruser); + my $result = &sso_login($r,$handle,$user{'name'}); if (defined($result)) { return $result; } @@ -425,7 +428,7 @@ sub handler { if ($handle eq '') { unless (($requrl eq '/adm/switchserver') && (!$r->is_initial_req())) { - $r->log_reason("Cookie $handle not valid", $r->filename); + $r->log_reason("Cookie not valid", $r->filename); } } elsif ($handle ne '') {