--- loncom/auth/lonacc.pm 2020/10/01 21:37:16 1.159.2.5.2.4 +++ loncom/auth/lonacc.pm 2018/09/05 23:06:53 1.159.2.6 @@ -1,7 +1,7 @@ # The LearningOnline Network # Cookie Based Access Handler # -# $Id: lonacc.pm,v 1.159.2.5.2.4 2020/10/01 21:37:16 raeburn Exp $ +# $Id: lonacc.pm,v 1.159.2.6 2018/09/05 23:06:53 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -351,14 +351,6 @@ sub sso_login { # login but immediately go to switch server to find us a new # machine &Apache::lonauth::success($r,$user,$domain,$home,'noredirect'); - foreach my $item (keys(%form)) { - $env{'form.'.$item} = $form{$item}; - } - unless ($form{'symb'}) { - unless (($r->uri eq '/adm/roles') || ($r->uri eq '/adm/sso')) { - $env{'form.origurl'} = $r->uri; - } - } $env{'request.sso.login'} = 1; if (defined($r->dir_config("lonSSOReloginServer"))) { $env{'request.sso.reloginserver'} = @@ -524,8 +516,7 @@ sub handler { } } elsif ($env{'request.course.id'} && (($requrl =~ m{^/adm/$match_domain/$match_username/aboutme$}) || - ($requrl =~ m{^/public/$cdom/$cnum/syllabus$}) || - ($requrl =~ m{^/adm/$cdom/$cnum/\d+/ext\.tool$}))) { + ($requrl =~ m{^/public/$cdom/$cnum/syllabus$}))) { my $query = $r->args; if ($query) { foreach my $pair (split(/&/,$query)) { @@ -534,7 +525,6 @@ sub handler { if ($value =~ /^supplemental/) { $suppext = 1; } - last; } } } @@ -547,7 +537,6 @@ sub handler { my $lonhost = &Apache::lonnet::host_from_dns($hostname); if ($lonhost) { my $actual = &Apache::lonnet::absolute_url($hostname); - my $exphostname = &Apache::lonnet::hostname($lonhost); my $expected = $Apache::lonnet::protocol{$lonhost}.'://'.$hostname; unless ($actual eq $expected) { $env{'request.use_absolute'} = $expected; @@ -585,67 +574,12 @@ sub handler { $env{'form.origurl'} = $r->uri; } } - if ($requrl=~m{^/+tiny/+$match_domain/+\w+$}) { - return OK; - } # ---------------------------------------------------------------- Check access my $now = time; - my $check_symb; if ($requrl !~ m{^/(?:adm|public|prtspool)/} || $requrl =~ /^\/adm\/.*\/(smppg|bulletinboard)(\?|$ )/x) { - my ($access,$poss_symb); - if (($env{'request.course.id'}) && (!$suppext)) { - $requrl=~/\.(\w+)$/; - if ((&Apache::loncommon::fileembstyle($1) eq 'ssi') || - ($requrl=~/^\/adm\/.*\/(aboutme|smppg|bulletinboard)(\?|$ )/x) || - ($requrl=~/^\/adm\/wrapper\//) || - ($requrl=~m|^/adm/coursedocs/showdoc/|) || - ($requrl=~m|\.problem/smpedit$|) || - ($requrl=~/^\/public\/.*\/syllabus$/) || - ($requrl=~/^\/adm\/(viewclasslist|navmaps)$/) || - ($requrl=~/^\/adm\/.*\/aboutme\/portfolio(\?|$)/) - ($requrl=~m{^/adm/$cdom/$cnum/\d+/ext\.tool$})) { - $check_symb = 1; - } - } - if ($check_symb) { - if ($env{'form.symb'}) { - $poss_symb=&Apache::lonnet::symbclean($env{'form.symb'}); - } elsif (($env{'request.course.id'}) && ($r->args ne '')) { - my $query = $r->args; - foreach my $pair (split(/&/,$query)) { - my ($name, $value) = split(/=/,$pair); - $name = &unescape($name); - $value =~ tr/+/ /; - $value =~ s/%([a-fA-F0-9][a-fA-F0-9])/pack("C",hex($1))/eg; - if ($name eq 'symb') { - $poss_symb = &Apache::lonnet::symbclean($value); - last; - } - } - } - if ($poss_symb) { - my ($possmap,$resid,$url)=&Apache::lonnet::decode_symb($poss_symb); - $url = &Apache::lonnet::clutter($url); - unless (($url eq $requrl) && (&Apache::lonnet::is_on_map($possmap))) { - undef($poss_symb); - } - if ($poss_symb) { - if ((!$env{'request.role.adv'}) && ($env{'acc.randomout'}) && - ($env{'acc.randomout'}=~/\&\Q$poss_symb\E\&/)) { - undef($poss_symb); - } - } - } - if ($poss_symb) { - $access=&Apache::lonnet::allowed('bre',$requrl,$poss_symb); - } else { - $access=&Apache::lonnet::allowed('bre',$requrl,'','','','',1); - } - } else { - $access=&Apache::lonnet::allowed('bre',$requrl); - } + my $access=&Apache::lonnet::allowed('bre',$requrl); if ($handle eq '') { unless ($access eq 'F') { if ($requrl =~ m{^/res/$match_domain/$match_username/}) { @@ -662,14 +596,6 @@ sub handler { return OK; } if ($access eq 'B') { - if ($poss_symb) { - if ($requrl=~m{^(/adm/.*/aboutme)/portfolio$}) { - $requrl = $1; - } - if (&Apache::lonnet::symbverify($poss_symb,$requrl)) { - $env{'request.symb'} = $poss_symb; - } - } &Apache::blockedaccess::setup_handler($r); return OK; } @@ -720,7 +646,7 @@ sub handler { $env{'user.domain'} eq 'public' && $requrl !~ m{^/+(res|public|uploaded)/} && $requrl !~ m{^/adm/[^/]+/[^/]+/aboutme/portfolio$ }x && - $requrl !~ m{^/adm/blockingstatus/.*$} && + $requrl !~ m{^/adm/blockingstatus/.*$} && $requrl !~ m{^/+adm/(help|logout|restrictedaccess|randomlabel\.png)}) { $env{'request.querystring'}=$r->args; $env{'request.firsturl'}=$requrl; @@ -729,8 +655,16 @@ sub handler { # ------------------------------------------------------------- This is allowed if ($env{'request.course.id'}) { &Apache::lonnet::countacc($requrl); + $requrl=~/\.(\w+)$/; my $query=$r->args; - if ($check_symb) { + if ((&Apache::loncommon::fileembstyle($1) eq 'ssi') || + ($requrl=~/^\/adm\/.*\/(aboutme|smppg|bulletinboard)(\?|$ )/x) || + ($requrl=~/^\/adm\/wrapper\//) || + ($requrl=~m|^/adm/coursedocs/showdoc/|) || + ($requrl=~m|\.problem/smpedit$|) || + ($requrl=~/^\/public\/.*\/syllabus$/) || + ($requrl=~/^\/adm\/(viewclasslist|navmaps)$/) || + ($requrl=~/^\/adm\/.*\/aboutme\/portfolio(\?|$)/)) { # ------------------------------------- This is serious stuff, get symb and log my $symb; if ($query) { @@ -762,50 +696,24 @@ sub handler { if ($requrl=~m{^(/adm/.*/aboutme)/portfolio$}) { $requrl = $1; } - $symb=&Apache::lonnet::symbread($requrl); - if (&Apache::lonnet::is_on_map($requrl) && $symb) { - my ($encstate,$invalidsymb); - unless (&Apache::lonnet::symbverify($symb,$requrl,\$encstate)) { - $invalidsymb = 1; - # - # If $env{'request.enc'} is true, but no encryption for $symb retrieved - # by original lonnet::symbread() call, call again to check for an instance - # of $requrl in the course which has encryption, and set that as the symb. - # If there is no such symb, or symbverify() fails for the new symb proceed - # to report invalid symb. - # - if ($env{'request.enc'} && !$encstate) { - my %possibles; - my $nocache = 1; - $symb = &Apache::lonnet::symbread($requrl,'','','',\%possibles,$nocache); - if ($symb) { - if (&Apache::lonnet::symbverify($symb,$requrl)) { - $invalidsymb = ''; - } - } elsif (keys(%possibles) > 1) { - $r->internal_redirect('/adm/ambiguous'); - return OK; - } - } - if ($invalidsymb) { - $r->log_reason('Invalid symb for '.$requrl.': '.$symb); - $env{'user.error.msg'}= - "$requrl:bre:1:1:Invalid Access"; - return HTTP_NOT_ACCEPTABLE; - } - } - } - if ($symb) { - my ($map,$mid,$murl)= - &Apache::lonnet::decode_symb($symb); - &Apache::lonnet::symblist($map,$murl =>[$murl,$mid], - 'last_known' =>[$murl,$mid]); + unless ($suppext) { + $symb=&Apache::lonnet::symbread($requrl); + if (&Apache::lonnet::is_on_map($requrl) && $symb && + !&Apache::lonnet::symbverify($symb,$requrl)) { + $r->log_reason('Invalid symb for '.$requrl.': '.$symb); + $env{'user.error.msg'}= + "$requrl:bre:1:1:Invalid Access"; + return HTTP_NOT_ACCEPTABLE; + } + if ($symb) { + my ($map,$mid,$murl)= + &Apache::lonnet::decode_symb($symb); + &Apache::lonnet::symblist($map,$murl =>[$murl,$mid], + 'last_known' =>[$murl,$mid]); + } } } $env{'request.symb'}=$symb; - if (($env{'request.symbread.cached.'}) && ($env{'request.symbread.cached.'} ne $symb)) { - $env{'request.symbread.cached.'} = $symb; - } &Apache::lonnet::courseacclog($symb); } else { # ------------------------------------------------------- This is other content