--- loncom/auth/lonacc.pm	2006/07/14 21:38:26	1.86
+++ loncom/auth/lonacc.pm	2006/07/17 19:49:14	1.87
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Cookie Based Access Handler
 #
-# $Id: lonacc.pm,v 1.86 2006/07/14 21:38:26 albertel Exp $
+# $Id: lonacc.pm,v 1.87 2006/07/17 19:49:14 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -138,7 +138,21 @@ sub get_posted_cgi {
 }
 
 sub portfolio_access {
+    my ($r,$requrl) = @_;
+    my (undef,$udom,$unum,$file_name,$group) = &parse_portfolio_url($requrl);
+    my $result = &get_portfolio_access($udom,$unum,$file_name,$group);
+    if ($result eq 'ok') {
+	return OK;
+    } elsif ($result =~ /^[^:]+:guest_/) {
+	&passphrase_access_checker($r,$result,$requrl);
+	return OK;
+    }
+    return FORBIDDEN;
+}
+
+sub get_portfolio_access {
     my ($udom,$unum,$file_name,$group) = @_;
+ 
     my $current_perms = &Apache::lonnet::get_portfile_permissions($udom,$unum);
     my %access_controls = &Apache::lonnet::get_access_controls(
                                              $current_perms,$group,$file_name);
@@ -322,6 +336,34 @@ sub course_group_datechecker {
     return; 
 }
 
+sub parse_portfolio_url {
+    my ($url) = @_;
+
+    my ($type,$udom,$unum,$group,$file_name);
+    
+    if ($url =~  m-/+uploaded/([^/]+)/([^/]+)/portfolio(/.+)$-) {
+	$type = 1;
+        $udom = $1;
+        $unum = $2;
+        $file_name = $3;
+    } elsif ($url =~ m-/+uploaded/([^/]+)/([^/]+)/groups/([^/]+)/portfolio/(.+)$-) {
+	$type = 2;
+        $udom = $1;
+        $unum = $2;
+        $group = $3;
+        $file_name = $3.'/'.$4;
+    }
+    if (wantarray) {
+	return ($type,$udom,$unum,$file_name,$group);
+    }
+    return $type;
+}
+
+sub is_portfolio_url {
+    my ($url) = @_;
+    return scalar(&parse_portfolio_url($url));
+}
+
 sub handler {
     my $r = shift;
     my $requrl=$r->uri;
@@ -384,23 +426,9 @@ sub handler {
 
 # ---------------------------------------------------------------- Check access
             my $now = time;
-            if ($requrl =~ m|/+uploaded/([^/]+)/([^/]+)/portfolio(/.+)$|) {
-                my $result = &portfolio_access($1,$2,$3);
-                if ($result eq 'ok') {
-                    return OK;
-                } elsif ($result =~ /^[^:]+:guest_/) {
-                    &passphrase_access_checker($r,$result,$requrl);
-		    return OK;
-                }
-            } elsif ($requrl =~ m|/+uploaded/([^/]+)/([^/]+)/groups/([^/]+)/portfolio/(.+)$|) {
-                my $result = &portfolio_access($1,$2,$3.'/'.$4,$3);
-                if ($result eq 'ok') {
-                    return OK;
-                } elsif ($result =~ /^[^:]+:guest_/) {
-                    &passphrase_access_checker($r,$result,$requrl);
-		    return OK;
-                }
-            }
+	    if (&is_portfolio_url($requrl)) {
+		return &portfolio_access($r,$requrl);
+	    }
             if ($requrl!~/^\/adm|public|prtspool\//) {
 		my $access=&Apache::lonnet::allowed('bre',$requrl);
                 if ($access eq '1') {
@@ -514,23 +542,10 @@ sub handler {
 	return OK;
     }
 # ------------------------------------- See if this is a viewable portfolio file
-    if ($requrl =~ m|/+uploaded/([^/]+)/([^/]+)/portfolio(/.+)$|) {
-        my $result = &portfolio_access($1,$2,$3);
-        if ($result eq 'ok') {
-            return OK;
-        } elsif ($result =~ /^[^:]+:guest_/) {
-            &passphrase_access_checker($r,$result,$requrl);
-	    return OK;
-        }
-    } elsif ($requrl =~ m|/+uploaded/([^/]+)/([^/]+)/groups/([^/]+)/portfolio/(.+)$|) {
-        my $result = &portfolio_access($1,$2,$3.'/'.$4,$3);
-        if ($result eq 'ok') {
-            return OK;
-        } elsif ($result =~ /^[^:]+:guest_/) {
-            &passphrase_access_checker($r,$result,$requrl);
-	    return OK;
-	}
+    if (&is_portfolio_url($requrl)) {
+	return &portfolio_access($r,$requrl);
     }
+
 # -------------------------------------------------------------- Not authorized
     $requrl=~/\.(\w+)$/;
 #    if ((&Apache::loncommon::fileembstyle($1) eq 'ssi') ||