--- loncom/auth/lonauth.pm	2003/03/02 02:16:53	1.43
+++ loncom/auth/lonauth.pm	2003/06/06 02:24:49	1.52
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # User Authentication Module
 #
-# $Id: lonauth.pm,v 1.43 2003/03/02 02:16:53 www Exp $
+# $Id: lonauth.pm,v 1.52 2003/06/06 02:24:49 www Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -42,6 +42,7 @@ use CGI qw(:standard);
 use CGI::Cookie();
 use DynaLoader; # for Crypt::DES version
 use Crypt::DES;
+use Apache::loncommon();
 use Apache::lonnet();
 use Apache::lonmenu();
 use Fcntl qw(:flock);
@@ -77,36 +78,8 @@ sub success {
 
 # ------------------------------------ Check browser type and MathML capability
 
-    my @browsertype=split(/\&/,$r->dir_config("lonBrowsDet"));
-    my %mathcap=split(/\&/,$r->dir_config("lonMathML"));
-    my $httpbrowser=$ENV{"HTTP_USER_AGENT"};
-    my $i;
-    my $clientbrowser='unknown';
-    my $clientversion='0';
-    my $clientmathml='';
-    my $clientunicode='0';
-    for ($i=0;$i<=$#browsertype;$i++) {
-        my ($bname,$match,$notmatch,$vreg,$minv,$univ)=split(/\:/,$browsertype[$i]);
-	if (($httpbrowser=~/$match/i)  && ($httpbrowser!~/$notmatch/i)) {
-	    $clientbrowser=$bname;
-            $httpbrowser=~/$vreg/i;
-	    $clientversion=$1;
-            $clientmathml=($clientversion>=$minv);
-            $clientunicode=($clientversion>=$univ);
-	}
-    }
-    my $clientos='unknown';
-    if (($httpbrowser=~/linux/i) ||
-        ($httpbrowser=~/unix/i) ||
-        ($httpbrowser=~/ux/i) ||
-        ($httpbrowser=~/solaris/i)) { $clientos='unix'; }
-    if (($httpbrowser=~/vax/i) ||
-        ($httpbrowser=~/vms/i)) { $clientos='vms'; }
-    if ($httpbrowser=~/next/i) { $clientos='next'; }
-    if (($httpbrowser=~/mac/i) ||
-        ($httpbrowser=~/powerpc/i)) { $clientos='mac'; }
-    if ($httpbrowser=~/win/i) { $clientos='win'; }
-    if ($httpbrowser=~/embed/i) { $clientos='pda'; }
+    my ($httpbrowser,$clientbrowser,$clientversion,$clientmathml,
+        $clientunicode,$clientos) = &Apache::loncommon::decode_user_agent($r);
 
 # -------------------------------------- Any accessibility options to remember?
     if (($FORM{'interface'}) && ($FORM{'remember'} eq 'true')) {
@@ -133,6 +106,7 @@ sub success {
     if (($userenv{'interface'}) && (!$FORM{'interface'})) {
 	$FORM{'interface'}=$userenv{'interface'};
     }
+    $ENV{'environment.remote'}=$userenv{'remote'};
 # --------------------------------------------------------- Write first profile
 
     {
@@ -156,6 +130,7 @@ sub success {
 	print $idf "request.course.uri=\n";
 	print $idf "request.course.sec=\n";
 	print $idf "request.role=cm\n";
+        print $idf "request.role.adv=$ENV{'user.adv'}\n";
 	print $idf "request.host=$ENV{'REMOTE_ADDR'}\n";
 	if ($FORM{'interface'}) {
 	    $FORM{'interface'}=~s/\W//gs;
@@ -173,6 +148,7 @@ sub success {
 	$idf->close();
     }
     $ENV{'request.role'}='cm';
+    $ENV{'request.role.adv'}=$ENV{'user.adv'};
     $ENV{'browser.type'}=$clientbrowser;
 # -------------------------------------------------------------------- Log this
 
@@ -242,7 +218,7 @@ ENDFHEADER
 $bodytag
 <h1>Sorry ...</h1>
 <p><b>$message</b></p>
-<p>Please <a href="/adm/login?username=$FORM{'uname'}&domain=$FORM{'udom'}">login</a> again.</p>
+<p>Please <a href="/adm/login?username=$FORM{'uname'}&domain=$FORM{'udom'}">log in again</a>.</p>
 <p>
 <a href="/adm/loginproblems.html">Problems?</a></p>
 </body>
@@ -256,7 +232,7 @@ sub handler {
     my $r = shift;
 
     my $buffer;
-    $r->read($buffer,$r->header_in('Content-length'));
+    $r->read($buffer,$r->header_in('Content-length'),0);
     my @pairs=split(/&/,$buffer);
     my $pair; my $name; my $value;
     undef %FORM;
@@ -287,8 +263,12 @@ sub handler {
     if (($tmpinfo=~/^error/) || ($tmpinfo eq 'con_lost')) {
 	failed($r,'Information needed to verify your login information is missing, inaccessible or expired.');
         return OK;
+    } else {
+        unless (&Apache::lonnet::reply('tmpdel:'.$FORM{'logtoken'},
+                                         $FORM{'serverid'}) eq 'ok') {
+            &failed($r,'Session could not be opened.');
+	}
     }
-    
     my ($key,$firsturl)=split(/&/,$tmpinfo);
 
     my $keybin=pack("H16",$key);