CVS log for loncom/auth/lonroles.pm

Up to [LON-CAPA] / loncom / auth

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- For 2.11.4 (modified)
  Include changes in 1.372

- For 2.11.4 (modified)
  Include changes in 1.371

- Available editors in Authoring Space: value set for specific author can
  override domain default.

- Show correct role name for currently selected ad hoc helpdesk role in course.

- Support case where assignment of roles in a different domain is queued
  pending acceptance of the role by the role recipient.
  - A user can also choose to decline the role.
  - Domain configuration can be set for domain roles, co-author roles,
    course roles and community roles.

- For 2.11.4 (modified)
  Include changes in 1.368, 1.369

- Bug 6975
  - &get_supplemental() routine moved from lonnet.pm to loncommon.pm
  - use LONCAPA::map() moved out of conditional block in loncommon.pm
  - $keeporder arg for update_content_constraints() no longer needed

- Bug 6975
  Folders and Resources in Supplemental Content area can be hidden using
  Course Editor.

- For 2.11.4 (modified)
  Include changes in 1.367

- For 'Map not loaded' error on course initialization for a map in /res which
  user can edit switch server loads map (or parent map) in Authoring Space.

- For 2.11.4 (modified)
  Include changes in 1.365, 1.366

- Bug 6907
  - When loading role after launch via deep link to tiny URL just display
    "Continue" link.

- Bug 6907
  - Set request.linkprotuser in %env for students accessing deep-linked items
    with LTI link protection which includes username from other LMS.
  - Set "only_body" for intermediate pages shown while session is being set up
    for LTI link-protected access.
  - Provide appropriate feedback when a deep link is followed but the user
    only has a future and/or expired role in the target course.

- For 2.11.4 (modified)
  Include changes in rev. 1.363 and 1.364.

- Bug 6907
  Remove request.deeplink.target, if set, when deeplink no longer in effect.

- Bug 6907 option to stop deep-linked items escaping iframe context.
  Seventh component (target) added to the deeplink parameter.
  Launch of deep-link (i.e. a tiny URL) sets $env{'request.deeplink.target'}.

- For 2.11.4 (modified)
  Include changes in 1.360, 1.362

- For 2.11
  - Backport 1.360, 1.362
  - Remove part of 1.269.2.39 which supports LTI; not used in 2.11

- xhtml validation

- Punctuation

- xhtml validation

- For 2.11.4 (modified)
  - If menu collection in use for selected course role collapse Remote
  Control.
  - If current role is in a course, and menu collection in use, disallow
  launch of Remote Control.

- For 2.11.4 (modified)
  Include changes in 1.332, 1.346 (part), 1.350, 1.351 (part), 1.352, 1.353,
  1.355, 1.356

- For 2.11
  Backport 1.313 (part), 1.345, 1.346 (part), 1.347, 1.348, 1.349,
           1.351 (part), 1.354, 1.357, 1.358, 1.359

- Bug 6955 IP-based blocking. Pass user'sIP address as third arg to
  loncommon::blockcheck() and second to loncommon::blocking_status().

- Include "package path".

- Bug 6955. Domain configuration to limit selection of course role based on
  user's IP address.

- Typo.

- Modified roles/courses page when /adm/roles is error document for 406
  (unauthorized access) and session was launched via deeplink, with
  Roles/Courses link disabled in menu collection.

- Menu links on page displaying progress indicator while course role loads
  set to be unclickable until course is loaded.
- "Continue" link shown on page once course is loaded.

- Bug 6907
  - Use of token to store linkprot or linkkey compatible with use of
    btoken and iptoken (for load balancing and IP change respectively).
  - Launching access from a deeplink, with its own ltoken and/or linkkey,
    for a user session originally launched from a different deeplink will
    update required session information.

- When access is via deep-link and menu collection in effect is configured
  to omit Courses/Roles link, roles listing shows only current role.

- Support case where first URL in course is an external resource and
  encrypturl in use.
- Use symb in first_url from lonuserstate::readmap() for other resources
  besides external resource.
- Retrieve symb in first_url in lonpageflip::first_accessible_resource()
  when encrypturl in use.

- Bug 6907
  On role selection in a course, if first resource is deeplink-only and login
  was not via a deeplink which provides access, find first accessible one.

- Bug 6914
  Update domain config UI to support settings documented in
  Domain_Configuration_WAF_Proxy.tex

- Fix typos in rev. 1.345 and 1.347.

- Display progress indicator after selecting role in a course while course
  session is established.

- Only check for critical messages initializing course session, when
  readmap() is called from roles screen, and critical alerts are *not*
  blocked for selected course.

- Verify symb in query string (if included) before internal redirect to
  load course role.

- For 2.11.3 (modified)
  Include changes in 1.344

- For 2.11
  Backport 1.344

- Retrieval of requestor's IP address centralized in lonnet::get_requestor_ip()
- Domain configuration to allow domain's LON-CAPA nodes to operate behind a
  WAF/Reverse Proxy using aliased hostname (CNAME).
- Web requests from other nodes bypass the WAF as their requests are made
  directly to the server hostname (A record); same for internal LON-CAPA
  connections for lonc -> lond.

- For 2.11.3 (modified)
  Include changes in 1.332

- For 2.11.2
  Include changes in 1.332

- For 2.11
  Backport 1.343

- Suggest use of "Check for changes" link as way to update roles list, when
  an unprivileged user has no roles listed, and it is more than 10 minutes
  since last check (or log-in).

- For 2.11
  Backport 1.326, 1.327, 1.342

- For servers using Apache/SSL where External Resource points at http:// URL
  or syllabus is configured to use an external http:// URL, query string for
  links contains usehttp=1, unless server has Strict-Transport-Security set
  for Apache with max-age > 0.

- Trust settings
  - Correct key for: "Co-author roles for this domain's users elsewhere".

- Trust settings
  - Fix logic for checking whether co-author role admissible
  - Correct key for: "Co-author roles for this domain's users elsewhere".

- For 2.11
  Backport 1.334, 1.336.

- Bug 6754 LON-CAPA as LTI Provider
  - If LTI Consumer does not provide 'launch_presentation_document_target'
    set $env{'request.lti.target'} to iframe, if LON-CAPA display in iframe.

- Bug 6754 LON-CAPA as LTI Provider
  - Support LTI Extension: Context Memberships Service, whereby launch of
    Consumer can trigger Provider to request course roster.
  - Code moved from ltiauth.pm to routines in ltiutils.pm:
    &get_lc_roles(), &create_user() and &enrolluser(); &create_passwd() routine
    also moved.
  - Code moved from &parse_roster() to &get_roster() in ltiutils.pm.
  - New routines: &batchaddroster(), &datechange_check(), &store_passbackurl()
    added to support roster updates, (including saving user-specific values
    for: lis_result_sourcedid, used for passback of grades to Consumer.

- Bug 6754 LON-CAPA as LTI Provider
  - When loading role following LTI launch just display a "Continue" link.

- Include use of "Check for changes" link as mechanism to update roles list,
  in case where an unprivileged user has no roles listed.

- Set $env{'request.course.timechecked'} when a course is initialized after
  selection of a course role.

- For 2.11.2 (modified).
  - Includes changes in rev. 1.334

- In course context the Functions menu will include a "View source" item/icon
  for a published assessment item, if the user does not have rights to edit,
  and either of the following are true:
  (a) user has a cre priv, and content has source set to "open",
  (b) user has vxc priv (View XML of assessments in course where
      course owner/co-owner is author/co-author of content).
- vxc priv is assignable to custom role, including ad hoc custom roles
  which can be made available to users with domain helpdesk role.

- Take into account trust settings for:
  - othcoau ("Co-author roles in this domain for others")
  - coaurem ("Co-author roles for this domain's users elsewhere")
  when displaying "Switch Server" link to Authoring Space's home server,
  and whether to skip check for ability to host a user on a remote server.

- Blocking communication/resource access (e.g., for exams) can include
  suppression of interruptions to a student's workflow due to:
  (a) Critical messages not moved to INBOX
  (b) Detection of changes to course structure, as a result of actions by
      a Course Coordinator.

- For 2.11
  - Backport 1.330, 1.331

- Facilitate localization.

- Facilitate localization.

- For 2.11
  - Backport 1.329

- &authorbrowser_javascript() not needed unless user has DC role(s).

- For 2.11
  - Backport 1.328

- Eliminate empty row between role itself and ad hoc role selection link
  for Domain Helpdesk and Domain Helpdesk Assistant roles.

- For servers using Apache/SSL where an External Resource points at an
  http:// URL, links to display the page use http:// to avoid mixed active
  content issue, unless editing the resource (when https:// is used).

- For servers using Apache/SSL, and LON-CAPA syllabus requested is configured
  to use an external http:// URL, links to display of syllabus page use http://
  to avoid mixed active content issue, unless editing the syllabus (in which
  case https:// is used).

- For 2.11
  - Backport 1.325.

- Domain Helpdesk Assistant role for use by domain helpdesk student employees
  - browse access to shared repository (including own domain) is excluded.

- For 2.11
  - Backport 1.323, 1.324.

- Ad hoc roles for helpdesk personnel
 - all custom ad hoc roles for helpdesk personnel are unavailable in "official"
   courses in which user is a registered student (automated enrollment in use).

- Ad hoc roles for helpdesk personnel.
  - Domain configuration for:
    - which user(s) with dh role in domain may use each ad hoc role.
      - set by institutional status, or by include specific people, or by
        exclude specific people.
    - assign role description (displayed on Roles page, and at top left of
      page, when role active).
    - assign role order (numerical).
  - Course configuration (available for editing by course owner, and viewing
    by co-owner(s).
    - can override domain defaults for which dh role users can use ad hoc role(s)
      in course.
    - can override domain defaults set for course-level privileges for ad hoc
      role(s).

- For 2.11
  - Backport 1.321, 1.322

- Ad hoc role in a course for Domain Helpdesk can be for a specific section.

- Coordinator role in a Community is co.

- For 2.11
  - Backport 1.319, 1.320

- Fix indentation. Standard LON-CAPA indentation is four spaces.

- "Switch role" drop-down provided in course context to domain helpdesk
  ad hoc course roles:
  (a) if user has rights to use a single ad hoc role, but course has at
  least one section, or
  (b) user has rights to use more than one ad hoc role.

- For 2.11
  - Backport 1.315, 1.316, 1.317, 1.318

- Links to ad hoc roles for DC and DH roles in Roles Hotlist.

- Link(s) to course/community selector(s) for ad hoc custom roles included
  with Domain Helpdesk role entry, for any custom helpdesk roles assigned
  to user.

- Typo

- Add role for domain helpdesk staff

- For 2.11
  - Backport 1.314

- For 2.11
  - Fix typo in 1.269.2.24 backport of 1.312.

- For 2.11
  - Backport 1.312

- Improve display of roles page for mobile devices with small viewports.

- Bug 6808. New course container -- "Placement" for Placement Tests.
  Work in progress.

fixed bug 6782, and escaped most localized messages used in Javascript blocks to make sure bugs like that do not happen again

- For 2.11
  Backport 1.311

- When entering a course in which the first resource is subject to content
  blocking, display Contents page (Uncompleted "Homework") instead.

- For 2.11
  Backport 1.309, 1.310

- &check_release_required() moved from lonroles.pm to loncommon.pm to
  facilitate reuse.
- Display of Contents page will check if it has been more than 10 minutes
  since last check for content change in course.
 - If it has been: loncommon::needs_coursereinit() will be called to check if
   course was changes after the "Big Hash" was last tied for the user's session
   in the course.
 - The course will be re-initialized (or a Switch Server link displayed),
   as needed.

- Coding style: sort() keys()

- For 2.11
  - Backport 1.308

- Remove superfluous links show to advacnced users on Roles page.
  - Use existing links instead:
    Logout available at top right of page; Catalog link in Functions menu.

- For 2.11
  - Backport 1.304, 1.305, 1.306, 1.307

- Check there are domains and course types for which user has request
  rights.

- For users with no active roles, but with rights to request courses
  only display invitation to request creation of a course.
- For other users with no active roles display information about Course
  Catalog (if appropriate).

- Remove some debugging output.

Calls critical_redirect() to check for critical messages

- For 2.11
  - Backport 1.303

- For 2.10
  - Backport 1.303

- Support situation where different servers belonging to user's (and course's)
  domain are running different versions of LON-CAPA, and role selected has a
  version requirement unmet by server currently hosting user session.
  - Additional arg passed to &choose_server() -- $skiploadbal (boolean)
    If true, a server identified in domain configuration as a loadbalancer
    will not be included when choosing from the domain's servers.

- For 2.11
  - Backport 1.293, 1.294, 1.302

- Catalog type set for domain (authenticated and unauthenticated) included
  in domain defaults (cached).
- Display of prompts on roles/courses screen for users without any active
  roles depend on catalog type set for user's domain (or default domain,
  if unauthenticated).

- For 2.11
  - Backport 1.298, 1.299, 1.300, 1.301

- Backport 1.301.

- Support situation where different servers belonging to user's (and course's)
  domain are running different versions of LON-CAPA, and role selected has a
  version requirement unmet by server currently hosting user session.
  - Additional arg passed to &choose_server() -- $required (version of LON-CAPA
    required for selected role).
  - Additional arg passed to &compare_server_load() -- $required (version of
    LON-CAPA required).

- Update some comments for changes in rev. 1.299.

Goes back to using lonnet::allowed to check the status of the first resource.  The first resource can now also be external with an appended query.

Fix wording typos

- For 2.11
  - Backport 1.295, 1.296, 1.297.

- Remove check_needs_switchserver() routine which is no longer used.
- Changes to regexps to support adhoc role switching to custom roles
  created by a user with an e-mail address as username.

- Coding style.
  keys().

Improve internationalization:
- Proper compilation of output string, then pass to translation
- Re-use existing phrases

- For 2.11
  - Backport 1.292.

Consistent spelling (upper case): Authoring Space

Translate role status

- Prevent roles page redirecting to itself.
- Add missing ;

- For 2.11
  - Change in rev 1.287 missed in earlier backport (1.269.2.10).

- For 2.11
  - Backport 1.291

- Case consistent with other items in Functions menu on roles page.

- For 2.11
  - Backport 1.290

- Include link to Course/Community catalog in Functions menu on roles/courses
  screen, if user's domain has log-in page preference to show course catalog
  link.
- Wording changes to shorten titles of items in Functions menu.

- For 2.11
  - Backport 1.289.

- Supplemental Content Tab not shown on Course Contents screen unless
  user has mdc priv in course, or Supplemental content contains one or
  more resources (folders not counted).

- For 2.11
  - Backport 1.287, 1.288

- Replace term: "Construction Space" with "Authoring Space" for
  consistency with type of role used to access it, and action taken there.

- Non-advanced users select a course not a role.

- For 2.11
  - Backport 1.286.

- Changes for which role, group or privilege information is unavailable
  excluded from display generated by "Check for changes" item.
  - Eliminates o -- items in "Expired roles" where roles are ad hoc
  course or community roles previously selected by a Coordinator.

- For 2.11
  - Backport 1.282, 1.283, 1.284, 1.285.

  - Suppress "Apache2::RequestIO::print: (103) Software caused connection abort"
    messages in Apache error log by returning OK when internal redirect is used.

  - Don't show Syllabus item in secondary menu in course context to students
    unless syllabus has been edited.
  - Information about active course feeds and syllabus modification time
    stored in %env with keys: 'request.course.feeds' and
    'request.course.syllabustime'

- lonrss::advertisefeeds() takes two additional, optional args:
  $count, $hidden (refs to scalars to accumulate counts of visible feeds
- Set additional item in %env for a course:
  $env{'course.<courseid>.feeds'} contains number of visible course RSS feeds.
- Added information in Syllabus template about availability of RSS Feeds and
  Blogs item (editing mode).

- Missing line break.

- For 2.11
  - Backport 1.281.

- Eliminate duplicate declaration
- Eliminate unnecessary lines
- Actually set $currcrs when checking for courses with new groups.

- For 2.11.
  - Backport 1.279.

- Fix typo in rev. 1.277.
- Remove whitespace.

- Checking for changes to roles or groups
  - For any changes show course, role, section, and or group information
    in unabbreviated format.
  - For custom roles, only compare stored privileges with privileges in
    %env for active roles.

- For 2.11
  - Backport 1.278.

- Coordinator switching course role to custom role.
  - Set privs for adhoc role.

- For 2.11
  - Backport 1.277

- Support case where destinationurl's query string contains symb as other than
  first item.

- For 2.11.
  - Backport 1.276.

- Bug 6419.
  - "Switch role to ..." in a course can handle switching back and forth
    between roles with/without request.role.adv = 1, where course item has
    URL hidden (from Course Editor).

- For 2.11.
  - Backport 1.270, 1.271, 1.272, 1.273, 1.274, 1.275.

- Keep track of last course "login".
  - DC selecting adhoc role in a course (in which he/she has no existing
    role,  and use of role switcher within course do *not* cause update
    of last log-in for that user/role/section.

- Functions List for Roles page
  - access to tools appropriate for current user:
    (show/hide expired roles, check for role changes, request course/community,
     request authoring space, show queued requests (course/author/self-enroll),
     hot list config).
  - lonpreferences.pm
    - returnurl = /adm/roles when using rolespref modifies behavior
    - clean up display (simplification of wording).
  - lonroles.pm
    - Individual buttons for display, changes, author space moved to functions.
    - new routine -- &roles_from_env() -gets hash of roles -used by &gather_roles().

- Remove routines which are no loger used
  (equivalents from loncoursequeueadmin.pm used instead).

- Requests author roles by users who do not have them.
  - Move code from lonroles.pm to new routines in loncoursequeueadmin.pm
    is_active_author(), author_prompt(), reqauthor_check(), process_reqauthor()
    to facilitate re-use.
  - At conclusion of course/community request process, offer option to
    request an author role to users without one, who have to rights to
    request one.

- New roles should be active immediately if start date has been reached.

- Add ability for users to request creation of an author role in their
  domain, if they do not already have an active author role.
  - Domain defaults can be assigned based on institutional status.
  - Defaults can be overridden for individual users by the DC.
  - Requests can either be processed automatically or queued for DC
    approval.
  - Notification message can be sent to DCs when queued for approval
  - Notification message sent to requester if approved/rejected.

- For 2.11.
  - Remote Control retained in 2.11.
  - Reverse part of changes in loncommon.pm rev 1.949, 1.953, 1.962, 1.964.
  - Reverse part of changes in lonmenu.pm rev 1.316, 1.318, 1.321.
  - Reverse part of changes in lonroles.pm rev 1.245.

- Timestamp in user's env for when coursemap was last tied:
  $env{'request.course.tied'}.

- Facilitate code re-use.
- Move &update_content_constraints() from lonroles.pm to loncommon.pm
- Move &parse_supplemental_title() from londocs.pm to loncommon.pm

Improved design of server announcements on roles screen: Headline and additional padding

Replaced calls to selfenroll::validate_course_id and createaccount::validate_course by lonnet::is_course.
Extended functionality of lonnet::is_course.
Code cleanup.

- Added blank line to improve readability.

- Customization for MITrelate
  - Switch directly to active role, if only one active role, and no
    future roles.

- Customization for MITrelate
 - Keep track of last course "login".

- Customization for MITrelate
  - Backport 1.260, 1.264.

- Result of pushing "Check for role changes" button.
  - More compact display if no role or groups changes.
  - Checking for changed privileges in custom roles correct where
    role had no system or domain privs.

Bug #1320

Bug #1320

- Backport 1.261.

Style correction for display of syllabus link (rev. 1.211)

- Bug 5932. Roles Screen usability improvements
  - Work in progress.
  - Check for new roles button to check for new roles or groups or privilege changes for existing groups since last log-in.
    - Handles special cases of:
      (a) expiration/deletion of current role
      (b) section switching for student role
  - New routines: &update_session_roles(), &curr_role_status(),
      &gather_roleprivs(), &is_active_course().
  - New item in %env - user.update.time records when last new role check occurred.

- Support for pop-up Course Contents window (remotenavmap) retained in 2.10.

- Customization for GCI_3.
  - Support multiple Concept Inventories

- Customization for GCI_3.
  - Different functionality for different Concept Inventories.

- Customization for GCI_3.
  - Suport for multiple Concept Inventories.

- Customization for GCI_3.
  - Eliminate lines no longer needed now gctest_switcher_js() is called elsewhere.

- Customization for GCI_3
  - Separate call to &gcitest_switcher_js() no longer needed.
  - Eliminate breadcrumbs for roles page for faculty.
  - Custom message for faculty without pending request for GCI access.

- Customization for GCI_3.
  - Substitute the term 'Concept Tests' for 'Roles' when appropriate.

- Customization for GCI_3
  - gctest_switcher() and gcitest_switcher_js() moved from lonmainmenu.pm to loncommon.pm
  - No breadcrumbs for /adm/gci_info
  - Woding change - more than a single question can be submitted to the GCI WebCenter.

- Customization for GCI_3.
  - Add a new "Tutorials" tab to provide access to a GCI "course" containing video tutorials.

- Backport 1.259.

- Reduce load time for users with lots of roles.
  - Only check course or domain timezone for active or future roles, or if display 'all" has been
    selected by an advanced user.
  - Get course timezone settings from %env where available.
- Flush print buffer before compiling roles table.
- xhtml: don't emit <tr></tr> in recent roles part if role text is blank.

- Backport 1.258.

- Correct domain shown for adhoc roles in hotlist.

- Backport 1.252, 1.253.

- Backport 1.257.

- Allow letters in Version name after major and minor version number
  (e.g., 2.10.0.RC1).

- For 2.10 reverse changes in 1.245 and 1.246.
  - Remote Control still retained for 2.10.

- Customization for GCI_3.  For Concept Tests:
  - Keep track of last course "login"
  - Keep track of submission count by students in Concep Tests.
  - New What's New item - Last login for users (day, week, month, ever).
  - Eliminate columns for groups and clickers for classlist display.
  - Add new columns for last login and test status (completed, incomplete, unattempted).

- Correction to LON-CAPA version checking in rev 1.255.

- Check if required LON-CAPA release needs updating
  when re-initializing course after editing course.
- When processing selected role in a course, check if
  server's LON-CAPA version is compatible with version
  required for course.

- For Course/Community roles requiring a specific minimum LON-CAPA version,
  where server hosting session is not running a recent enough version:
  (a) If server hosting session is running 2.10 or later, switch server
      link shown for role on roles/courses screen.
      - switch is to a server in user's domain (if any have required version)
        or to a server in course's domain (if any have required version).
  (b) For servers hosting sessions running 2.9 or earlier, lond on the
      user's home machine will only supply information for roles which
      can be run on the version on the server hosting the session.

- Localization: Optimized customrole mt() call (rev. 1.345): split content and layout parameter
- Consistent Wording username:domain

- Active CCs should be able to use "Switch course role to ..." to switch to another course role in cases where their assigned roles include an expired role of the same type/section in the course.

- Backport 1.251, and line missing from earlier 1.249 backport.

- More of bug 6294.
 - Eliminate <tr></tr>

- Backport 1.247, 1.248, 1.29, 1.250.

- Remove line no longer needed after changes in 1.249.

- Bug 6294.
- regexp to extract role, domain, num was changed in 1.240. Matches
  $1, $2 and $3 updated accordingly.
- Eliminate <tr></tr>
- &display_cc_role() returns an array.

- xhtml.

- HTML readability: move javascript used for ad hoc course or role selection outside
  roles table.
- Coding style: eliminate $_.

In process of removing remote control, remote navmap and different icon modes code
- removed no_inline_link argument from loncommon::start_page, loncommon::bodytag
- removed subs
    o loncommon::head: it wasn't used
    o loncommon::endheadtag: functionality now covered by loncommon::headtag
    o lonmenu::registerurl: functionality moved to loncommon::headtag, because it was the only function that called registerurl
- removed remote control related translations in de.pm
- refactoring and cleanup

In process of removing remote control, remote navmap and different icon modes code
- mostly remote navmap related code and files removed
- some minor refactoring
- some translations added/removed

- Missed in earlier backport of 1.238 (rev 1.231.4.8).

- Backport 1.241, 1.242, 1.243, 1.244.

- Customization for GCI_3.
  - Backport 1.244.

- &queued_selfenrollment() moved from lonroles.pm (see rev 1.241)
  to loncoursequeueadmin.pm.

- Fix typo in 1.240.2.12 backport of 1.242.

- Customization for GCI_3
  - Backport 1.242, 1.243.
    - Use replacement title for standard course roles if set in course's configuration.

- Use replacement title for standard course roles if set in course's configuration.

- Use replacement title for standard course roles if set in course's configuration.

- Customization for GCI_3.
  - If user's %env currently has no roles:
     get roles added since log-in with &loncommon::new_user_roles().

- &lonmainmenu::gcitest_switcher() takes two args: role and courses hash.

- Customization for GCI_3.
  - Backport 1.241.

- Move &queued_selfenrollment() from lonroles.pm to loncoursequeueadmin.pm
  to facilitate re-use.
 - &queued_selfenrollment() has a different arg - $notitle - which when true
   will omit title of pending requests table.

- Customization for GCI_3.
  &loncommon::existing_gcitest_courses() requires role as argument.

- Customization for GCI_3.
  - Exclude Course Catalog link and advice on missing courses and
    self-enrollment for students in Concept Courses.

- Backport 1.240.

- Backport 1.239.

- Backport part of 1.238 not included in earlier backports.

- Backport 1.237

- Backport part of 1.235 not included in earlier backports.

- Backport 1.234.

- Backport 1.233.

- Backport 1.232.

- Customization for GCI_3
  - Prevent double breadcrumbs during role switching.
  - Don't direct DCs to non-existent page after adhoc course role selection.

- Customization for GCI_3
  - Welcome page after successful log-in.

- Customization for GCI_3.
 - Eliminate duplicate code.
 - Set request.role.adv before calling lonuserstate::readmap() so order
    randomized when CC is viewing as a student (if randomorder set for folder).

- Customization for GCI_3.
 - For GCI users:
  - Replace standard roles screen with custom main menu.
  - First item displayed for CCs after selecting Concept Test is Course Contents instead of What's New?

- Customization for GCI_3.
  - If no role, redirect to orgurl (if specified as a form element).

- Customization for GCI_3.

- Ad hoc community coordinator role ("co") available to DCs.

- Accommodate Communities.
  - adhoc Coordinator role for DCs is "co" role.

Localization:
- Corrected &mt() update lonroles.pm 1.234: Allow change of parameter order due to localization but keep proper HTML structure.
- Wording correction on roles screen (no roles): It's actually the right to _request_ creation of courses/communities, not the right to create them
- Corrected &mt() update lonwhatsnew.pm 1.95: Allow proper translation of course type. Include "all" in second link to highlight the difference between "this" and "all".
- de.pm: additions/updates and some other updates/corrections

- Screen ergonomics for "show all roles" option on roles screen: First checkbox, then option text. Added "Update" to button text.

- Area for Community roles in existing roles page implementation.

- More succinct.

- Consistent Wording "Course/Community Catalog":
    - Updated phrases in translation files de, es, zh corresponding to updates in lonroles.pm 1.234
    - Wording/Consistency
- Consistent Wording "Self-Enrollment"

- Link to course request page if user has no active roles, and has rights to request creation of courses.
- Some wording changes to accommodate communities as well as courses.
- Additional argument for &lonnet::check_can_request() -
   hashref: $request_domains used to accumulate domains for each course
            type for which user has course request rights.
- New subroutine: &requestcourse_advice() in lonroles.pm

Consistent wording "Course Catalog" -> "Course/Community Catalog"

- bug 6102.
   - Set user.login.time hash item even when the user has no roles,
     in case user requests a course, and acquires role(s) in current session.
   - Change role status from 'future' to 'is' if role start time was after
     login but before last refresh.
   - Compare CC role start time with refresh time instead of login time
     for role selector to work where course was created in the current session
     (via course request process).

- Customization for GCI.
- Automatically select role if user only has one active role.
- Backport 1.216 and part of 1.224

- lonroles.pm for GCI_1 updated to 2.8.X
- Backport 1.215

- Customization for GCI.
- Automatically select role if user only has one active role.

- lonroles.pm for GCI_2 updated to 2.9.X
- Remove changes made in 1.228 - not in 2.9.X.
--------------------------------

- Fix typo in 1.231.4.1.

- Remove changes made in 1.228 - not in 2.9.X.

loncreateuser.pm:
- Removed double data_table start (-> rev. 1.301)
- Removed unneeded <br> between header and page content
- Separate row for "Update Display" Button

loncreateuser.pm, lonslotrequest.pm:
- Corrected server version &mt() calls
- Replaced special note style for version note by standard info style

loncreateuser.pm, lonslotrequest.pm, lonroles.pm:
- Consistent and optimized wording (server version)

de.pm, zh.pm:
- Corresponding wording updates
- Additions of missing phrases

- lonnet::check_adhoc_privs() now takes six args (fourth is $refresh).

- Bug 3987.
- Destination URL and Symb supplied in query string to log-in page, used to load page after appropriate role selection.

- Added breadcrumbs to "Switching Role" and "Problems during Course Initialization"
- Added line feed after error message headline

DC ad hoc roles line:
- Removed unnecessary table
- Corrected &mt usage (don't translate twice)

- Usability improvements.
- Reduce need for user to complete logout/login cycle to be able to select roles with 'will' role status (roles with future access which existed at time of last log-in, and are "active"):
  - Display of roles screen causes privs to propagate to %env in the background and become selectable.
  - &gather_roles() routine created (ongoing simplification of monolithic handler() routine).
  - &Apache::lonnet::roles_status() takes new arg ($refresh).
  - New environment variable: user.refresh.time - records when last check was made for 'will' type role.

XHTML:
- Properly exclude javascript code from being interpreted as HTML code
- Added alt attributes to <img> tags
- Lower case attributes (onclick)
- Added dummy action to <form>

- Added error style to lonroles error message

- Use 'Courses' instead of 'Roles' for consistency with inline menu.
- Wording change: Re-Initialize -> Re-Select.

- Fix alternating background colors for rows in roles table.

Don't use <h1> for info text

Don't use <h1> and <h3> to highlight error messages

- Bug 5914.
  - Selection of "Scantron Operator" role launches Scantron data upload page (from grades.pm)
  - Add header to upload table (until such time as breadcrumbs are updated for grades.pm).

- HTML documents uploaded directly to a course can be edited by a Course Coordinator (mdc priv).
- "Edit this resource" link displayed in inline menu.
- Link will switch server to course's home server if session is currently hoosted elsewehere (unless a lock is in place).

- Deep linking:
  - origurl and symb args can be included in query string for switchserver call, so switched session will go to the same resource on the new server.

Work in progress.
Logging needed: changes, and by whom.

Bug 5842.
 - "Edit this resource" link is displayed in inline menu if user is a DC in domain of resource author, and author has not blocked DC access to CSTR.
 - request for /priv/$author sets ad hoc co-author privs for user (if no existing privs) if user is a DC in author's CSTR, and if DC access is not blocked by author's user prefs.

&check_privs(), &set_privileges(), and &role_status() moved from lonroles.pm to lonnet.pm -- first two renamed as: check_adhoc_privs(), set_adhoc_privileges().

&is_active_dc() added to loncacc.pm to check if user has active DC role in resource author's domain.

Box title is now the main title of the next page and the link text or the former page title will be set to the subtitle in the near future.
Group: consistent wording

- &queued_selfenrollment() generates a table of a user's self-enrollment requests currently pending approval by Course Coordinators in the respective courses.

- Backport 1.215.

- Bug 5792.
- Timezones used in start and end dates on roles screen are specific to the role (appropriate course time zone for course roles, otherwise domain default for other roles based on role's domain).

- $brcrum is a reference to an anonymous array [] (use $brcrum not @brcrum).
- add sanity checking to confirm that the arg passed was an array ref.
- style
  - indentation
  - exists()

Added Breadcrumbs in Sites that dose not have any
Added a parameter bread_crumbs to the start_page function, so it can handel the creation of breadcrumbs

Standard styles for roles screen
and some other optimizations

lonroles.pm:
- Use data_table for roles screen
- Moved status color from whole row background to only the first column.
  (This change is meant as an intermediate suggestion to get rid of the "color shock" effect ("Everything's green here!") and usage of standard LON-CAPA styles by keeping the main functionality)
-  Only the green background for active, unselected roles isn't used anymore. (No special indication needed)
- Removed some hardcoded font styles
- Removed the usage of different font colors (not needed anymore; -> $tfont)
- Removed empty separator rows (separation now done by different background colors in the data table rows)
- Replaced hardcoded color styles with new external styles (->  $tbg)
- Use double quotes for html attributes
- Added missing &mt() call (-> Current Privileges)

loncommon.pm:
- Removed unneeded and unused rolesmenu styles
- Added new styles for status display on roles screen but keep already used color values (-> lonroles.pm)
- Don't change background color counter for standard rows anymore, if empty_row is called and displayed
- Removed now unused font parameter from syllabuswrapper

Removed font tags replaced by span tags

Added/modified POD documentation

- "Re-initialize" button in roles screen no longer restricted to advanced users.
- Show appropriate message on roles screen when navmap object could not be created because inactivity caused deletion of $user_$course.db and/or $user_$course_params.db from lonDaemns/tmp directory.

- Ad hoc role for CC needs to set privs for any groups to which the CC belongs when selecting other roles in the course.

Do not automatically select the only available role

Bug 5779 (introduced in 1.183 -- work on bug 3765):
- If user was a DC in at least one domain, but was not a DC in the domain to which the CA role belonged, the assigned CA role could not be selected.
- Fix is to check if DC actually has the CA role active in user roles in %env, before checking for DC status in the domain to which the CA belongs.  If so, check if switchserver is needed.

- Also check if requested CA role is actually for author space of current user - if so, set role request to AU instead of CA (CA in the user's own CSTR doesn't make sense).

- Do not block CA role access if user has been assigned a CA role, (was occurring if user is also a DC, and author blocked ad hoc access by DCs).

Localization:
- Added missing &mt() calls
- Optimized &mt() calls

- For bug 3987.  lonroles.pm will accept a destsymb form item, encode it and append it to the destinationurl.
- Intended to support linking to a specific resource in a course from outside LON-CAPA.
- Login page and SSO need to preserve an appropriate query string for the call to /adm/roles after authentication and session initialization.

- If user has only one active role do not show "Select a Course to Enter" header line.
- If user has only one active role do not show "No role specified" line, since automatic role selection for users with a single role means role type "cm" is inaccessible.
- If user has a single active role, and that role is au, ca or aa, only do automatic role selection if user's session is on home server for corresponding author; display a switch server link if not (we don't automatically switch in case the home server is overloaded and we could get into an infinite loop of switching/offloading).

- use showdom in coursecatalog query string to default to display of the course catalog for an appropriate domain.
- eliminate duplicate declaration ($cdom, $cnum).

- Use &Apache::lonnet::auto_run() to check if auto-enrollment is active for the user's domain to replace &check_autoenroll() which is no longer needed.

- Correction to match for valid custom role for CC needing an ad hoc in a course.

- role is in $env{'form.switchrole'} when CC is switching into a role in course context
- correction to regexp to extract section from adhoc role.

- Link to course catalog on roles screen for advanced users.

- Display a course catalog link at the top of the roles screen, with advice on self-enrollment, for users without advanced roles, and at least one active role.

Localized version number info on roles screen

No course restrictions.

- Domain Coordinator selection of ad hoc co-author role.
  - "Select Author" link triggers pop-up window with display of authors in domain.
  - Selection of author from list causes roles page to auto-submit.
  - Eliminated distinction between "new" ad hoc CA role and previously selected one.
  - Added redirection to switchserver, if current session is not on homeserver of selected author (needs testing).

- More compact display for ad hoc roles available to a DC
- Fix some unbalanced <tr> tags in Recent roles rows.
- Fix some xhtml - ordering of </span></font>, <input /> etc. (incomplete - font color="" needs to be from css).
Work in progress.

- If user has no active roles, now display any future roles, and a link to the course catalog.
- if automated enrollment is in use in the user's domain, display a message about     reasons why enrollment might not have occurred so far.
- moved some code from handler() into subroutines - roletable_headers(), print_rolerows() and roletypes().

Bug #5613 - user can opt out of DC access

More work on 5613

Locking

- backport 1.187

- backport 1.184

Localization:
Added missing &mt() to Access Control screen

Change arguments accepted by lonnet::appenv() to:
1. reference to hash
2. (optional) reference to array.

Change all instances where lonnet::appenv() is called to replace first argument passed (originally a hash) to a reference to the hash.

- Modify lonnet.pm rev 1.35 code intended to prevent "dangerous" modifications of the environment, so it will actually do this.
- Allow these modifications to be made in certain instances:
   DC switching to adhoc role
   CC switching to a different course role in the current course.
   user self-enrolling as a student

- Improving ease of use (cf. Moodle).

Inline navigation includes dropdown to change to a different role in the course.
Course Coordinator - can switch to any role currently used in the course.
Other users - can switch to any other course roles assigned to them.

Work in progress.
- Needs additional dropdown for section context.
- Needs to maintain display of encrypted URLs as unencrypted when switching into CC role.

- Typo and some localization for alert messages.

Don't go to non-exising authorspaces

Bug #3765: Ad-hoc co-author

- BUG#5516 - TA's aren't ADV but should trigger the wording change from Course -> role

Bug 2593 csv file upload by DC to change passwords
- DCs can change authentication, add a domain or course role for uploaded users, and/or change user information (names, ID, e-mail address etc.)
- Authors can add co-authors
- Course Coordinators can add course roles.
- Some subroutines in londropdd.pm moved to lonuserutils.pm.  Some routines in loncreateuser.pm moved to lonuserutils.pm
- &process_pick() moved from lonroles.pm to lonpickcourse.pm
- Work in progress.  Ultimate goal is to provide user listing functionality in different contexts and eliminate separate ENRL button.

With SSO enabled, it is possible to log-in and reach the roles screen with Javascript disabled.
- provide a warning
- for users with a single active role, provide a "Continue" button.
- xhtml

Not needed anymore after Switchserver

* increase character contrast by default (white background)
* labels
* fix some &mt()s
* css on roles screen

- starting work on moving to distributed DNS, eliminate usage of the lonnet hostanme global

- make the privileges section into it's own sub

- BUG#5011 when initing a course if the bighash .db file is gone can get ISE warn and ask for reinit

- back to one selector for DC

- lots of \w -> probper regexp replacements

- course ids and usernames are slightly different (courseids must start \d\w\d usernames can not start with a digit) add re for both course ids and any kind of internal name

- swithc to using helper cleaing functions and helper matchi re

- $furl could have the symb arg and other complicators, just let the pageflip sug figure out where we should be

- set_arearole want the domain of the user not the role

- addd lonnav disply to some needed locations

- splitting the handlery bits of lonnavmaps from the functional components

- backport 1.165

- no calendar for author or dc roles

- show future roles by default

- backport 1.163

People do not always see the Roles page first, and or don't expect the general
access to the help system on that page.

- hide course type idea from 2.2

- why be generic when we can be specific

- help_open_menu morph

- 'user roles' isn't a real function

- extend plaintext to handle cr roles
- lonroles makes use of the improved plaintext
- from mlucas

- BUG#3763 - reqork role freezing functionality

- fixes to discussion group &mt()
- switch to course_type accessor
- switch to <span class="LC_error">

- typo

- and unless conversion that was incorrect

-make use of new hash interface

Conversion of role names now occurs in lonnet::plaintext().  If rolename is set for a specific role in the course environment this is used, otherwise defaults to name defined in rolesplain.tab.  rolesplain.tab can now contain multiple entries (: separated) - which one is used depends on course type. loncommon::course_type() is accesssor function added to provide type; loncommon::convert_role() eliminated.  loncommon::bodytag() now includes $realm information for co-author role.

Adding ANGEL-style groups as a thin veneer. Roles in Discussion groups are separated from roles in Courses.

Bug #1223: error when first resource is hidden
Also: error when first resource is encrypted

Bug #4370: better warning if there are errors during course initialization,
e.g., a map included more than once.

&Apache::lonnet::unescape -> &unescape
&Apache::lonnet::escape -> &escape

- BUG#3254 - remote wasn't getting start when doing 'Switch Server'

- start_page

DC's assumption of any CC role.  Improve readibility by replacing $1 and $2 in calls to &set_privileges with $domain and $coursenum.  Correct the setting of $env{request.role} to cc./$cdom/$cnum (instead of just cc).

- check whn for both course and course+section

- switch to using ::get

- backport 1.143

- fix author role so switch server works for author too

Add whn privilege to make what's new available to cc, in, ta and custom role. Display NEW button for users with this privilege in a course.
CeS: ----------------------------------------------------------------------

- death to user.adv

typo

Display of whatsnew page on entering a course can be set for specific courses (override user prefs).  Can suppress count of unread posts per resource. Link to first resource at top of page not shown if NEW button used to get to whatsnew. What's new no longer restricted to CC role - accessible to adavnced roles in a course.

DC's "Select Course" link to become a CC in a course in the domain now works for regular link in "Domain" as well as link in "Recent Roles".

Adding link to Groups in inline menu, adding GRPS button, adding request.course.groups to %env to allow easy access to a user's active groups.

Don't include course group affiliations in selectable roles.

In some tralslations the Pleasestandby ends up with a newline in it.

Trying to catch if Role is initialized twice in a row

- CC role secltor comes along with the DC role into recent roles

- the roles screen got some reorg to increase the space avaible for remarks, and to better associate the DC role with the associated line for the CC in any course line.

- xhtmlize

- 'switch server' now really does

- a desire for Domain to trump other roles

- missed one bit for making sure the whatsnew page appears when it should with external nav screen

- taking out the highlighting code
- recentering the 'realm' dividers

Back in town.

Bug #4135: underprivileged "assistant co-author"
Part of Bug #1900: CUSR shows up for authors again

- course init helper should defeat what'snew (Bug# 4132)

Syntax error

Default is now to display "What's New?" screen to Course Coordinators, unless they have set preference to go to start of course, whenever a course is accessed from roles screen.

- bug #3193, column 3 is a bit spurious

- trying to be moe helpful in access control problem cases, throw up the 're-init course' button if the get the access control message and have modified the course with reinit (Kinda BUG# 3646)

- nolonger need to clean_env

- ENV -> env

- BG#3985, the adv permissions didn;t have an effect in cases where it depended on athe course id

- xhtml cleaning

BUG#3736

If displaying 'Recent Roles', show header for other role type.

Eliminate display of "Recent courses visited by DC" - use Recent Roles instead. Recent roles display will now retrieve role info for recently visited CC roles created on the fly for a DC, if not yet visited this session.

DC selection of CC role from all courses in a particular domain modified to work when user is DC in more than one domain. No longer duplicate javascript functions in allcourses_row().

- Mark Lucas's changes to fix BUG#2078

Recent roles display for DC now gathers info for CC roles not viewed this session, but in recently viewed list.  Change in db name for recent roles.  Keys n db now: user.role.cc.\$dom\$course etc.  Ready for generalization to display of recent roles for all users.

Users with multiple DC roles can now select a CC role from any of the domains in which they are DC. Extra click eliminated -- selection in Pickcourse window loads CC role in opener window.

DC selection of CC roles.  Intermediate page eliminated.  Ordering of roles reverted to original order as per v 1.103.  Recent courses visited by DC now displayed at top of roles page. "Select Course" link for DC to go to open pickcourse window now displayed on main roles page.

CC privs created on the fly as needed for DC.  Works nicely now.

DC can select a CC role in his/her domain, and receive CC privileges on the fly.  Work in progress. Access is not quite set right for pages.

Changes made during a house call by the style police

Suppress display of CC roles in a domain in which the user is a DC.  Allow the DC to select from recently visited CC roles in the domain, or select a course via lonpickcourse.

Consolidation + correction to role_status subroutine.

Consolidating repeated code into subroutine.

- make adv a real role priv

- don't &mt the role text it's already &mt
- when changing roels delete the user.state

- adding more 'Continue' links

Bug #3419: better explanation of Remarks column

- don't tell student 'Go Away' when an html page is closed
- allow CC to see closed content
   (BUG#3357)

- backport 1.97

-BUG#3254

- Okay switching from course to author role colse the external nav window

- first pass at Concrod 'external nav window' request (BUG#3231)
     - create new env parm for stuent 'remotenavmap'
     - when entering course, lonroles will start up the window if it is closed
     - launch and close of the window works

- add in text describing ?

- change lonroles to use new integrated help link
- fix stupid typo

Bug #3021: spaces in filename of first course resource

Bug #2970: Key authority other than course possible

Saving my work.

Continued work on key verification.

Trying to prevent endless loop if course cannot be initialized for a user
with only one role.