--- loncom/debugging_tools/move_construction_spaces.pl	2011/10/27 14:01:21	1.5
+++ loncom/debugging_tools/move_construction_spaces.pl	2012/06/08 13:04:08	1.8
@@ -5,7 +5,7 @@
 # Move Construction Spaces from /home/$user/public_html
 # to /home/httpd/html/priv/$domain/$user and vice versa
 #
-# $Id: move_construction_spaces.pl,v 1.5 2011/10/27 14:01:21 raeburn Exp $
+# $Id: move_construction_spaces.pl,v 1.8 2012/06/08 13:04:08 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -38,8 +38,9 @@ use LONCAPA qw(:DEFAULT :match);
 use Apache::lonlocal;
 use File::Copy;
 use GDBM_File;
+use DBI;
 
-my ($lonusersdir,$londocroot,$londaemons);
+my ($lonusersdir,$londocroot,$londaemons,$lonsqlaccess);
 
 BEGIN {
     my $perlvar=&LONCAPA::Configuration::read_conf();
@@ -47,6 +48,7 @@ BEGIN {
         $lonusersdir = $perlvar->{'lonUsersDir'};
         $londocroot = $perlvar->{'lonDocRoot'};
         $londaemons = $perlvar->{'lonDaemons'};
+        $lonsqlaccess = $perlvar->{'lonSqlAccess'};
     }
     undef($perlvar);
 }
@@ -254,6 +256,7 @@ if ($lonusersdir) {
     my ($dir,$output);
     if (opendir($dir,$lonusersdir)) {
         my @contents = (grep(!/^\.{1,2}$/,readdir($dir)));
+        closedir($dir);
         foreach my $item (@contents) {
             if (-d "$lonusersdir/$item") {
                 if ($item =~ /^$match_domain$/) {
@@ -301,7 +304,6 @@ if ($lonusersdir) {
                 }
             }
         }
-        closedir($dir);
     } else {
         $output = &mt('Could not open [_1].',"'$lonusersdir'")."\n";
         print $output;
@@ -316,10 +318,12 @@ if ($londocroot ne '') {
         my ($dir,$domdir);
         if (opendir($dir,"$londocroot/res")) {
             my @contents = (grep(!/^\.{1,2}$/,readdir($dir)));
+            closedir($dir);
             foreach my $dom (@contents) {
                 if ((grep(/^\Q$dom\E/,@machinedoms)) && (-d "$londocroot/res/$dom")) {
                     if (opendir($domdir,"$londocroot/res/$dom")) {
                         my @unames = (grep(!/^\.{1,2}$/,readdir($domdir)));
+                        closedir($domdir);
                         foreach my $uname (@unames) {
                             if ($uname =~ /^$match_username$/) {
                                 push(@{$pubusers{$uname}},$dom);
@@ -339,10 +343,12 @@ if ($action eq 'undo') {
             my ($dir,$domdir);
             if (opendir($dir,"$londocroot/priv")) {
                 my @contents = (grep(!/^\.{1,2}/,readdir($dir)));
+                closedir($dir);
                 foreach my $dom (@contents) {
                     next if (!-d "$londocroot/priv/$dom");
                     if (opendir($domdir,"$londocroot/priv/$dom")) {
                         my @unames = (grep(!/^\.{1,2}$/,readdir($domdir)));
+                        closedir($domdir);
                         foreach my $uname (@unames) {
                             if ($uname =~ /^$match_username$/) {
                                 push(@{$privspaces{$uname}},$dom);
@@ -355,6 +361,7 @@ if ($action eq 'undo') {
     }
     foreach my $uname (keys(%privspaces)) {
         if (ref($privspaces{$uname}) eq 'ARRAY') {
+            my $output;
             if (@{$privspaces{$uname}} > 1) {
                 my $displaydoms = join(', ',@{$privspaces{$uname}});
                 print &mt('Same username used for authors in multiple domains.')."\n".
@@ -365,29 +372,70 @@ if ($action eq 'undo') {
                 my $choice=<STDIN>;
                 chomp($choice);
                 if (grep(/^\Q$choice\E$/,@{$privspaces{$uname}})) {
-                    my $output = &move_priv_to_home($londocroot,$uid,$gid,$uname,$choice);
-                    print $output;
-                    print $logfh $output;
+                    $output = &move_priv_to_home($londocroot,$uid,$gid,$uname,$choice);
                 } else {
                     print &mt('Invalid choice of domain:')." $choice\n";
-                    my $output = &mt('Skipping this user: [_1].',"'$uname'")."\n";
+                    $output = &mt('Skipping this user: [_1].',"'$uname'")."\n";
                     print $output;
                     print $logfh $output;
                     next;
                 }
             } elsif (@{$privspaces{$uname}} == 1) {
-                my $output = &move_priv_to_home($londocroot,$uid,$gid,$uname,$privspaces{$uname}[0]);
-                print $output;
-                print $logfh $output;
+                $output = &move_priv_to_home($londocroot,$uid,$gid,$uname,$privspaces{$uname}[0]);
             } else {
                 print &mt('Username [_1] found in [_2] was not within a domain',
                           "'$uname'","'$londocroot/priv'")."\n";
-                my $output = &mt('Skipping this user: [_1].',"'$uname'")."\n";
-                print $output;
-                print $logfh $output;
+                $output = &mt('Skipping this user: [_1].',"'$uname'")."\n";
             }
+            print $output;
+            print $logfh $output;
         }
     }
+    if (-d "$londocroot/priv") {
+        my $output;
+        if (opendir(my $dir,"$londocroot/priv")) {
+            my @doms = grep(!/^\.{1,2}/,readdir($dir));
+            closedir($dir);
+            foreach my $dom (@doms) {
+                if (opendir(my $domdir,"$londocroot/priv/$dom")) {
+                    my @contents =  grep(!/^\.{1,2}/,readdir($domdir));
+                    closedir($domdir);
+                    if (@contents == 0) {
+                        if (rmdir("$londocroot/priv/$dom")) {
+                            $output = &mt('Removed empty directory: [_1]',
+                                          "'$londocroot/priv/$dom'")."\n";
+                        } else {
+                            $output = &mt('Failed to remove directory: [_1]',
+                                          "'$londocroot/priv/$dom'")."\n";
+                        }
+                    }
+                }
+            }
+        }
+        my $warning = &mt('WARNING: Access to Construction Spaces in their old locations (i.e., in [_1]) via LON-CAPA with URLs of the form [_2] will not work until the directory at [_3] is moved or deleted.',"'/home/<user>/'","'/priv/<user>/'","'$londocroot/priv/'")."\n";
+        if (opendir(my $dir,"$londocroot/priv")) {
+            my @contents = (grep(!/^\.{1,2}/,readdir($dir)));
+            closedir($dir);
+            if (@contents == 0) {
+                if (rmdir("$londocroot/priv")) {
+                    $output .= &mt('Removed empty directory: [_1]',
+                                   "'$londocroot/priv'")."\n";
+                } else {
+                    $output .= &mt('Failed to remove directory: [_1]',
+                                   "'$londocroot/priv'")."\n".
+                               $warning."\n";
+                }
+            } else {
+                $output .= $warning."\n".
+                           &mt('The attempt to remove the directory failed, because it is not empty.')."\n";
+            }
+        } else {
+            $output .= $warning."\n".
+                       &mt('The attempt to open the directory to see its contents failed, hence no attempt was made to remove it.')."\n";
+        }
+        print $output;
+        print $logfh $output;
+    }
     &stop_logging($logfh);
     print "\n".&mt('Done')."\n";
     exit;
@@ -395,23 +443,51 @@ if ($action eq 'undo') {
 
 my @allskipped;
 my %allmoved;
+my ($dbh,$dbflag);
 
 # Iterate over directories in /home
 if (opendir(my $dir,"/home")) {
-    my @possibles = grep(!/^\.{1,2}$/,readdir($dir)); 
+    my @possibles = grep(!/^\.{1,2}$/,readdir($dir));
+    closedir($dir);
     foreach my $item (sort(@possibles)) {
         next if ($item eq 'www');
         if ((-d "/home/$item") && ($item ne '')) {
 # Is there a public_html-directory?
             if (-d "/home/$item/public_html") {
                 my $author = $item;
-                my ($domain,$skipped,$output);
+                my ($domain,$skipped,$output,$stopnow);
                 if (ref($allauthors{$author}) eq 'ARRAY') {
-                    ($domain,$skipped) = &choose_domain($action,$author,$allauthors{$author});
+                    ($domain,$skipped,$stopnow) = 
+                        &choose_domain($action,$author,$allauthors{$author});
+                    if ($stopnow) {
+                        if ($action ne 'dryrun') {
+                            my $output = &mt('Stopped by user at author: [_1].',
+                                             "'$author'")/"\n";
+                            &stop_logging($logfh,$output);
+                        }
+                        if ($dbflag == 1) {
+                            &disconnect_mysql($dbh);
+                        }
+                        print &mt('Stopped.')."\n";
+                        exit;
+                    }
                 }
                 if (($domain eq '') && (!$skipped)) {
                     if (ref($pubusers{$author}) eq 'ARRAY') {
-                        ($domain,$skipped) = &choose_domain($action,$author,$pubusers{$author});
+                        ($domain,$skipped,$stopnow) = 
+                            &choose_domain($action,$author,$pubusers{$author});
+                    }
+                    if ($stopnow) {
+                        if ($action ne 'dryrun') {
+                            my $output = &mt('Stopped by user at author: [_1].',
+                                             "'$author'")/"\n";
+                            &stop_logging($logfh,$output);
+                        }
+                        if ($dbflag == 1) {
+                            &disconnect_mysql($dbh);
+                        }
+                        print &mt('Stopped.')."\n";
+                        exit;
                     }
                 }
                 if (($domain eq '') && (!$skipped)) {
@@ -439,7 +515,44 @@ if (opendir(my $dir,"/home")) {
                         }
                     }
                     if (@foundauthor > 0) {
-                        ($domain,$skipped) = &choose_domain($action,$author,\@foundauthor);
+                        ($domain,$skipped,$stopnow) = 
+                             &choose_domain($action,$author,\@foundauthor);
+                        if ($stopnow) {
+                            if ($action ne 'dryrun') {
+                                my $output = &mt('Stopped by user at author: [_1].',
+                                                 "'$author'")/"\n";
+                                &stop_logging($logfh,$output);
+                            }
+                            if ($dbflag == 1) {
+                                &disconnect_mysql($dbh);
+                            }
+                            print &mt('Stopped.')."\n";
+                            exit;
+                        }
+                    }
+                }
+                if (($domain eq '') && (!$skipped)) {
+                    if (!$dbflag) {
+                        ($dbh,$dbflag) = &connect_mysql($lonsqlaccess);
+                    }
+                    if (defined($dbh)) {
+                        my $foundusers = &search_allusers($dbh,$author);
+                        if (ref($foundusers) eq 'HASH') {
+                            ($domain,$skipped,$stopnow) = 
+                                &choose_domain($action,$author,$foundusers);
+                        }
+                        if ($stopnow) {
+                            if ($action ne 'dryrun') {
+                                my $output = &mt('Stopped by user at author: [_1].',
+                                                 "'$author'")/"\n";
+                                &stop_logging($logfh,$output);
+                            }
+                            if ($dbflag == 1) {
+                                &disconnect_mysql($dbh);
+                            }
+                            print &mt('Stopped.')."\n";
+                            exit;
+                        }
                     }
                 }
                 my $source_path="/home/$author/public_html";
@@ -460,6 +573,7 @@ if (opendir(my $dir,"/home")) {
                                 if (opendir(my $homedir,"/home/$author")) {
                                     my @contents = 
                                         grep(!/^\.{1,2}$/,readdir($homedir));
+                                    closedir($homedir);
                                     if (@contents == 0) {
                                         if (rmdir("/home/$author/")) {
                                             $output .= &mt('Removed empty directory: [_1]',
@@ -496,7 +610,7 @@ if (opendir(my $dir,"/home")) {
                     }
                 } else {
                     print '*** '.&mt('WARNING: [_1] has no domain.',"'$author'")."\n".
-                          &mt('Enter [_1]: do nothing, continue.','1')."\n".
+                          &mt('Enter [_1]: skip this user.','1')."\n".
                           &mt('Enter [_1]: stop.','2')."\n".
                           &mt('or enter domain for user to be placed into')."\n".
                           &mt('Your input: ');
@@ -520,13 +634,16 @@ if (opendir(my $dir,"/home")) {
                                              "'$author'")/"\n";
                             &stop_logging($logfh,$output); 
                         }
+                        if ($dbflag == 1) {
+                            &disconnect_mysql($dbh);
+                        } 
                         exit;
                     } elsif ($choice =~ /^$match_domain$/) {
                         print &mt('You entered:')." $choice\n".
                               &mt('Is this ok? ~[Y/n~] ');
                         if (!&get_user_selection(1)) {
                             print &mt('Try again ...')."\n".
-                                  &mt('Enter [_1]: do nothing, continue.','1')."\n".
+                                  &mt('Enter [_1]: skip this user.','1')."\n".
                                   &mt('Enter [_1]: stop.','2')."\n".
                                   &mt('or enter domain for user to be placed into')."\n".
                                   &mt('Your input: ');
@@ -550,6 +667,9 @@ if (opendir(my $dir,"/home")) {
                                                      "'$author'")/"\n";
                                     &stop_logging($logfh,$output);
                                 }
+                                if ($dbflag == 1) {
+                                    &disconnect_mysql($dbh);
+                                }
                                 exit;
                             } elsif ($choice !~ /^$match_domain$/) {
                                 print &mt('Invalid domain entered:')." $choice\n";
@@ -579,7 +699,7 @@ if (opendir(my $dir,"/home")) {
                             if (-e $dompath) {
                                 if (move($source_path,$newpath)) {
                                     chown($uid,$gid,$newpath);
-                                    chmod($newpath,0750);
+                                    chmod(0750,$newpath);
                                     $output = &mt('Moved [_1] to [_2].',
                                                   "'$source_path'","'$newpath'")."\n";
                                 } else {
@@ -630,50 +750,67 @@ $skipcount = scalar(@allskipped);
 print "\n";
 if ($action ne 'dryrun') {
     my $output = &mt('You skipped: [_1].',$skipcount)."\n".
+                 join("\n",sort(@allskipped))."\n\n".
                  &mt('Moved ... [_1]',$moveinfo);
     print $output;
     print $logfh $output;
     &stop_logging($logfh);
 } else {
     print &mt('You would have skipped: [_1].',$skipcount)."\n".
+          join("\n",sort(@allskipped))."\n\n".
           &mt('You would have moved ... [_1]',$moveinfo);
 }
 print "\n\n".&mt('Done.')."\n";
 
-sub choose_domain { 
-    my ($action,$author,$domarrayref) = @_;
-    my ($domain,$skipped);
-    if (ref($domarrayref) eq 'ARRAY') {
-         if (@{$domarrayref} > 1) {
-             print '*** '.&mt('ERROR: [_1] found in multiple domains.',"'$author'")."\n".
-                   &mt('Enter a number to choose what action to take.')."\n";
-             my $num = 1;
-             for (my $i=0; $i<@{$domarrayref}; $i++) {
-                 print &mt('To use: [_1] enter [_2].',$domarrayref->[$i],$num)."\n";
-                 $num ++;
-             }
-             print &mt('To skip this user enter: [_1].',$num)."\n".
-                   &mt('Your choice:').' ';
-             my $choice=<STDIN>;
-             chomp($choice);
-             if ($choice =~ /^\d+$/) {
-                 if (($choice == $num) || ($choice > $num)) {
-                     $skipped = 1;       
-                 } elsif (($choice < $num) && ($choice > 0)) {
-                     $domain = $domarrayref->[$choice-1];
-                 } else {
-                     print &mt('Invalid choice:')." $choice\n";
-                     $skipped = 1;
-                 }
-             } else {
-                 print &mt('Invalid choice:')." $choice\n";
-                 $skipped = 1;
-             }
-         } elsif (@{$domarrayref} == 1) {
-             $domain = $domarrayref->[0];
-         }
+sub choose_domain {
+    my ($action,$author,$domref) = @_;
+    my ($domain,$skipped,$stopnow,@domains);
+    if (ref($domref) eq 'ARRAY') {
+        @domains = @{$domref};
+    } elsif (ref($domref) eq 'HASH') {
+        @domains = sort(keys(%{$domref}));
+    }
+    if (@domains > 1) {
+        print '*** '.&mt('ERROR: [_1] found in multiple domains.',"'$author'")."\n".
+               &mt('Enter a number to choose what action to take.')."\n";
+        my $num = 1;
+        print &mt('Enter [_1]: skip this user.',$num)."\n";
+        for (my $i=0; $i<@domains; $i++) {
+            my $shown = $domains[$i];
+            if (ref($domref) eq 'HASH') {
+                if ($domref->{$shown} ne '') {
+                    $shown .= ' ('.$domref->{$shown}.') ';
+                }
+            }
+            $num ++; 
+            print &mt('Enter [_1]: use domain - [_2].',$num,$shown)."\n";
+        }
+        $num ++;
+        print &mt('Enter [_1]: stop.',$num)."\n";
+        print &mt('Your choice:').' ';
+        my $choice=<STDIN>;
+        chomp($choice);
+        if ($choice =~ /^\d+$/) {
+            if ($choice == 1) {
+                $skipped = 1;       
+            } elsif (($choice < $num) && ($choice > 1)) {
+                $domain = $domains[$choice-2];
+            } elsif ($choice == $num) {
+                $stopnow = 1;
+            } else {
+                print &mt('Invalid choice:')." $choice\n".
+                      &mt('Skipping this user.')."\n";
+                $skipped = 1;
+            }
+        } else {
+            print &mt('Invalid choice:')." $choice\n".
+                  &mt('Skipping this user.')."\n";
+            $skipped = 1;
+        }
+    } elsif (@domains == 1) {
+        $domain = $domains[0];
     }
-    return ($domain,$skipped);
+    return ($domain,$skipped,$stopnow);
 }
 
 sub move_priv_to_home {
@@ -684,7 +821,7 @@ sub move_priv_to_home {
         my $target_path="/home/$uname/public_html";
         if (!-e "/home/$uname") {
             my (undef,undef,$userid,$groupid) = getpwnam($uname);
-            if (mkdir("/home/$uname",0750)) {
+            if (mkdir("/home/$uname",0711)) {
                 if ($userid ne '' && $groupid ne '') {
                     chown($userid,$groupid,"/home/$uname");
                 }
@@ -698,8 +835,12 @@ sub move_priv_to_home {
             if (!-e $target_path) {
                 move($source_path,$target_path);
                 chown($uid,$gid,$target_path);
-                chmod($target_path,2770);
-                $output = &mt('Moved [_1] to [_2].',"'$source_path'","'$target_path'")."\n";
+                chmod(02770,$target_path);
+                if (-e $target_path && !-e $source_path) {
+                    $output = &mt('Moved [_1] to [_2].',"'$source_path'","'$target_path'")."\n";
+                } else {
+                    $output = &mt('Failed to move [_1] to [_2].',"'$source_path'","'$target_path'")."\n";
+                }
             } else {
                 $output = &mt('Directory [_1] already exists -- not moving [_2].',
                               "'$target_path'","'$source_path'")."\n";
@@ -753,6 +894,7 @@ sub check_for_restore_files {
     my ($londaemons,$author,$domain) = @_;
     if (opendir(my $homedir,"/home/$author")) {
         my @contents = grep(!/^\.{1,2}$/,readdir($homedir));
+        closedir($homedir);
         if (@contents > 0) {
             if (grep(/^restore_\d+\.sh$/,@contents)) {
                 if (!-e "$londaemons/logs/moved_construction_spaces") { 
@@ -791,3 +933,46 @@ sub check_for_restore_files {
     return;
 }
 
+sub connect_mysql {
+    my ($lonsqlaccess) = @_;
+    my ($dbh,$dbflag);
+    eval { $dbh = DBI->connect("DBI:mysql:loncapa","www",
+                               $lonsqlaccess,
+                               {RaiseError =>0,PrintError=>0}); 
+    };
+    if ($@) {
+        $dbflag = -1;
+    } else {
+        if (defined($dbh)) {
+            $dbflag = 1;
+        }
+    }
+    return ($dbh,$dbflag);
+}
+
+sub disconnect_mysql {
+    my ($dbh) = @_;
+    if (ref($dbh)) {
+        $dbh->disconnect;
+    }
+    return;
+}
+
+sub search_allusers {
+    my ($dbh,$author) = @_;
+    my %fullnames;
+    if ((ref($dbh)) && ($author ne '')) {
+        eval {
+            my $statement = "SELECT domain, lastname, firstname FROM allusers WHERE username='$author'";
+            my $sth = $dbh->prepare($statement);
+            $sth->execute();
+            while ( my ($dom,$last,$first) = $sth->fetchrow_array()) {
+                if ($dom ne '') {
+                    $fullnames{$dom} = "$first $last";
+                }
+            }
+            $sth->finish;
+        };
+    }
+    return \%fullnames;
+}