--- loncom/homework/bridgetask.pm	2006/05/30 12:45:36	1.158
+++ loncom/homework/bridgetask.pm	2006/06/09 22:31:36	1.163
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA 
 # definition of tags that give a structure to a document
 #
-# $Id: bridgetask.pm,v 1.158 2006/05/30 12:45:36 www Exp $
+# $Id: bridgetask.pm,v 1.163 2006/06/09 22:31:36 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -43,7 +43,7 @@ use LONCAPA;
  
 
 BEGIN {
-    &Apache::lonxml::register('Apache::bridgetask',('Task','IntroParagraph','Dimension','Question','Instance','InstanceText','Criteria','ClosingParagraph'));
+    &Apache::lonxml::register('Apache::bridgetask',('Task','IntroParagraph','Dimension','Question','QuestionText','Setup','Instance','InstanceText','Criteria','ClosingParagraph'));
 }
 
 sub initialize_bridgetask {
@@ -365,26 +365,44 @@ sub file_list {
 	my $file=$file_url.$partial_file;
 	$file=~s|/+|/|g;
 	&Apache::lonnet::allowuploaded('/adm/bridgetask',$file);
-	$file_list.='<li><nobr><a href="'.$file.'?rawmode=1" target="lonGRDs"><img src="'.
-	    &Apache::loncommon::icon($file).'" border="0"> '.$file.
-	    '</a></nobr></li>'."\n";
+	$file_list.='<li><span style="white-space: nowrap;"><a href="'.$file.'?rawmode=1" target="lonGRDs"><img src="'.
+	    &Apache::loncommon::icon($file).'" alt="file icon" border="0" /> '.$file.
+	    '</a></span></li>'."\n";
     }
     $file_list.="</ul>\n";
     return $file_list;
 }
 
+sub grade_mode {
+    if ($env{'form.regrade'} || $env{'form.regradeaspecificsubmission'}) {
+	return 'regrade';
+    }
+    return 'queue_grade';
+}
+
 sub webgrade_standard_info {
     my ($version)=&get_version();
 
     my $file_list = &file_list($Apache::lonhomework::history{"resource.$version.0.bridgetask.portfiles"});
 
-    my %lt=&Apache::lonlocal::texthash('done' => 'Next Item',
-				       'stop' => 'Quit Grading',
-				       'fail' => 'Fail Rest',
-				       );
-				       
+    my %lt=('done'   => 'Next Item',
+	    'stop'   => 'Quit Grading',
+	    'fail'   => 'Fail Rest',
+	    'cancel' => 'Cancel',
+	    );
+    my %lt=&Apache::lonlocal::texthash(%lt);
+
     my $result=<<INFO;
   <div class="LC_GRADING_maincontrols">
+INFO
+
+    if (&grade_mode() eq 'regrade') {
+	$result.=<<INFO;
+    <input type="submit" name="cancel" value="$lt{'cancel'}" />
+INFO
+    }
+
+    $result.=<<INFO;
     <input type="submit" name="next" value="$lt{'done'}" />
     <input type="submit" name="stop" value="$lt{'stop'}" />
     <input type="button" name="fail" value="$lt{'fail'}" 
@@ -455,8 +473,10 @@ sub start_Task {
     if ($target eq 'web' && $env{'request.state'} eq 'construct') {
 	$form_tag_start.=&Apache::structuretags::problem_web_to_edit_header($env{'form.rndseed'});
     }
-    if ($target eq 'web' || ($target eq 'grade' && !$env{'form.webgrade'}) || $target eq 'answer' ||
-	$target eq 'tex') {
+    if ($target eq 'web' 
+	|| ($target eq 'grade' && !$env{'form.webgrade'}) 
+	|| $target eq 'answer' 
+	|| $target eq 'tex') {
 	my ($version,$previous)=&get_version();
 	($status,$accessmsg,my $slot_name,$slot) = 
 	    &Apache::lonhomework::check_slot_access('0','Task');
@@ -592,6 +612,8 @@ DONESCREEN
 		    &mt('Return to resource').'</a></p>';
 		if      ($status_code eq 'stop') {
 		    $result.='<b>'.&mt("Stopped grading.").'</b>'.$back;
+		} elsif ($status_code eq 'cancel') {
+		    $result.='<b>'.&mt("Cancelled grading.").'</b>'.$back;
 		} elsif ($status_code eq 'lock_failed') {
 		    $result.='<b>'.&mt("Failed to lock the requested record.")
 			.'</b>'.$back;
@@ -612,6 +634,8 @@ DONESCREEN
 		}
 	    }
 	    $webgrade='no';
+	}
+	if (!$todo || $env{'form.cancel'}) {
 	    my $bodytext=&Apache::lonxml::get_all_text("/task",$parser,$style);
 	}
 	if ($target eq 'webgrade' && defined($env{'form.queue'})) {
@@ -702,6 +726,8 @@ sub get_key_todo {
 	if (!$queue) {
 	    $env{'form.queue'} = $queue = 'none';
 	    #not queued so doing either a re or pre grade
+	    #FIXME don't allow pregrade
+	    &Apache::lonxml::debug("not in queue no lock");
 	    return ($gradingkey);
 	}
 
@@ -709,11 +735,13 @@ sub get_key_todo {
 	if ($who eq $me) {
 	    #already have the lock
 	    $env{'form.gradingkey'}=&escape($gradingkey);
+	    &Apache::lonxml::debug("already locked");
 	    return ($gradingkey);
 	}
 	
 	if (!defined($who)) {
 	    if (&lock_key($queue,$gradingkey)) {
+		&Apache::lonxml::debug("newly locked");
 		return ($gradingkey);
 	    } else {
 		return (undef,'lock_failed');
@@ -740,6 +768,8 @@ sub get_key_todo {
 	    if ($target eq 'webgrade') {
 		if ($env{'form.stop'}) {
 		    return (undef,'stop');
+		} elsif ($env{'form.cancel'}) {
+		    return (undef,'cancel');
 		} elsif ($env{'form.next'}) {
 		    return (undef,'select_user');
 		}
@@ -785,7 +815,8 @@ sub get_key_todo {
 
     if ($env{'form.queuemode'} ne 'selected') {
 	# don't get something new from the queue if they hit the stop button
-    	if (!($env{'form.stop'} && $target eq 'webgrade') 
+    	if (!(($env{'form.cancel'} || $env{'form.stop'}) 
+	      && $target eq 'webgrade') 
 	    && !$env{'form.gradingaction'}) {
 	    &Apache::lonxml::debug("Getting anew $queue");
 	    return (&get_from_queue($queue));
@@ -937,7 +968,12 @@ DONEBUTTON
 	} elsif ($Apache::lonhomework::results{'INTERNAL_store'}) {
 	    &Apache::structuretags::finalize_storage();
 	}
-	if ($target eq 'grade' && $env{'form.webgrade'} eq 'yes') {
+	if ($target eq 'grade' && $env{'form.webgrade'} eq 'yes' 
+	    && exists($env{'form.cancel'})) {
+	    &check_queue_unlock($env{'form.queue'});
+	    &Apache::lonxml::debug(" cancelled grading .".$env{'form.queue'});
+	} elsif ($target eq 'grade' && $env{'form.webgrade'} eq 'yes' 
+		 && !exists($env{'form.cancel'})) {
 	    my $optional_required=
 		&Apache::lonxml::get_param('OptionalRequired',$parstack,
 					   $safeeval);
@@ -1091,6 +1127,7 @@ sub check_queue_unlock {
     my $me=$env{'user.name'}.':'.$env{'user.domain'};
     my $who=&queue_key_locked($queue,$key,$cdom,$cnum);
     if  ($who eq $me) {
+	&Apache::lonxml::debug("unlocking my own $who");
 	return &Apache::lonnet::del($queue,["$key\0locked"],$cdom,$cnum);
     } elsif ($allow_not_me) {
 	&Apache::lonxml::debug("unlocking $who by $me");
@@ -1257,12 +1294,20 @@ sub show_queue {
     my %queue=&Apache::lonnet::dump($queue,$cdom,$cnum,$regexp);
     my ($tmp)=%queue;
     if ($tmp=~/^error: 2 /) {
-	return "\n<h3>Current Queue - $queue</h3><table border='1'><tr><td>Empty</td></tr></table>";
+	return "\n<h3>Current Queue - $queue</h3>".
+	    &Apache::loncommon::start_data_table().
+	    &Apache::loncommon::start_data_table_row().
+	    '<td>'.&mt('Empty').'</td>'.
+	    &Apache::loncommon::end_data_table_row().
+	    &Apache::loncommon::end_data_table();
     }
     my $title=&Apache::lonnet::gettitle($symb);
-    $result.="\n<h3>Current Queue - $title $queue </h3><table border='1'><tr>";
+    $result.="\n<h3>Current Queue - $title $queue </h3>".
+	&Apache::loncommon::start_data_table().
+	&Apache::loncommon::start_data_table_header_row();
     if ($with_selects) { $result.="<th>Status</th><th></th>"; }
-    $result.="<th>user</th><th>data</th></tr>";
+    $result.="<th>user</th><th>data</th>".
+	&Apache::loncommon::end_data_table_header_row();
     foreach my $key (sort(keys(%queue))) {
 	my ($symb,$uname,$udom) = &decode_queue_key($key);
 	if (!defined($classlist->{$uname.':'.$udom})) { next; }
@@ -1277,14 +1322,15 @@ sub show_queue {
 	}
 
 	if ($key=~/locked$/ && !$with_selects) {
-	    $result.="<tr><td>$uname</td>";
+	    $result.= &Apache::loncommon::start_data_table_row().
+		"<td>$uname</td>";
 	    $result.='<td>'.$queue{$key}.'</td></tr>';
 	} elsif ($key=~/timestamp$/ && !$with_selects) {
-	    $result.="<tr><td></td>";
+	    $result.=&Apache::loncommon::start_data_table_row()."<td></td>";
 	    $result.='<td>'.
 		&Apache::lonlocal::locallocaltime($queue{$key})."</td></tr>";
 	} elsif ($key!~/(timestamp|locked)$/) {
-	    $result.="<tr>";
+	    $result.= &Apache::loncommon::start_data_table_row();
 	    my ($end_time,$slot_text);
 	    if (my $slot=&slotted_access($queue{$key})) {
 		my %slot_data=&Apache::lonnet::get_slot($slot);
@@ -1336,10 +1382,10 @@ FORM
 		" <tt>($uname:$udom)</tt> </td>";
 	    $result.='<td>'.$slot_text.' End time: '.
 		&Apache::lonlocal::locallocaltime($end_time).
-		"</td></tr>";
+		"</td>".&Apache::loncommon::end_data_table_row();
 	}
     }
-    $result.="</table><hr />\n";
+    $result.= &Apache::loncommon::end_data_table()."<hr />\n";
     return $result;
 }
 
@@ -1643,7 +1689,7 @@ sub select_user {
 	$result.='<p> Showing only sections <tt>'.join(', ',@chosen_sections).
 	    '</tt>.</p> '."\n";
     }
-    $result.='<table border="1">';
+    $result.=&Apache::loncommon::start_data_table();
 
     foreach my $student (sort {lc($classlist->{$a}[&Apache::loncoursedata::CL_FULLNAME()]) cmp lc($classlist->{$b}[&Apache::loncoursedata::CL_FULLNAME()]) } (keys(%$classlist))) {
 	my ($uname,$udom) = split(/:/,$student);
@@ -1668,7 +1714,8 @@ sub select_user {
 	my $todo = 
 	    &escape(&encode_queue_key($symb,$udom,$uname));
 	if ($cannot_grade) {
-	    $result.='<tr><td>&nbsp;</td><td>'.$classlist->{$student}[&Apache::loncoursedata::CL_FULLNAME()].
+	    $result.=&Apache::loncommon::start_data_table_row().
+		'<td>&nbsp;</td><td>'.$classlist->{$student}[&Apache::loncoursedata::CL_FULLNAME()].
 		'</td><td>';
 	} else {
 	    my $seclist;
@@ -1676,8 +1723,8 @@ sub select_user {
 		$seclist.='<input type="hidden" name="chosensections" 
                                value="'.$sec.'" />';
 	    }
+	    $result.=&Apache::loncommon::start_data_table_row();
 	    $result.=<<RESULT;
-<tr>
   <td>
     <form style="display: inline" method="post">
       <input type="hidden" name="gradingkey" value="$todo" />
@@ -1726,9 +1773,9 @@ RESULT
 	} else {
 	    $result.="&nbsp;";
 	}
-	$result.= '</td></tr>';
+	$result.= '</td>'.&Apache::loncommon::end_data_table_row();
     }
-    $result.='</table>';
+    $result.=&Apache::loncommon::end_data_table();
     return $result;
 }
 
@@ -1781,6 +1828,15 @@ sub get_id {
 }
 
 my %dimension;
+sub start_Setup {
+    my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;
+    undef(%dimension);
+    my $dim_id=&get_id($parstack,$safeeval);
+    $Apache::bridgetask::dimension=$dim_id;
+    undef(@Apache::bridgetask::instance);
+    &Apache::lonxml::startredirection();
+    return &internal_location($dim_id);
+}
 sub start_Question { return &start_Dimension(@_); }
 sub start_Dimension {
     my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;
@@ -1795,6 +1851,20 @@ sub start_Dimension {
     return &internal_location($dim_id);
 }
 
+sub start_QuestionText {
+    my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
+    my $dim_id=$Apache::bridgetask::dimension;
+    my $text=&Apache::lonxml::get_all_text('/questiontext',$parser,$style);
+    if ($target eq 'grade' || $target eq 'web' || $target eq 'webgrade') {
+	$dimension{'questiontext'}=$text;
+    }
+    return '';
+}
+
+sub end_QuestionText {
+    return '';
+}
+
 sub get_instance {
     my ($dim)=@_;
     my $rand_alg=&Apache::lonnet::get_rand_alg();
@@ -1855,9 +1925,12 @@ sub get_instance {
 	    if (&Apache::response::showallfoils()) {
 		@instances = @{$dimension{'instances'}};
 	    }
+	    my $shown_question_text;
 	    foreach my $instance (@instances) {
 		@Apache::scripttag::parser_env = @_;
 		$result.=&Apache::scripttag::xmlparse($dimension{$instance.'.text'});
+		@Apache::scripttag::parser_env = @_;
+		$result.=&Apache::scripttag::xmlparse($dimension{'questiontext'});
 		if ($Apache::lonhomework::history{"resource.$version.0.status"} eq 'pass' ||
 		    $Apache::lonhomework::history{"resource.$version.0.status"} eq 'fail') {
 
@@ -1942,6 +2015,8 @@ sub get_instance {
 	    &Apache::scripttag::xmlparse($dimension{'intro'});
 	    @Apache::scripttag::parser_env = @_;
 	    &Apache::scripttag::xmlparse($dimension{$instance.'.text'});
+	    @Apache::scripttag::parser_env = @_;
+	    &Apache::scripttag::xmlparse($dimension{'questiontext'});
 	    foreach my $id (@{$dimension{$instance.'.criterias'}},
 			    @{$dimension{'criterias'}} ) {
 		my $link=&link($id);
@@ -1977,11 +2052,14 @@ sub get_instance {
 
 	    @Apache::scripttag::parser_env = @_;
 	    $result.=&Apache::scripttag::xmlparse($dimension{'intro'});
+	    @Apache::scripttag::parser_env = @_;
+	    $result.=&Apache::scripttag::xmlparse($dimension{$instance.'.text'});
+	    @Apache::scripttag::parser_env = @_;
+	    &Apache::scripttag::xmlparse($dimension{'questiontext'});
+
 	    foreach my $id (@{$dimension{$instance.'.criterias'}},
 			    @{$dimension{'criterias'}}) {
 		my $link=&link($id);
-		@Apache::scripttag::parser_env = @_;
-		$result.=&Apache::scripttag::xmlparse($dimension{$instance.'.text'});
 		my $status=$Apache::lonhomework::results{"resource.$version.0.$dim.$id.status"}=$env{'form.HWVAL_'.$link};
 		$Apache::lonhomework::results{"resource.$version.0.$dim.$id.comment"}=$env{'form.HWVAL_comment_'.$link};
 		my $mandatory=($dimension{'criteria.'.$id.'.mandatory'} ne 'N');
@@ -2025,6 +2103,41 @@ sub get_instance {
 	} else {
 	    # any other targets no output
 	    undef($result);
+	}
+	return $result;
+    }
+
+    sub end_Setup {
+	my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;
+	my $result=&Apache::lonxml::endredirection();
+	my $dim=&get_id($parstack,$safeeval);
+	my $instance=&get_instance($dim);
+	my $version=&get_version();
+	if ($target eq 'web') {
+	    @Apache::scripttag::parser_env = @_;
+	    $result.=&Apache::scripttag::xmlparse($dimension{'intro'});
+	    my @instances = $instance;
+	    if (&Apache::response::showallfoils()) {
+		@instances = @{$dimension{'instances'}};
+	    }
+	    foreach my $instance (@instances) {
+		@Apache::scripttag::parser_env = @_;
+		$result.=&Apache::scripttag::xmlparse($dimension{$instance.'.text'});
+		@Apache::scripttag::parser_env = @_;
+		$result.=&Apache::scripttag::xmlparse($dimension{'questiontext'});
+	    }
+	} elsif ($target eq 'webgrade' 
+		 || $target eq 'grade' && $env{'form.webgrade'}) {
+	    # in case of any side effects that we need
+	    @Apache::scripttag::parser_env = @_;
+	    &Apache::scripttag::xmlparse($dimension{'intro'});
+	    @Apache::scripttag::parser_env = @_;
+	    &Apache::scripttag::xmlparse($dimension{$instance.'.text'});
+	    @Apache::scripttag::parser_env = @_;
+	    &Apache::scripttag::xmlparse($dimension{'questiontext'});
+	} else {
+	    # any other targets no output
+	    undef($result);
 	}
 	return $result;
     }