[BACK]Return to bridgetask.pm CVS log [TXT] [DIR] Up to [LON-CAPA] / loncom / homework

Diff for /loncom/homework/bridgetask.pm between versions 1.19 and 1.22

version 1.19, 2005/05/09 21:55:01 version 1.22, 2005/05/10 20:29:26
Line 48  sub initialize_bridgetask { Line 48  sub initialize_bridgetask {
     $Apache::bridgetask::dimension='';      $Apache::bridgetask::dimension='';
     # list of all Dimension ids seen      # list of all Dimension ids seen
     @Apache::bridgetask::dimensionlist=();      @Apache::bridgetask::dimensionlist=();
       # mandatory attribute of all Dimensions seen
       %Apache::bridgetask::dimensionmandatory=();
     # list of all current Instance ids      # list of all current Instance ids
     @Apache::bridgetask::instance=();      @Apache::bridgetask::instance=();
     # list of all Instance ids seen in this problem      # list of all Instance ids seen in this problem
Line 57  sub initialize_bridgetask { Line 59  sub initialize_bridgetask {
 }  }
   
 sub proctor_check_auth {  sub proctor_check_auth {
     my ($slot)=@_;      my ($slot_name,$slot)=@_;
     my $user=$env{'form.proctorname'};      my $user=$env{'form.proctorname'};
     my $domain=$env{'form.proctordomain'};      my $domain=$env{'form.proctordomain'};
           
Line 69  sub proctor_check_auth { Line 71  sub proctor_check_auth {
     if ($authhost ne 'no_host') {      if ($authhost ne 'no_host') {
  $Apache::lonhomework::results{'resource.checkedin'}=   $Apache::lonhomework::results{'resource.checkedin'}=
     $user.'@'.$domain;      $user.'@'.$domain;
    $Apache::lonhomework::results{'resource.checkedin.slot'}=
       $slot_name;
  return 1;   return 1;
     }      }
  }   }
Line 92  sub add_grading_button { Line 96  sub add_grading_button {
     return $result;      return $result;
 }  }
   
   sub add_request_another_attempt_button {
       
   }
   
 sub start_Task {  sub start_Task {
     my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;      my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;
   
Line 115  sub start_Task { Line 123  sub start_Task {
     $body_tag_start.=$uri.'">'.&add_grading_button()."</form>";      $body_tag_start.=$uri.'">'.&add_grading_button()."</form>";
  }   }
     }      }
     if ($target eq 'web' || $target eq 'grade' || $target eq 'answer' ||      if ($target eq 'web' || ($target eq 'grade' && !$env{'form.webgrade'}) || $target eq 'answer' ||
  $target eq 'tex') {   $target eq 'tex') {
  ($status,$accessmsg,my $slot_name,$slot) =    ($status,$accessmsg,my $slot_name,$slot) = 
     &Apache::lonhomework::check_task_access('0');      &Apache::lonhomework::check_task_access('0');
Line 130  sub start_Task { Line 138  sub start_Task {
     ( $status eq 'UNAVAILABLE') ||      ( $status eq 'UNAVAILABLE') ||
     ( $status eq 'NOT_IN_A_SLOT') ||      ( $status eq 'NOT_IN_A_SLOT') ||
     ( $status eq 'NEEDS_CHECKIN') ||      ( $status eq 'NEEDS_CHECKIN') ||
       ( $status eq 'WAITING_FOR_GRADE') ||
     ( $status eq 'INVALID_ACCESS')) {      ( $status eq 'INVALID_ACCESS')) {
     my $bodytext=&Apache::lonxml::get_all_text("/task",$parser);      my $bodytext=&Apache::lonxml::get_all_text("/task",$parser);
     if ( $target eq "web" ) {      if ( $target eq "web" ) {
Line 142  sub start_Task { Line 151  sub start_Task {
  } elsif ($status eq 'NEEDS_CHECKIN') {   } elsif ($status eq 'NEEDS_CHECKIN') {
     $msg.='<h1>'.&mt('You need the Proctor to validate you.').      $msg.='<h1>'.&mt('You need the Proctor to validate you.').
  '</h1>'.&proctor_validation_screen($slot);   '</h1>'.&proctor_validation_screen($slot);
    } elsif ($status eq 'WAITING_FOR_GRADE') {
       $msg.='<h1>'.&mt('Your submission is in the grading queue.').'</h1>';
  } elsif ($status ne 'NOT_YET_VIEWED') {   } elsif ($status ne 'NOT_YET_VIEWED') {
     $msg.='<h1>'.&mt('Not open to be viewed').'</h1>';      $msg.='<h1>'.&mt('Not open to be viewed').'</h1>';
  }   }
Line 156  sub start_Task { Line 167  sub start_Task {
  } else {   } else {
     $result.=&mt('Problem is not open to be viewed. It')." $accessmsg \\vskip 0 mm ";      $result.=&mt('Problem is not open to be viewed. It')." $accessmsg \\vskip 0 mm ";
  }   }
     } elsif ($target eq 'grade') {      } elsif ($target eq 'grade' && !$env{'form.webgrade'}) {
  if ($status eq 'NEEDS_CHECKIN') {   if ($status eq 'NEEDS_CHECKIN') {
     if (&proctor_check_auth($slot)) {      if (&proctor_check_auth($slot_name,$slot)) {
  #FIXME immeadiatly add this to the grading queue   #FIXME immeadiatly add this to the grading queue
                         #      with slot->{'endtime'} for when grading can                           #      with slot->{'endtime'} for when grading can 
                         #      begin on this resource                          #      begin on this resource
    # FIXME I think the above is done by default,
                           #        need to check that
                           #        failure doesn't do this.
      }       }
  }   }
     }      }
Line 177  sub start_Task { Line 191  sub start_Task {
  '" value="'.$env{"form.grade_$field"}.'" />'."\n";   '" value="'.$env{"form.grade_$field"}.'" />'."\n";
  }   }
     }      }
       if ($Apache::lonhomework::history{'resource.status'} eq 'fail') {
    $result.='<h1><font color="red">'.&mt('Did not pass').'</font></h1>';
    $result.=&request_another_attempt_button();
       }
       if ($Apache::lonhomework::history{'resource.status'} eq 'pass') {
    $result.='<h1><font color="green">'.&mt('Passed').'</font></h1>';
       }
    }
       } elsif ( ($target eq 'grade' && $env{'form.webgrade'}) ||
         $target eq 'webgrade') {
    if ($target eq 'webgrade') {
       $result.=$head_tag_start.$body_tag_start.$form_tag_start;
       $result.='<input type="hidden" name="webgrade" value="yes" />';
       $result.=&show_queue();
  }   }
     } elsif ($target eq 'webgrade') {  
  $result.=$head_tag_start.$body_tag_start.$form_tag_start;  
  $result.=  
     '<input type="hidden" name="grade_target" value="webgrade" />';  
  $result.=&show_queue();  
  my $todo=&get_from_queue();   my $todo=&get_from_queue();
  if ($todo) {   if ($todo) {
     &setup_env_for_other_user($todo,$safeeval);      &setup_env_for_other_user($todo,$safeeval);
Line 196  sub start_Task { Line 219  sub start_Task {
     &Apache::lonhomework::showhash(%Apache::lonhomework::history);      &Apache::lonhomework::showhash(%Apache::lonhomework::history);
     $result.="\n".'<table width="100%" style="width:100%" border="1">';      $result.="\n".'<table width="100%" style="width:100%" border="1">';
  } else {   } else {
     $result.="\n".      if ($target eq 'webgrade') {
  '<table><tr><td>No user to be graded.</td></tr></table>';   $result.="\n".
       '<table><tr><td>No user to be graded.</td></tr></table>';
       }
     my $bodytext=&Apache::lonxml::get_all_text("/task",$parser);      my $bodytext=&Apache::lonxml::get_all_text("/task",$parser);
  }   }
   
     } else {      } else {
  # page_start returned a starting result, delete it if we don't need it   # page_start returned a starting result, delete it if we don't need it
  $result = '';   $result = '';
Line 231  sub end_Task { Line 255  sub end_Task {
  $result.=&Apache::lonxml::xmlend().'</html>';   $result.=&Apache::lonxml::xmlend().'</html>';
     }      }
  }   }
  if ($target eq 'grade') {   if ($target eq 'grade' && !$env{'form.webgrade'}) {
     my $award='SUBMITTED';      my $award='SUBMITTED';
     &Apache::essayresponse::file_submission('0','bridgetask','portfiles',\$award);      &Apache::essayresponse::file_submission('0','bridgetask',
       'portfiles',\$award);
     if ($award eq 'SUBMITTED' &&      if ($award eq 'SUBMITTED' &&
  $Apache::lonhomework::results{"resource.0.bridgetask.portfiles"}) {   $Apache::lonhomework::results{"resource.0.bridgetask.portfiles"}) {
  $Apache::lonhomework::results{"resource.0.tries"}=   $Apache::lonhomework::results{"resource.0.tries"}=
Line 246  sub end_Task { Line 271  sub end_Task {
  &add_to_queue();   &add_to_queue();
     }      }
  }   }
    if ($target eq 'grade' && $env{'form.webgrade'}) {
       my $optional_required=
    &Apache::lonxml::get_param('OptionalRequired',$parstack,
      $safeeval);
       my $optional_passed=0;
       my $mandatory_failed=0;
       my $ungraded=0;
       my $review=0;   
       &Apache::lonhomework::showhash(%Apache::lonhomework::results);
       foreach my $dim_id (@Apache::bridgetask::dimensionlist) {
    my $status=
       $Apache::lonhomework::results{"resource.$dim_id.status"};
    my $mandatory=
       ($Apache::bridgetask::dimensionmandatory{$dim_id} ne 'N');
    if ($status eq 'pass') {
       if (!$mandatory) { $optional_passed++; }
    } elsif ($status eq 'fail') {
       if ($mandatory) { $mandatory_failed++; }
    } elsif ($status eq 'ungraded') {
       $ungraded++;
    } elsif ($status eq 'review') {
       $review++;
    }
       }
       if ($optional_passed < $optional_required) {
    $mandatory_failed++;
       }
       &Apache::lonxml::debug("all dim ".join(':',@Apache::bridgetask::dimensionlist)."results -> m_f $mandatory_failed o_p $optional_passed u $ungraded r $review");
       $Apache::lonhomework::results{'resource.grader'}=
    $env{'user.name'}.'@'.$env{'user.domain'};
       if ($review) {
    $Apache::lonhomework::results{'resource.status'}='review';
    &move_to_review_queue();
       } elsif ($ungraded) {
    $Apache::lonhomework::results{'resource.status'}='ungraded';
    &check_queue_unlock();
       } elsif ($mandatory_failed) {
    $Apache::lonhomework::results{'resource.status'}='fail';
    $Apache::lonhomework::results{"resource.0.award"}='EXACT_ANS';
    &remove_from_queue();
       } else {
    $Apache::lonhomework::results{'resource.status'}='pass';
    $Apache::lonhomework::results{"resource.0.award"}='INCORRECT';
    &remove_from_queue();
       }
       &Apache::structuretags::finalize_storage();
    }
     } elsif ($target eq 'webgrade') {      } elsif ($target eq 'webgrade') {
  $result.="</table>\n<hr />";   $result.="</table>\n<hr />";
  $result.='<input type="submit" name="next" value="'.   #$result.='<input type="submit" name="next" value="'.
     &mt('Save & Next').'" /> ';   #    &mt('Save &amp; Next').'" /> ';
  $result.='<input type="submit" name="end" value="'.   #$result.='<input type="submit" name="end" value="'.
     &mt('Save & Stop Grading').'" /> ';   #    &mt('Save &amp; Stop Grading').'" /> ';
  $result.='<input type="submit" name="end" value="'.   #$result.='<input type="submit" name="throwaway" value="'.
     &mt('Throw Away & Stop Grading').'" /> ';   #    &mt('Throw Away &amp; Stop Grading').'" /> ';
    #$result.='<input type="submit" name="save" value="'.
    #    &mt('Save Partial Grade and Continue Grading').'" /> ';
  $result.='</form>'.&Apache::loncommon::endbodytag().'</html>';   $result.='</form>'.&Apache::loncommon::endbodytag().'</html>';
     } elsif ($target eq 'meta') {      } elsif ($target eq 'meta') {
  $result.='<parameter part="0" package="Task"></parameter>'."\n";   $result.='<parameter part="0" package="Task"></parameter>'."\n";
Line 264  sub end_Task { Line 338  sub end_Task {
     return $result;      return $result;
 }  }
   
   sub move_to_review_queue {
       &Apache::lonxml::debug("Want to move");
   }
   
   sub check_queue_unlock {
       &Apache::lonxml::debug("Want to unlock?");
   }
   
   sub remove_from_queue {
       &Apache::lonxml::debug("Want to remove. Done?");
   }
   
 sub setup_env_for_other_user {  sub setup_env_for_other_user {
     my ($queue_key,$safeeval)=@_;      my ($queue_key,$safeeval)=@_;
     my ($symb,$uname,$udom)=&decode_queue_key($queue_key);      my ($symb,$uname,$udom)=&decode_queue_key($queue_key);
Line 290  sub show_queue { Line 376  sub show_queue {
     my $cdom=$env{'course.'.$cid.'.domain'};      my $cdom=$env{'course.'.$cid.'.domain'};
     my $regexp="^$symb\0";      my $regexp="^$symb\0";
     my %queue=&Apache::lonnet::dump('gradingqueue',$cdom,$cnum,$regexp);      my %queue=&Apache::lonnet::dump('gradingqueue',$cdom,$cnum,$regexp);
     $result.="\n<h3>Current Queue</h3><table><tr><th>resource</th><th>user</th><th>type</th><th>data</th></tr>";      $result.="\n<h3>Current Queue</h3><table><tr><th>resource</th>".
    "<th>user</th><th>type</th><th>data</th></tr>";
     foreach my $key (sort(keys(%queue))) {      foreach my $key (sort(keys(%queue))) {
  if ($key=~/locked$/) {   if ($key=~/locked$/) {
     my ($symb,$uname,$udom) = &decode_queue_key($key);      my ($symb,$uname,$udom) = &decode_queue_key($key);
Line 309  sub show_queue { Line 396  sub show_queue {
     $result.="<tr><td>$title</td><td>$uname</td><td>";      $result.="<tr><td>$title</td><td>$uname</td><td>";
     my $slot=$queue{$key}->[0];      my $slot=$queue{$key}->[0];
     my %slot_data=&Apache::lonnet::get_slot($slot);      my %slot_data=&Apache::lonnet::get_slot($slot);
     $result.='<td>queue entry</td><td>End time: '.&Apache::lonlocal::locallocaltime($slot_data{'endtime'})."</td></tr>";      $result.='<td>queue entry</td><td>End time: '.
    &Apache::lonlocal::locallocaltime($slot_data{'endtime'}).
    "</td></tr>";
  }   }
     }      }
     $result.="</table><hr />\n";      $result.="</table><hr />\n";
Line 484  sub start_Dimension { Line 573  sub start_Dimension {
     $Apache::bridgetask::dimension=$dim_id;      $Apache::bridgetask::dimension=$dim_id;
     push(@Apache::bridgetask::dimensionlist,$dim_id);      push(@Apache::bridgetask::dimensionlist,$dim_id);
     undef(@Apache::bridgetask::instance);      undef(@Apache::bridgetask::instance);
       $Apache::bridgetask::dimensionmandatory{$dim_id}=
    &Apache::lonxml::get_param('Mandatory',$parstack,$safeeval);
     return '';      return '';
 }  }
   
Line 501  sub get_instance { Line 592  sub get_instance {
     sub end_Dimension {      sub end_Dimension {
  my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;   my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;
  my $result;   my $result;
    my $dim_id=&get_id($parstack,$safeeval);
  my $instance=&get_instance();   my $instance=&get_instance();
  if ($target eq 'web') {   if ($target eq 'web') {
     $result=$dimension{'intro'}.$dimension{$instance.'.text'};      $result=$dimension{'intro'}.$dimension{$instance.'.text'};
       if ($Apache::lonhomework::history{'resource.status'} eq 'pass' ||
    $Apache::lonhomework::history{'resource.status'} eq 'fail') {
    foreach my $id (@{$dimension{$instance.'.criterias'}}) {
       my $status=$Apache::lonhomework::history{"resource.$dim_id.$instance.$id.status"};
       my $comment=$Apache::lonhomework::history{"resource.$dim_id.$instance.$id.comment"};
       $result.='<table border="1"><tr><td>';
       if ($status eq 'fail') {
    $result.='<font color="red">'.&mt('Did not pass').'</font>';
       } elsif ($status eq 'pass') {
    $result.='<font color="green">'.&mt('Passed').'</font>';
       } else {
    &Apache::lonxml::error("Student viewing a graded bridgetask was show a status of $status");
       }
       $result.='</td></tr><tr><td>';
       if ($Apache::lonhomework::history{"resource.$dim_id.$instance.$id.comment"}) {
    $result.=&mt('Comment from grader: ').$Apache::lonhomework::history{"resource.$dim_id.$instance.$id.comment"}.'</td></tr><tr><td>';
       }
       $result.=$dimension{$instance.'.criteria.'.$id}.
    '</td></tr></table>';
    }
       }
  } elsif ($target eq 'webgrade') {   } elsif ($target eq 'webgrade') {
     foreach my $id (@{$dimension{$instance.'.criterias'}}) {      foreach my $id (@{$dimension{$instance.'.criterias'}}) {
  my $link='criteria_'.$instance.'_'.$id;   my $link='criteria_'.$instance.'_'.$id;
    my $status=$Apache::lonhomework::history{"resource.$dim_id.$instance.$id.status"};
  $result.='<tr><td width="100%" valign="top">'.   $result.='<tr><td width="100%" valign="top">'.
     '<a name="'.$link.'" />'.      '<a name="'.$link.'" />'.
     '<a name="next_'.$last_link.'" />'.      '<a name="next_'.$last_link.'" />'.
Line 514  sub get_instance { Line 628  sub get_instance {
     #$dimension{$instance.'.criteria.'.$id}.      #$dimension{$instance.'.criteria.'.$id}.
     '</td>'.      '</td>'.
     '<td><nobr>Additional Comment for Student</nobr> <br />'.      '<td><nobr>Additional Comment for Student</nobr> <br />'.
     '<textarea style="width:100%" rows="8" width="25" wrap="hard" name="HWVAL_comment_'.$link.'"></textarea>'.      '<textarea style="width:100%" rows="8" width="25" wrap="hard" name="HWVAL_comment_'.$link.'">'.&HTML::Entities::encode($Apache::lonhomework::history{"resource.$dim_id.$instance.$id.comment"}).'</textarea>'.
     '</td>'.      '</td>'.
     '<td>'.      '<td>'.
     '<nobr><label><input type="radio" name="HWVAL_'.$link.'" value="ungraded" />Ungraded</label></nobr><br />'.      '<nobr><label><input type="radio" name="HWVAL_'.$link.'" value="ungraded" '.($status eq 'ungraded' || !$status ? 'checked="checked"':'').'/>Ungraded</label></nobr><br />'.
     '<label><input type="radio" name="HWVAL_'.$link.'" value="pass" />Pass</label><br />'.      '<label><input type="radio" name="HWVAL_'.$link.'" value="pass" '.($status eq 'pass' ? 'checked="checked"':'').' />Pass</label><br />'.
     '<label><input type="radio" name="HWVAL_'.$link.'" value="fail" />Fail</label><br />'.      '<label><input type="radio" name="HWVAL_'.$link.'" value="fail" '.($status eq 'fail' ? 'checked="checked"':'').' />Fail</label><br />'.
     '<label><input type="radio" name="HWVAL_'.$link.'" value="review" />Review</label><br />'.      '<label><input type="radio" name="HWVAL_'.$link.'" value="review" '.($status eq 'review' ? 'checked="checked"':'').' />Review</label><br />'.
     '</td>'.      '</td>'.
     '<td>'.      '<td>'.
     '<a href="#'.$last_link.'">Prev</a><br />'.      '<a href="#'.$last_link.'">Prev</a><br />'.
     '<a href="#next_'.$link.'">Next</a><br />'.      '<a href="#next_'.$link.'">Next</a><br /><br /><br />'.
       '<input type="submit" name="next" value="'.
       &mt('Done').'" /> '.
     '</td></tr>';      '</td></tr>';
    $result.='<tr><td colspan="4">';
    my (undef,undef,$udom,$uname) = &Apache::lonxml::whichuser();
    my $file_url = '/uploaded/'.$udom.'/'.$uname.'/portfolio';
    foreach my $partial_file (split(',',$Apache::lonhomework::history{"resource.0.bridgetask.portfiles"})) {
       my $file=$file_url.$partial_file;
       &Apache::lonnet::allowuploaded('/adm/bridgetask',$file);
       $result.='<a href="'.$file.'" target="lonGRDs"><img src="'.
    &Apache::loncommon::icon($file).'" border=0"> '.$file.
    '</a>';
    }
    $result.='</td></tr>';
  $last_link=$link;   $last_link=$link;
     }      }
  } elsif ($target eq 'grade') {   } elsif ($target eq 'grade' && $env{'form.webgrade'}) {
     my $optional_passed=0;      my $optional_passed=0;
       my $mandatory_failed=0;
       my $ungraded=0;
       my $review=0;
     foreach my $id (@{$dimension{$instance.'.criterias'}}) {      foreach my $id (@{$dimension{$instance.'.criterias'}}) {
  if ($env{'form.HWVAL_criteria_'.$instance.'_'.$id} eq 'pass') {   my $status=$Apache::lonhomework::results{"resource.$dim_id.$instance.$id.status"}=$env{'form.HWVAL_criteria_'.$instance.'_'.$id};
  } elsif ($env{'form.HWVAL_criteria_'.$instance.'_'.$id} eq 'fail') {   $Apache::lonhomework::results{"resource.$dim_id.$instance.$id.comment"}=$env{'form.HWVAL_comment_criteria_'.$instance.'_'.$id};
  } elsif ($env{'form.HWVAL_criteria_'.$instance.'_'.$id} eq 'ungraded') {   my $mandatory=($dimension{$instance.'.criteria.'.$id.'.mandatory'} ne 'N');
  } elsif ($env{'form.HWVAL_criteria_'.$instance.'_'.$id} eq 'review') {   if ($status eq 'pass') {
       if (!$mandatory) { $optional_passed++; }
    } elsif ($status eq 'fail') {
       if ($mandatory) { $mandatory_failed++; }
    } elsif ($status eq 'review') {
       $review++;
    } elsif ($status eq 'ungraded') {
       $ungraded++;
    } else {
       &Apache::lonxml::error("got weird status --$status--");
  }   }
     }      }
       if ($optional_passed < $dimension{$instance.'.optionalrequired'}) {
    $mandatory_failed++;
       }
       &Apache::lonxml::debug("all instance ".join(':',@{$dimension{$instance.'.criterias'}})." results -> m_f $mandatory_failed o_p $optional_passed u $ungraded r $review");
       if ($review) {
    $Apache::lonhomework::results{"resource.$dim_id.status"}=
       'review';
       } elsif ($ungraded) {
    $Apache::lonhomework::results{"resource.$dim_id.status"}=
       'ungraded';
       } elsif ($mandatory_failed) {
    $Apache::lonhomework::results{"resource.$dim_id.status"}=
       'fail';
       } else {
    $Apache::lonhomework::results{"resource.$dim_id.status"}=
       'pass';
       }
  }   }
  return $result;   return $result;
     }      }
Line 570  sub start_Instance { Line 726  sub start_Instance {
     push(@{$dimension{'instances'}},$id);      push(@{$dimension{'instances'}},$id);
     push(@Apache::bridgetask::instance,$id);      push(@Apache::bridgetask::instance,$id);
     push(@Apache::bridgetask::instancelist,$id);      push(@Apache::bridgetask::instancelist,$id);
     $dimension{$instance_id.'.optionalrequired'}=      $dimension{$id.'.optionalrequired'}=
  &Apache::lonxml::get_param('OptionalRequired',$parstack,$safeeval);   &Apache::lonxml::get_param('OptionalRequired',$parstack,$safeeval);
     return '';      return '';
 }  }
Line 599  sub end_InstanceText { Line 755  sub end_InstanceText {
   
 sub start_Criteria {  sub start_Criteria {
     my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;      my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;
     if ($target eq 'web' || $target eq 'webgrade') {      if ($target eq 'web' || $target eq 'webgrade' || $target eq 'grade') {
  &Apache::lonxml::startredirection();   &Apache::lonxml::startredirection();
     }      }
     return '';      return '';
Line 608  sub start_Criteria { Line 764  sub start_Criteria {
 sub end_Criteria {  sub end_Criteria {
     my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;      my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;
     my $instance_id=$Apache::bridgetask::instance[-1];      my $instance_id=$Apache::bridgetask::instance[-1];
     if ($target eq 'web' || $target eq 'webgrade') {      if ($target eq 'web' || $target eq 'webgrade' || $target eq 'grade') {
  my $criteria=&Apache::lonxml::endredirection();   my $criteria=&Apache::lonxml::endredirection();
  my $id=&get_id($parstack,$safeeval);   my $id=&get_id($parstack,$safeeval);
  $dimension{$instance_id.'.criteria.'.$id}=$criteria;   $dimension{$instance_id.'.criteria.'.$id}=$criteria;
Removed from v.1.19  
changed lines
  Added in v.1.22

FreeBSD-CVSweb <freebsd-cvsweb@FreeBSD.org>