Diff for /loncom/homework/bridgetask.pm between versions 1.48 and 1.49

version 1.48, 2005/09/14 21:03:48 version 1.49, 2005/09/20 06:45:02
Line 158  sub add_grading_button { Line 158  sub add_grading_button {
  $result.='<p>'.&mt("Review Queue has [_1] entries. [_2] of them are ready to be graded and [_3] of them are currently being graded",$entries,$ready,$locks);   $result.='<p>'.&mt("Review Queue has [_1] entries. [_2] of them are ready to be graded and [_3] of them are currently being graded",$entries,$ready,$locks);
  $result.=' <input type="submit" name="reviewasubmission" value="'.   $result.=' <input type="submit" name="reviewasubmission" value="'.
     &mt("Select an entry from the review queue").'" /> </p>'."\n";      &mt("Select an entry from the review queue").'" /> </p>'."\n";
    $result.=' <input type="submit" name="regradeasubmission" value="'.
       &mt("Select a user to regrade.").'" /> </p>'."\n";
     }      }
     return $result;      return $result;
 }  }
Line 311  sub start_Task { Line 313  sub start_Task {
  my $webgrade='yes';   my $webgrade='yes';
  if ($target eq 'webgrade') {   if ($target eq 'webgrade') {
     $result.=$head_tag_start.$body_tag_start;      $result.=$head_tag_start.$body_tag_start;
     $result.='<br />Review'.&show_queue('reviewqueue');      #$result.='<br />Review'.&show_queue('reviewqueue');
     $result.='<br />Grade'.&show_queue('gradingqueue');      #$result.='<br />Grade'.&show_queue('gradingqueue');
  }   }
  # FIXME Blast! still need to reorg this, need to reshow the   # FIXME Blast! still need to reorg this, need to reshow the
         #       queue being reviewed once done with the grade pass...          #       queue being reviewed once done with the grade pass...
Line 334  sub start_Task { Line 336  sub start_Task {
     &Apache::structuretags::initialize_storage();      &Apache::structuretags::initialize_storage();
     &Apache::lonhomework::showhash(%Apache::lonhomework::history);      &Apache::lonhomework::showhash(%Apache::lonhomework::history);
     if ($target eq 'webgrade') {      if ($target eq 'webgrade') {
  $result.='<br />After -'.&show_queue($env{'form.queue'});   #$result.='<br />After -'.&show_queue($env{'form.queue'});
  $result.="\n".'<table width="100%" style="width:100%" border="1">';   $result.="\n".'<table width="100%" style="width:100%" border="1">';
  if ($status_code eq 'selected') {   if ($status_code eq 'selected') {
     $form_tag_start.=      $form_tag_start.=
Line 353  sub start_Task { Line 355  sub start_Task {
     $result.=&show_queue($env{'form.queue'},1);      $result.=&show_queue($env{'form.queue'},1);
  } elsif ($status_code eq 'show_list') {   } elsif ($status_code eq 'show_list') {
     $result.=&show_queue($env{'form.queue'},1);      $result.=&show_queue($env{'form.queue'},1);
    } elsif ($status_code eq 'select_user') {
       $result.=&select_user();
  } else {   } else {
     $result.='<b>'.&mt("No user to be graded.").'</b>';      $result.='<b>'.&mt("No user to be graded.").'</b>';
  }   }
Line 390  sub get_key_todo { Line 394  sub get_key_todo {
  return (undef,'show_list');   return (undef,'show_list');
     }      }
   
       if (defined($env{'form.regradeasubmission'})) {
    &Apache::lonxml::debug("regrade a grading....");
    $env{'form.queue'}='none';
    return (undef,'select_user');
       }
   
     my $queue=$env{'form.queue'};      my $queue=$env{'form.queue'};
   
     if (!defined($queue)) {      if (!defined($queue)) {
Line 398  sub get_key_todo { Line 408  sub get_key_todo {
   
     my $gradingkey=&Apache::lonnet::unescape($env{'form.gradingkey'});      my $gradingkey=&Apache::lonnet::unescape($env{'form.gradingkey'});
   
       if ($env{'form.queue'} eq 'none') {
    if (defined($env{'form.gradingkey'})) {
       if ($target eq 'webgrade') {
    if ($env{'form.stop'}) {
       return (undef,'stop');
    } elsif ($env{'form.next'}) {
       return (undef,'show_list');
    }
       }
       return ($gradingkey,'selected');
    } else {
       return (undef,'show_list');
    }
       }
     if (defined($env{'form.queue'}) && defined($env{'form.gradingkey'})      if (defined($env{'form.queue'}) && defined($env{'form.gradingkey'})
  && !defined($env{'form.gradingaction'})    && !defined($env{'form.gradingaction'}) 
  && $env{'form.queuemode'} eq 'selected') {   && $env{'form.queuemode'} eq 'selected') {
Line 516  sub end_Task { Line 540  sub end_Task {
     $ungraded++;      $ungraded++;
  } elsif ($status eq 'review') {   } elsif ($status eq 'review') {
     $review++;      $review++;
  }   } else {
       $ungraded++;
    }
     }      }
     if ($optional_passed < $optional_required) {      if ($optional_passed < $optional_required) {
  $mandatory_failed++;   $mandatory_failed++;
Line 530  sub end_Task { Line 556  sub end_Task {
     &check_queue_unlock($env{'form.queue'});      &check_queue_unlock($env{'form.queue'});
     &Apache::lonxml::debug(" still needs review not changing status.");      &Apache::lonxml::debug(" still needs review not changing status.");
  } else {   } else {
     &move_between_queues('gradingqueue','reviewqueue');      &move_between_queues($env{'form.queue'},'reviewqueue');
  }   }
     } elsif ($ungraded) {      } elsif ($ungraded) {
  $Apache::lonhomework::results{"resource.$version.status"}='ungraded';   $Apache::lonhomework::results{"resource.$version.status"}='ungraded';
  if ($env{'form.queue'} eq 'reviewqueue') {   if ($env{'form.queue'} eq 'reviewqueue' ||
       $env{'form.queue'} eq 'none' ) {
     &Apache::lonxml::debug("moving back.");      &Apache::lonxml::debug("moving back.");
     &move_between_queues('reviewqueue','gradingqueue');      &move_between_queues($env{'form.queue'},'gradingqueue');
  } else {   } else {
     &check_queue_unlock($env{'form.queue'});      &check_queue_unlock($env{'form.queue'});
  }   }
Line 605  sub end_Task { Line 632  sub end_Task {
   
 sub move_between_queues {  sub move_between_queues {
     my ($src_queue,$dest_queue)=@_;      my ($src_queue,$dest_queue)=@_;
     my $cur_data=&get_queue_data($src_queue);      my $cur_data;
     if (!$cur_data) { return 'not_exist'; }      if ($src_queue ne 'none') {
    $cur_data=&get_queue_data($src_queue);
    if (!$cur_data) { return 'not_exist'; }
       } else {
    $cur_data = ['none'];
       }
     my $result=&add_to_queue($dest_queue,$cur_data->[0]);      my $result=&add_to_queue($dest_queue,$cur_data->[0]);
     if ($result ne 'ok') {      if ($result ne 'ok') {
  return $result;   return $result;
Line 617  sub move_between_queues { Line 649  sub move_between_queues {
   
 sub check_queue_unlock {  sub check_queue_unlock {
     my ($queue,$key,$allow_not_me)=@_;      my ($queue,$key,$allow_not_me)=@_;
       if ($queue eq 'none') { return 'ok'; }
     my ($symb,$cid,$udom,$uname)=&Apache::lonxml::whichuser();      my ($symb,$cid,$udom,$uname)=&Apache::lonxml::whichuser();
     if (!defined($key)) {      if (!defined($key)) {
  $key="$symb\0queue\0$uname\@$udom";   $key="$symb\0queue\0$uname\@$udom";
Line 636  sub check_queue_unlock { Line 669  sub check_queue_unlock {
   
 sub remove_from_queue {  sub remove_from_queue {
     my ($queue)=@_;      my ($queue)=@_;
       if ($queue eq 'none') { return 'ok'; }
     my ($symb,$cid,$udom,$uname)=&Apache::lonxml::whichuser();      my ($symb,$cid,$udom,$uname)=&Apache::lonxml::whichuser();
     my $cnum=$env{'course.'.$cid.'.num'};      my $cnum=$env{'course.'.$cid.'.num'};
     my $cdom=$env{'course.'.$cid.'.domain'};      my $cdom=$env{'course.'.$cid.'.domain'};
Line 668  sub get_queue_data { Line 702  sub get_queue_data {
     return undef;      return undef;
 }  }
   
   sub check_queue_for_key {
       my ($cid,$queue,$todo)=@_;
       my $cnum=$env{'course.'.$cid.'.num'};
       my $cdom=$env{'course.'.$cid.'.domain'};
       my %results=
    &Apache::lonnet::get($queue,[$todo,"$todo\0locked"],$cdom,$cnum);
       
       if (exists($results{$todo}) && ref($results{$todo})) {
    if (defined($results{"$todo\0locked"})) {
       return 'locked';
    }
    return 'enqueued';
       }
       return undef;
   }
   
 sub add_to_queue {  sub add_to_queue {
     my ($queue,$slot_name)=@_;      my ($queue,$slot_name)=@_;
       if ($queue eq 'none') { return 'ok'; }
     my ($symb,$cid,$udom,$uname)=&Apache::lonxml::whichuser();      my ($symb,$cid,$udom,$uname)=&Apache::lonxml::whichuser();
     my $cnum=$env{'course.'.$cid.'.num'};      my $cnum=$env{'course.'.$cid.'.num'};
     my $cdom=$env{'course.'.$cid.'.domain'};      my $cdom=$env{'course.'.$cid.'.domain'};
Line 781  sub get_queue_counts { Line 832  sub get_queue_counts {
     return ($entries,$ready_to_grade,$locks);      return ($entries,$ready_to_grade,$locks);
 }  }
   
   sub encode_queue_key {
       my ($symb,$udom,$uname)=@_;
       return "$symb\0queue\0$uname\@$udom";
   }
   
 sub decode_queue_key {  sub decode_queue_key {
     my ($key)=@_;      my ($key)=@_;
     my ($symb,undef,$user) = split("\0",$key);      my ($symb,undef,$user) = split("\0",$key);
Line 929  sub get_from_queue { Line 985  sub get_from_queue {
     return $todo;      return $todo;
 }  }
   
   sub select_user {
       my ($symb,$cid)=&Apache::lonxml::whichuser();
       my $result.='<table border="1">';
   
       &Apache::grades::init_perm();
       my ($classlist,$section,$fullname)=&Apache::grades::getclasslist('all',);
       &Apache::grades::reset_perm();
   
       foreach my $student (sort {lc($$fullname{$a}) cmp lc($$fullname{$b}) } keys %$fullname) {
    my ($uname,$udom) = split(/:/,$student);
    my %status = &get_student_status($symb,$cid,$udom,$uname);
    my $queue = 'none';
    if ($status{'reviewqueue'} eq 'enqueued') {
       $queue = 'reviewqueue';
    } elsif ($status{'gradingqueue'} eq 'enqueued') {
       $queue = 'gradingqueue';
    }
    my $todo = 
       &Apache::lonnet::escape(&encode_queue_key($symb,$udom,$uname));
    $result.=<<RESULT;
   <tr>
     <td>
       <form method="POST">
         <input type="hidden" name="gradingkey" value="$todo" />
         <input type="hidden" name="queue" value="$queue" />
         <input type="hidden" name="webgrade" value="no" />
        <input type="submit" name="submit" value="Regrade" />
       </form>
     <td>$fullname->{$student}</td>
     <td>
   RESULT
   
           if ($status{'status'} eq 'pass') {
       $result .= '<font color="green">'.&mt('Passed').'</font>';
    } elsif ($status{'status'} eq 'fail') {
       $result .= '<font color="red">'.&mt('Failed').'</font>';
    } elsif ($status{'status'} eq 'review') {
       $result .= '<font color="blue">'.&mt('Under Review').'</font>';
    } elsif ($status{'status'} eq 'ungraded') {
       $result .= &mt('Ungraded');
    } elsif ($status{'status'} ne '') {
       $result .= '<font color="orange">'.&mt('Unknown Status').'</font>';
    } else {
       $result.="&nbsp;";
    }
    if ($status{'version'}) {
       $result .= ' '.&mt('Version').' '.$status{'version'};
    }
    $result.= '</td><td>';
    if ($status{'reviewqueue'} eq 'enqueued') {
       $result .= &mt('Awaiting Review');
    } elsif ($status{'reviewqueue'} eq 'locked') {
       $result .= &mt('Under Review');
    } elsif ($status{'gradingqueue'} eq 'enqueued') {
       $result .= &mt('Awaiting Grading');
    } elsif ($status{'gradingqueue'} eq 'locked') {
       $result .= &mt('Being Graded');
    } else {
       $result.="&nbsp;";
    }
    $result.= '</td></tr>';
       }
       $result.='</table>';
       return $result;
   }
   
   sub get_student_status {
       my ($symb,$cid,$udom,$uname)=@_;
       my %record = &Apache::lonnet::restore($symb,$env{'request.course.id'},
     $udom,$uname);
       my %status;
       $status{'status'}=$record{'resource.status'};
       $status{'version'}=$record{'resource.version'};
       $status{'grader'}=$record{'resource.grader'};
       $status{'reviewqueue'}=&check_queue_for_key($cid,'reviewqueue',
          &encode_queue_key($symb,$udom,$uname));
       $status{'gradingqueue'}=&check_queue_for_key($cid,'gradingqueue',
          &encode_queue_key($symb,$udom,$uname));
       return %status;
   }
   
 sub start_ClosingParagraph {  sub start_ClosingParagraph {
     my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;      my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;
     my $result;      my $result;
Line 1002  sub get_instance { Line 1139  sub get_instance {
     } elsif ($status eq 'pass') {      } elsif ($status eq 'pass') {
  $result.='<font color="green">'.&mt('Passed').'</font>';   $result.='<font color="green">'.&mt('Passed').'</font>';
     } else {      } else {
  &Apache::lonxml::error("Student viewing a graded bridgetask was show a status of $status");   &Apache::lonxml::error("Student viewing a graded bridgetask was shown a status of $status");
     }      }
     $result.='</td></tr><tr><td>';      $result.='</td></tr><tr><td>';
     if ($Apache::lonhomework::history{"resource.$version.$dim.$instance.$id.comment"}) {      if ($Apache::lonhomework::history{"resource.$version.$dim.$instance.$id.comment"}) {

Removed from v.1.48  
changed lines
  Added in v.1.49


FreeBSD-CVSweb <freebsd-cvsweb@FreeBSD.org>