--- loncom/homework/caparesponse/caparesponse.c	2004/12/23 18:32:50	1.15
+++ loncom/homework/caparesponse/caparesponse.c	2024/04/29 03:06:39	1.25
@@ -1,6 +1,6 @@
 /* The LearningOnline Network with CAPA 
  * CAPA wrapper code
- * $Id: caparesponse.c,v 1.15 2004/12/23 18:32:50 albertel Exp $
+ * $Id: caparesponse.c,v 1.25 2024/04/29 03:06:39 raeburn Exp $
  *
  * Copyright Michigan State University Board of Trustees
  *
@@ -27,6 +27,7 @@
 
 #include <capaCommon.h>
 #include <ranlib.h>
+#include <ctype.h> /* isdigit() */
 
 PointsList_t * parse_pts_list (char *pts_list) {
   PointsList_t *new=NULL, *end=NULL, *beforeend=NULL, *rlist=NULL;
@@ -34,7 +35,7 @@ PointsList_t * parse_pts_list (char *pts
   int done=0;
   /*fprintf(stderr,"ids %s\n",id_list);
     fprintf(stderr,"pts %s\n",pts_list);*/
-  while (!done) {
+  while (!done && pts_list) {
     int idx;
     /*fprintf(stderr,"pts; %s\n",idx_pts);*/
     new=gen_ptslist_str(idx_pts);
@@ -97,6 +98,9 @@ int caparesponse_capa_check_answer(char
   if (type == ANSWER_IS_FORMULA) {
     p.id_list=id_list;
     p.pts_list=parse_pts_list(pts_list);
+//  if ( p.id_list == NULL || p.pts_list == NULL) {
+//    return BAD_FORMULA;
+//  }
   }
   p.ans_type   = type;
   p.answer     = correct;
@@ -110,7 +114,10 @@ int caparesponse_capa_check_answer(char
   }
   if (unit_str != NULL && unit_str[0]!='\0') {
     strncpy(p.unit_str,unit_str,ANSWER_STRING_LENG-1);
-    p.ans_unit   = u_parse_unit(unit_str);
+    //p.ans_unit = u_parse_unit(unit_str);
+    p.ans_unit   = parse_unit_expr(unit_str);
+    p.ans_unit   = process_utree(p.ans_unit);
+    //print_unit_t(p.ans_unit);
   } else {
     p.unit_str[0]='\0';
     p.ans_unit=NULL;
@@ -128,12 +135,15 @@ int caparesponse_capa_check_answer(char
 int caparesponse_get_real_response (char* unit_str, char* answer,
 				    double* scaled) {
   //double caparesponse_get_real_response (char* unit_str, char* answer) {
-  int     input_len,all_alphabet,idx,outcome,result;
-  double  n_part,scale=1.0,given,target;
+  int     input_len,all_alphabet,idx,outcome=-1;
+  #pragma GCC diagnostic push
+  #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
+  int result;
+  #pragma GCC diagnostic pop
+  double  n_part,scale=1.0,given;
   char    input[ANSWER_STRING_LENG],filename[FILE_NAME_LENGTH],
     tmp_unit_str[ANSWER_STRING_LENG];
   Unit_t *ans_unit;
-  long    seed1,seed2;
   FILE   *fp;
   sprintf(filename,"/home/httpd/html/res/adm/includes/capa.units");
   if ((fp=fopen(filename,"r"))==NULL) {
@@ -144,7 +154,8 @@ int caparesponse_get_real_response (char
   fclose(fp);
 
   if (unit_str != NULL && unit_str[0]!='\0') {
-    ans_unit   = u_parse_unit(unit_str);
+    ans_unit   = parse_unit_expr(unit_str);
+    ans_unit   = process_utree(ans_unit);
   } else {
     ans_unit=NULL;
   }
@@ -156,7 +167,10 @@ int caparesponse_get_real_response (char
     }
   }
   if( !all_alphabet ) {
+    tmp_unit_str[0] = 0;
     outcome = split_num_unit(answer,&n_part,input,tmp_unit_str);
+  }
+  if( outcome > 0 ) {
     if( outcome > 1 ) { /* with both num and unit parts or only unit part */
       if( ans_unit != NULL ) {
 	result = check_correct_unit(tmp_unit_str,ans_unit,&scale);
@@ -169,14 +183,32 @@ int caparesponse_get_real_response (char
 	result = NO_UNIT;
       }
     }
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
     if( (result != NO_UNIT) && (!check_for_unit_fail(result)) && ( result != UNIT_NOTNEEDED) ) {
       given = n_part * scale;
       *scaled=given;
       /* convert the given answer into proper scale for units */
     } /* end if unit check */
-  } else { /* user entered a
-lphabet, but no number */
+  } else { /* user entered alphabet, but no number */
     result = WANTED_NUMERIC;
-  } 
+  }
+#pragma GCC diagnostic pop
   return result;
 }
+
+/* Testing harness
+int main(void) {
+  int result=0;
+  char *reterror=NULL;
+  result= caparesponse_capa_check_answer("10^3","1000",
+					 ANSWER_IS_FORMULA,
+					 TOL_ABSOLUTE,1E-3,
+					 3,5,NULL,NULL,
+					 CALC_UNFORMATED,
+					 "","4",
+					 "rndseed",
+					 &reterror);
+  fprintf(stderr,"result %d\nreterror: %s\n",result,reterror);
+}
+*/