--- loncom/homework/default_homework.lcpm 2014/06/25 10:48:39 1.167 +++ loncom/homework/default_homework.lcpm 2019/04/03 21:37:11 1.176 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # used by lonxml::xmlparse() as input variable $safeinit to Apache::run::run() # -# $Id: default_homework.lcpm,v 1.167 2014/06/25 10:48:39 raeburn Exp $ +# $Id: default_homework.lcpm,v 1.176 2019/04/03 21:37:11 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -309,10 +309,13 @@ sub caparesponse_check_list { #for numerical problems split off the unit my $part1; my $part2; + my $match_algebra = qr{^(.*[^\s])\s+([^\s]+)$}; + # FIXME: with the above regexp, algebra with spaces will not be evaluated correctly + my $match_numerical_units = qr{^([\d\.\,\s\$]*(?:(?:[xX\*]10[\^\*]*|[eE]*)[\+\-]*\d*)*(?:^|\S)\d+)([\$\s\w\^\*\/\(\)\+\-]*[^\d\.\s\,][\$\s\w\^\*\/\(\)\+\-]*)$}; if ($allowalgebra) { - ($part1,$part2)=($responses->[0][-1]=~ /^(.*[^\s])\s+([^\s]+)$/); + ($part1,$part2) = ($responses->[0][-1] =~ /$match_algebra/); } else { - ($part1,$part2)=($responses->[0][-1]=~ /^([\d\.\,\s\$]*(?:(?:[xX\*]10[\^\*]*|[eE]*)[\+\-]*\d*)*(?:^|\S)\d+)([\$\s\w\^\*\/\(\)\+\-]*[^\d\.\s\,][\$\s\w\^\*\/\(\)\+\-]*)$/); + ($part1,$part2) = ($responses->[0][-1] =~ /$match_numerical_units/); } if (defined($part1) && defined($part2)) { $responses->[0][-1]=$part1; @@ -327,6 +330,27 @@ sub caparesponse_check_list { } } } + if (scalar(@$responses) > 0 && defined $answerunit) { + # there are several response values, units should be the same for all + $part2 =~ s/^\s+|\s+$//g; + for (my $i=1; $i[$i][-1]; + my ($part1i, $part2i); + if ($allowalgebra) { + ($part1i, $part2i) = ($element =~ /$match_algebra/); + } else { + ($part1i, $part2i) = ($element =~ /$match_numerical_units/); + } + $part2i =~ s/^\s+|\s+$//g; + if (!defined $part2i) { + return 'NO_UNIT'; + } elsif ($part2i ne $part2) { + return ('UNIT_FAIL', "$part2 $part2i"); + } else { + $responses->[$i][-1] = $part1i; + } + } + } } } $unit=~s/\s//; @@ -632,16 +656,29 @@ sub hinton { sub random { my ($start,$end,$step)=@_; if ( ! $hidden::RANDOMINIT ) { - if ($external::randomseed == 0) { $external::randomseed=1; } - if ($external::randomseed =~/,/) { - my ($num1,$num2)=split(/,/,$external::randomseed); - &random_set_seed(1,abs($num1)); - } elsif ($external::randomseed =~/:/) { - my ($num1,$num2)=split(/:/,$external::randomseed); - &random_set_seed(abs($num1),abs($num2)); - } else { - &random_set_seed(1,int(abs($external::randomseed))); - } + if ($external::randomseed == 0) { $external::randomseed=1; } + if ($external::randomseed =~/,/) { + my ($num1,$num2) = map { abs($_); } split(/,/,$external::randomseed); + if ((!$num1) || ($num1 > 2147483398)) { + &random_set_seed_from_phrase($external::randomseed); + } else { + &random_set_seed(1,$num1); + } + } elsif ($external::randomseed =~/:/) { + my ($num1,$num2) = map { abs($_); } split(/:/,$external::randomseed); + if ((!$num1) || (!$num2) || ($num1 > 2147483562) || ($num2 > 2147483398)) { + &random_set_seed_from_phrase($external::randomseed); + } else { + &random_set_seed($num1,$num2); + } + } else { + my $num1 = int(abs($external::randomseed)); + if ((!$num1) || ($num1 > 2147483398)) { + &random_set_seed_from_phrase($external::randomseed); + } else { + &random_set_seed(1,$num1); + } + } &math_random_uniform(); $hidden::RANDOMINIT=1; } @@ -902,11 +939,19 @@ sub chemparse { my $formula = ''; foreach my $token (@tokens) { if ($token eq '->' ) { - $formula .= '\ensuremath{\rightarrow} '; + if ($external::target eq 'web') { + $formula .= '→ '; + } else { + $formula .= '\ensuremath{\rightarrow} '; + } next; } if ($token eq '<-' ) { - $formula .= '\ensuremath{\leftarrow} '; + if ($external::target eq 'web') { + $formula .= '← '; + } else { + $formula .= '\ensuremath{\leftarrow} '; + } next; } if ($token eq '<=>') { @@ -944,6 +989,18 @@ sub chemparse { return &xmlparse($formula); } +sub conv_eng_format { + my ($ans,$baseunit)=@_; + my ($value,$answer,$unit); + $baseunit =~ s{[^\w/\-\.]}{}g; + eval { + $value = &number_format_pref($ans); + }; + my ($answer,$prefix) = ($value=~ /^(.+)(\w)$/); + my $unit = $prefix.$baseunit; + return($answer,$unit); +} + sub prettyprint { my ($value,$fmt,$target)=@_; my $result; @@ -1228,18 +1285,78 @@ sub sec { } sub submission { - my ($partid,$responseid,$subnumber,$encode)=@_; + my ($partid,$responseid,$subnumber,$encode,$cleanupnum,$mapalias)=@_; my $sub=''; if ($subnumber) { $sub=$subnumber.':'; } my $output = - &EXT('user.resource.'.$sub.'resource.'.$partid.'.'.$responseid.'.submission'); - if ($encode) { - $output =~ s/&/&/g; - $output =~ s//>/g; - $output =~ s/"/"/g; + &EXT('user.resource.'.$sub.'resource.'.$partid.'.'.$responseid.'.submission',$mapalias); + if (ref($output) eq 'ARRAY') { + my @items = @{$output}; + if ($encode) { + @items = map { &encode_response($_); } @items; + } + if (ref($cleanupnum) eq 'HASH') { + @items = map { &cleanup_numerical_response($cleanupnum,$_); } @items; + } + return \@items; + } else { + if ($encode) { + $output = &encode_response($output); + } + if (ref($cleanupnum) eq 'HASH') { + $output = &cleanup_numerical_response($cleanupnum,$output); + } + return $output; } - return $output; +} + +sub encode_response { + my ($value) = @_; + $value =~ s/&/&/g; + $value =~ s//>/g; + $value =~ s/"/"/g; + return $value; +} + +sub cleanup_numerical_response { + my ($cleanupnum,$value) = @_; + if (ref($cleanupnum) eq 'HASH') { + if ($cleanupnum->{exponent}) { + if ($value =~ m{^(.*)[\*xX]\s*10\s*\^\s*(\+|\-)?\s*(\d+)(.*)$}) { + my $pre_exp = $1; + my $sign = $2; + my $exponent = $3; + my $post_exp = $4; + if ($pre_exp !~ /\./) { + $pre_exp .= '.'; + } + if ($sign eq '') { + $sign = '+'; + } + $value = $pre_exp.'E'.$sign.$exponent.$post_exp; + } + } + if ($cleanupnum->{comma}) { + $value =~ s{(\d+),(\d+)}{$1$2}; + } + if ($cleanupnum->{letterforzero}) { + $value =~ s/^\s*o(\.\d+)/0$1/i; + } + if ($cleanupnum->{spaces}) { + $value =~ s{^\s+|\s+$}{}g; + if ($value =~ m{^(.*)\.\s+(\d+)(.*)$}) { + my $pre_pt = $1; + my $decimal = $2; + my $post_dec = $3; + $value = $pre_pt.'.'.$decimal.$post_dec; + } + } + if ($cleanupnum->{format} =~ /^\d+s$/i) { + $value = &format_significant_figures($value,$cleanupnum->{format}); + } + } + return $value; } sub currentpart { @@ -1398,3 +1515,8 @@ sub proper_path { } } +sub input_id { + my ($part_id, $response_id, $textline_id) = @_; + return 'HWVAL_'.$part_id.'_'.$response_id.'_'.$textline_id; +} +