--- loncom/homework/essayresponse.pm 2002/07/24 16:58:08 1.10 +++ loncom/homework/essayresponse.pm 2002/08/01 15:20:34 1.13 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # essay (ungraded) style responses # -# $Id: essayresponse.pm,v 1.10 2002/07/24 16:58:08 ng Exp $ +# $Id: essayresponse.pm,v 1.13 2002/08/01 15:20:34 ng Exp $ # # Copyright Michigan State University Board of Trustees # @@ -45,48 +45,56 @@ sub start_essayresponse { my $ncol= &Apache::lonnet::EXT("resource.$part".'_'."$id.maxcollaborators"); my $coll= &HTML::Entities::encode($Apache::lonhomework::history{"resource.$part.$id.collaborators"}); + $result='
'; if ($ncol > 0) { - $result .='
Collaborators:
'. + $result .=''; } + $result.='
'. + 'Collaborators:
'. '(Enter maximum '.$ncol.' collaborators using username or username@domain, e.g. '. 'smithje or smithje@'.$ENV{'user.domain'}.'.)
'; $result .= &check_collaborators($ncol,$coll) if ($coll =~ /\w+/); + $result .='
'. + ''. + ' Submit text below as answer to receive credit
'. + ''. + ' Save text below as a draft answer (not submitting it for credit yet) '. + '
'; } return $result; } sub end_essayresponse { my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_; - my $part=$Apache::inputtags::part; - my $id = &Apache::response::start_response($parstack,$safeeval); + my $part = $Apache::inputtags::part; + my $id = &Apache::response::start_response($parstack,$safeeval); + my $collaborators = $ENV{'form.HWCOL'.$part.'_'.$id}; + if ($collaborators =~ /[^\s]/) { + my $previous_list= &HTML::Entities::encode($Apache::lonhomework::history{"resource.$part.$id.collaborators"}); + + $Apache::lonhomework::results{"resource.$part.$id.collaborators"}=$collaborators + if ($collaborators ne $previous_list); + } if ( $target eq 'grade' ) { if ( defined $ENV{'form.submitted'}) { my $response = $ENV{'form.HWVAL'.$id}; if ( $response =~ /[^\s]/) { $Apache::lonhomework::results{"resource.$part.$id.submission"}=$response; - $Apache::lonhomework::results{"resource.$part.$id.awarddetail"}="SUBMITTED"; + $Apache::lonhomework::results{"resource.$part.$id.awarddetail"}= + $ENV{'form.HWDRAFT'.$part.'_'.$id} eq 'yes' ? 'SUBMITTED' : 'DRAFT'; my %previous=&Apache::response::check_for_previous($response,$part,$id); &Apache::response::handle_previous(\%previous,'SUBMITTED'); } } } - my $collaborators = $ENV{'form.HWCOL'.$id}; - if ($collaborators =~ /[^\s]/) { - my $ncol= &Apache::lonnet::EXT("resource.$part".'_'."$id.maxcollaborators"); - my ($badlist,$toomany) = &check_collaborators($ncol,$collaborators,'yes'); - $Apache::lonhomework::results{"resource.$part.$id.collaborators"}=$collaborators; - $Apache::lonhomework::results{"resource.$part.$id.badcollaborators"}=(join(', ',@$badlist)) - if (scalar(@$badlist) > 0); - $Apache::lonhomework::results{"resource.$part.$id.toomanycollaborators"}=$$toomany - if ($toomany > 0); - } + &Apache::response::end_response; return ''; } sub check_collaborators { - my ($ncol,$coll,$retbad) = @_; + my ($ncol,$coll) = @_; my %classlist=&Apache::lonnet::dump('classlist', $ENV{'course.'.$ENV{'request.course.id'}.'.domain'}, $ENV{'course.'.$ENV{'request.course.id'}.'.num'}); @@ -103,10 +111,9 @@ sub check_collaborators { } if (scalar(@badcollaborators)) { - my $badlist = sprintf ("The following user%s invalid: ", - (scalar(@badcollaborators) > 1 ? 's are' : ' is')); - $result .= '
'. - $badlist.join(', ',@badcollaborators).'. Please correct.
'; + $result = '
The following user'. + (scalar(@badcollaborators) > 1 ? 's are' : ' is').' invalid: '. + join(', ',@badcollaborators).'. Please correct.
'; } my $toomany = scalar(@collaborators) - $ncol; if ($toomany > 0) { @@ -114,7 +121,6 @@ sub check_collaborators { 'You have too many collaborators. Please remove '.$toomany.' collaborator'. ($toomany > 1 ? 's' :'').'.'; } - return (\@badcollaborators,\$toomany) if ($retbad eq 'yes'); return $result; }