--- loncom/homework/functionplotresponse.pm	2010/10/09 22:31:49	1.12
+++ loncom/homework/functionplotresponse.pm	2010/10/10 00:14:15	1.13
@@ -1,7 +1,7 @@
 # LearningOnline Network with CAPA
 # option list style responses
 #
-# $Id: functionplotresponse.pm,v 1.12 2010/10/09 22:31:49 www Exp $
+# $Id: functionplotresponse.pm,v 1.13 2010/10/10 00:14:15 www Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -276,12 +276,28 @@ sub start_backgroundplot {
    unless ($function) { $function="0"; }
    if ($target eq 'web') {
       $result.=&plot_script($internalid,$function,$fixed);
-   }
-   return $result;
+   } elsif ($target eq 'edit') {
+        $result=&Apache::edit::tag_start($target,$token,'Background Function Plot').
+             &Apache::edit::text_arg('Function:','function',
+                                     $token,'16').
+             &Apache::edit::select_arg('Fixed location:','fixed',
+                                  ['yes','no'],$token).
+             &Apache::edit::end_row();
+  } elsif ($target eq 'modified') {
+    my $constructtag=&Apache::edit::get_new_args($token,$parstack,
+                                                 $safeeval,'function','fixed');
+    if ($constructtag) { $result=&Apache::edit::rebuild_tag($token); }
+  }
+  return $result;
 }
 
 sub end_backgroundplot {
-   return '';
+   my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
+   my $result='';
+   if ($target eq 'edit') {
+       $result=&Apache::edit::end_table();
+   }
+   return $result;
 }
 
 #
@@ -291,11 +307,20 @@ sub start_splinerule {
    my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
    my $result='';
    my $internalid = $Apache::inputtags::part.'_'.$Apache::inputtags::response[-1];
+   if ($target eq 'edit') {
+        $result=&Apache::edit::tag_start($target,$token,'Spline Evaluation Rule').
+                &Apache::edit::end_row();
+   }
    return $result;
 }
 
 sub end_splinerule {
-   return '';
+   my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
+   my $result='';
+   if ($target eq 'edit') {
+       $result=&Apache::edit::end_table();
+   }
+   return $result;
 }
 
 
@@ -306,36 +331,70 @@ sub end_splinerule {
 #
 sub start_spline {
    my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
-   my $label=&Apache::lonxml::get_param('label',$parstack,$safeeval);
-   $Apache::functionplotresponse::counter++;
-   $label=~s/\W//gs;
-   unless ($label) { $label='S'.$Apache::functionplotresponse::counter; }
-
-   my $order=&Apache::lonxml::get_param('order',$parstack,$safeeval);
-   if ($order<2) { $order=2; }
-   if ($order>8) { $order=8; }
-   $Apache::functionplotresponse::splineorder{$label}=$order;
-
-   my $x=&Apache::lonxml::get_param('initx',$parstack,$safeeval);
-   unless ($x) { $x=0; }
-   $Apache::functionplotresponse::splineinitx{$label}=$x;
-
-   my $y=&Apache::lonxml::get_param('inity',$parstack,$safeeval);
-   unless ($y) { $y=0; }
-   $Apache::functionplotresponse::splineinity{$label}=$y;
-
-   my $sx=&Apache::lonxml::get_param('scalex',$parstack,$safeeval);
-   unless ($sx) { $sx=$order; }
-   $Apache::functionplotresponse::splinescalex{$label}=$sx;
-
-   my $sy=&Apache::lonxml::get_param('scaley',$parstack,$safeeval);
-   unless ($sy) { $sy=2; }
-   $Apache::functionplotresponse::splinescaley{$label}=$sy;
-   return '';
+   my $result='';
+   if ($target eq 'web') {
+      my $label=&Apache::lonxml::get_param('label',$parstack,$safeeval);
+      $Apache::functionplotresponse::counter++;
+      if ($label=~/\W/) {
+         &Apache::lonxml::warning(&mt('Spline labels should only contain alphanumeric characters.'));
+      }
+      $label=~s/\W//gs;
+      unless ($label) { $label='S'.$Apache::functionplotresponse::counter; }
+      if ($Apache::functionplotresponse::splineorder{$label}) {
+         &Apache::lonxml::error(&mt('Spline labels must be unique.'));
+      }
+
+      my $order=&Apache::lonxml::get_param('order',$parstack,$safeeval);
+      if ($order<2) { $order=2; }
+      if ($order>8) { $order=8; }
+      $Apache::functionplotresponse::splineorder{$label}=$order;
+
+      my $x=&Apache::lonxml::get_param('initx',$parstack,$safeeval);
+      unless ($x) { $x=0; }
+      $Apache::functionplotresponse::splineinitx{$label}=$x;
+
+      my $y=&Apache::lonxml::get_param('inity',$parstack,$safeeval);
+      unless ($y) { $y=0; }
+      $Apache::functionplotresponse::splineinity{$label}=$y;
+
+      my $sx=&Apache::lonxml::get_param('scalex',$parstack,$safeeval);
+      unless ($sx) { $sx=$order; }
+      $Apache::functionplotresponse::splinescalex{$label}=$sx;
+
+      my $sy=&Apache::lonxml::get_param('scaley',$parstack,$safeeval);
+      unless ($sy) { $sy=2; }
+      $Apache::functionplotresponse::splinescaley{$label}=$sy;
+   } elsif ($target eq 'edit') {
+        $result=&Apache::edit::tag_start($target,$token,'Spline').
+             &Apache::edit::text_arg('Label:','label',
+                                     $token,'4').
+             &Apache::edit::select_arg('Order:','order',
+                                  ['2','3','4','5','6','7','8','9'],$token).
+             &Apache::edit::text_arg('Initial x-value:','initx',
+                                     $token,'4').
+             &Apache::edit::text_arg('Initial y-value:','inity',
+                                     $token,'4').
+             &Apache::edit::text_arg('Scale x:','scalex',
+                                     $token,'4').
+             &Apache::edit::text_arg('Scale y:','scaley',
+                                     $token,'4').
+             &Apache::edit::end_row();
+  } elsif ($target eq 'modified') {
+    my $constructtag=&Apache::edit::get_new_args($token,$parstack,
+                                                 $safeeval,'label','order','initx','inity',
+                                                           'scalex','scaley');
+    if ($constructtag) { $result=&Apache::edit::rebuild_tag($token); }
+  }
+  return $result;
 }
 
 sub end_spline {
-   return '';
+   my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
+   my $result='';
+   if ($target eq 'edit') {
+       $result=&Apache::edit::end_table();
+   }
+   return $result;
 }
  
 sub end_init_script {