--- loncom/homework/functionplotresponse.pm 2010/10/19 02:04:27 1.15 +++ loncom/homework/functionplotresponse.pm 2010/11/12 22:23:40 1.36 @@ -1,7 +1,7 @@ # LearningOnline Network with CAPA # option list style responses # -# $Id: functionplotresponse.pm,v 1.15 2010/10/19 02:04:27 www Exp $ +# $Id: functionplotresponse.pm,v 1.36 2010/11/12 22:23:40 www Exp $ # # Copyright Michigan State University Board of Trustees # @@ -31,9 +31,9 @@ use strict; use Apache::response(); use Apache::lonlocal; use Apache::lonnet; - + BEGIN { - &Apache::lonxml::register('Apache::functionplotresponse',('functionplotresponse','backgroundplot','spline','splinerule')); + &Apache::lonxml::register('Apache::functionplotresponse',('functionplotresponse','backgroundplot','spline','functionplotrule')); } # @@ -101,12 +101,25 @@ ENDDEFAULTPARAMETERS # sub init_script { - if ($Apache::functionplotresponse::callscripts) { + if ($#Apache::functionplotresponse::callscripts>=0) { + my $script=''; + foreach my $id (@Apache::functionplotresponse::callscripts) { + $script.="if (param=='applet_$id') { loaded_$id=true; }\n"; + } + $script.="if (".join(' && ',map { "loaded_$_" } (@Apache::functionplotresponse::callscripts)). + ") { setTimeout('ggbInitAll()',20) }"; + my $calls=join("\n",map { "ggbInit_$_();" } (@Apache::functionplotresponse::callscripts)); return (< // @@ -194,14 +207,16 @@ sub new_coordinate { # sub start_init_script { my ($id)=@_; -# Add a line to ggbOnInit-function which calls the right function based on parameter passed from GeoGebra - $Apache::functionplotresponse::callscripts.="if (param=='applet_$id') { ggbInit_$id(); }\n"; +# Add id to the list of ggbInit_$id functions that need to be called + push(@Apache::functionplotresponse::callscripts,$id); # ... and open this function return (< // +# # -sub start_splinerule { +sub start_functionplotrule { my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_; my $result=''; - my $internalid = $Apache::inputtags::part.'_'.$Apache::inputtags::response[-1]; - if ($target eq 'edit') { - $result=&Apache::edit::tag_start($target,$token,'Spline Evaluation Rule'). - &Apache::edit::end_row(); + my $label=&Apache::lonxml::get_param('index',$parstack,$safeeval); + $Apache::functionplotresponse::counter++; + if ($label=~/\W/) { + &Apache::lonxml::warning(&mt('Rule indices should only contain alphanumeric characters.')); + } + $label=~s/\W//gs; + unless ($label) { + $label='R'.$Apache::functionplotresponse::counter; + } else { + $label='R'.$label; + } + if ($Apache::functionplotresponse::splineorder{$label}) { + &Apache::lonxml::error(&mt('Rule indices must be unique.')); + } + + + if ($target eq 'grade') { +# Simply remember - in order - for later + my $beginninglabel=&Apache::lonxml::get_param('xinitiallabel',$parstack,$safeeval); + my $endinglabel=&Apache::lonxml::get_param('xfinallabel',$parstack,$safeeval); + if (($beginninglabel=~/\W/) || ($endinglabel=~/W/)) { + &Apache::lonxml::warning(&mt('Rule labels must be alphanumeric.')); + } + $beginninglabel=~s/\W//gs; + $endinglabel=~s/\W//gs; + my $relationship=&Apache::lonxml::get_param('relationship',$parstack,$safeeval); + $relationship=~s/\W//gs; + $relationship=lc($relationship); + unless ($relationship=~/^(eq|ge|gt|le|lt|ne)$/) { + &Apache::lonxml::warning(&mt('Rule relationship not defined.')); + $relationship='eq'; + } + my $derivative=&Apache::lonxml::get_param('derivativeorder',$parstack,$safeeval); + unless (($derivative==0) || ($derivative==1) || ($derivative==2)) { + &Apache::lonxml::warning(&mt('Rule derivative not defined.')); + $derivative=0; + } + push(@Apache::functionplotresponse::functionplotrules,join(':',( + $label, + $derivative, + &Apache::lonxml::get_param('xinitial',$parstack,$safeeval), + $beginninglabel, + &Apache::lonxml::get_param('xfinal',$parstack,$safeeval), + $endinglabel, + &Apache::lonxml::get_param('minimumlength',$parstack,$safeeval), + &Apache::lonxml::get_param('maximumlength',$parstack,$safeeval), + $relationship, + &Apache::lonxml::get_param('value',$parstack,$safeeval), + &Apache::lonxml::get_param('percenterror',$parstack,$safeeval) + ))); + } elsif ($target eq 'edit') { + $result=&Apache::edit::tag_start($target,$token,'Function Plot Evaluation Rule'). + &Apache::edit::text_arg('Index/Name:','index', + $token,'10').' '. + &Apache::edit::select_arg(&mt('Function:'),'derivativeorder', + [['0','Function itself'], + ['1','First derivative'], + ['2','Second derivative']],$token).'
'. + &Apache::edit::text_arg('(Initial) x-value:','xinitial', + $token,'8'). + &Apache::edit::select_or_text_arg('(Initial) x-value label:','xinitiallabel', + [['start','Start of Plot']],$token,'8').'
'. + + &Apache::edit::text_arg('Optional final x-value for ranges:','xfinal', + $token,'8'). + &Apache::edit::select_or_text_arg('Optional final x-value label:','xfinallabel', + [['end','End of Plot']],$token,'8').'
'. + &Apache::edit::text_arg('Optional minimum length for range:','minimumlength', + $token,'8'). + &Apache::edit::text_arg('Optional maximum length for range:','maximumlength', + $token,'8').'
'. + &Apache::edit::select_arg(&mt('Relationship:'),'relationship', + [['eq','equal'], + ['ne','not equal'], + ['ge','greater than or equal'], + ['gt','greater than'], + ['lt','less than'], + ['le','less than or equal']],$token). + $result.= &Apache::edit::select_or_text_arg('Value:','value', + [['undef','not defined']],$token,'8'). + &Apache::edit::text_arg('Percent error:','percenterror', + $token,'8'). + &Apache::edit::end_row(); + } elsif ($target eq 'modified') { + my $constructtag=&Apache::edit::get_new_args($token,$parstack, + $safeeval,'index','derivativeorder', + 'xinitial','xinitiallabel','xfinal','xfinallabel', + 'minimumlength','maximumlength', + 'relationship','value','percenterror'); + if ($constructtag) { $result=&Apache::edit::rebuild_tag($token); } } return $result; } -sub end_splinerule { +sub end_functionplotrule { my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_; my $result=''; if ($target eq 'edit') { @@ -348,7 +449,7 @@ sub end_splinerule { # -# +# # # Unfortunately, GeoGebra seems to want all splines after everything else, so we need to store them # @@ -356,15 +457,19 @@ sub start_spline { my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_; my $result=''; if ($target eq 'web') { - my $label=&Apache::lonxml::get_param('label',$parstack,$safeeval); + my $label=&Apache::lonxml::get_param('index',$parstack,$safeeval); $Apache::functionplotresponse::counter++; if ($label=~/\W/) { - &Apache::lonxml::warning(&mt('Spline labels should only contain alphanumeric characters.')); + &Apache::lonxml::warning(&mt('Spline indices should only contain alphanumeric characters.')); } $label=~s/\W//gs; - unless ($label) { $label='S'.$Apache::functionplotresponse::counter; } + unless ($label) { + $label='S'.$Apache::functionplotresponse::counter; + } else { + $label='S'.$label; + } if ($Apache::functionplotresponse::splineorder{$label}) { - &Apache::lonxml::error(&mt('Spline labels must be unique.')); + &Apache::lonxml::error(&mt('Spline indices must be unique.')); } my $order=&Apache::lonxml::get_param('order',$parstack,$safeeval); @@ -389,7 +494,7 @@ sub start_spline { $Apache::functionplotresponse::splinescaley{$label}=$sy; } elsif ($target eq 'edit') { $result=&Apache::edit::tag_start($target,$token,'Spline'). - &Apache::edit::text_arg('Label:','label', + &Apache::edit::text_arg('Index:','index', $token,'4').' '. &Apache::edit::select_arg('Order:','order', ['2','3','4','5','6','7','8','9'],$token).' '. @@ -404,7 +509,7 @@ sub start_spline { &Apache::edit::end_row(); } elsif ($target eq 'modified') { my $constructtag=&Apache::edit::get_new_args($token,$parstack, - $safeeval,'label','order','initx','inity', + $safeeval,'index','order','initx','inity', 'scalex','scaley'); if ($constructtag) { $result=&Apache::edit::rebuild_tag($token); } } @@ -484,6 +589,77 @@ sub d2dt2_cubic_hermite { } # +# Array index calculation +# +sub array_index { + my ($xmin,$xmax,$x)=@_; + return int(($x-$xmin)/($xmax-$xmin)*400.+0.5); +} + +# +# Populate the arrays +# + +sub populate_arrays { + my ($id,$xmin,$xmax)=@_; + for (my $i=0; $i<=400; $i++) { + $Apache::functionplotresponse::actualxval[$i]=undef; + $Apache::functionplotresponse::func[$i]=undef; + $Apache::functionplotresponse::dfuncdx[$i]=undef; + $Apache::functionplotresponse::d2funcd2x[$i]=undef; + } + unless ($xmax>$xmin) { return 'no_func'; } +# Run over all splines in response + foreach my $label (split(/\,/,$env{"form.HWVAL_AllSplines_$id"})) { + my $xiold=-1; +# Run over all points in spline + for (my $i=1; $i<$env{"form.HWVAL_SplineOrder_".$id."_".$label}; $i++) { + my $ni=$i+1; + my @xparms=($env{'form.HWVAL_'.$id.'_'.$label.'P'.$i.'_x'}, + $env{'form.HWVAL_'.$id.'_'.$label.'S'.$i.'_x'}, + $env{'form.HWVAL_'.$id.'_'.$label.'P'.$ni.'_x'}, + $env{'form.HWVAL_'.$id.'_'.$label.'S'.$ni.'_x'}); + my @yparms=($env{'form.HWVAL_'.$id.'_'.$label.'P'.$i.'_y'}, + $env{'form.HWVAL_'.$id.'_'.$label.'S'.$i.'_y'}, + $env{'form.HWVAL_'.$id.'_'.$label.'P'.$ni.'_y'}, + $env{'form.HWVAL_'.$id.'_'.$label.'S'.$ni.'_y'}); +# Run in small steps over spline parameter + for (my $t=0; $t<=1; $t+=0.0001) { + my $xreal=&cubic_hermite($t,@xparms); + my $xi=&array_index($xmin,$xmax,$xreal); + if ($xi<$xiold) { return 'no_func'; } + if (($xi>$xiold) && ($xi>=0) && ($xi<=400)) { + if (defined($Apache::functionplotresponse::func[$xi])) { return 'no_func'; } + $xiold=$xi; + $Apache::functionplotresponse::actualxval[$xi]=$xreal; +# Function value + my $funcval=&cubic_hermite($t,@yparms); + $Apache::functionplotresponse::func[$xi]=$funcval; + if (defined($funcval)) { + if ($xi<$Apache::functionplotresponse::functionplotrulelabels{'start'}) { + $Apache::functionplotresponse::functionplotrulelabels{'start'}=$xi; + } + if ($xi>$Apache::functionplotresponse::functionplotrulelabels{'end'}) { + $Apache::functionplotresponse::functionplotrulelabels{'end'}=$xi; + } + } +# Chain rule +# dy/dx=dy/dt/(dx/dt) + my $dxdt=&ddt_cubic_hermite($t,@xparms); + if ($dxdt) { + $Apache::functionplotresponse::dfuncdx[$xi]=&ddt_cubic_hermite($t,@yparms)/$dxdt; +# Second derivative + $Apache::functionplotresponse::d2funcdx2[$xi]= + ($dxdt*&d2dt2_cubic_hermite($t,@yparms)-&ddt_cubic_hermite($t,@yparms)*&d2dt2_cubic_hermite($t,@xparms))/ + ($dxdt*$dxdt*$dxdt); + } + } + } + } + } +} + +# # Implentation of # @@ -500,6 +676,8 @@ sub start_functionplotresponse { undef %Apache::functionplotresponse::previous; $Apache::functionplotresponse::inputfields=''; $Apache::functionplotresponse::counter=0; +# Remember rules + undef @Apache::functionplotresponse::functionplotrules; # Part and ID my $partid=$Apache::inputtags::part; my $id=&Apache::response::start_response($parstack,$safeeval); @@ -510,13 +688,21 @@ sub start_functionplotresponse { # Parameters of my $xmin=&Apache::lonxml::get_param('xmin',$parstack,$safeeval); - $xmin=($xmin?$xmin:-10); + $xmin=(defined($xmin)?$xmin:-10); my $xmax=&Apache::lonxml::get_param('xmax',$parstack,$safeeval); - $xmax=($xmax?$xmax:10); + $xmax=(defined($xmax)?$xmax:10); my $ymin=&Apache::lonxml::get_param('ymin',$parstack,$safeeval); - $ymin=($ymin?$ymin:-10); + $ymin=(defined($ymin)?$ymin:-10); my $ymax=&Apache::lonxml::get_param('ymax',$parstack,$safeeval); - $ymax=($ymax?$ymax:10); + $ymax=(defined($ymax)?$ymax:10); + if ($xmax<=$xmin) { + &Apache::lonxml::warning('Maximum x-value needs to be larger than minimum value.'); + $xmax=$xmin+20; + } + if ($ymax<=$ymin) { + &Apache::lonxml::warning('Maximum y-value needs to be larger than minimum value.'); + $ymax=$ymin+20; + } my $xaxisvisible=(&Apache::lonxml::get_param('xaxisvisible',$parstack,$safeeval)=~/on|true|yes|1/i?'true':'false'); my $yaxisvisible=(&Apache::lonxml::get_param('yaxisvisible',$parstack,$safeeval)=~/on|true|yes|1/i?'true':'false'); my $gridvisible=(&Apache::lonxml::get_param('gridvisible',$parstack,$safeeval)=~/on|true|yes|1/i?'true':'false'); @@ -539,7 +725,7 @@ sub start_functionplotresponse { &Apache::edit::text_arg('Maximum x-value:','xmax', $token,'4').' '. &Apache::edit::select_arg('x-axis visible:','xaxisvisible', - ['yes','no'],$token).'  '. + ['yes','no'],$token).'
'. &Apache::edit::text_arg('Label y-axis:','ylabel', $token,'6').' '. &Apache::edit::text_arg('Minimum y-value:','ymin', @@ -547,7 +733,7 @@ sub start_functionplotresponse { &Apache::edit::text_arg('Maximum y-value:','ymax', $token,'4').' '. &Apache::edit::select_arg('y-axis visible:','yaxisvisible', - ['yes','no'],$token).'  '. + ['yes','no'],$token).'
'. &Apache::edit::select_arg('Grid visible:','gridvisible', ['yes','no'],$token). &Apache::edit::end_row().&Apache::edit::start_spanning_row(); @@ -568,10 +754,195 @@ sub start_functionplotresponse { $result.=&axes_script($internalid,$xmin,$xmax,$ymin,$ymax,$xaxisvisible,$yaxisvisible,$gridvisible); $result.=&axes_label($internalid,$xlabel,$ylabel); # init script is left open - } + } elsif (($target eq 'answer') && + ($env{'form.answer_output_mode'} ne 'tex') && + ($Apache::lonhomework::viewgrades == 'F')) { + my (undef,undef,$udom,$uname)=&Apache::lonnet::whichuser(); + my $windowopen=&Apache::lonhtmlcommon::javascript_docopen(); + my $start_page = &Apache::loncommon::start_page('Rules Log', undef, + {'only_body' => 1, + 'bgcolor' => '#FFFFFF', + 'js_ready' => 1,}); + my $end_page = &Apache::loncommon::end_page({'js_ready' => 1,}); + $uname =~s/\W//g; + $udom =~s/\W//g; + my $function_name = + join('_','LONCAPA_scriptvars',$uname,$udom, + $env{'form.counter'},$Apache::lonxml::curdepth); + my $rules_var ="".&mt('Rules Log')."
"; + &Apache::lonxml::add_script_result($rules_var); + } + return $result; } +sub compare_rel { + my ($relationship,$value,$realval,$tol)=@_; +# is the real value undefined? + unless (defined($realval)) { +# the real value is not defined + if ($relationship eq 'eq') { + if ($value eq 'undef') { + return 1; + } else { + return 0; + } + } elsif ($relationship eq 'ne') { + if ($value eq 'undef') { + return 0; + } else { + return 1; + } + } else { + return 0; + } + } + +# is the expected value undefined? + if ($value eq 'undef') { +# but by now we know that the real value is defined + return 0; + } + +# both are defined. + if ($relationship eq 'gt') { + return ($realval>$value); + } elsif ($relationship eq 'ge') { + return ($realval>$value-$tol); + } elsif ($relationship eq 'lt') { + return ($realval<$value); + } elsif ($relationship eq 'le') { + return ($realval<$value+$tol); + } elsif ($relationship eq 'ne') { + return (abs($value-$realval)>$tol); + } else { + return (abs($value-$realval)<$tol); + } + return 0; +} + +sub addlog { + my ($text)=@_; + $Apache::functionplotresponse::ruleslog.=$text.'
'; +} + +sub actualval { + my ($i,$xmin,$xmax)=@_; + return $xmin+$i/400.*($xmax-$xmin); +} + +sub functionplotrulecheck { + my ($rule,$xmin,$xmax,$ymin,$ymax)=@_; + + my ($label,$derivative,$xinitial,$xinitiallabel,$xfinal,$xfinallabel,$minimumlength,$maximumlength,$relationship,$value,$percent) + =split(/\:/,$rule); + $percent=($percent>0?$percent:5); + &addlog("================="); + &addlog("Rule $label for ".('function itself','first derivative','second derivative')[$derivative]." $relationship $value"); + my $li=0; + my $lh=400; + +# Special case: the upper boundary was not defined +# and needs to be set to the value where +# the condition is not true anymore => set flag + + my $findupper=0; + if (($xfinal eq '') + && (!defined($Apache::functionplotresponse::functionplotrulelabels{$xfinallabel})) + && ($xfinallabel)) { + $findupper=1; + } + +# if a hard value is set for the boundaries, it overrides the label + if (($xinitial ne '') && ($xinitiallabel ne '') && ($xinitiallabel ne 'start')) { + $li=&array_index($xmin,$xmax,$xinitial); + $Apache::functionplotresponse::functionplotrulelabels{$xinitiallabel}=$li; + } + if (($xfinal ne '') && ($xfinallabel ne '') && ($xfinallabel ne 'end')) { + $lh=&array_index($xmin,$xmax,$xfinal); + $Apache::functionplotresponse::functionplotrulelabels{$xfinallabel}=$lh; + } +# if the label is defined, use it + if (defined($Apache::functionplotresponse::functionplotrulelabels{$xinitiallabel})) { + &addlog("Using lower label $xinitiallabel"); + $li=$Apache::functionplotresponse::functionplotrulelabels{$xinitiallabel}; + } else { + $li=&array_index($xmin,$xmax,$xinitial); + } + unless ($findupper) { + if (defined($Apache::functionplotresponse::functionplotrulelabels{$xfinallabel})) { + &addlog("Using upper label $xfinallabel"); + $lh=$Apache::functionplotresponse::functionplotrulelabels{$xfinallabel}-1; + } else { + $lh=&array_index($xmin,$xmax,$xfinal); + } + } +# Basic sanity checks + if ($li<0) { $li=0; } + if ($lh>400) { $lh=400; } + if ($li>$lh) { + $lh=$li; + } + + &addlog("Boundaries: x=".&actualval($li,$xmin,$xmax)." (".$Apache::functionplotresponse::actualxval[$li]."; index $li)) to x=". + &actualval($lh,$xmin,$xmax)." (".$Apache::functionplotresponse::actualxval[$lh]."; index $lh))"); + if ($findupper) { + &addlog("Looking for label $xfinallabel"); + } + my $tol=$percent*($ymax-$ymin)/100; + if ($xmax>$xmin) { + if ($derivative==2) { + $tol=4.*$tol/($xmax-$xmin); + } elsif ($derivative==1) { + $tol=2.*$tol/($xmax-$xmin); + } + } + for (my $i=$li; $i<=$lh; $i++) { + my $val; + if ($derivative==2) { + $val=$Apache::functionplotresponse::d2funcdx2[$i]; + } elsif ($derivative==1) { + $val=$Apache::functionplotresponse::dfuncdx[$i]; + } else { + $val=$Apache::functionplotresponse::func[$i]; + } + &addlog("Actual value ".(defined($val)?$val:'undef').", expected $value, tolerance $tol"); + unless (&compare_rel($relationship,$value,$val,$tol)) { + &addlog("Condition not fulfilled at x=".&actualval($i,$xmin,$xmax)." (".$Apache::functionplotresponse::actualxval[$i]."; index $i)"); + if (($findupper) && ($i>$li)) { +# check for minimum and maximum lengths + my $length=&actualval($i,$xmin,$xmax)-&actualval($li,$xmin,$xmax); + if ($minimumlength) { + if ($length<$minimumlength) { + &addlog("Rule $label failed, actual length $length, minimum length $minimumlength"); + return 0; + } + } + if ($maximumlength) { + if ($length>$maximumlength) { + &addlog("Rule $label failed, actual length $length, maximum length $maximumlength"); + return 0; + } + } + $Apache::functionplotresponse::functionplotrulelabels{$xfinallabel}=$i; + &addlog("Rule $label passed, setting label $xfinallabel"); + return 1; + } else { + &addlog("Rule $label failed."); + return 0; + } + } + } + &addlog("Rule $label passed."); + return 1; +} + sub end_functionplotresponse { my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_; &Apache::response::end_response; @@ -581,12 +952,13 @@ sub end_functionplotresponse { my $partid=$Apache::inputtags::part; my $internalid = $partid.'_'.$id; + if ($target eq 'edit') { $result=&Apache::edit::end_table(); } if ($target eq 'grade' && &Apache::response::submitted() && $Apache::lonhomework::type eq 'exam') { - #&Apache::response::scored_response($partid,$id); + &Apache::response::scored_response($partid,$id); } elsif ($target eq 'grade' && &Apache::response::submitted() @@ -597,7 +969,39 @@ sub end_functionplotresponse { # # Actually grade # - my $ad='INCORRECT'; + my $xmin=&Apache::lonxml::get_param('xmin',$parstack,$safeeval); + $xmin=(defined($xmin)?$xmin:-10); + my $xmax=&Apache::lonxml::get_param('xmax',$parstack,$safeeval); + $xmax=(defined($xmax)?$xmax:10); + my $ymin=&Apache::lonxml::get_param('ymin',$parstack,$safeeval); + $ymin=(defined($ymin)?$ymin:-10); + my $ymax=&Apache::lonxml::get_param('ymax',$parstack,$safeeval); + $ymax=(defined($ymax)?$ymax:10); + + my $ad=''; + undef %Apache::functionplotresponse::functionplotrulelabels; + $Apache::functionplotresponse::ruleslog=''; + $Apache::functionplotresponse::functionplotrulelabels{'start'}=400; + $Apache::functionplotresponse::functionplotrulelabels{'end'}=0; + if (&populate_arrays($internalid,$xmin,$xmax) eq 'no_func') { + $ad='NOT_FUNCTION'; + } else { + &addlog("Start of function ".&actualval($Apache::functionplotresponse::functionplotrulelabels{'start'},$xmin,$xmax)." (index ". + $Apache::functionplotresponse::functionplotrulelabels{'start'}.")"); + &addlog("End of function ".&actualval($Apache::functionplotresponse::functionplotrulelabels{'end'},$xmin,$xmax)." (index ". + $Apache::functionplotresponse::functionplotrulelabels{'end'}.")"); + +# We have a function that we can actually grade, go through the spline rules. + foreach my $rule (@Apache::functionplotresponse::functionplotrules) { + unless (&functionplotrulecheck($rule,$xmin,$xmax,$ymin,$ymax)) { + $ad='INCORRECT'; + last; + } + } +# If it's not wrong, it's correct + unless ($ad) { $ad='EXACT_ANS' }; + } + # # Store grading info # @@ -610,6 +1014,13 @@ sub end_functionplotresponse { } # close the init script $result.=&end_init_script(); +# register all splines in this response + $result.=''."\n"; + foreach my $label (keys(%Apache::functionplotresponse::splineorder)) { + $result.=''."\n"; + } # generate the input fields $result.=$Apache::functionplotresponse::inputfields; # actually start the -tag