--- loncom/homework/grades.pm 2002/07/26 20:28:42 1.42 +++ loncom/homework/grades.pm 2002/07/30 19:59:58 1.43 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # The LON-CAPA Grading handler # -# $Id: grades.pm,v 1.42 2002/07/26 20:28:42 ng Exp $ +# $Id: grades.pm,v 1.43 2002/07/30 19:59:58 ng Exp $ # # Copyright Michigan State University Board of Trustees # @@ -131,7 +131,7 @@ sub response_type { my %seen = (); my (@partlist,%handgrade); foreach (split(/,/,&Apache::lonnet::metadata($url,'packages'))) { - if (/^\w+response_\d{1,2}.*/) { + if (/^\w+response_\d+.*/) { my ($responsetype,$part) = split(/_/,$_,2); my ($partid,$respid) = split(/_/,$part); $handgrade{$part} = $responsetype.':'.($allkeys =~ /parameter_$part\_handgrade/ ? 'yes' : 'no'); @@ -158,7 +158,7 @@ sub listStudents { for (sort keys(%$handgrade)) { my ($responsetype,$handgrade)=split(/:/,$$handgrade{$_}); $ENV{'form.handgrade'} = 'yes' if ($handgrade eq 'yes'); - $result.='Part id: '.$_.''. + $result.='Part id: '.(split(/_/))[0].''. 'Type: '.$responsetype.''. 'Handgrade: '.$handgrade.''; } @@ -196,7 +196,7 @@ ENDTABLEST ' Select  Username '. ' Fullname  Domain '; foreach (sort(@$partlist)) { - $result.=' Part ID '.$_.' Status '; + $result.=' Part ID '.(split(/_/))[0].' Status '; } $request->print($result.''."\n"); @@ -206,7 +206,7 @@ ENDTABLEST my $statusflg = ''; foreach (keys(%status)) { $statusflg = 1 if ($status{$_} ne 'nothing'); - my ($foo,$partid,$foo) = split(/\./,$_); + my ($foo,$partid,$foo1) = split(/\./,$_); if ($status{'resource.'.$partid.'.submitted_by'} ne '') { $statusflg = ''; $request->print(''. '
'; - $result.='
Fullname: '.$fullname. + $result.=''; - $result.=''."\n"; $result.=''. + $result.=''. ''. ''; } @@ -927,10 +928,7 @@ sub view_edit_entire_class_form { foreach (sort (@$sections)) { $result.= ''."\n"; } - $result.= '
Fullname: '.$ENV{'form.fullname'}. +# $result.=''; if ($ENV{'form.handgrade'} eq 'yes') { @@ -555,8 +556,8 @@ KEYWORDS $result.='
Fullname: '.$fullname. '   Username: '.$uname. '   Domain: '.$udom.'
'; # display radio buttons in a nice table 10 across while ($ctr<=$wgt) { $result.= '\n"; $result.=(($ctr+1)%10 == 0 ? '' : ''); @@ -565,18 +566,18 @@ KEYWORDS $result.='
'.$ctr."
'; $result.='
 or /'.$wgt.' '.$wgtmsg.' '; - $result.=''."  \n"; @@ -760,7 +761,7 @@ sub processHandGrade { my $statusflg = ''; foreach (keys(%status)) { $statusflg = 1 if ($status{$_} ne 'nothing'); - my ($foo,$partid,$foo) = split(/\./,$_); + my ($foo,$partid,$foo1) = split(/\./,$_); $statusflg = '' if ($status{'resource.'.$partid.'.submitted_by'} ne ''); } next if ($statusflg eq ''); @@ -796,11 +797,11 @@ sub saveHandGrade { # my %record=&Apache::lonnet::restore($symb,$ENV{'request.course.id'},$domain,$stuname); my %newrecord; foreach (split(/:/,$ENV{'form.partlist'.$newflg})) { - if ($ENV{'form.GRADE_SEL'.$newflg.'_'.$_} eq 'excused') { + if ($ENV{'form.GD_SEL'.$newflg.'_'.$_} eq 'excused') { $newrecord{'resource.'.$_.'.solved'} = 'excused'; } else { - my $pts = ($ENV{'form.GRADE_BOX'.$newflg.'_'.$_} ne '' ? - $ENV{'form.GRADE_BOX'.$newflg.'_'.$_} : $ENV{'form.RADVAL'.$newflg.'_'.$_}); + my $pts = ($ENV{'form.GD_BOX'.$newflg.'_'.$_} ne '' ? + $ENV{'form.GD_BOX'.$newflg.'_'.$_} : $ENV{'form.RADVAL'.$newflg.'_'.$_}); if ($pts eq '') { &userError($request,'No point was assigned for part id '.$_.' and for username '.$stuname.'.'); return 'error'; @@ -857,7 +858,7 @@ sub gradingmenu { my ($responsetype,$handgrade)=split(/:/,$$handgrade{$_}); $resptype = $responsetype; $hdgrade = $handgrade if ($handgrade eq 'yes'); - $result.='
Part id: '.$_.'
Part ID: '.(split(/_/))[0].'Type: '.$responsetype.'Handgrade: '.$handgrade.'
'."\n"; $result.='
'."\n"; @@ -1058,15 +1056,17 @@ sub viewgrades_js { textbox.value = point; } for (i=0;i VIEWJAVASCRIPT @@ -1156,9 +1174,9 @@ sub viewgrades { &viewgrades_js($request); my ($symb,$url) = ($ENV{'form.symb'},$ENV{'form.url'}); - $request->print ('

Manual Grading

'); + my $result='

Manual Grading

'; - my $result='Resource: '.$ENV{'form.url'}.''."\n"; + $result.='Resource: '.$ENV{'form.url'}.''."\n"; #view individual student submission form - called using Javascript viewOneStudent $result.= '
'."\n". @@ -1214,7 +1232,9 @@ sub viewgrades { } $result.='
'; $result.='    '; + 'onClick="javascript:resetEntry('.$ctsparts.');" TARGET=_self>    '; +# $result.=''."\n"; $result.= ''."\n"; $result.= ''."\n"; } elsif ($type eq 'solved') { my ($status,$foo)=split(/_/,$score,2); $status = 'nothing' if ($status eq ''); $result.=''."\n"; + 'GD_'.$username.'_'.$part.'_sv_s" value="'.$status.'" />'."\n"; $result.='
'."\n". @@ -1242,7 +1262,7 @@ sub viewgrades { my $ctr = 0; foreach ( sort(@{ $$classlist{$ENV{'form.section'}} }) ) { (my $username = $_) = split(/:/); - $result.=''."\n"; + $result.=''."\n"; $result.=&viewstudentgrade($url,$symb,$ENV{'request.course.id'}, $_,$$fullname{$_},\@parts,\%weight); $ctr++; @@ -1268,18 +1288,18 @@ sub viewstudentgrade { if ($type eq 'awarded') { my $pts = $score eq '' ? '' : $score*$$weight{$part}; $result.=''."\n"; + 'GD_'.$username.'_'.$part.'_aw_s" value="'.$pts.'" />'."\n"; $result.=''."\n"; + if ($updateflag) { + $newrecord{'resource.regrader'}="$ENV{'user.name'}:$ENV{'user.domain'}"; + &Apache::lonnet::cstore(\%newrecord,$symb,$ENV{'request.course.id'}, + $udom,$user); + } + } + $result .= '
'."\n"; + $result.= ''. + ''."\n"; + + my %scoreptr = ( + 'correct' =>'correct_by_override', + 'incorrect'=>'incorrect_by_override', + 'excused' =>'excused', + 'ungraded' =>'ungraded_attempted', + 'nothing' => '', + ); + my ($classlist,$seclist,$ids,$stusec,$fullname) = &getclasslist($ENV{'form.section'},'0'); - my $result.=''."\n". - ''."\n". - ''."\n". - ''."\n". - '
'."\n"; - - my (@parts) = &getpartlist($url); - my ($classlist) = &getclasslist($ENV{'form.section'},'0'); - foreach my $student ( sort(@{ $$classlist{$ENV{'form.section'}} }) ) { - $result.=&setstudentgrade($url,$symb,$ENV{'request.course.id'},$student,@parts); + my (@partid); + my %weight = (); + my ($i,$ctr) = (0,0); + while ($ctr < $ENV{'form.totalparts'}) { + my $partid = $ENV{'form.partid_'.$ctr}; + push @partid,$partid; + my $wgt = &Apache::lonnet::EXT('resource.'.$partid.'.weight',$symb); + $weight{$partid} = $wgt eq '' ? '1' : $wgt; + $ctr++; + $result .= ''; } + $result .= ''; + foreach (@partid) { + $result .= ''. + ''; + } + $result .= ''."\n"; + + for ($i=0; $i<$ENV{'form.total'}; $i++) { + my $user = $ENV{'form.ctr'.$i}; + my %newrecord; + my $updateflag = 0; + my @userdom = grep /^$user:/,keys %$classlist; + my ($foo,$udom) = split(/:/,$userdom[0]); + + $result .= ''; + + foreach (@partid) { + my $old_aw = $ENV{'form.GD_'.$user.'_'.$_.'_aw_s'}; + my $old_part = $old_aw eq '' ? '' : $old_aw/$weight{$_}; + my $old_score = $scoreptr{$ENV{'form.GD_'.$user.'_'.$_.'_sv_s'}}; + + my $awarded = $ENV{'form.GD_'.$user.'_'.$_.'_aw'}; + my $partial = $awarded eq '' ? '' : $awarded/$weight{$_}; + my $score; + if ($partial eq '') { + $score = $scoreptr{$ENV{'form.GD_'.$user.'_'.$_.'_sv_s'}}; + } elsif ($partial > 0) { + $score = 'correct_by_override'; + } elsif ($partial == 0) { + $score = 'incorrect_by_override'; + } + $score = 'excused' if (($ENV{'form.GD_'.$user.'_'.$_.'_sv'} eq 'excused') && + ($score ne 'excused')); + $result .= ''. + ''; + + next if ($old_part eq $partial && $old_score eq $score); + + $updateflag = 1; + $newrecord{'resource.'.$_.'.awarded'} = $partial if $partial ne ''; + $newrecord{'resource.'.$_.'.solved'} = $score; - $result.='
UsernameFullname Part ID '.$partid. + ' (Weight = '.$weight{$partid}.')
 Old Score  New Score 
'.$user.' '. + $$fullname{$userdom[0]}.' '.$old_aw.' '.$awarded. + ($score eq 'excused' ? $score : '').' 
'; + } + $result .= '
'."\n"; return $result; } @@ -1329,7 +1416,7 @@ sub setstudentgrade { foreach my $part (@parts) { my ($temp,$part,$type)=split(/_/,$part); my $oldscore=$record{"resource.$part.$type"}; - my $newscore=$ENV{"form.GRADE.$student.$part.$type"}; + my $newscore=$ENV{"form.GD.$student.$part.$type"}; if ($type eq 'solved') { my $update=0; if ($newscore eq 'nothing' ) {