--- loncom/homework/grades.pm	2007/11/03 00:18:37	1.478
+++ loncom/homework/grades.pm	2007/11/06 11:21:21	1.482
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # The LON-CAPA Grading handler
 #
-# $Id: grades.pm,v 1.478 2007/11/03 00:18:37 albertel Exp $
+# $Id: grades.pm,v 1.482 2007/11/06 11:21:21 foxr Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -5116,7 +5116,8 @@ sub username_to_idmap {
 
 sub scantron_fixup_scanline {
     my ($scantron_config,$scan_data,$line,$whichline,$field,$args)=@_;
-
+    
+    
     if ($field eq 'ID') {
 	if (length($args->{'newid'}) > $$scantron_config{'IDlength'}) {
 	    return ($line,1,'New value too large');
@@ -5147,28 +5148,58 @@ sub scantron_fixup_scanline {
 		   $$scantron_config{'CODElength'})=$args->{'CODE'};
 	}
     } elsif ($field eq 'answer') {
-	my $length=$scantron_config->{'Qlength'};
+	&scantron_get_maxbubble(); # Need the bubble counter info.
+	my $length =$scantron_config->{'Qlength'};
 	my $off=$scantron_config->{'Qoff'};
 	my $on=$scantron_config->{'Qon'};
-	my $answer=${off}x$length;
-	if ($args->{'response'} eq 'none') {
-	    &scan_data($scan_data,
-		       "$whichline.no_bubble.".$args->{'question'},'1');
-	} else {
-	    if ($on eq 'letter') {
-		my @alphabet=('A'..'Z');
-		$answer=$alphabet[$args->{'response'}];
-	    } elsif ($on eq 'number') {
-		$answer=$args->{'response'}+1;
-		if ($answer == 10) { $answer = '0'; }
+        my $question_number = $args->{'question'} -1;
+        my $first_position  = $first_bubble_line{$question_number};
+	my $bubble_count    = $bubble_lines_per_response{$question_number};
+        my $bubbles_per_line= $$scantron_config{'Qlength'};
+	my $answer=${off}x($bubbles_per_line*$bubble_count);
+        my $final_answer;
+        if ($$scantron_config{'Qon'} eq 'letter'  ||
+	    $$scantron_config{'Qon'} eq 'number') { 
+	    $bubbles_per_line = 10;
+	}
+	if (defined $args->{'response'}) {
+	    
+	    if ($args->{'response'} eq 'none') {
+		&scan_data($scan_data,
+			   "$whichline.no_bubble.".$args->{'question'},'1');
 	    } else {
-		substr($answer,$args->{'response'},1)=$on;
+		my ($bubble_line, $bubble_number) = split(/:/,$args->{'response'});
+		if ($on eq 'letter') {
+		    my @alphabet=('A'..'Z');
+		    $answer=$alphabet[$bubble_number];
+		} elsif ($on eq 'number') {
+		    $answer= $bubble_number+1;
+		    if ($answer == 10) { $answer = '0'; }
+		} else {
+		    substr($answer,$bubble_number+$bubble_line*$bubbles_per_line,1)=$on;
+		    $final_answer = $answer;
+		}
+		&scan_data($scan_data,
+			   "$whichline.no_bubble.".$args->{'question'},undef,'1');
+		
+		# Positional notation already has the right final answer length..
+
+		if (($on eq 'letter') || ($on eq 'number')) {
+		    for (my $l = 0; $l < $bubble_count; $l++) {
+			if ($l eq $bubble_line) {
+			    $final_answer .= $answer;
+			} else {
+			    $final_answer .= ' ';
+			}
+		    }
+		}
 	    }
-	    &scan_data($scan_data,
-		       "$whichline.no_bubble.".$args->{'question'},undef,'1');
+	    # $where=$length*($args->{'question'}-1)+$scantron_config->{'Qstart'};
+	    #substr($line,$where-1,$length)=$answer;
+	    substr($line, 
+		   $scantron_config->{'Qstart'}+$first_position-1,
+		   $bubbles_per_line*$length) = $final_answer;
 	}
-	my $where=$length*($args->{'question'}-1)+$scantron_config->{'Qstart'};
-	substr($line,$where-1,$length)=$answer;
     }
     return $line;
 }
@@ -5415,7 +5446,11 @@ sub scantron_parse_scanline {
 		if (!&scan_data($scan_data,"$whichline.no_bubble.$questnum")) {
 		    push(@{$record{"scantron.missingerror"}},$questnum);
 		}
-	    } elsif (scalar(@array) lt 2) {
+		
+		#  If the bubble is not the last position, there will be
+		# 2 elements.  If it is the last position, there will be 1 element.
+
+	    } elsif (scalar(@array) le 2) {
 
 		my $location      = length($array[0]);
 		my $line_num      = $location / $$scantron_config{'Qlength'};
@@ -6546,6 +6581,7 @@ sub scantron_bubble_selector {
 
     my $total_lines = $lines*2;
     my @alphabet=('A'..'Z');
+
     $r->print("<table border='1'><tr><td rowspan='".$total_lines."'>$quest</td>");
 
     for (my $l = 0; $l < $lines; $l++) {
@@ -6579,9 +6615,10 @@ sub scantron_bubble_selector {
 	#        multiline questions (different values e.g..).
 
 	for (my $i=0;$i<$max;$i++) {
+	    my $value = "$l:$i";	# Relative bubble line #: Bubble in line.
 	    $r->print("\n".
 		      '<td><label><input type="radio" name="scantron_correct_Q_'.
-		      $quest.'" value="'.$i.'" />'.$alphabet[$i]."</label></td>");
+		      $quest.'" value="'.$value.'" />'.$alphabet[$i]."</label></td>");
 	}
 	$r->print('</tr>');