--- loncom/homework/hint.pm	2001/04/05 00:08:40	1.10
+++ loncom/homework/hint.pm	2001/08/17 21:42:19	1.18
@@ -11,7 +11,7 @@ sub BEGIN {
 
 @Apache::hint::which=();
 sub start_hintgroup {
-  my ($target,$token,$parstack,$parser,$safeeval,$style)=@_;
+  my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
   my $skiptoend='0';
   my $result;
   
@@ -22,8 +22,8 @@ sub start_hintgroup {
     my $hinttries=&Apache::lonnet::EXT("resource.$id.hinttries");
     if ( $hinttries eq '') { $hinttries = 1; }
     &Apache::lonxml::debug("found :$id:$numtries:$hinttries:");
-    if ( $numtries <= $hinttries ) {
-      $skiptoend='1'; 
+    if ( $numtries < $hinttries ) {
+      $skiptoend='1';
     } else {
       if ($target eq 'web') {$result='<table bgcolor="#dddddd"><tr><td>';}
     }
@@ -36,7 +36,7 @@ sub start_hintgroup {
 }
 
 sub end_hintgroup {
-  my ($target,$token,$parstack,$parser,$safeeval,$style)=@_;
+  my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
   my $result;
 
   if ($target eq 'web') {
@@ -46,7 +46,7 @@ sub end_hintgroup {
     my $hinttries=&Apache::lonnet::EXT("resource.$id.hinttries");
     if ( $hinttries eq '') { $hinttries = 1; }
     &Apache::lonxml::debug("found :$id:$numtries:$hinttries:");
-    if ( $numtries <= $hinttries ) {
+    if ( $numtries => $hinttries ) {
       if ($target eq 'web') {$result='</td></tr></table>';}
     }	
   }
@@ -55,44 +55,56 @@ sub end_hintgroup {
 }
 
 sub start_numericalhint {
+  my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
   #do everything in end, so intervening <responseparams> work
+  &Apache::response::start_hintresponse($parstack,$safeeval);
+  return '';
 }
 
 sub end_numericalhint {
-  my ($target,$token,$parstack,$parser,$safeeval,$style)=@_;
+  my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
   my $result;
   if ($target eq 'web') {
-    my $args ='';
     $safeeval->share_from('capa',['&caparesponse_capa_check_answer']);
-    if ( $#$parstack > -1 ) { $args=$$parstack[$#$parstack]; }
-    my $name = &Apache::run::run("{$args;".'return $name}',$safeeval);
-    my $response = $Apache::lonhomework::history{"resource.$Apache::inputtags::part.$Apache::inputtags::response['-1'].submission"};
+    my $name= &Apache::lonxml::get_param('name',$parstack,$safeeval);
+    &Apache::response::setup_params('numericalhint');
+    my $partid=$Apache::inputtags::part;
+    my $id=$Apache::inputtags::response['-1'];
+    #id submissions occured under
+    my $submitid=$Apache::inputtags::response['-2'];
+    my $response = $Apache::lonhomework::history{
+			    "resource.$partid.$submitid.submission"};
     &Apache::lonxml::debug("hintgroup is using $response<br />\n");
+    #build safe space expression
     my $expression="&caparesponse_check_list('".$response."','".
-      $$parstack[$#$parstack].
-	';my $tol="'.$Apache::inputtags::params{'tol'}.'"'.
-	';my $sig="'.$Apache::inputtags::params{'sig'}.'"'.
-	  "');";
+      $$parstack[$#$parstack];
+    #need to get all possible parms
+    foreach my $key (keys(%Apache::inputtags::params)) {
+      $expression.= ';my $'. #'
+	$key.'="'.$Apache::inputtags::params{$key}.'"';
+    }
+    $expression.="');";
     $result = &Apache::run::run($expression,$safeeval);
     &Apache::lonxml::debug("$expression:result:$result:$Apache::lonxml::curdepth");
     my ($awards) = split /:/ , $result;
     my ($ad) = &Apache::inputtags::finalizeawards(split /,/ , $awards);
     if ($ad eq 'EXACT_ANS' || $ad eq 'APPROX_ANS') { push (@Apache::hint::which,$name); }
     $result='';
+  } elsif ($target eq 'meta') {
+    $result=&Apache::response::meta_package_write('numericalhint');
   }
+  &Apache::response::end_hintresponse();
   return $result;
 }
 
 # a part shows if it is on, if no specific parts are on, then default shows
 sub start_hintpart {
-  my ($target,$token,$parstack,$parser,$safeeval,$style)=@_;
+  my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
 
   my $show ='0';
 
   if ($target eq 'web') {
-    my $args ='';
-    if ( $#$parstack > -1 ) { $args=$$parstack[$#$parstack]; }
-    my $on = &Apache::run::run("{$args;".'return $on}',$safeeval);
+    my $on= &Apache::lonxml::get_param('on',$parstack,$safeeval);
     &Apache::lonxml::debug("hintpart sees $on and ,$#Apache::hint::which");
     if ( $on eq 'default' && $#Apache::hint::which == '-1') {
       $show=1;
@@ -110,6 +122,7 @@ sub start_hintpart {
 }
 
 sub end_hintpart {
+  return '';
 }
 
 1;