--- loncom/homework/hint.pm	2001/01/22 19:58:09	1.6
+++ loncom/homework/hint.pm	2001/08/06 20:33:23	1.15
@@ -11,21 +11,22 @@ sub BEGIN {
 
 @Apache::hint::which=();
 sub start_hintgroup {
-  my ($target,$token,$parstack,$parser,$safeeval,$style)=@_;
-  my $skiptoend='1';
+  my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
+  my $skiptoend='0';
   my $result;
   
-  if ($target ne 'meta' || $target ne 'grade') {
+  if ($target eq 'web') {
     my $id=$Apache::inputtags::part;
     my $numtries=$Apache::lonhomework::history{"resource.$id.tries"};
     if ( $numtries eq '') { $numtries = 0; }
     my $hinttries=&Apache::lonnet::EXT("resource.$id.hinttries");
     if ( $hinttries eq '') { $hinttries = 1; }
     &Apache::lonxml::debug("found :$id:$numtries:$hinttries:");
-    if ( $numtries >= $hinttries ) {
-      $skiptoend='0'; 
+    if ( $numtries < $hinttries ) {
+      $skiptoend='1';
+    } else {
       if ($target eq 'web') {$result='<table bgcolor="#dddddd"><tr><td>';}
-    }	
+    }
   }
   if ($skiptoend) {
     &Apache::lonxml::get_all_text("/hintgroup",$$parser[$#$parser]);
@@ -35,17 +36,17 @@ sub start_hintgroup {
 }
 
 sub end_hintgroup {
-  my ($target,$token,$parstack,$parser,$safeeval,$style)=@_;
+  my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
   my $result;
 
-  if ($target ne 'meta' || $target ne 'grade') {
+  if ($target eq 'web') {
     my $id=$Apache::inputtags::part;
     my $numtries=$Apache::lonhomework::history{"resource.$id.tries"};
     if ( $numtries eq '') { $numtries = 0; }
     my $hinttries=&Apache::lonnet::EXT("resource.$id.hinttries");
     if ( $hinttries eq '') { $hinttries = 1; }
     &Apache::lonxml::debug("found :$id:$numtries:$hinttries:");
-    if ( $numtries >= $hinttries ) {
+    if ( $numtries => $hinttries ) {
       if ($target eq 'web') {$result='</td></tr></table>';}
     }	
   }
@@ -55,18 +56,17 @@ sub end_hintgroup {
 
 sub start_numericalhint {
   #do everything in end, so intervening <responseparams> work
+  return '';
 }
 
 sub end_numericalhint {
-  my ($target,$token,$parstack,$parser,$safeeval,$style)=@_;
+  my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
   my $result;
-  if ($target ne 'meta' && $target ne 'grade') {
-    my $args ='';
+  if ($target eq 'web') {
     $safeeval->share_from('capa',['&caparesponse_capa_check_answer']);
-    if ( $#$parstack > -1 ) { $args=$$parstack[$#$parstack]; }
-    my $name = &Apache::run::run("{$args;".'return $name}',$safeeval);
+    my $name= &Apache::lonxml::get_param('name',$parstack,$safeeval);
     my $response = $Apache::lonhomework::history{"resource.$Apache::inputtags::part.$Apache::inputtags::response['-1'].submission"};
-    &Apache::lonxml::debug("hintgroup is using $response<br>\n");
+    &Apache::lonxml::debug("hintgroup is using $response<br />\n");
     my $expression="&caparesponse_check_list('".$response."','".
       $$parstack[$#$parstack].
 	';my $tol="'.$Apache::inputtags::params{'tol'}.'"'.
@@ -84,15 +84,15 @@ sub end_numericalhint {
 
 # a part shows if it is on, if no specific parts are on, then default shows
 sub start_hintpart {
-  my ($target,$token,$parstack,$parser,$safeeval,$style)=@_;
+  my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
 
   my $show ='0';
 
-  if ($target ne 'meta' && $target ne 'grade') {
-    my $args ='';
-    if ( $#$parstack > -1 ) { $args=$$parstack[$#$parstack]; }
-    my $on = &Apache::run::run("{$args;".'return $on}',$safeeval);
+  if ($target eq 'web') {
+    my $on= &Apache::lonxml::get_param('on',$parstack,$safeeval);
+    &Apache::lonxml::debug("hintpart sees $on and ,$#Apache::hint::which");
     if ( $on eq 'default' && $#Apache::hint::which == '-1') {
+      $show=1;
     } else {
       my $which;
       foreach $which (@Apache::hint::which) { if ($which eq $on) { $show = 1; last } }
@@ -100,13 +100,14 @@ sub start_hintpart {
     if (!$show) {
       &Apache::lonxml::get_all_text("/hintpart",$$parser[$#$parser]);
     }
-  } else {
+  } elsif ($target eq 'grade') {
     &Apache::lonxml::get_all_text("/hintpart",$$parser[$#$parser]);
   }
   return '';
 }
 
 sub end_hintpart {
+  return '';
 }
 
 1;