--- loncom/homework/inputtags.pm 2015/10/30 11:33:07 1.333.2.3 +++ loncom/homework/inputtags.pm 2021/09/11 16:09:56 1.333.2.10 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # input definitons # -# $Id: inputtags.pm,v 1.333.2.3 2015/10/30 11:33:07 raeburn Exp $ +# $Id: inputtags.pm,v 1.333.2.10 2021/09/11 16:09:56 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -666,10 +666,13 @@ sub file_selector { if ($constraints) { $result .= $constraints.'
'; } - if ($which eq 'uploadonly' || $which eq 'both') { - $result.=&mt('Submit a file: (only one file per submission)'). - '

'; + if ($which eq 'uploadonly' || $which eq 'both') { + my $free_space = $maxfilesize * 1048576; + $result .= &mt('Submit a file: (only one file per submission)'). + '
'. + '
'; } if ( $which eq 'both') { $result.='
'.''.&mt('OR:').'
'; @@ -691,7 +694,6 @@ sub file_selector { &mt('Select Portfolio Files: (one or more files per submission)').'
'. ''. '
'; - } $result.=&Apache::lonhtmlcommon::row_closure(1); return $result; @@ -1035,6 +1037,7 @@ sub decideoutput { 'not_charged_try' => 'LC_answer_not_charged_try', 'no_grade' => 'LC_answer_no_grade', 'no_message' => 'LC_no_message', + 'no_charge_warn' => 'LC_answer_warning', ); my $part = $Apache::inputtags::part; @@ -1048,7 +1051,7 @@ sub decideoutput { # my $computer = ($handgrade || $nocorrect)? '' - : " ".&mt("Computer's answer now shown above."); + : &mt("Computer's answer now shown above."); &Apache::lonxml::debug("handgrade has :$handgrade:"); if ($previous) { $previousmsg=&mt('You have entered that answer before'); } @@ -1072,7 +1075,9 @@ sub decideoutput { $message = '\textbf{'.$message.'}'; } else { $message = "".$message.""; - $message.= $computer; + if ($computer) { + $message = "$computer $message"; + } } $added_computer_text=1; if ($awarded > 0) { @@ -1116,7 +1121,9 @@ sub decideoutput { $message = '\textbf{'.&mt('You are correct.').'}'; } else { $message = "".&mt('You are correct.').""; - $message.= $computer; + if ($computer) { + $message = "$computer $message"; + } } $added_computer_text=1; if ($awarded > 0 @@ -1194,8 +1201,12 @@ sub decideoutput { } elsif ($award eq 'SIG_FAIL') { my ($used,$min,$max)=split(':',$awardmsg); my $word = ($used < $min) ? 'more' : 'fewer'; - $message = &mt("Submission not graded. Use $word digits.",$used); - $css_class=$possible_class{'not_charged_try'}; + $message = &mt("Submission not graded. Use $word significant figures.",$used); + if (&Apache::lonhomework::show_some_problem_status()) { + $css_class=$possible_class{'no_charge_warn'}; + } else { + $css_class=$possible_class{'not_charged_try'}; + } $button=1; } elsif ($award eq 'UNIT_INVALID_INSTRUCTOR') { $message = &mt('Error in instructor specifed unit. This error has been reported to the instructor.', $awardmsg); @@ -1328,7 +1339,9 @@ sub decideoutput { } if ($Apache::inputtags::status[-1] eq 'SHOW_ANSWER' && !$added_computer_text && $target ne 'tex') { - $message.= $computer; + if ($computer) { + $message = "$computer $message"; + } $added_computer_text=1; } if ($Apache::lonhomework::type eq 'practice') { @@ -1865,9 +1878,16 @@ sub previous_tries { my $tries_text = &get_tries_text('link'); my $prefix = $env{'form.request.prefix'}; $prefix =~ tr{.}{_}; - my $function_name = "LONCAPA_previous_tries_".$prefix. - $Apache::lonxml::curdepth.'_'.$env{'form.counter'}; - my $result = &Apache::loncommon::modal_adhoc_window($function_name,420,410,$output,&mt($tries_text))."
"; + my $function_name = 'LONCAPA_previous_tries_'.$prefix; + if (($env{'request.state'} eq 'construct') || ($id =~ /[._]|[^\w\s\-]/)) { + $function_name .= $Apache::lonxml::curdepth; + } else { + $function_name .= &js_escape($id); + } + $function_name .= '_'.$Apache::lonxml::counter; + my $possmathjax = 1; + my $result = &Apache::loncommon::modal_adhoc_window($function_name,420,410,$output, + &mt($tries_text),$possmathjax)."
"; return $result; }