--- loncom/homework/lonhomework.pm	2005/07/13 19:48:07	1.213
+++ loncom/homework/lonhomework.pm	2005/12/21 17:53:25	1.230
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # The LON-CAPA Homework handler
 #
-# $Id: lonhomework.pm,v 1.213 2005/07/13 19:48:07 albertel Exp $
+# $Id: lonhomework.pm,v 1.230 2005/12/21 17:53:25 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -166,24 +166,34 @@ sub send_footer {
 }
 
 sub proctor_checked_in {
-    my ($slot_name,$slot)=@_;
-    my @allowed=split(",",$slot->{'proctor'});
-    my $version=$Apache::lonhomework::history{'resource.version'};
-    foreach my $possible (@allowed) { 
-	if ($Apache::lonhomework::history{"resource.$version.checkedin"} eq
-	    $possible &&
-	    $Apache::lonhomework::history{"resource.$version.checkedin.slot"}
-	       eq $slot_name) {
+    my ($slot_name,$slot,$type)=@_;
+    my @possible_proctors=split(",",$slot->{'proctor'});
+    
+    my $key;
+    if ($type eq 'Task') {
+	my $version=$Apache::lonhomework::history{'resource.0.version'};
+	$key ="resource.$version.0.checkedin";
+    } elsif ($type eq 'problem') {
+	$key ='resource.0.checkedin';
+    }
+    
+    foreach my $possible (@possible_proctors) { 
+	if ($Apache::lonhomework::history{$key} eq $possible
+	    && $Apache::lonhomework::history{$key.'.slot'} eq $slot_name) {
 	    return 1;
 	}
     }
+    
     return 0;
 }
 
 $Apache::lonxml::browse='';
 sub check_ip_acc {
     my ($acc)=@_;
-    if (!defined($acc) || $acc =~ /^\s*$/) { return 1; }
+    &Apache::lonxml::debug("acc is $acc");
+    if (!defined($acc) || $acc =~ /^\s*$/ || $acc =~/^\s*no\s*$/i) { 
+	return 1;
+    }
     my $allowed=0;
     my $ip=$ENV{'REMOTE_ADDR'};
     my $name;
@@ -227,13 +237,19 @@ sub check_ip_acc {
     return $allowed;
 }
 
-sub check_task_access {
+sub check_slot_access {
+    my ($id,$type)=@_;
+
     # does it pass normal muster
-    # yes we really do want the default args passing
-    my ($status,$datemsg)=&check_access;
+    my ($status,$datemsg)=&check_access($id);
+    
+    my $useslots = &Apache::lonnet::EXT("resource.$id.useslots");
+    if ($useslots ne 'resource') {
+	return ($status,$datemsg);
+    }
+
     if ($status eq 'SHOW_ANSWER' ||
 	$status eq 'CLOSED' ||
-	$status eq 'CANNOT_ANSWER' ||
 	$status eq 'INVALID_ACCESS' ||
 	$status eq 'UNAVAILABLE') {
 	return ($status,$datemsg);
@@ -241,12 +257,15 @@ sub check_task_access {
     if ($env{'request.state'} eq "construct") {
 	return ($status,$datemsg);
     }
-    my $version=$Apache::lonhomework::history{'resource.version'};
-    if ($Apache::lonhomework::history{"resource.$version.checkedin"} &&
-	$Apache::lonhomework::history{"resource.$version.status"} eq 'pass') {
-	return ('SHOW_ANSWER');
+    
+    if ($type eq 'Task') {
+	my $version=$Apache::lonhomework::history{'resource.version'};
+	if ($Apache::lonhomework::history{"resource.$version.0.checkedin"} &&
+	    $Apache::lonhomework::history{"resource.$version.0.status"} eq 'pass') {
+	    return ('SHOW_ANSWER');
+	}
     }
-    my ($id)=@_;
+
     my @slots=
 	(split(':',&Apache::lonnet::EXT("resource.$id.availablestudent")),
 	 split(':',&Apache::lonnet::EXT("resource.$id.available")));
@@ -271,18 +290,38 @@ sub check_task_access {
 	}
     }
     if ($slotstatus eq 'NEEDS_CHECKIN' &&
-	&proctor_checked_in($slot_name,$returned_slot)) {
+	&proctor_checked_in($slot_name,$returned_slot,$type)) {
 	&Apache::lonxml::debug("protoctor checked in");
 	$slotstatus='CAN_ANSWER';
     }
-    if ( $slotstatus eq 'NOT_IN_A_SLOT' && 
-	$Apache::lonhomework::history{"resource.$version.checkedin"}) {
-	if ($Apache::lonhomework::history{"resource.$version.status"} eq 'fail') {
+
+    my ($pass_status,$checkedin);
+    if ($type eq 'Task') {
+	my $version=$Apache::lonhomework::history{'resource.0.version'};
+	$pass_status = 
+	    $Apache::lonhomework::history{"resource.$version.0.status"} eq 'fail';
+	$checkedin =
+	    $Apache::lonhomework::history{"resource.$version.0.checkedin"};
+    } elsif ($type eq 'problem') {
+	$pass_status = 1;
+	$checkedin = $Apache::lonhomework::history{"resource.0.checkedin"};
+    }
+    
+    if ($slotstatus eq 'NOT_IN_A_SLOT' 
+	&& $checkedin ) {
+
+	if ($pass_status) {
 	    return ('SHOW_ANSWER');
 	} else {
 	    return ('WAITING_FOR_GRADE');
 	}
+
+    }
+    if ( $status eq 'CANNOT_ANSWER' && 
+	 ($slotstatus ne 'NEEDS_CHECKIN' && $slotstatus ne 'NOT_IN_A_SLOT')) {
+	return ($status,$datemsg);
     }
+
     return ($slotstatus,$datemsg,$slot_name,$returned_slot);
 }
 
@@ -294,7 +333,6 @@ sub check_access {
     my $status;
     my $datemsg = '';
     my $lastdate = '';
-    my $temp;
     my $type;
     my $passed;
 
@@ -331,7 +369,7 @@ sub check_access {
 	    return($status,$date);
 	}
 	
-	foreach $temp ("opendate","duedate","answerdate") {
+	foreach my $temp ("opendate","duedate","answerdate") {
 	    $lastdate = $date;
 	    $date = &Apache::lonnet::EXT("resource.$id.$temp");
 	    my $thistype = &Apache::lonnet::EXT("resource.$id.$temp.type");
@@ -578,10 +616,8 @@ sub handle_save_or_undo {
 
 sub analyze_header {
     my ($request) = @_;
-    my $bodytag='<body bgcolor="#ffffff">';
-    if ($env{'environment.remote'} eq 'off') {
-	$bodytag=&Apache::loncommon::bodytag();
-    }
+    my $bodytag=&Apache::loncommon::bodytag(undef,undef,undef,
+					    ($env{'environment.remote'} ne 'off'));
     my $html=&Apache::lonxml::xmlbegin();
     my $result.=$html.'
             <head><title>'.&mt("Analyzing a problem").'</title></head>
@@ -612,6 +648,7 @@ sub analyze {
     &Apache::lonxml::debug("Analyze");
     my $result;
     my %overall;
+    my %seedexample;
     my %allparts;
     my $rndseed=$env{'form.rndseed'};
     &analyze_header($request);
@@ -624,9 +661,10 @@ sub analyze {
 	&Apache::lonhtmlcommon::Increment_PrgWin($request,\%prog_state,
 						 &mt('last problem'));
 	if (&Apache::loncommon::connection_aborted($request)) { return; }
+        my $thisseed=$i+$rndseed;
 	my $subresult=&Apache::lonnet::ssi($request->uri,
 					   ('grade_target' => 'analyze'),
-					   ('rndseed' => $i+$rndseed));
+					   ('rndseed' => $thisseed));
 	(my $garbage,$subresult)=split(/_HASH_REF__/,$subresult,2);
 	my %analyze=&Apache::lonnet::str2hash($subresult);
 	my @parts;
@@ -638,8 +676,13 @@ sub analyze {
 	    if ($analyze{$part.'.type'} eq 'numericalresponse'	||
 		$analyze{$part.'.type'} eq 'stringresponse'	||
 		$analyze{$part.'.type'} eq 'formularesponse'   ) {
+		my $concatanswer=join("\0",@{ $analyze{$part.'.answer'} });
+		if (($concatanswer eq '') || ($concatanswer=~/^\@/)) {
+		    @{$analyze{$part.'.answer'}}=('<font color="red">'.&mt('Error').'</font>');
+		}
 		push( @{ $overall{$part.'.answer'} },
 		      [@{ $analyze{$part.'.answer'} }]);
+                $seedexample{join("\0",@{ $analyze{$part.'.answer'}})}=$thisseed;
 	    }
 	}
     }
@@ -649,17 +692,18 @@ sub analyze {
     foreach my $part (sort(keys(%allparts))) {
 	if (defined(@{ $overall{$part.'.answer'} })) {
 	    my $num_cols=scalar(@{ $overall{$part.'.answer'}->[0] });
-	    $request->print('<table><tr><th colspan="'.($num_cols+1).'">'.&mt('Part').' '.$part.'</th></tr>');
+	    $request->print('<table class="thinborder"><tr><th colspan="'.($num_cols+1).'">'.&mt('Part').' '.$part.'</th></tr>');
 	    my %frequency;
 	    foreach my $answer (sort {$a->[0] <=> $b->[0]} (@{ $overall{$part.'.answer'} })) {
 		$frequency{join("\0",@{ $answer })}++;
 	    }
-	    $request->print('<tr><th colspan="'.($num_cols).'">'.&mt('Answer').'</th><th>'.&mt('Frequency').'</th></tr>');
+	    $request->print('<tr><th colspan="'.($num_cols).'">'.&mt('Answer').'</th><th>'.&mt('Frequency').'<br />('
+			    .&mt('click for example').')</th></tr>');
 	    foreach my $answer (sort {(split("\0",$a))[0] <=> (split("\0",$b))[0]} (keys(%frequency))) {
-		$request->print('<tr><td align="right">'.
-				join('</td><td align="right">',split("\0",$answer)).
-				'</td><td>('.$frequency{$answer}.
-				')</td></tr>');
+		$request->print('<tr><td class="center">'.
+				join('</td><td class="center">',split("\0",$answer)).
+				'</td><td class="center"><a href="'.$request->uri.'?rndseed='.$seedexample{$answer}.'">'.$frequency{$answer}.
+				'</a></td></tr>');
 	    }
 	    $request->print('</table>');
 	} else {
@@ -668,7 +712,7 @@ sub analyze {
 	}
     }
     if (scalar(keys(%allparts)) == 0 ) {
-	$request->print('<p>'.&mt('Found no analyzable respones in this problem, currently only Numerical, Formula and String response styles are supported.').'</p>');
+	$request->print('<p>'.&mt('Found no analyzable responses in this problem, currently only Numerical, Formula and String response styles are supported.').'</p>');
     }
     &Apache::lonhtmlcommon::Close_PrgWin($request,\%prog_state);
     &analyze_footer($request);
@@ -706,28 +750,31 @@ sub editxmlmode {
 	if ($cols > 80) { $cols = 80; }
 	if ($cols < 70) { $cols = 70; }
 	if ($rows < 20) { $rows = 20; }
-	my $bodytag='<body bgcolor="#ffffff">';
-	if ($env{'environment.remote'} eq 'off') {
-	    $bodytag=&Apache::loncommon::bodytag();
-	}
+	my $bodytag=&Apache::loncommon::bodytag(undef,undef,undef,
+					($env{'environment.remote'} ne 'off'));
 	my $html=&Apache::lonxml::xmlbegin();
-	$result.=$html.$bodytag.
+	my $head="<head><title>EditXML $file</title>".
+	    &Apache::edit::js_change_detection()."</head>";
+
+	$result.=$html.$head.$bodytag.
 	    &renderpage($request,$file,['no_output_web'],1).
 	    &Apache::lonxml::message_location().'
-            <form name="lonhomework" method="POST" action="'.
+            <form '.&Apache::edit::form_change_detection().' name="lonhomework" method="POST" action="'.
 	    &HTML::Entities::encode($env{'request.uri'},'<>&"').'">'.
 	    &Apache::structuretags::remember_problem_state().'
             <input type="hidden" name="problemmode" value="'.&mt('EditXML').'" />
             <input type="submit" name="problemmode" accesskey="d" value="'.&mt('Discard Edits and View').'" />
             <input type="submit" name="problemmode" accesskey="e" value="'.&mt('Edit').'" />
+            <input type="submit" name="Undo" accesskey="u" value="'.&mt('undo').'" />
             <hr />
             <input type="submit" name="submit" accesskey="s" value="'.&mt('Submit Changes').'" />
             <input type="submit" name="submit" accesskey="v" value="'.&mt('Submit Changes and View').'" />
-            <input type="submit" name="Undo" accesskey="u" value="'.&mt('undo').'" />
             <hr />
             ' . $xml_help . '
-            <textarea style="width:100%" rows="'.$rows.'" cols="'.$cols.'" name="editxmltext">'.
-	    &HTML::Entities::encode($problem,'<>&"').'</textarea>
+            <textarea '.&Apache::edit::element_change_detection().' style="width:100%" rows="'.$rows.'" cols="'.$cols.'" name="editxmltext">'.
+	    &HTML::Entities::encode($problem,'<>&"').'</textarea><br />
+            <input type="submit" name="submit" accesskey="s" value="'.&mt('Submit Changes').'" />
+            <input type="submit" name="submit" accesskey="v" value="'.&mt('Submit Changes and View').'" />
             </form></body></html>';
 	&Apache::lonxml::add_messages(\$result);
 	$request->print($result);
@@ -759,8 +806,10 @@ sub renderpage {
 	    $target = 'web'; $output=0;
 	}
 	my $problem=&Apache::lonnet::getfile($file);
+	my $result;
 	if ($problem eq -1) {
-	    &Apache::lonxml::error("<b> ".&mt('Unable to find')." <i>$file</i></b>");
+	    my $filename=(split('/',$file))[-1];
+	    $result.="<b> ".&mt('Unable to find')." <i>$filename</i></b>";
 	    $problem='';
 	}
 
@@ -770,10 +819,10 @@ sub renderpage {
 	if ($target eq 'web') {&Apache::lonhomework::showhashsubset(\%env,'^form');}
 
 	&Apache::lonxml::debug("Should be parsing now");
-	my $result = &Apache::lonxml::xmlparse($request, $target, $problem,
-					       &setup_vars($target),%mystyle);
+	$result .= &Apache::lonxml::xmlparse($request, $target, $problem,
+					     &setup_vars($target),%mystyle);
 	undef($Apache::lonhomework::parsing_a_problem);
-	if (!$output) { $result = '';&Apache::lonxml::message_location().'c'; }
+	if (!$output) { $result = ''; }
 	#$request->print("Result follows:");
 	if ($target eq 'modified') {
 	    &handle_save_or_undo($request,\$problem,\$result);
@@ -910,7 +959,7 @@ EDITMENU
 sub handler {
     #my $t0 = [&gettimeofday()];
     my $request=$_[0];
-    
+    $Apache::lonxml::request=$request;
     $Apache::lonxml::debug=$env{'user.debug'};
     $env{'request.uri'}=$request->uri;
     &setuppermissions();
@@ -930,10 +979,6 @@ sub handler {
 	if ($Apache::lonhomework::browse ne 'F' && 
 	    $env{'request.state'} ne "construct") {
 	    #should know where we are, so ask
-	    if ( &Apache::lonnet::mod_perl_version() == 2 ) {
-		&Apache::lonnet::cleanenv();
-	    }
-	    &Apache::lonnet::logthis(&Apache::lonnet::mod_perl_version());
 	    $request->internal_redirect('/adm/ambiguous'); return OK;
 	}
     }