--- loncom/homework/lonhomework.pm 2001/01/06 15:32:22 1.25 +++ loncom/homework/lonhomework.pm 2001/02/07 00:29:30 1.36 @@ -12,24 +12,27 @@ use Apache::inputtags; use Apache::structuretags; use Apache::response; use Apache::hint; -use Apache::Constants(:common); +use Apache::outputtags; +use Apache::Constants qw(:common); sub get_target { if ( $ENV{'request.state'} eq "published") { - if ( defined $ENV{'form.submit'}) { + if ( defined $ENV{'form.submitted'}) { return ('grade', 'web'); } else { return ('web'); } } elsif ($ENV{'request.state'} eq "construct") { if ( defined $ENV{'form.preview'}) { - if ( defined $ENV{'form.submit'}) { + if ( defined $ENV{'form.submitted'}) { return ('grade', 'web'); } else { return ('web'); } } else { - return ('edit'); + #return ('edit'); + #edit is currently broken + return ('web'); } } return (); @@ -48,14 +51,23 @@ sub send_header { # $request->print('
'); } +sub createmenu { + my ($which,$request)=@_; + if ($which eq 'grade') { + $request->print(''); + } +} + sub send_footer { my ($request)= @_; # $request->print('
'); $request->print(&Apache::lontexconvert::footer()); } -#@Apache::lonhomework::date_status=(); -#@Apache::lonhomework::date_msg=(); +$Apache::lonxml::browse=''; sub check_date { my ($id) = @_; my $date =''; @@ -72,6 +84,8 @@ sub check_date { &Apache::lonxml::debug("found :$date: for :$temp:"); if ($date eq '') { $date = "an unknown date"; $passed = 0; + } elsif ($date eq 'con_lost') { + $date = "an indeterminate date"; $passed = 0; } else { if (time < $date) { $passed = 0; } else { $passed = 1; } $date = localtime $date; @@ -90,9 +104,22 @@ sub check_date { $datemsg = "is due at $date"; } elsif ($type eq 'answerdate') { $status='CLOSED'; - $datemsg = "was due as $lastdate, and answers will be available at $date"; + $datemsg = "was due on $lastdate, and answers will be available on $date"; + } + if ($status eq 'CAN_ANSWER') { + #check #tries + my $tries = $Apache::lonhomework::history{"resource.$id.tries"}; + my $maxtries = &Apache::lonnet::EXT("resource.$id.maxtries"); + if ( $tries eq '' ) { $tries = '0'; } + if ( $maxtries eq '' ) { $maxtries = '2'; } + if ($tries >= $maxtries) { $status = 'CANNOT_ANSWER'; } } &Apache::lonxml::debug("sending back :$status:$datemsg:"); + if (($Apache::lonhomework::browse eq 'F') && ($status eq 'CLOSED')) { + &Apache::lonxml::debug("should be allowed to browse a resource when closed"); + $status='CAN_ANSWER'; + $datemsg='is closed but you are allowed to view it'; + } if ($ENV{'request.state'} eq "construct") { &Apache::lonxml::debug("in construction ignoring dates"); $status='CAN_ANSWER'; @@ -104,7 +131,7 @@ sub check_date { sub handler { my $request=$_[0]; - if ( $ENV{'user.name'} eq 'albertel' ) { $Apache::lonxml::debug=1; } + if ( $ENV{'user.name'} eq 'albertel' ) {$Apache::lonxml::debug=1;} else {$Apache::lonxml::debug=0;} my (@targets) = &get_target(); @@ -115,11 +142,23 @@ sub handler { } $request->send_http_header; return OK if $request->header_only; - + + #setup permissions + $Apache::lonhomework::browse= &Apache::lonnet::allowed('bre'); + $Apache::lonhomework::viewgrades=&Apache::lonnet::allowed('vgr'); + &Apache::lonxml::debug("Permissions:$Apache::lonhomework::browse:$Apache::lonhomework::viewgrades:"); + + #check if we know where we are + if ($ENV{'request.course.fn'} && !&Apache::lonnet::symbread()) { + # if we are browsing we might not be able to know where we are + if ($Apache::lonhomework::browse ne 'F') { + #should know where we are, so ask + $request->internal_redirect('/adm/ambiguous'); return; + } + } + &Apache::lonhomework::send_header($request); - #check if allowed to see - foreach my $target (@targets) { my $file=&Apache::lonnet::filelocation("",$request->uri); my $problem=&Apache::lonnet::getfile($file); @@ -136,8 +175,15 @@ sub handler { #ignore error conditions my ($temp)=keys %Apache::lonhomework::history ; if ($temp =~ m/^error:.*/) { %Apache::lonhomework::history=(); } - if ($target eq 'web' && &Apache::lonnet::symbread() eq '') { - $request->print("Vieiwing this problem as not a student, submissions will be ignored."); + if ($target eq 'web') { + if (&Apache::lonnet::symbread() eq '') { + if ($ENV{'request.state'} eq "construct") { + $request->print("In construction space, submissions ignored
"); + } else { + $request->print("Browsing or ambiguous reference, submissions ignored
"); + } + } + if ($Apache::lonhomework::viewgrades eq 'F') {&createmenu('grade',$request); } } if ($target eq 'grade') { my $resultkey; @@ -151,11 +197,6 @@ sub handler { &Apache::lonxml::error("Unable to find default_homework.lcpm"); $default=''; } - if ( $target eq 'grade') { - $Apache::lonxml::textredirection = 0; - } else { - $Apache::lonxml::textredirection = 1; - } $result = &Apache::lonxml::xmlparse($target, $problem, $default.&setup_vars($target),%mystyle); @@ -163,6 +204,7 @@ sub handler { $request->print($result); #$request->print(":Result ends"); if ($target eq 'grade') { + my $resultkey; foreach $resultkey (sort keys %Apache::lonhomework::results) { &Apache::lonxml::debug("$resultkey ---- $Apache::lonhomework::results{$resultkey}");