--- loncom/homework/lonhomework.pm	2001/01/11 15:25:46	1.32
+++ loncom/homework/lonhomework.pm	2001/02/13 18:42:06	1.37
@@ -17,14 +17,14 @@ use Apache::Constants qw(:common);
 
 sub get_target {
   if ( $ENV{'request.state'} eq "published") {
-    if ( defined $ENV{'form.submit'}) {
+    if ( defined $ENV{'form.submitted'}) {
       return ('grade', 'web');
     } else {
       return ('web');
     }
   } elsif ($ENV{'request.state'} eq "construct") {
     if ( defined $ENV{'form.preview'}) {
-      if ( defined $ENV{'form.submit'}) {
+      if ( defined $ENV{'form.submitted'}) {
 	return ('grade', 'web');
       } else {
 	return ('web');
@@ -51,14 +51,23 @@ sub send_header {
 #  $request->print('<form name='.$ENV{'form.request.prefix'}.'lonhomework method="POST" action="'.$request->uri.'">');
 }
 
+sub createmenu {
+  my ($which,$request)=@_;
+  if ($which eq 'grade') {
+    $request->print('<script language="JavaScript"> 
+          hwkmenu=window.open("/res/adm/pages/homeworkmenu.html","LONCAPAhomeworkmenu",
+                 "height=350,width=150,menubar=no");
+          </script>');
+  }
+}
+
 sub send_footer {
   my ($request)= @_;
 #  $request->print('</form>');
   $request->print(&Apache::lontexconvert::footer());
 }
 
-#@Apache::lonhomework::date_status=();
-#@Apache::lonhomework::date_msg=();
+$Apache::lonxml::browse='';
 sub check_date {
   my ($id) = @_;
   my $date ='';
@@ -106,6 +115,11 @@ sub check_date {
     if ($tries >= $maxtries) { $status = 'CANNOT_ANSWER'; } 
   }
   &Apache::lonxml::debug("sending back :$status:$datemsg:");
+  if (($Apache::lonhomework::browse eq 'F') && ($status eq 'CLOSED')) {
+    &Apache::lonxml::debug("should be allowed to browse a resource when closed");
+    $status='CAN_ANSWER';
+    $datemsg='is closed but you are allowed to view it';
+  }
   if ($ENV{'request.state'} eq "construct") {
     &Apache::lonxml::debug("in construction ignoring dates");
     $status='CAN_ANSWER';
@@ -116,8 +130,8 @@ sub check_date {
 
 sub handler {
   my $request=$_[0];
-
-  if ( $ENV{'user.name'} eq 'albertel' ) { $Apache::lonxml::debug=1; }
+  
+ if ( $ENV{'user.name'} eq 'albertel' ) {$Apache::lonxml::debug=1;} else {$Apache::lonxml::debug=0;}
   
   my (@targets) = &get_target();
 
@@ -128,11 +142,23 @@ sub handler {
   }
   $request->send_http_header;
   return OK if $request->header_only;
-  
+
+  #setup permissions
+  $Apache::lonhomework::browse= &Apache::lonnet::allowed('bre',$ENV{'request.filename'});
+  $Apache::lonhomework::viewgrades=&Apache::lonnet::allowed('vgr',$ENV{'request.course.id'});
+  &Apache::lonxml::debug("Permissions:$Apache::lonhomework::browse:$Apache::lonhomework::viewgrades:");
+
+  #check if we know where we are
+  if ($ENV{'request.course.fn'} && !&Apache::lonnet::symbread()) { 
+    # if we are browsing we might not be able to know where we are
+    if ($Apache::lonhomework::browse ne 'F') {
+      #should know where we are, so ask
+      $request->internal_redirect('/adm/ambiguous'); return; 
+    }
+  }
+
   &Apache::lonhomework::send_header($request);
   
-  #check if allowed to see
-  
   foreach my $target (@targets) {
     my $file=&Apache::lonnet::filelocation("",$request->uri);
     my $problem=&Apache::lonnet::getfile($file);
@@ -149,8 +175,15 @@ sub handler {
     #ignore error conditions
     my ($temp)=keys %Apache::lonhomework::history ;
     if ($temp =~ m/^error:.*/) { %Apache::lonhomework::history=(); } 
-    if ($target eq 'web' && &Apache::lonnet::symbread() eq '') {
-      $request->print("Vieiwing this problem as not a student, submissions will be ignored.");
+    if ($target eq 'web') {
+      if (&Apache::lonnet::symbread() eq '') {
+	if ($ENV{'request.state'} eq "construct") {
+	  $request->print("In construction space, submissions ignored<br>");
+	} else {
+	  $request->print("Browsing or <a href=\"/adm/ambiguous\">ambiguous</a> reference, submissions ignored<br>");
+	}
+      }
+      if ($Apache::lonhomework::viewgrades eq 'F') {&createmenu('grade',$request); }
     }
     if ($target eq 'grade') {
       my $resultkey;