--- loncom/homework/lonhomework.pm	2019/02/19 15:38:36	1.344.2.8.4.3
+++ loncom/homework/lonhomework.pm	2016/08/31 19:08:18	1.364
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # The LON-CAPA Homework handler
 #
-# $Id: lonhomework.pm,v 1.344.2.8.4.3 2019/02/19 15:38:36 raeburn Exp $
+# $Id: lonhomework.pm,v 1.364 2016/08/31 19:08:18 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -49,8 +49,10 @@ use Apache::matchresponse();
 use Apache::chemresponse();
 use Apache::functionplotresponse();
 use Apache::drawimage();
+use Apache::loncapamath();
 use Apache::Constants qw(:common);
 use Apache::loncommon();
+use Apache::lonparmset();
 use Apache::lonlocal;
 use Time::HiRes qw( gettimeofday tv_interval );
 use HTML::Entities();
@@ -219,8 +221,41 @@ sub check_slot_access {
 	return ($status,$datemsg);
     }
 
-    if ($status eq 'SHOW_ANSWER' ||
-	$status eq 'CLOSED' ||
+    my $checkin = 'resource.0.checkedin';
+    my $version;
+    if ($type eq 'Task') {
+        $version=$Apache::lonhomework::history{'resource.version'};
+        $checkin = "resource.$version.0.checkedin";
+    }
+    my $checkedin = $Apache::lonhomework::history{$checkin};
+    my ($returned_slot,$slot_name,$checkinslot,$ipused,$blockip,$now,$ip,
+        $consumed_uniq);
+    $now = time;
+    $ip=$ENV{'REMOTE_ADDR'} || $env{'request.host'};
+
+    if ($checkedin) {
+        $checkinslot = $Apache::lonhomework::history{"$checkin.slot"};
+        my %slot=&Apache::lonnet::get_slot($checkinslot);
+        $consumed_uniq = $slot{'uniqueperiod'};
+        if ($slot{'iptied'}) {
+            $ipused = $Apache::lonhomework::history{"$checkin.ip"};
+            unless (($ip ne '') && ($ipused eq $ip)) {
+                $blockip = $slot{'iptied'};
+                $slot_name = $checkinslot;
+                $returned_slot = \%slot;
+            }
+        }
+    }
+
+    if ($status eq 'SHOW_ANSWER') {
+        if ($blockip eq 'answer') {
+            return ('NEED_DIFFERENT_IP','',$slot_name,$returned_slot,$ipused);
+        } else {
+            return ($status,$datemsg);
+        }
+    } 
+
+    if ($status eq 'CLOSED' ||
 	$status eq 'INVALID_ACCESS' ||
 	$status eq 'UNAVAILABLE') {
 	return ($status,$datemsg);
@@ -230,11 +265,14 @@ sub check_slot_access {
     }
     
     if ($type eq 'Task') {
-	my $version=$Apache::lonhomework::history{'resource.version'};
-	if ($Apache::lonhomework::history{"resource.$version.0.checkedin"} &&
+	if ($checkedin &&
 	    $Apache::lonhomework::history{"resource.$version.0.status"} eq 'pass') {
-	    return ('SHOW_ANSWER');
-	}
+	    if ($blockip eq 'answer') {
+                return ('NEED_DIFFERENT_IP','',$slot_name,$returned_slot,$ipused);
+            } else {
+	        return ('SHOW_ANSWER');
+            }
+        }
     }
 
     my $availablestudent = &Apache::lonnet::EXT("resource.0.availablestudent",$symb);
@@ -244,11 +282,11 @@ sub check_slot_access {
 #    if (!@slots) {
 #	return ($status,$datemsg);
 #    }
+    undef($returned_slot);
+    undef($slot_name);
     my $slotstatus='NOT_IN_A_SLOT';
-    my ($returned_slot,$slot_name);
-    my $now = time;
     my $num_usable_slots = 0;
-    unless ($symb) {
+    if (!$symb) {
         ($symb) = &Apache::lonnet::whichuser();
     }
     foreach my $slot (@slots) {
@@ -260,13 +298,42 @@ sub check_slot_access {
         $num_usable_slots ++;
 	if ($slot{'starttime'} < $now &&
 	    $slot{'endtime'} > $now &&
-	    &Apache::loncommon::check_slotip_acc($slot{'ip'})) {
-	    &Apache::lonxml::debug("$slot is good");
-	    $slotstatus='NEEDS_CHECKIN';
-	    $returned_slot=\%slot;
-	    $slot_name=$slot;
-	    last;
-        } 
+	    &Apache::loncommon::check_ip_acc($slot{'ip'})) {
+            if ($slot{'iptied'}) {
+                if ($env{'request.course.id'}) {
+                    my $cdom = $env{'course.'.$env{'request.course.id'}.'.domain'};
+                    my $cnum = $env{'course.'.$env{'request.course.id'}.'.num'};
+                    if ($slot eq $checkinslot) {
+                        if ($ip eq $ipused) {
+                            &Apache::lonxml::debug("$slot is good");
+                            $slotstatus ='NEEDS_CHECKIN'; 
+                        } else {
+                            $slotstatus = 'NEED_DIFFERENT_IP';
+                            $slot_name = $slot;
+                            $returned_slot = \%slot;
+                            last;
+                        }
+                    } elsif ($ip) {
+                        my $uniqkey = "$slot\0$symb\0$ip";
+                        my %used_ip = &Apache::lonnet::get('slot_uniqueips',[$uniqkey],$cdom,$cnum);
+                        if ($used_ip{$uniqkey}) {
+                            $slotstatus = 'NEED_DIFFERENT_IP';
+                        } else {
+                            &Apache::lonxml::debug("$slot is good");
+                            $slotstatus ='NEEDS_CHECKIN';
+                        }
+                    }
+                }
+            } else {
+	        &Apache::lonxml::debug("$slot is good");
+	        $slotstatus='NEEDS_CHECKIN';
+            }
+            if ($slotstatus eq 'NEEDS_CHECKIN') {
+	        $returned_slot=\%slot;
+	        $slot_name=$slot;
+	        last;
+            }
+        }
     }
     if ($slotstatus eq 'NEEDS_CHECKIN' &&
 	&proctor_checked_in($slot_name,$returned_slot,$type)) {
@@ -274,28 +341,16 @@ sub check_slot_access {
 	$slotstatus=$status;
     }
 
-    my ($is_correct,$got_grade,$checkin,$checkinslot,$checkedin,$consumed_uniq);
+    my ($is_correct,$got_grade);
     if ($type eq 'Task') {
 	my $version=$Apache::lonhomework::history{'resource.0.version'};
-        $checkin = "resource.$version.0.checkedin";
 	$got_grade = 
 	    ($Apache::lonhomework::history{"resource.$version.0.status"} 
 	     =~ /^(?:pass|fail)$/);
 	$is_correct =  
 	    ($Apache::lonhomework::history{"resource.$version.0.status"} eq 'pass'
 	     || $Apache::lonhomework::history{"resource.0.solved"} =~ /^correct_/ );
-	$checkedin =
-	    $Apache::lonhomework::history{"resource.$version.0.checkedin"};
     } elsif ($type eq 'problem') {
-        $checkin = 'resource.0.checkedin';
-	$checkedin  = $Apache::lonhomework::history{$checkin};
-    }
-    if ($checkedin) {
-        $checkinslot = $Apache::lonhomework::history{"$checkin.slot"};
-        my %slot=&Apache::lonnet::get_slot($checkinslot);
-        $consumed_uniq = $slot{'uniqueperiod'};
-    }
-    if ($type eq 'problem') {
         if ((ref($partlist) eq 'ARRAY') && (@{$partlist} > 0)) {
             my ($numcorrect,$numgraded) = (0,0);
             foreach my $part (@{$partlist}) {
@@ -304,7 +359,7 @@ sub check_slot_access {
                 my $probstatus = &Apache::structuretags::get_problem_status($part);
                 my $earlyout;
                 unless (($probstatus eq 'no') ||
-                        ($probstatus eq 'no_feedback_ever')) {
+                        ($probstatus eq 'no_feedback_ever')) { 
                     if ($Apache::lonhomework::history{"resource.$part.solved"} =~/^correct_/) {
                         $numcorrect ++;
                     } else {
@@ -313,7 +368,7 @@ sub check_slot_access {
                 }
                 if (($currtries == $maxtries) || ($is_correct)) {
                     $earlyout = 1;
-                } else {
+                } else { 
                     $numgraded ++;
                 }
                 last if ($earlyout);
@@ -354,13 +409,16 @@ sub check_slot_access {
     # However, the problem is not closed, and potentially, another slot might be
     # used to gain access to it to work on it, until the due date is reached, and the
     # problem then becomes CLOSED.  Therefore return the slotstatus - 
-    # (which will be one of: NOT_IN_A_SLOT, RESERVABLE, RESERVABLE_LATER, or NOTRESERVABLE.
+    # (which will be one of: NOT_IN_A_SLOT, RESERVABLE, RESERVABLE_LATER, or NOTRESERVABLE).
     if (!defined($slot_name) && $type eq 'problem') {
         if ($slotstatus eq 'NOT_IN_A_SLOT') {
             if (!$num_usable_slots) {
                 if ($env{'request.course.id'}) {
                     my $cdom = $env{'course.'.$env{'request.course.id'}.'.domain'};
                     my $cnum = $env{'course.'.$env{'request.course.id'}.'.num'};
+                    unless ($symb) {
+                        ($symb)=&Apache::lonnet::whichuser();
+                    }
                     $slotstatus = 'NOTRESERVABLE';
                     my ($reservable_now_order,$reservable_now,$reservable_future_order,
                         $reservable_future) = 
@@ -431,14 +489,18 @@ sub check_slot_access {
 	&& $checkedin ) {
 
 	if ($got_grade) {
-	    return ('SHOW_ANSWER');
+            if ($blockip eq 'answer') {
+                return ('NEED_DIFFERENT_IP','',$slot_name,$returned_slot,$ipused);
+            } else {
+	        return ('SHOW_ANSWER');
+            }
 	} else {
 	    return ('WAITING_FOR_GRADE');
 	}
 
     }
 
-    if ( $is_correct) {
+    if (($is_correct) && ($blockip ne 'answer')) {
 	if ($type eq 'problem') {
 	    return ($status);
 	}
@@ -446,11 +508,11 @@ sub check_slot_access {
     }
 
     if ( $status eq 'CANNOT_ANSWER' && 
-	 ($slotstatus ne 'NEEDS_CHECKIN' && $slotstatus ne 'NOT_IN_A_SLOT')) {
+	 ($slotstatus ne 'NEEDS_CHECKIN' && $slotstatus ne 'NOT_IN_A_SLOT' &&
+          $slotstatus ne 'NEED_DIFFERENT_IP') ) {
 	return ($status,$datemsg);
     }
-
-    return ($slotstatus,$datemsg,$slot_name,$returned_slot);
+    return ($slotstatus,$datemsg,$slot_name,$returned_slot,$ipused);
 }
 
 # JB, 9/24/2002: Any changes in this function may require a change
@@ -582,15 +644,16 @@ sub check_access {
     if ($status eq 'CAN_ANSWER' || $status eq 'CANNOT_ANSWER') {
 	my @interval=&Apache::lonnet::EXT("resource.$id.interval",$symb);
 	&Apache::lonxml::debug("looking for interval @interval");
-	if ($interval[0]) {
+	if ($interval[0]=~ /^\d+/) {
 	    my $first_access=&Apache::lonnet::get_first_access($interval[1],$symb);
 	    &Apache::lonxml::debug("looking for accesstime $first_access");
 	    if (!$first_access) {
 		$status='NOT_YET_VIEWED';
 		my $due_date = &due_date($id,$symb);
 		my $seconds_left = $due_date - time;
-		if ($seconds_left > $interval[0] || $due_date eq '') {
-		    $seconds_left = $interval[0];
+		my ($timelimit) = ($interval[0] =~ /^(\d+)/);
+		if ($seconds_left > $timelimit || $due_date eq '') {
+		    $seconds_left = $timelimit;
 		}
 		$datemsg=&seconds_to_human_length($seconds_left);
 	    }
@@ -625,7 +688,8 @@ sub due_date {
 	my $first_access=&Apache::lonnet::get_first_access($interval[1],$symb);
 	&Apache::lonxml::debug("looking for first_access $first_access ($interval[1])");
 	if (defined($first_access)) {
-	    my $interval = $first_access+$interval[0];
+	    my ($timelimit) = ($interval[0] =~ /^(\d+)/);
+	    my $interval = $first_access+$timelimit;
 	    $date = (!$due_date || $interval < $due_date) ? $interval
                                                           : $due_date;
 	} else {
@@ -861,7 +925,7 @@ sub analyze_header {
        .&Apache::loncommon::head_subbox(
                 &Apache::loncommon::CSTR_pageheader());
     $result .= 
-            '<form name="lonhomework" method="post" action="'.
+	    '<form name="lonhomework" method="post" action="'.
 	    &HTML::Entities::encode($env{'request.uri'},'<>&"').'">'.
             '<input type="hidden" name="problemmode" value="'.
             $env{'form.problemmode'}.'" />'.
@@ -876,8 +940,8 @@ sub analyze_header {
             'onclick="javascript:setmode(this.form,'."'view'".')" />
             <hr />
             </div>'
-            .&Apache::lonxml::message_location().'
-            </form>';
+            .&Apache::lonxml::message_location().
+            '</form>';
     &Apache::lonxml::add_messages(\$result);
     $request->print($result);
     $request->rflush();
@@ -1056,9 +1120,8 @@ sub editxmlmode {
 
 	$problem='';
     }
-
     if (($env{'form.problemmode'} eq 'saveeditxml') ||
-        ($env{'form.problemmode'} eq 'saveviewxml') || 
+        ($env{'form.problemmode'} eq 'saveviewxml') ||
         ($env{'form.problemmode'} eq 'undoxml')) {
 	my $error=&handle_save_or_undo($request,\$problem,
 				       \$env{'form.editxmltext'});
@@ -1107,7 +1170,7 @@ sub editxmlmode {
             <div class="LC_edit_problem_header">
               <div class="LC_edit_problem_header_title">'.
                 &mt('Problem Editing').' '.&Apache::loncommon::help_open_topic('Problem_Editor_XML_Index').
-                '</div><div class="LC_edit_actionbar" id="actionbar">';
+              '</div><div class="LC_edit_actionbar" id="actionbar">';
 
     $result.='<input type="hidden" name="problemmode" value="saveedit" />'.
                   &Apache::structuretags::problem_edit_buttons('editxml');
@@ -1117,27 +1180,27 @@ sub editxmlmode {
 
     unless ($env{'environment.nocodemirror'}) {
         # dropdown menus
-        $result .= Apache::lonmenu::create_submenu("#", "",
+        $result .= Apache::lonmenu::create_submenu("#", "", 
             &mt("Problem Templates"), template_dropdown_datastructure());
 
-        $result .= Apache::lonmenu::create_submenu("#", "",
+        $result .= Apache::lonmenu::create_submenu("#", "", 
             &mt("Response Types"), responseblock_dropdown_datastructure());
 
-        $result .= Apache::lonmenu::create_submenu("#", "",
+        $result .= Apache::lonmenu::create_submenu("#", "", 
             &mt("Conditional Blocks"), conditional_scripting_datastructure());
 
-        $result .= Apache::lonmenu::create_submenu("#", "",
+        $result .= Apache::lonmenu::create_submenu("#", "", 
             &mt("Miscellaneous"), misc_datastructure());
     }
 
-    $result .= Apache::lonmenu::create_submenu("#", "",
+    $result .= Apache::lonmenu::create_submenu("#", "", 
         &mt("Help") . ' <img src="/adm/help/help.png" alt="' . &mt("Help") .
-        '" style="vertical-align:text-bottom; height: auto; margin:0; "/>',
+        '" style="vertical-align:text-bottom; height: auto; margin:0; "/>', 
         helpmenu_datastructure(),"");
 
     $result.="</ol></div>";
-
-    $result .= '</div></div>' .
+         
+    $result .= '</div></div>' . 
         &Apache::lonxml::message_location() .
         &Apache::loncommon::xmleditor_js() .
         '<textarea ' . &Apache::edit::element_change_detection() .
@@ -1173,7 +1236,7 @@ sub editxmlmode {
                 autoCloseBrackets: true,
                 height: "auto",
                 styleActiveLine: true,
-
+                
                 extraKeys: {
                     "Tab": "indentMore",
                     "Shift-Tab": "indentLess",
@@ -1194,7 +1257,7 @@ sub editxmlmode {
 #    Render the page in whatever target desired.
 #
 sub renderpage {
-    my ($request,$file,$targets,$return_string) = @_;
+    my ($request,$file,$targets,$return_string,$donebuttonmsg) = @_;
 
     my @targets = @{$targets || [&get_target()]};
     &Apache::lonhomework::showhashsubset(\%env,'form.');
@@ -1220,8 +1283,10 @@ sub renderpage {
 	    $problem='';
 	    my $filename=(split('/',$file))[-1];
 	    my $error =
-                &mt('Unable to find [_1]',
-			   '<span class="LC_filename">'.$filename.'</span>');
+		'<p class="LC_error">'
+               .&mt('Unable to find [_1]',
+			   '<span class="LC_filename">'.$filename.'</span>')
+		."</p>";
 	    $result.=
 		&Apache::loncommon::simple_error_page($request,'Not available',
 						      $error,{'no_auto_mt_msg' => 1});
@@ -1245,7 +1310,12 @@ sub renderpage {
 	    if ($target eq 'analyze') {
 		$result=&Apache::lonnet::hashref2str(\%Apache::lonhomework::analyze);
 		undef(%Apache::lonhomework::analyze);
-	    }
+	    } elsif ($target eq 'web') {
+                if ($donebuttonmsg) {
+                    $result =~ s{</body>}{};
+                    $result.= &Apache::loncommon::confirmwrapper(&Apache::lonhtmlcommon::confirm_success($donebuttonmsg,1))."\n</body>";
+                }
+            }
 	    #my $td=&tv_interval($t0);
 	    #if ( $Apache::lonxml::debug) {
 	    #$result =~ s:</body>::;
@@ -1272,21 +1342,20 @@ sub finished_parsing {
     undef($Apache::lonhomework::parsing_a_task);
 }
 
-
 # function extracted from get_template_html
 # returns "key" -> list
 # key: path of template
 # value 1: title
 # value 2: category
 # value 3: name of help topic ???
-sub get_template_list {
+sub get_template_list{
     my ($extension) = @_;
-
+    
     my @files = glob($Apache::lonnet::perlvar{'lonIncludes'}.
-		     '/templates/*.'.$extension);
+                     '/templates/*.'.$extension);
     @files = map {[$_,&mt(&Apache::lonnet::metadata($_, 'title')),
                       (&Apache::lonnet::metadata($_, 'category')?&mt(&Apache::lonnet::metadata($_, 'category')):&mt('Miscellaneous')),
-                     &mt(&Apache::lonnet::metadata($_, 'help'))]} (@files);
+                      &mt(&Apache::lonnet::metadata($_, 'help'))]} (@files);
     @files = sort {$a->[2].$a->[1] cmp $b->[2].$b->[1]} (@files);
     return @files;
 }
@@ -1298,7 +1367,7 @@ sub get_template_html {
     &Apache::lonxml::debug("Looking for :$extension:");
     my $glob_extension  = $extension;
     if ($extension eq 'survey' || $extension eq 'exam') {
-        $glob_extension = 'problem';
+	$glob_extension = 'problem';
     }
     my @files = &get_template_list($extension);
     my ($midpoint,$seconddiv,$numfiles);
@@ -1362,39 +1431,18 @@ sub get_template_html {
 sub newproblem {
     my ($request) = @_;
 
-    if ($env{'form.mode'} eq 'blank'){
+	if ($env{'form.mode'} eq 'blank'){
         my $dest = &Apache::lonnet::filelocation("",$request->uri);
-        my $templatefilename =
-            $request->dir_config('lonIncludes').'/templates/blank.problem';
-        &File::Copy::copy($templatefilename,$dest);
+        &File::Copy::copy('/home/httpd/html/res/adm/includes/templates/blank.problem',$dest);
         &renderpage($request,$dest);
         return;
     }
-    my $errormsg;
     if ($env{'form.template'}) {
-        my $file;
-        my ($extension) = ($env{'form.template'} =~ /\.(\w+)$/);
-        if ($extension) {
-            my @files = &get_template_list($extension);
-            foreach my $poss (@files) {
-                if (ref($poss) eq 'ARRAY') {
-                    if ($env{'form.template'} eq $poss->[0]) {
-                        $file = $env{'form.template'};
-                        last;
-                    }
-                }
-            }
-            if ($file) {
-                my $dest = &Apache::lonnet::filelocation("",$request->uri);
-                &File::Copy::copy($file,$dest);
-                &renderpage($request,$dest);
-                return;
-            } else {
-                $errormsg = '<p class="LC_error">'.&mt('Invalid template file.').'</p>';
-            }
-        } else {
-            $errormsg = '<p class="LC_error">'.&mt('Invalid template file; template needs to be a .problem, .library, or .task file.').'</p>';
-        }
+	my $file = $env{'form.template'};
+	my $dest = &Apache::lonnet::filelocation("",$request->uri);
+	&File::Copy::copy($file,$dest);
+	&renderpage($request,$dest);
+	return;
     }
 
     my ($extension) = ($request->uri =~ m/\.(\w+)$/);
@@ -1411,6 +1459,7 @@ sub newproblem {
     } else {
 	my $url=&HTML::Entities::encode($request->uri,'<>&"');
 	my $dest = &Apache::lonnet::filelocation("",$request->uri);
+	my $errormsg;
 	my $instructions;
         my $brcrum = [{'href' => &Apache::loncommon::authorspace($request->uri),
                        'text' => 'Authoring Space'},
@@ -1461,44 +1510,74 @@ sub update_construct_style {
 }
 
 #
-# Sets interval for current user so time left will be zero, either for the entire folder
+# Sets interval for current user so time left will be zero, either for the entire folder 
 # containing the current resource, or just the resource, depending on value of first item
 # in interval array retrieved from EXT("resource.0.interval");
 #
 sub zero_timer {
     my ($symb) = @_;
     my ($hastimeleft,$first_access,$now);
-    my @interval=&Apache::lonnet::EXT("resource.0.interval");
+    my @interval=&Apache::lonnet::EXT("resource.0.interval",$symb);
     if (@interval > 1) {
         if ($interval[1] eq 'course') {
-            return;
+            return ('fail',&mt('Ending of timed events not supported for intervals set course-wide'));
         } else {
             my $now = time;
             my $first_access=&Apache::lonnet::get_first_access($interval[1],$symb);
             if ($first_access > 0) {
-                if ($first_access+$interval[0] > $now) {
-                    my $done_time = $now - $first_access;
-                    my $snum = 1;
-                    if ($interval[1] eq 'map') {
-                        $snum = 2;
+                my ($timelimit,$donesuffix) = split(/_/,$interval[0],2);
+                if ($donesuffix =~ /^done(?:|\:[^\:]+\:)(.*)$/) {
+                    my ($dummy,$proctor,$secret) = split(/_/,$1);
+                    if (($proctor) && ($secret ne '')) {
+                        my $key = $env{'form.LC_interval_done_proctorpass'};
+                        $key =~ s/^\s+//;
+                        $key =~ s/\s+$//;
+                        if ($env{'form.LC_interval_done_proctorpass'} ne $secret) {
+                            return ('fail',
+                                   &mt('Incorrect key entered by proctor')); 
+                        }
+                    }
+                    if ($first_access+$timelimit > $now) {
+                        my $done_time = $now - $first_access;
+                        my $snum = 1;
+                        if ($interval[1] eq 'map') {
+                            $snum = 2;
+                        }
+                        my $result =
+                            &Apache::lonparmset::storeparm_by_symb_inner($symb,'0_interval',
+                                                                         $snum,$done_time,
+                                                                         'date_interval',
+                                                                         $env{'user.name'},
+                                                                         $env{'user.domain'});
+                        if ($result eq '') {
+                            # Record action in "User Notes"
+                            &Apache::lonmsg::store_instructor_comment(
+                                'Pressed Done button for symb:<br />'.$symb,
+                                $env{'user.name'}, $env{'user.domain'});
+                            return ('ok');
+                        } else {
+                            return ('fail',&mt('Error ending timed event: [_1]',$result));
+                        } 
+                    } else {
+                        return ('fail',&mt('Timed event already ended'));
                     }
-                    my $result =
-                        &Apache::lonparmset::storeparm_by_symb_inner($symb,'0_interval',
-                                                                     $snum,$done_time,
-                                                                     'date_interval',
-                                                                     $env{'user.name'},
-                                                                     $env{'user.domain'});
-                    return $result;
+                } else {
+                    return ('fail',&mt('Timed event can not be ended before the time limit'));
                 }
+            } else {
+                return ('fail',&mt('Timer not yet started for this timed event'));
             }
         }
+    } else {
+        return ('fail',&mt('No timer in use'));
     }
-    return;
+    return();
 }
 
 sub handler {
     #my $t0 = [&gettimeofday()];
     my $request=$_[0];
+
     $Apache::lonxml::request=$request;
     $Apache::lonxml::debug=$env{'user.debug'};
     $env{'request.uri'}=$request->uri;
@@ -1507,7 +1586,7 @@ sub handler {
     my $file=&Apache::lonnet::filelocation("",$request->uri);
 
     #check if we know where we are
-    if ($env{'request.course.fn'} && !&Apache::lonnet::symbread('','',1,1)) { 
+    if ($env{'request.course.fn'} && !&Apache::lonnet::symbread('','',1,1)) {
 	# if we are browsing we might not be able to know where we are
 	if ($Apache::lonhomework::browse ne 'F' && 
 	    $env{'request.state'} ne "construct") {
@@ -1521,6 +1600,7 @@ sub handler {
 	&unset_permissions();
 	return OK;
     }
+
     &Apache::lonxml::debug("Permissions:$Apache::lonhomework::browse:$Apache::lonhomework::viewgrades:$Apache::lonhomework::modifygrades:$Apache::lonhomework::queuegrade");
     &Apache::lonxml::debug("Problem Mode ".$env{'form.problemmode'});
     my ($symb) = &Apache::lonnet::whichuser();
@@ -1545,21 +1625,23 @@ sub handler {
 		&renderpage($request,$file);
 	    }
 	} else {
-            &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'},
-                                                    ['mode']);
+		&Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'},
+						    ['mode']);
 	    # requested file doesn't exist in contruction space
 	    &newproblem($request);
 	}
     } else {
         # Set the event timer to zero if the "done button" was clicked.  The button is
-        # part of the LCdoneButton form created in lonmenu.pm
-        if ($symb && $env{'form.LC_interval_done'} eq 'true') {
-            &zero_timer($symb);
+        # part of the doneButton form created in lonmenu.pm
+        my ($donebuttonresult,$donemsg);
+        if ($symb && $env{'form.LC_interval_done'} eq 'true') {  
+            ($donebuttonresult,$donemsg) = &zero_timer($symb);
             undef($env{'form.LC_interval_done'});
+            undef($env{'form.LC_interval_done_proctorpass'});
         }
 	# just render the page normally outside of construction space
 	&Apache::lonxml::debug("not construct");
-	&renderpage($request,$file);
+	&renderpage($request,$file,undef,undef,$donemsg);
     }
     #my $td=&tv_interval($t0);
     #&Apache::lonxml::debug("Spent $td seconds processing");
@@ -1577,7 +1659,7 @@ sub template_dropdown_datastructure {
     my %tmplthash = ();
     # template title => path
     my %tmpltcontent = ();
-
+	
     foreach my $template (@templates){
         # put in hash if the template is not empty
         unless ($template->[1] eq ''){
@@ -1586,9 +1668,9 @@ sub template_dropdown_datastructure {
         }
     }
 
-        my $catList = [];
+	my $catList = [];
     foreach my $cat (sort keys %tmplthash) {
-                my $catItems = [];
+		my $catItems = [];
         foreach my $title (sort @{$tmplthash{$cat}}) {
             my $path = $tmpltcontent{$title}->[0];
             my $code;
@@ -1598,62 +1680,62 @@ sub template_dropdown_datastructure {
             }
             close(FH);
 
-                        if ($code ne '') {
+			if ($code ne '') {				
                 my $href = 'javascript:insertText(\'' . &convert_for_js(&HTML::Entities::encode($code,'<>&"')) . '\')';
-                                my $currItem = [$href, $title, undef];
-                                push @{$catItems}, $currItem;
-                        }
+				my $currItem = [$href, $title, undef];
+				push @{$catItems}, $currItem;
+			}
         }
-                push @{$catList}, [$catItems, $cat, undef];
+		push @{$catList}, [$catItems, $cat, undef];
     }
 
     return $catList;
 }
 
 sub responseblock_dropdown_datastructure {
+	
+	my $mathCat = [
+		[
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_formularesponse())) . "\')", &mt("Formula Response"), undef],
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_functionplotresponse())) . "\')", &mt("Function Plot Response"), undef],
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_mathresponse())) . "\')", &mt("Math Response"), undef],
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_numericalresponse())) . "\')", &mt("Numerical Response"), undef]
+		], 
+		&mt("Math"), 
+		undef
+	];
 
-    my $mathCat = [
-                    [
-                        ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_formularesponse())) . "\')", &mt("Formula Response"), undef],
-                        ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_functionplotresponse())) . "\')", &mt("Function Plot Response"), undef],
-                        ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_mathresponse())) . "\')", &mt("Math Response"), undef],
-                        ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_numericalresponse())) . "\')", &mt("Numerical Response"), undef]
-                    ],
-                    &mt("Math"),
-                    undef
-        ];
-
-    my $miscCat = [
-                    [
+	my $miscCat = [		
+		[
             ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_imageresponse())) . "\')", &mt("Click on Image"), undef],
             ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_customresponse())) . "\')", &mt("Custom Response"), undef],
             ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_externalresponse())) . "\')", &mt("External Response"), undef],
             ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_matchresponse())) . "\')", &mt("Match Two Lists"), undef],
             ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_radiobuttonresponse())) . "\')", &mt("One out of N statements"), undef],
-            ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_optionresponse())) . "\')", &mt("Select from Options"), undef],
-                        ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_rankresponse())) . "\')", &mt("Rank Values"), undef]
-                ],
-                &mt("Miscellaneous"),
-                undef
-        ];
-
-    my $chemCat = [
-                    [
-                        ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_reactionresponse())) . "\')", &mt("Chemical Reaction"), undef],
-                        ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_organicresponse())) . "\')", &mt("Organic Chemical Structure"), undef]
-                     ],
-                     &mt("Chemistry"),
-                     undef
-                   ];
-
-    my $textCat = [
-                    [
-                      ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_stringresponse())) . "\')", &mt("String Response"), undef],
-                      ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_essayresponse())) . "\')", &mt("Essay"), undef]
-                     ],
-                     &mt("Text"),
-                     undef
-                   ];
+            ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_optionresponse())) . "\')", &mt("Select from Options"), undef], 
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_rankresponse())) . "\')", &mt("Rank Values"), undef]
+		],
+		&mt("Miscellaneous"),
+		undef
+	];
+
+	my $chemCat = [
+		[
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_reactionresponse())) . "\')", &mt("Chemical Reaction"), undef],
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_organicresponse())) . "\')", &mt("Organic Chemical Structure"), undef]
+		],
+		&mt("Chemistry"),
+		undef
+	];
+
+	my $textCat = [
+		[
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_stringresponse())) . "\')", &mt("String Response"), undef],
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&Apache::edit::insert_essayresponse())) . "\')", &mt("Essay"), undef]
+		],
+		&mt("Text"),
+		undef
+	];
 
     return [$mathCat, $miscCat, $chemCat, $textCat];
 }
@@ -1668,18 +1750,18 @@ sub conditional_scripting_datastructure
 #TODO translated is currently temporarily here, another solution should be found where the
 # needed string can be retrieved
 
-    my $translatedTag = '
+	my $translatedTag = '
 <translated>
     <lang which="en"></lang>
     <lang which="default"></lang>
 </translated>';
     return [
-             ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode($translatedTag)) . "\')", &mt("Translated Block"), undef],
-             ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&default_xml_tag("block"))) . "\')", &mt("Conditional Block"), undef],
-             ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&default_xml_tag("postanswerdate"))) . "\')", &mt("After Answer Date Block"), undef],
-             ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&default_xml_tag("preduedate"))) . "\')", &mt("Before Due Date Block"), undef],
-             ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&default_xml_tag("solved"))) . "\')", &mt("Block For After Solved"), undef],
-             ["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&default_xml_tag("notsolved"))) . "\')", &mt("Block For When Not Solved"), undef]
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode($translatedTag)) . "\')", &mt("Translated Block"), undef],
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&default_xml_tag("block"))) . "\')", &mt("Conditional Block"), undef],
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&default_xml_tag("postanswerdate"))) . "\')", &mt("After Answer Date Block"), undef],
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&default_xml_tag("preduedate"))) . "\')", &mt("Before Due Date Block"), undef],
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&default_xml_tag("solved"))) . "\')", &mt("Block For After Solved"), undef],
+			["javascript:insertText(\'" . &convert_for_js(&HTML::Entities::encode(&default_xml_tag("notsolved"))) . "\')", &mt("Block For When Not Solved"), undef]
         ];
 }
 
@@ -1698,49 +1780,45 @@ sub misc_datastructure {
 
 # helper routine for the datastructure building subroutines
 sub default_xml_tag {
-    my ($tag) = @_;
-    return "\n<$tag></$tag>";
+	my ($tag) = @_;
+	return "\n<$tag></$tag>";
 }
 
+
 sub helpmenu_datastructure {
 
-    # filename, title, width, height
-    my $helpers = [
-                    ['Problem_LON-CAPA_Functions.hlp', &mt('Script Functions'), 800, 600],
-                    ['Greek_Symbols.hlp', &mt('Greek Symbols'), 500, 600],
-                    ['Other_Symbols.hlp', &mt('Other Symbols'), 500, 600],
-                    ['Authoring_Output_Tags.hlp', &mt('Output Tags'), 800, 600],
-                    ['Authoring_Multilingual_Problems.hlp', &mt('Languages'), 800, 600],
-                   ];
-
-    my $help_structure = [];
-
-    foreach my $count (0..(scalar(@{$helpers})-1)) {
-        my $filename = $helpers->[$count]->[0];
-        my $title = $helpers->[$count]->[1];
-        my $width = $helpers->[$count]->[2];
-        my $height = $helpers->[$count]->[3];
-        if ($width eq '') {
-            $width = 500;
-        }
-        if ($height eq '') {
-            $height = 600;
-        }
-        my $href = &HTML::Entities::encode("javascript:openMyModal('/adm/help/$filename',$width,$height,'yes');");
-        push @{$help_structure}, [$href, $title, undef];
-    }
+	my $width = 500;
+	my $height = 600;
+
+	my $helpers = [
+		['Problem_LON-CAPA_Functions', &mt('Script Functions')],
+		['Greek_Symbols', &mt('Greek Symbols')],
+ 		['Other_Symbols', &mt('Other Symbols')],
+		['Authoring_Output_Tags', &mt('Output Tags')],
+		['Authoring_Multilingual_Problems', 
+			&mt('How to create problems in different languages')]
+	];
+
+	my $help_structure = [];
+
+	foreach my $count (0..(scalar(@{$helpers})-1)) {
+		my $filename = $helpers->[$count]->[0];
+		my $title = $helpers->[$count]->[1];
+		my $href = &HTML::Entities::encode("javascript:openMyModal('/adm/help/$filename.hlp',$width,$height,'yes');");
+		push @{$help_structure}, [$href, $title, undef];
+	}
 
-    return $help_structure;
+	return $help_structure;
 }
 
 # we need substitution to not break javascript code
 sub convert_for_js {
     my $return = shift;
-    $return =~ s|script|ESCAPEDSCRIPT|g;
-    $return =~ s|\\|\\\\|g;
-    $return =~ s|\n|\\r\\n|g;
-    $return =~ s|'|\\'|g;
-    $return =~ s|&#39;|\\&#39;|g;
+        $return =~ s|script|ESCAPEDSCRIPT|g;
+        $return =~ s|\\|\\\\|g;
+        $return =~ s|\n|\\r\\n|g;
+        $return =~ s|'|\\'|g;
+		$return =~ s|&#39;|\\&#39;|g;
     return $return;
 }