--- loncom/homework/lonhomework.pm	2016/09/14 16:13:17	1.365
+++ loncom/homework/lonhomework.pm	2017/01/05 19:39:31	1.367
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # The LON-CAPA Homework handler
 #
-# $Id: lonhomework.pm,v 1.365 2016/09/14 16:13:17 raeburn Exp $
+# $Id: lonhomework.pm,v 1.367 2017/01/05 19:39:31 damieng Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1439,12 +1439,31 @@ sub newproblem {
         &renderpage($request,$dest);
         return;
     }
+    my $errormsg;
     if ($env{'form.template'}) {
-	my $file = $env{'form.template'};
-	my $dest = &Apache::lonnet::filelocation("",$request->uri);
-	&File::Copy::copy($file,$dest);
-	&renderpage($request,$dest);
-	return;
+        my $file;
+        my ($extension) = ($env{'form.template'} =~ /\.(\w+)$/);
+        if ($extension) {
+            my @files = &get_template_list($extension);
+            foreach my $poss (@files) {
+                if (ref($poss) eq 'ARRAY') {
+                    if ($env{'form.template'} eq $poss->[0]) {
+                        $file = $env{'form.template'};
+                        last;
+                    }
+                }
+            }
+            if ($file) {
+	        my $dest = &Apache::lonnet::filelocation("",$request->uri);
+	        &File::Copy::copy($file,$dest);
+	        &renderpage($request,$dest);
+	        return;
+            } else {
+                $errormsg = '<p class="LC_error">'.&mt('Invalid template file.').'</p>';
+            }
+        } else {
+            $errormsg = '<p class="LC_error">'.&mt('Invalid template file; template needs to be a .problem, .library, or .task file.').'</p>';
+        }
     }
 
     my ($extension) = ($request->uri =~ m/\.(\w+)$/);
@@ -1461,7 +1480,6 @@ sub newproblem {
     } else {
 	my $url=&HTML::Entities::encode($request->uri,'<>&"');
 	my $dest = &Apache::lonnet::filelocation("",$request->uri);
-	my $errormsg;
 	my $instructions;
         my $brcrum = [{'href' => &Apache::loncommon::authorspace($request->uri),
                        'text' => 'Authoring Space'},
@@ -1789,16 +1807,15 @@ sub default_xml_tag {
 
 sub helpmenu_datastructure {
 
-	my $width = 500;
-	my $height = 600;
-
+	# filename, title, width, height
 	my $helpers = [
-		['Problem_LON-CAPA_Functions', &mt('Script Functions')],
-		['Greek_Symbols', &mt('Greek Symbols')],
- 		['Other_Symbols', &mt('Other Symbols')],
-		['Authoring_Output_Tags', &mt('Output Tags')],
-		['Authoring_Multilingual_Problems', 
-			&mt('How to create problems in different languages')]
+		['Problem_LON-CAPA_Functions.hlp', &mt('Script Functions'), 800, 600],
+		['Greek_Symbols.hlp', &mt('Greek Symbols'), 500, 600],
+ 		['Other_Symbols.hlp', &mt('Other Symbols'), 500, 600],
+		['Authoring_Output_Tags.hlp', &mt('Output Tags'), 800, 600],
+		['Authoring_Multilingual_Problems.hlp', 
+			&mt('How to create problems in different languages'), 800, 600],
+		['loncapa.html', &mt('Language reference'), 800, 600],
 	];
 
 	my $help_structure = [];
@@ -1806,7 +1823,9 @@ sub helpmenu_datastructure {
 	foreach my $count (0..(scalar(@{$helpers})-1)) {
 		my $filename = $helpers->[$count]->[0];
 		my $title = $helpers->[$count]->[1];
-		my $href = &HTML::Entities::encode("javascript:openMyModal('/adm/help/$filename.hlp',$width,$height,'yes');");
+		my $width = $helpers->[$count]->[2];
+                my $height = $helpers->[$count]->[3];
+		my $href = &HTML::Entities::encode("javascript:openMyModal('/adm/help/$filename',$width,$height,'yes');");
 		push @{$help_structure}, [$href, $title, undef];
 	}