Diff for /loncom/homework/lonmaxima.pm between versions 1.23 and 1.38

version 1.23, 2008/06/14 16:34:54 version 1.38, 2017/06/12 00:22:35
Line 51  sub maximareply { Line 51  sub maximareply {
  print $socket &escape($cmd)."\n";   print $socket &escape($cmd)."\n";
         my $reply=<$socket>;          my $reply=<$socket>;
         chomp($reply);          chomp($reply);
         if ($reply=~/^Incorrect/) { $reply='Error: '.$reply; }          if ($reply=~/^Incorrect/i) { $reply='Error: '.$reply; }
         return &unescape($reply);          return &unescape($reply);
     } else {      } else {
         return 'Error: no connection.';          return 'Error: no connection.';
Line 60  sub maximareply { Line 60  sub maximareply {
   
 sub blacklisted {  sub blacklisted {
     my ($cmd)=@_;      my ($cmd)=@_;
     foreach my $forbidden ('save','load','plot','lisp','includ','compil',      foreach my $forbidden (
    'file','batch','stringout','translat','stout',          '\? ','\?','%i\d+','%o','batch','block'
    'stin','block','system','concat','read','inchar',         ,'compil','concat','describe','display2d','file','inchar'
    'outchar','ttyoff','with_stdout','writefile',         ,'includ','lisp','load','outchar','plot','quit'
    'reset') {         ,'read','reset','save','stin','stout','stringout'
          ,'system','translat','ttyoff','with_stdout','writefile'
        ) {
  if ($cmd=~/$forbidden/s) { return 1; }   if ($cmd=~/$forbidden/s) { return 1; }
     }       } 
     return 0;      return 0;
Line 115  sub runscript { Line 117  sub runscript {
   
 sub maxima_cas_formula_fix {  sub maxima_cas_formula_fix {
    my ($expression)=@_;     my ($expression)=@_;
    return &Apache::response::implicit_multiplication($expression);     $expression=&Apache::response::implicit_multiplication($expression);
      $expression=~s/(^|[^\w\%])pi(\W|$)/$1\%pi$2/gs;
      return $expression;
 }  }
   
 sub maxima_run {  sub maxima_run {
Line 151  sub maxima_eval { Line 155  sub maxima_eval {
   
 sub compareterms {  sub compareterms {
     my ($socket,$terma,$termb)=@_;      my ($socket,$terma,$termb)=@_;
     my $difference=$terma.'-('.$termb.')';      my $difference='('.$terma.')-('.$termb.')';
     if (&blacklisted($difference)) { return 'Error: blacklisted'; }      if (&blacklisted($difference)) { return 'Error: blacklisted'; }
     my $reply=&maximareply($socket,'trigsimp(trigreduce('.$difference.'));');      my $reply=&maximareply($socket,'trigsimp(trigreduce('.$difference.'));');
     if ($reply=~/^\s*0\s*$/) { return 'true'; }      if ($reply=~/^\s*0\s*$/) { return 'true'; }
Line 162  sub compareterms { Line 166  sub compareterms {
 sub maxima_check {  sub maxima_check {
     my ($response,$answer,$reterror) = @_;      my ($response,$answer,$reterror) = @_;
     my $socket=&connect();      my $socket=&connect();
     my $reply=&compareterms($socket,$response,$answer);      my $reply=&maximareply($socket,$response.';');
       unless ($reply=~/^Error\:/) {
           $reply=&compareterms($socket,$response,$answer);
       }
     &disconnect($socket);      &disconnect($socket);
     # integer to string mappings come from capaParser.h      # integer to string mappings come from capaParser.h
     # 1 maps to 'EXACT_ANS'      # 1 maps to 'EXACT_ANS'

Removed from v.1.23  
changed lines
  Added in v.1.38


FreeBSD-CVSweb <freebsd-cvsweb@FreeBSD.org>