--- loncom/homework/matchresponse.pm 2012/12/29 01:21:10 1.87 +++ loncom/homework/matchresponse.pm 2015/01/19 15:35:53 1.92 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # Full matching style response # -# $Id: matchresponse.pm,v 1.87 2012/12/29 01:21:10 raeburn Exp $ +# $Id: matchresponse.pm,v 1.92 2015/01/19 15:35:53 goltermann Exp $ # # Copyright Michigan State University Board of Trustees # @@ -55,7 +55,7 @@ sub start_matchresponse { $result=&Apache::response::meta_package_write('matchresponse'); } elsif ($target eq 'edit' ) { $result.=&Apache::edit::start_table($token). - ''.&Apache::lonxml::description($token).'' + ''.&Apache::loncommon::insert_folding_button().&Apache::lonxml::description($token).'' .''.&mt('Delete?').' ' .&Apache::edit::deletelist($target,$token) .'' @@ -104,15 +104,15 @@ sub start_itemgroup { if ($target eq 'edit') { $result=&Apache::edit::tag_start($target,$token); $result.=&Apache::edit::select_arg('Randomize Order:','randomize', - ['yes','no'],$token).' 'x 3; + ['yes','no'],$token); $result.=&Apache::edit::select_arg('Items Display Location:', 'location', ['top','bottom','left','right'], - $token).' 'x 3; + $token); $result.=&Apache::edit::select_arg('Items Display Direction:', 'direction', ['vertical','horizontal'], - $token).' 'x 3; + $token); $result.=&Apache::edit::select_arg('Items Columns:', 'columns', [['','default'],'1','2','3','4'], @@ -262,7 +262,7 @@ sub start_item { $result=&Apache::edit::tag_start($target,$token,"Item"); $result.=&Apache::edit::text_arg('Name:','name',$token); if ($randomize ne 'no') { - $result.=' 'x 3 . + $result.= &Apache::edit::select_arg('Location:','location', ['random','top','bottom'], $token); @@ -319,7 +319,8 @@ sub start_foilgroup { &Apache::response::pushrandomnumber(undef,$target); if ($target eq 'edit') { $result.=&Apache::edit::start_table($token) - .''.&mt('Collection Of Foils').'' + .''.&Apache::loncommon::insert_folding_button() + .&mt('Collection Of Foils').'' .''.&mt('Delete?') .&Apache::edit::deletelist($target,$token) .'' @@ -580,7 +581,10 @@ sub format_prior_answer { my $output; foreach my $name (@{ $foil_order }) { - my $item=shift(@items); + my $item = &HTML::Entities::encode(shift(@items),'<>&"'); + if ($item eq '') { + $item = ' '; + } $output .= ''.$item.''; } return if (!defined($output)); @@ -652,9 +656,19 @@ sub displayfoils { $newvariation = 1; } } - unless ((($Apache::lonhomework::history{"resource.$part.type"} eq 'anonsurvey') || ($Apache::lonhomework::history{"resource.$part.type"} eq 'anonsurveycred') && (defined($env{'form.grade_symb'}))) || $newvariation) { - $lastresponse=$Apache::lonhomework::history{"resource.$part.$id.submission"}; + unless ($newvariation) { + if ((($env{'form.grade_username'} eq '') && ($env{'form.grade_domain'} eq '')) || + (($env{'form.grade_username'} eq $env{'user.name'}) && + ($env{'form.grade_domain'} eq $env{'user.domain'}))) { + $lastresponse=$Apache::lonhomework::history{"resource.$part.$id.submission"}; + } else { + unless (($Apache::lonhomework::history{"resource.$part.type"} eq 'anonsurvey') || + ($Apache::lonhomework::history{"resource.$part.type"} eq 'anonsurveycred')) { + $lastresponse=$Apache::lonhomework::history{"resource.$part.$id.submission"}; + } + } } + my %lastresponse=&Apache::lonnet::str2hash($lastresponse); my @alphabet=('A'..'Z'); my @used_letters=sort(keys(%letter_name_map));