--- loncom/homework/optionresponse.pm	2001/06/16 18:35:27	1.15
+++ loncom/homework/optionresponse.pm	2001/12/04 14:57:31	1.26
@@ -17,12 +17,22 @@ sub start_optionresponse {
   push (@Apache::lonxml::namespace,'optionresponse');
   my $id = &Apache::response::start_response($parstack,$safeeval);
   if ($target eq 'edit') {
-    $result.=&Apache::edit::start_table($token)."<tr><td>Multiple Option Response Question</td>
-<td>Delete:".
-  &Apache::edit::deletelist($target,$token)
-."</td></tr><tr><td colspan=\"3\">\n";
+    $result.=&Apache::edit::start_table($token).
+      "<tr><td>Multiple Option Response Question</td><td>Delete:".
+	&Apache::edit::deletelist($target,$token)
+	  ."</td><td>&nbsp;</td></tr><tr><td colspan=\"3\">\n";
+    $result.=&Apache::edit::text_arg('Max Number Of Foils:','max',$token,'4').
+      "</td></tr>";
+    $result.="<tr><td colspan=\"3\">\n";
+  }
+  if ($target eq 'modified') {
+    my $constructtag=&Apache::edit::get_new_args($token,$parstack,
+						 $safeeval,'max');
+    if ($constructtag) { $result = &Apache::edit::rebuild_tag($token); }
+  }
+  if ($target eq 'meta') {
+    $result=&Apache::response::meta_package_write('optionresponse');
   }
-
   return $result;
 }
 
@@ -35,14 +45,6 @@ sub end_optionresponse {
   return $result;
 }
 
-sub insert_optionresponse {
-  return '
-<optionresponse max="10">
-    <foilgroup options=\"\">
-    </foilgroup>
-</optionresponse>';
-}
-
 %Apache::response::foilgroup={};
 sub start_foilgroup {
   my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
@@ -56,9 +58,10 @@ sub start_foilgroup {
     my $option;
     my @opt;
     eval '@opt ='. &Apache::lonxml::get_param('options',$parstack,$safeeval);
-    my $count=0;
+    my $count=1;
     foreach $option (@opt) {
       $optionlist.="<option value=\"$count\">$option</option>\n";
+      $count++;
     }
     my $insertlist=&Apache::edit::insertlist($target,$token);
     $result.=&Apache::edit::start_table($token);
@@ -80,7 +83,8 @@ ENDTABLE
     eval '@options ='.&Apache::lonxml::get_param('options',$parstack,$safeeval);
     if ($ENV{"form.$Apache::lonxml::curdepth.deleteopt"}) {
       my $delopt=$ENV{"form.$Apache::lonxml::curdepth.deleteopt"};
-      splice(@options,$delopt,1);
+      &Apache::lonxml::debug("Deleting :$delopt:");
+      splice(@options,$delopt-1,1);
       $optchanged=1;
     }
     if ($ENV{"form.$Apache::lonxml::curdepth.options"}) {
@@ -110,7 +114,7 @@ sub end_foilgroup {
   my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
   
   my $result;
-  if ($target eq 'grade' || $target eq 'web') {
+  if ($target eq 'grade' || $target eq 'web' || $target eq 'answer') {
     my $name;
     my ($count,$max) = &getfoilcounts($parstack,$safeeval);
     if ($count>$max) { $count=$max } 
@@ -119,18 +123,20 @@ sub end_foilgroup {
     eval '@opt ='.&Apache::lonxml::get_param('options',$parstack,$safeeval);
     &Apache::lonxml::debug("Options are $#opt");
     if ($target eq 'web') {
-      $result=&displayfoils($count,@opt);
+      $result.=&displayfoils($count,@opt);
+    } elsif ( $target eq 'answer') {
+      $result.=&displayanswers($count,@opt);
     } elsif ( $target eq 'grade') {
       if ( defined $ENV{'form.submitted'}) {
 	my @whichopt = &whichfoils($count);
 	my $temp=1;my $name;
-	my $allresponse;
+	my %responsehash;
 	my $right=0;
 	my $wrong=0;
 	my $ignored=0;
 	foreach $name (@whichopt) {
 	  my $response = $ENV{'form.HWVAL_'.$Apache::inputtags::response['-1'].":$temp"};
-	  $allresponse.="$response:";
+	  $responsehash{$name}=$response;
 	  if ( $response =~ /[^\s]/) {
 	    &Apache::lonxml::debug("submitted a $response<br />\n");
 	    my $value=$Apache::response::foilgroup{$name.'.value'};
@@ -141,7 +147,7 @@ sub end_foilgroup {
 	  $temp++;
 	}
 	my $id = $Apache::inputtags::response['-1'];
-	$Apache::lonhomework::results{"resource.$Apache::inputtags::part.$id.submission"}=$allresponse;
+	$Apache::lonhomework::results{"resource.$Apache::inputtags::part.$id.submission"}=&Apache::lonnet::hash2str(%responsehash);
 	&Apache::lonxml::debug("Got $right right and $wrong wrong, and $ignored were ignored");
 	if ($wrong==0 && $ignored==0) {
 	  $Apache::lonhomework::results{"resource.$Apache::inputtags::part.$id.awarddetail"}='EXACT_ANS';
@@ -150,8 +156,7 @@ sub end_foilgroup {
 	}
       }
     }
-  }
-  if ($target eq 'edit') {
+  } elsif ($target eq 'edit') {
     $result.=&Apache::edit::end_table();
   }
   return $result;
@@ -180,6 +185,19 @@ sub whichfoils {
   return @whichopt;
 }
 
+sub displayanswers {
+  my ($max,@opt)=@_;
+  my @names = @{ $Apache::response::foilgroup{'names'} };
+  my @whichopt = &whichfoils($max);
+  my $result=&Apache::response::answer_header('optionresponse');
+  foreach my $name (@whichopt) {
+    $result.=&Apache::response::answer_part('optionresponse',
+		     $Apache::response::foilgroup{$name.'.value'})
+  }
+  $result.=&Apache::response::answer_footer('optionresponse');
+  return $result;
+}
+
 sub displayfoils {
   my ($max,@opt)=@_;
   my @names = @{ $Apache::response::foilgroup{'names'} };
@@ -193,7 +211,7 @@ sub displayfoils {
   foreach $option (@opt) {
     $optionlist.="<option>$option</option>\n";
   }
-  if ($Apache::lonhomework::history{"resource.$Apache::inputtags::part.solved"} =~ /^correct/ ) {
+  if (($Apache::lonhomework::history{"resource.$Apache::inputtags::part.solved"} =~ /^correct/)  || ($Apache::inputtags::status[-1] eq  'SHOW_ANSWER')) {
     foreach $name (@whichopt) {
       $result.="<br />".$Apache::response::foilgroup{$name.'.value'}.
 	":".$Apache::response::foilgroup{$name.'.text'}."\n";
@@ -217,10 +235,13 @@ sub start_conceptgroup {
   %Apache::response::conceptgroup={};
   my $result;
   if ($target eq 'edit') {
-    my $insertlist=&Apache::edit::insertlist($target,$token);
     $result.=&Apache::edit::tag_start($target,$token,"Concept Grouped Foils");
-    my $concept = &Apache::lonxml::get_param('concept',$parstack,$safeeval);
-    $result.="Concept: <input name=\"$Apache::lonxml::curdepth.concept\" type=\"text\" value=\"$concept\" /></td></tr><tr><td colspan=\"3\">";
+    $result.=&Apache::edit::text_arg('Concept:','concept',$token,'50')."</td></tr>";
+    $result.="<tr><td colspan=\"3\">\n";
+  }
+  if ($target eq 'modified') {
+    my $constructtag=&Apache::edit::get_new_args($token,$parstack,$safeeval,'concept');
+    if ($constructtag) { $result = &Apache::edit::rebuild_tag($token); }
   }
   return $result;
 }
@@ -229,16 +250,19 @@ sub end_conceptgroup {
   my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
   $Apache::optionresponse::conceptgroup=0;
   my $result='';
-  if ($target eq 'web' || $target eq 'grade') {
-    my @names = @{ $Apache::response::conceptgroup{'names'} };
-    my $pick=int rand $#names+1;
-    my $name=$names[$pick];
-    push @{ $Apache::response::foilgroup{'names'} }, $name;
-    $Apache::response::foilgroup{"$name.value"} =  $Apache::response::conceptgroup{"$name.value"};
-    $Apache::response::foilgroup{"$name.text"} =  $Apache::response::conceptgroup{"$name.text"};
-    my $concept = &Apache::lonxml::get_param('concept',$parstack,$safeeval);
-    $Apache::response::foilgroup{"$name.concept"} = $concept;
-    &Apache::lonxml::debug("Selecting $name in $concept");
+  if ($target eq 'web' || $target eq 'grade' || $target eq 'answer') {
+    #if not there aren't any foils to display and thus no question
+    if (defined(@{ $Apache::response::conceptgroup{'names'} })) {
+      my @names = @{ $Apache::response::conceptgroup{'names'} };
+      my $pick=int rand $#names+1;
+      my $name=$names[$pick];
+      push @{ $Apache::response::foilgroup{'names'} }, $name;
+      $Apache::response::foilgroup{"$name.value"} =  $Apache::response::conceptgroup{"$name.value"};
+      $Apache::response::foilgroup{"$name.text"} =  $Apache::response::conceptgroup{"$name.text"};
+      my $concept = &Apache::lonxml::get_param('concept',$parstack,$safeeval);
+      $Apache::response::foilgroup{"$name.concept"} = $concept;
+      &Apache::lonxml::debug("Selecting $name in $concept");
+    }
   }
   if ($target eq 'edit') {
     $result=&Apache::edit::end_table();
@@ -246,51 +270,28 @@ sub end_conceptgroup {
   return $result;
 }
 
+sub insert_conceptgroup {
+  my $result="\n\t\t<conceptgroup concept=\"\">".&insert_foil()."\n\t\t</conceptgroup>\n";
+  return $result;
+}
+
 sub start_foil {
   my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
   my $result='';
-  if ($target eq 'web') { &Apache::lonxml::startredirection; }
-  if ($target eq 'edit') {
+  if ($target eq 'web') {
+    &Apache::lonxml::startredirection;
+  } elsif ($target eq 'edit') {
     $result=&Apache::edit::tag_start($target,$token,"Foil");
     my $level='-2';
     if ($$tagstack['-2'] eq 'conceptgroup') { $level = '-3'; }
     my @opt;
     eval '@opt ='.&Apache::lonxml::get_param('options',$parstack,$safeeval,$level);
-    my $value=&Apache::lonxml::get_param('value',$parstack,$safeeval);
-    my $optionlist="<option>unused</option>\n";
-    foreach my $option (@opt) {
-      if ( $value eq $option ) {
-	$optionlist.="<option selected=\"on\">$option</option>\n";
-      } else {
-	$optionlist.="<option>$option</option>\n";
-      }
-    }
-    my $name=&Apache::lonxml::get_param('name',$parstack,$safeeval);
-    $result.="Name: <input name=\"$Apache::lonxml::curdepth.name\" type=\"text\" value=\"$name\" />".
-      "Correct Option:
-      <select name=\"$Apache::lonxml::curdepth.value\">
-        $optionlist
-      </select></td></tr><tr><td colspan=\"3\">";
-  }
-  if ($target eq 'modified') {
-    my $constructtag=0;
-    foreach my $arg ('value','name') {
-      my $value=&Apache::lonxml::get_param($arg,$parstack,$safeeval);
-      my $newvalue=$ENV{"form.$Apache::lonxml::curdepth.$arg"};
-      &Apache::lonxml::debug(" for:$arg: cur is :$value: new is :$newvalue:");
-      if ($value ne $newvalue) {
-	$token->[2]->{$arg}=$newvalue;
-	$constructtag=1;
-      }
-    }
-    if ($constructtag) {
-      $result = '<'.$token->[1];
-      while (my ($key,$val)= each(%{$token->[2]})) {
-	&Apache::lonxml::debug("setting :$key: to  :$val:");
-	$result.=' '.$key.'="'.$val.'"';
-      }
-      $result.=">";
-    }
+    $result.=&Apache::edit::text_arg('Name:','name',$token);
+    $result.= &Apache::edit::select_or_text_arg('Correct Option:','value',['unused',(@opt)],$token,'15');
+    $result .= '</td></tr><tr><td colspan="3">';
+  } elsif ($target eq 'modified') {
+    my $constructtag=&Apache::edit::get_new_args($token,$parstack,$safeeval,'value','name');
+    if ($constructtag) { $result = &Apache::edit::rebuild_tag($token); }
   }
   return $result;
 }
@@ -300,11 +301,13 @@ sub end_foil {
   my $text ='';
   my $result = '';
   if ($target eq 'web') { $text=&Apache::lonxml::endredirection; }
-  if ($target eq 'web' || $target eq 'grade') {
+  if ($target eq 'web' || $target eq 'grade' || $target eq 'answer') {
     my $value = &Apache::lonxml::get_param('value',$parstack,$safeeval);
     if ($value ne 'unused') {
       my $name = &Apache::lonxml::get_param('name',$parstack,$safeeval);
+      &Apache::lonxml::debug("Got a name of :$name:");
       if (!$name) { $name=$Apache::lonxml::curdepth; }
+      &Apache::lonxml::debug("Using a name of :$name:");
       if ( $Apache::optionresponse::conceptgroup ) {
 	push @{ $Apache::response::conceptgroup{'names'} }, $name;
 	$Apache::response::conceptgroup{"$name.value"} = $value;