--- loncom/homework/randomlabel.pm 2005/12/01 18:46:31 1.81 +++ loncom/homework/randomlabel.pm 2006/08/29 10:42:59 1.83 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # random labelling tool # -# $Id: randomlabel.pm,v 1.81 2005/12/01 18:46:31 albertel Exp $ +# $Id: randomlabel.pm,v 1.83 2006/08/29 10:42:59 foxr Exp $ # # Copyright Michigan State University Board of Trustees # @@ -61,6 +61,9 @@ use Apache::File(); use Apache::Constants qw(:common :http); use Image::Magick; use Apache::lonplot; +use lib '/home/httpd/lib/perl/'; +use LONCAPA; + my %args; my $cgi_id; @@ -138,7 +141,7 @@ sub start_randomlabel { if ($target eq 'web') { $cgi_id=&Apache::loncommon::get_cgi_id(); %args=(); - $args{"cgi.$cgi_id.BGIMG"}=&Apache::lonnet::escape($bgimg); + $args{"cgi.$cgi_id.BGIMG"}=&escape($bgimg); $height_param = &Apache::lonxml::get_param('height',$parstack, $safeeval); $width_param = &Apache::lonxml::get_param('width', $parstack, $safeeval); } elsif ($target eq 'tex' && defined($bgimg)) { @@ -223,7 +226,7 @@ sub end_bgimg { &Apache::lonxml::debug("Image: $bgimg"); $bgimg=&Apache::imageresponse::clean_up_image($bgimg); &Apache::lonxml::debug("Cleaned image: $bgimg"); - $args{"cgi.$cgi_id.BGIMG"}=&Apache::lonnet::escape($bgimg); + $args{"cgi.$cgi_id.BGIMG"}=&escape($bgimg); } elsif ($target eq 'tex') { # Some bg images can create latex for us... e.g. gnuplot. # If it looks like we have some latex use that, @@ -293,10 +296,20 @@ sub make_eps_image { &Apache::lonxml::debug("Image size: $height_param x $width_param"); my $dirtywidth=$width_param+5; + # + # Note that lonprintout/prinout will conspire to replace + # spaces in paths and names with _'s since spacess cause problems + # for latex included filenames. Therefore: + # + my $safe_path = $path; + $safe_path =~ s/ /\_/g; + my $safe_file = $file; + $safe_file =~ s/ /\_/g; + my $result ="\n".'\vspace*{2mm}\noindent'."\n". '\parbox{'.$dirtywidth. ' mm}{ \noindent \epsfxsize='.$width_param. - ' mm \epsffile{'.$path.$file. + ' mm \epsffile{'.$safe_path.$safe_file. '}\setlength{\unitlength}{1mm}'."\n".' \begin{picture}('. $width_param.','.$height_param.')(0,-'.$height_param.')'."\n"; my $magick = Image::Magick->new; @@ -422,13 +435,13 @@ sub end_labelgroup { my $i=$Apache::randomlabel::obj_cnt++; if( $type eq 'text') { &add_vars($gname,$_,$label,$idx_arr[$_],$value,'',$safeeval); - $str = join(':',$x,$y,&Apache::lonnet::escape($label)); + $str = join(':',$x,$y,&escape($label)); $args{"cgi.$cgi_id.OBJTYPE"}.='LABEL:'; } elsif ( $type eq 'image') { &add_vars($gname,$_, $Apache::randomlabel::description[$idx_arr[$_]], $idx_arr[$_],$value,$label,$safeeval); - $str = join(':',$x,$y,&Apache::lonnet::escape($label)); + $str = join(':',$x,$y,&escape($label)); $args{"cgi.$cgi_id.OBJTYPE"}.='IMAGE:'; } else { &Apache::lonxml::error('Unknown type of label :'.$type.':'); @@ -479,6 +492,11 @@ sub end_labelgroup { } elsif ( $type eq 'image') { my ($path,$file) = &Apache::londefdef::get_eps_image($label); my $image_name = $path.$file; + # + # Note that spaces in e.. \includegraphics cause problems for Latex + # so they get replaced by _'s by lonprintout/printout and us: + # + $image_name =~ s/ /\_/g; my $label_width = &get_label_width($label); $result .= '\includegraphics[width='.$label_width.'mm]{'