--- loncom/homework/templates/sampleexternal.problem	2010/12/20 18:14:18	1.1
+++ loncom/homework/templates/sampleexternal.problem	2010/12/20 19:18:14	1.2
@@ -10,7 +10,7 @@ sub fact {
 }
 
 $testvalues='0=1';
-for ($i=1,3) {
+foreach $i (1..3) {
    $rand=&random(3,8,1);
    $testvalues.=','.$rand.'='.&fact($rand);
 }