--- loncom/interface/courseprefs.pm	2009/11/21 18:07:03	1.11
+++ loncom/interface/courseprefs.pm	2009/11/23 21:45:18	1.12
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set configuration settings for a course
 #
-# $Id: courseprefs.pm,v 1.11 2009/11/21 18:07:03 www Exp $
+# $Id: courseprefs.pm,v 1.12 2009/11/23 21:45:18 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -332,7 +332,7 @@ sub handler {
                                                  \@prefs_order,\%prefs,\%values,
                                                   $cnum,undef,\@allitems);
     } elsif ($phase eq 'display') {
-        my $jscript = &get_jscript($cdom,$phase);
+        my $jscript = &get_jscript($cdom,$phase,$crstype);
         my @allitems = &get_allitems(%prefs);
         &Apache::lonconfigsettings::display_settings($r,$cdom,$phase,$context,
             \@prefs_order,\%prefs,\%values,undef,$jscript,\@allitems,$crstype);
@@ -1174,8 +1174,8 @@ sub get_course {
 }
 
 sub get_jscript {
-    my ($cdom,$phase) = @_;
-    my ($can_toggle_cat,$can_categorize) = &can_modify_catsettings($cdom);
+    my ($cdom,$phase,$crstype) = @_;
+    my ($can_toggle_cat,$can_categorize) = &can_modify_catsettings($cdom,$crstype);
     my ($jscript,$categorize_js);
     my $stubrowse_js = &Apache::loncommon::studentbrowser_javascript();
     my $browse_js = &Apache::loncommon::browser_and_searcher_javascript('parmset');
@@ -1294,14 +1294,14 @@ sub print_courseinfo {
         if (ref($cathash) eq 'HASH') {
             $categoriesform = 
                 &Apache::loncommon::assign_categories_table($cathash,
-                                                $settings->{'categories'})."\n";
+                                                $settings->{'categories'},$crstype)."\n";
         }
     }
     if (!defined($categoriesform)) {
         $categoriesform = &mt('No categories defined for this domain');
     }
 
-    my ($can_toggle_cat,$can_categorize) = &can_modify_catsettings($cdom);
+    my ($can_toggle_cat,$can_categorize) = &can_modify_catsettings($cdom,$crstype);
 
     my $replace;
     if ($crstype eq 'Community') {
@@ -1507,15 +1507,24 @@ sub new_cloners_dom_row {
 }
 
 sub can_modify_catsettings {
-    my ($dom) = @_;
+    my ($dom,$crstype) = @_;
     my %domconf = &Apache::lonnet::get_dom('configuration',['coursecategories'],$dom);
     my ($can_toggle_cat,$can_categorize);
     if (ref($domconf{'coursecategories'}) eq 'HASH') {
-        if ($domconf{'coursecategories'}{'togglecats'} eq 'crs') {
-            $can_toggle_cat = 1;
-        }
-        if ($domconf{'coursecategories'}{'categorize'} eq 'crs') {
-            $can_categorize = 1;
+        if ($crstype eq 'Community') {
+            if ($domconf{'coursecategories'}{'togglecatscomm'} eq 'comm') {
+                $can_toggle_cat = 1;
+            }
+            if ($domconf{'coursecategories'}{'categorizecomm'} eq 'comm') {
+                $can_categorize = 1;
+            }
+        } else {
+            if ($domconf{'coursecategories'}{'togglecats'} eq 'crs') {
+                $can_toggle_cat = 1;
+            }
+            if ($domconf{'coursecategories'}{'categorize'} eq 'crs') {
+                $can_categorize = 1;
+            }
         }
     }
     return ($can_toggle_cat,$can_categorize);
@@ -1531,7 +1540,13 @@ sub assign_course_categories {
     if (ref($domconf{'coursecategories'}) eq 'HASH') {
         $cathash = $domconf{'coursecategories'}{'cats'};
         if (ref($cathash) eq 'HASH') {
-            $hascats = 1;
+            foreach my $cat (keys(%{$cathash})) {
+                next if ($cat eq 'instcode::0');
+                unless ($crstype eq 'Community') {
+                    next if ($cat eq 'communities::0');
+                }
+                $hascats ++; 
+            }
         }
     }
     my $catwin_js;
@@ -1597,15 +1612,20 @@ ENDSCRIPT
     if ($hascats) {
         my %currsettings =
             &Apache::lonnet::get('environment',['hidefromcat','categories'],$cdom,$cnum);
-        $categoriesform .= $assign.'<br /><br />'.
-                           '<form name="chgcats" action="/adm/courseprefs" method="post">'."\n".
-                           &Apache::loncommon::assign_categories_table($cathash,
-                                                       $currsettings{'categories'})."\n".
-                           '<br /><input type="button" name="changes" value="'.
-                           &mt('Copy to main window').'" '.
-                           'onclick="javascript:updateCategories()" /></form><br />';
+        my $cattable = &Apache::loncommon::assign_categories_table($cathash,
+                                       $currsettings{'categories'},$crstype);
+        if ($cattable eq '') {
+            $categoriesform .= &mt('No suitable categories defined for this course type in this domain.'); 
+        } else {
+            $categoriesform .= $assign.'<br /><br />'.
+                               '<form name="chgcats" action="/adm/courseprefs" method="post">'."\n".
+                               $cattable."\n".
+                               '<br /><input type="button" name="changes" value="'.
+                               &mt('Copy to main window').'" '.
+                               'onclick="javascript:updateCategories()" /></form><br />';
+        }
     } else {
-        $categoriesform .= &mt('No categories defined for this domain');
+        $categoriesform .= &mt('No categories defined in this domain.');
     }
     $r->print($start_page.$categoriesform.$end_page);
     return;