--- loncom/interface/createaccount.pm	2022/02/20 19:53:07	1.72.4.7.2.1
+++ loncom/interface/createaccount.pm	2017/08/03 16:22:08	1.74
@@ -4,7 +4,7 @@
 # kerberos, or SSO) or an e-mail address. Requests to use an e-mail address as
 # username may be processed automatically, or may be queued for approval.
 #
-# $Id: createaccount.pm,v 1.72.4.7.2.1 2022/02/20 19:53:07 raeburn Exp $
+# $Id: createaccount.pm,v 1.74 2017/08/03 16:22:08 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -328,7 +328,7 @@ sub handler {
         &print_header($r,$start_page,$courseid,$pagetitle);
         my $now=time;
         if ((grep(/^login$/,@{$cancreate})) && (!grep(/^email$/,@{$cancreate}))) {
-            if (open(my $jsh,"<","$include/londes.js")) {
+            if (open(my $jsh,"<$include/londes.js")) {
                 while(my $line = <$jsh>) {
                     $r->print($line);
                 }
@@ -437,9 +437,7 @@ sub javascript_setforms {
                 }
                 $setuserinfo .= '                    server.elements.'.$key.'.value=client.elements.'.$key.'.value;'."\n";
             }
-            if ($usertype ne '') {
-                $setuserinfo .= '                    server.elements.type.value=client.elements.type.value;'."\n";
-            }
+            $setuserinfo .= '                    server.elements.type.value=client.elements.type.value;'."\n"; 
         }
         if ($captcha eq 'original') {
             $setuserinfo .= '                    server.elements.code.value=client.elements.code.value;'."\n".
@@ -522,12 +520,10 @@ ENDSCRIPT
 }
 
 sub javascript_checkpass {
-    my ($now,$context,$domain) = @_;
+    my ($now,$context) = @_;
     my $nopass = &mt('You must enter a password.');
     my $mismatchpass = &mt('The passwords you entered did not match.')."\n".
                        &mt('Please try again.'); 
-    my ($numrules,$intargjs) =
-        &Apache::loncommon::passwd_validation_js('upass',$domain);
     &js_escape(\$nopass);
     &js_escape(\$mismatchpass);
     my $js = <<"ENDSCRIPT";
@@ -544,10 +540,6 @@ sub javascript_checkpass {
                 return false;
             }
             if (upass == upasscheck) {
-                var numrules = $numrules;
-                if (numrules > 0) {
-$intargjs
-                }
                 client.elements.upasscheck$now.value='';
                 if (validate_email(client)) {
                     send(one,two,'$context');
@@ -571,7 +563,8 @@ sub javascript_validmail {
     my %js_lt = &Apache::lonlocal::texthash (
                email => 'The e-mail address you entered',
                notv  => 'is not a valid e-mail address',
-               avae  => 'A valid e-mail address is not formed when the value you entered is combined with the required domain',
+               avae  => 'A valid e-mail address is not formed when the value you entered',
+               isco  => 'is combined with the required domain',
     );
     my $output =  "\n".'<script type="text/javascript">'."\n".
                   '// <![CDATA['."\n".
@@ -583,7 +576,7 @@ function validate_email(client) {
     var condition = '$condition';
     if (validmail(field,condition) == false) {
         if ((condition != undefined) && (condition != '')) {
-            alert("$js_lt{'avae'}: "+condition);
+            alert("$js_lt{'avae'}: "+field.value+" $js_lt{'isco'}: "+condition);
         } else {
             alert("$js_lt{'email'}: "+field.value+" $js_lt{'notv'}.");
         }
@@ -641,7 +634,7 @@ sub print_username_form {
                     push(@posstypes,'default');
                 }
                 $output .= '<p>'.&mt('Choose your affiliation at [_1]',$domdesc).'</p>'."\n".
-                           '<form name="reportstatus" id="LC_reportstatus" action="/adm/createaccount" method="post" '.
+                           '<form name="reportstatus" id="LC_reportstatus" action="" method="post" '.
                            'onsubmit="return checkVerification();"><p>';
                 foreach my $type (@posstypes) {
                     my $name;
@@ -655,11 +648,7 @@ sub print_username_form {
                             }
                         }
                     }
-                    my $checked;
-                    if ($env{'form.type'} eq $type) {
-                        $checked = ' checked="checked"';
-                    }
-                    $output .= '<label><input type="radio" name="type" value="'.$type.'"'.$checked.' />'.
+                    $output .= '<label><input type="radio" name="type" value="'.$type.'" />'.
                                $name.'</label>'.('&nbsp;'x2);
                 }
                 if ($env{'form.courseid'} =~ /^$match_domain\_$match_courseid$/) {
@@ -698,18 +687,6 @@ sub print_username_form {
                     }
                     if ($usertype eq '') {
                         $usertype = 'default';
-                    } elsif (ref($usertypes) eq 'HASH') {
-                        my $usertitle;
-                        if ($usertype eq 'default') {
-                            $usertitle = $othertitle;
-                        } elsif (exists($usertypes->{$usertype})) {
-                            $usertitle = $usertypes->{$usertype};
-                        }
-                        if ($usertitle ne '') {
-                            $output .= &mt('Self-reported affiliation: [_1]',
-                                           '<span style="font-style: italic;">'.$usertitle.'</span>').
-                                       '<br />';
-                        }
                     }
                     $output .= &print_dataentry_form($r,$domain,$lonhost,$include,$now,$captchaform,
                                                      $courseid,$emailusername,$captcha,$usertype,
@@ -842,24 +819,8 @@ sub process_email_request {
             } else {
                 my ($captcha_chk,$captcha_error) = &Apache::loncommon::captcha_response('usercreation',$server);
                 if ($captcha_chk != 1) {
-                    $output = '<span class="LC_warning">'.
-                              &mt('Validation of the code you entered failed.').'</span>'.
-                              '<br />'.$captcha_error."\n".'<br /><p>'.
-                               &mt('[_1]Return[_2] to the previous page to try again.',
-                                   '<a href="javascript:document.retryemail.submit();">','</a>')."\n".
-                              '<form name="retryemail" action="/adm/createaccount" method="post" />'.
-                              '<input type="hidden" name="domain" value="'.$domain.'" />'."\n";
-                    if ($env{'form.courseid'} =~ /^$match_domain\_$match_courseid$/) {
-                        $output .= '<input type="hidden" name="courseid" value="'.$env{'form.courseid'}.'" />'."\n";
-                    }
-                    if ($env{'form.type'}) {
-                        my $usertype = &get_usertype($domain);
-                        if ($usertype ne '') {
-                            $output .= '<input type="hidden" name="type" value="'.$usertype.'" />'."\n".
-                                       '<input type="hidden" name="reportedtype" value="'.&mt('Submit').'" />'."\n";
-                        }
-                    }
-                    $output .= '</form></p>';
+                    $output = &invalid_state('captcha',$domdesc,$contact_name,
+                                             $contact_email,$captcha_error);
                     return $output;
                 }
                 my (%rulematch,%inst_results,%curr_rules,%got_rules,%alerts);
@@ -917,74 +878,17 @@ sub send_token {
     $env{'form.logtoken'} =~ s/(`)//g;
     if ($env{'form.logtoken'}) {
         my $logtoken = $env{'form.logtoken'};
-        my $earlyout;
         my $tmpinfo=Apache::lonnet::reply('tmpget:'.$logtoken,$server);
         if (($tmpinfo=~/^error/) || ($tmpinfo eq 'con_lost')) {
             $msg = &mt('Information needed to process your request is missing, inaccessible or expired.')
-                  .'<br /><p>'.&mt('[_1]Return[_2] to the previous page to try again.',
-                                   '<a href="javascript:document.retryemail.submit();">','</a>');
-            $earlyout = 1;
+                  .'<br />'.&mt('Return to the previous page to try again.');
         } else {
             my $reply = &Apache::lonnet::reply('tmpdel:'.$logtoken,$server);
             unless ($reply eq 'ok') {
                 $msg .= &mt('Request could not be processed.');
             }
         }
-# Check if the password entered by the user satisfies domain's requirements
-        my %passwdconf = &Apache::lonnet::get_passwdconf($domain);
-        my ($min,$max,@chars);
-        $min = $Apache::lonnet::passwdmin;
-        if (ref($passwdconf{'chars'}) eq 'ARRAY') {
-            if ($passwdconf{'min'} =~ /^\d+$/) {
-                if ($passwdconf{'min'} > $min) {
-                    $min = $passwdconf{'min'};
-                }
-            }
-            if ($passwdconf{'max'} =~ /^\d+$/) {
-                $max = $passwdconf{'max'};
-            }
-            @chars = @{$passwdconf{'chars'}};
-        }
-        my $encpass = $env{'form.upass'};
-        if ($encpass eq '') {
-            $msg = &mt('Password retrieved was blank.').
-                   '<br /><p>'.&mt('[_1]Return[_2] to the previous page to try again.',
-                                   '<a href="javascript:document.retryemail.submit();">','</a>');
-            $earlyout = 1;
-        } else {
-# Split the logtoken to retrieve the DES key and decrypt the encypted password
-            my ($key,$caller)=split(/&/,$tmpinfo);
-            if ($caller eq 'createaccount') {
-                my $plainpass = &Apache::loncommon::des_decrypt($key,$encpass);
-                if (($min > 0) || ($max ne '') || (@chars > 0)) {
-                    my $warning = &Apache::loncommon::check_passwd_rules($domain,$plainpass);
-                    if ($warning) {
-                        $msg = $warning.
-                               '<p>'.&mt('[_1]Return[_2] to the previous page to try again.',
-                                         '<a href="javascript:document.retryemail.submit();">','</a>');
-                        $earlyout = 1;
-                    }
-                }
-            }
-        }
-        if ($earlyout) {
-            $msg .= '<form name="retryemail" action="/adm/createaccount" method="post" />'.
-                    '<input type="hidden" name="domain" value="'.$domain.'" />'."\n";
-            if ($env{'form.courseid'} =~ /^$match_domain\_$match_courseid$/) {
-                $msg .= '<input type="hidden" name="courseid" value="'.$env{'form.courseid'}.'" />'."\n";
-            }
-            if ($env{'form.type'}) {
-                my $usertype = &get_usertype($domain);
-                if ($usertype ne '') {
-                    $msg .= '<input type="hidden" name="type" value="'.$usertype.'" />'.
-                            '<input type="hidden" name="reportedtype" value="'.&mt('Submit').'" />'."\n";
-                }
-            }
-            $msg .= '</form></p>';
-            return $msg;
-        }
-        my $ip = &Apache::lonnet::get_requestor_ip();
-        my %info = ('ip'         => $ip,
+        my %info = ('ip'         => $ENV{'REMOTE_ADDR'},
                     'time'       => $now,
                     'domain'     => $domain,
                     'username'   => $email,
@@ -1100,9 +1004,8 @@ sub process_mailtoken {
                             &create_account($r,$domain,$domdesc,\%data);
                         if ($result eq 'ok') {
                             $msg = $output;
-                            my $ip = &Apache::lonnet::get_requestor_ip();
                             my $shownow = &Apache::lonlocal::locallocaltime($now);
-                            my $mailmsg = &mt('A LON-CAPA account for the institution: [_1] has been created [_2] from IP address: [_3]. If you did not perform this action or authorize it, please contact the [_4] ([_5]).',$domdesc,$shownow,$ip,$contact_name,$contact_email)."\n";
+                            my $mailmsg = &mt('A LON-CAPA account for the institution: [_1] has been created [_2] from IP address: [_3]. If you did not perform this action or authorize it, please contact the [_4] ([_5]).',$domdesc,$shownow,$ENV{'REMOTE_ADDR'},$contact_name,$contact_email)."\n";
                             my $mailresult = &Apache::resetpw::send_mail($domdesc,$data{'email'},
                                                                         $mailmsg,$contact_name,
                                                                         $contact_email);
@@ -1170,66 +1073,54 @@ sub print_dataentry_form {
     my ($r,$domain,$lonhost,$include,$now,$captchaform,$courseid,$emailusername,$captcha,
         $usertype,$recaptchaversion,$usernameset,$condition,$excluded) = @_;
     my ($error,$output);
-    if (open(my $jsh,"<","$include/londes.js")) {
+    if (open(my $jsh,"<$include/londes.js")) {
         while(my $line = <$jsh>) {
             $r->print($line);
         }
         close($jsh);
         $output = &javascript_setforms($now,$emailusername,$captcha,$usertype,$recaptchaversion,
                                        $usernameset,$condition,$excluded).
-                  "\n".&javascript_checkpass($now,'email',$domain);
+                  "\n".&javascript_checkpass($now,'email');
         my ($lkey,$ukey) = &Apache::loncommon::des_keys();
         my ($lextkey,$uextkey) = &getkeys($lkey,$ukey);
         my $logtoken=Apache::lonnet::reply('tmpput:'.$ukey.$lkey.'&createaccount:createaccount',
                                            $lonhost);
-        my $showsubmit = 1;
-        my $serverform =
+        $output .=
             '<form name="createaccount" method="post" target="_top" action="/adm/createaccount">';
         if ($courseid ne '') {
-            $serverform .= '<input type="hidden" name="courseid" value="'.$courseid.'"/>'."\n";
+            $output .= '<input type="hidden" name="courseid" value="'.$courseid.'"/>'."\n";
         }
         if (ref($emailusername) eq 'HASH') {
             if (ref($emailusername->{$usertype}) eq 'HASH') {
                 foreach my $field (sort(keys(%{$emailusername->{$usertype}}))) {
-                    $serverform .= '<input type="hidden" name="'.$field.'" value="" />'."\n";
+                    $output .= '<input type="hidden" name="'.$field.'" value="" />'."\n";
                 }
             }
         }
         if ($captcha eq 'original') {
-            $serverform .= '
+            $output .= '
    <input type="hidden" name="crypt" value="" />
    <input type="hidden" name="code" value="" />
 ';
         } elsif ($captcha eq 'recaptcha') {
             if ($recaptchaversion eq '2') {
-                $serverform .= &Apache::lonhtmlcommon::start_pick_box().
-                               &Apache::lonhtmlcommon::row_title(&mt('Validation').'<b>*</b>',
-                                                                 'LC_pick_box_title',
-                                                                 'LC_oddrow_value')."\n".
-                                                                 $captchaform.
-                               &Apache::lonhtmlcommon::row_closure(1)."\n".
-                               &Apache::lonhtmlcommon::row_title()."\n".
-                               '<br /><input type="button" name="createaccount" value="'.
-                               &mt('Create account').'" onclick="checkpass('."'createaccount','newemail'".')" />'.
-                               &Apache::lonhtmlcommon::row_closure(1)."\n".
-                               &Apache::lonhtmlcommon::end_pick_box();
+                $output .= "$captchaform\n";
                 undef($captchaform);
-                undef($showsubmit);
             } else {
-                $serverform .= '
+                $output .= '
    <input type="hidden" name="recaptcha_challenge_field" value="" />
    <input type="hidden" name="recaptcha_response_field" value="" />
 ';
             }
         }
         if ($usertype ne '') {
-            $serverform .= '<input type="hidden" name="type" value="'.
-                           &HTML::Entities::encode($usertype,'\'<>"&').'" />'."\n";
+            $output .= '<input type="hidden" name="type" value="'.
+                       &HTML::Entities::encode($usertype,'\'<>"&').'" />'."\n";
         }
         if ($usernameset eq 'free') {
-            $serverform .= '<input type="hidden" name="username" value="" />'."\n"; 
+            $output .= '<input type="hidden" name="username" value="" />'."\n"; 
         }
-        $serverform .= <<"ENDSERVERFORM";
+        $output .= <<"ENDSERVERFORM";
    <input type="hidden" name="logtoken" value="$logtoken" />
    <input type="hidden" name="serverid" value="$lonhost" />
    <input type="hidden" name="uname" value="" />
@@ -1241,33 +1132,25 @@ sub print_dataentry_form {
 ENDSERVERFORM
         my $beginclientform = '<form name="newemail" method="post" action="" '.
                               'onsubmit="return checkpass('."'createaccount','newemail'".');">'."\n";
-        my $endclientform;
-        unless ($showsubmit) {
-            if ($usertype ne '') {
-                $endclientform = '<input type="hidden" name="type" value="'.
-                                 &HTML::Entities::encode($usertype,'\'<>"&').'" />'."\n";
-            }
-        }
-        $endclientform .= '<input type="hidden" name="udom" value="'.$domain.'" />'."\n".
-                          '<input type="hidden" name="lextkey" value="'.$lextkey.'" />'."\n".
-                          '<input type="hidden" name="uextkey" value="'.$uextkey.'" />'."\n".
-                          '</form>'."\n";
+        my $endclientform = '<input type="hidden" name="udom" value="'.$domain.'" />'."\n".
+                            '<input type="hidden" name="lextkey" value="'.$lextkey.'" />'."\n".
+                            '<input type="hidden" name="uextkey" value="'.$uextkey.'" />'."\n".
+                            '</form>'."\n".
+                            '<p class="LC_info">'.&mt('Fields marked [_1]*[_2] are required.','<b>','</b>').'</p>';
         my ($datatable,$rowcount) =
             &Apache::loncreateuser::personal_data_display('',$domain,'email','selfcreate',
                                                           '','',$now,$captchaform,
                                                           $emailusername,$usertype,
-                                                          $usernameset,$condition,$excluded,
-                                                          $showsubmit);
+                                                          $usernameset,$condition,$excluded);
         if ($rowcount) {
-            $output .= '<div class="LC_left_float">'.$beginclientform.$datatable.$endclientform.'</div>'."\n".
-                       '<div class="LC_clear_float_footer"></div>'."\n";
+            $output .= '<div class="LC_left_float">'.$beginclientform.$datatable.$endclientform;
         } else {
             $output .= $beginclientform.$endclientform;
         }
-        $output .= $serverform.
-                   '<p class="LC_info">'.
-                   &mt('Fields marked [_1]*[_2] are required.','<b>','</b>').
-                   '</p>';
+        if ($rowcount) {
+            $output .= '</div>'."\n".
+                       '<div class="LC_clear_float_footer"></div>'."\n";
+        }
     } else {
         $output = &mt('Could not load javascript file [_1]','<tt>londes.js</tt>');
     }
@@ -1428,7 +1311,7 @@ sub create_account {
             unless (($inststatus eq 'default') || ($inststatus eq '')) {
                 &Apache::lonnet::put('environment',{inststatus => $inststatus},$domain,$username);
             }
-            $output .= '<br />'.&mt('Home Server').": $uhome ".
+            $output .= '<br />'.&mt('Home server: [_1]',$uhome).' '.
                        &Apache::lonnet::hostname($uhome).'<br /><br />';
             return ('ok',$output,$uhome);
         } else {
@@ -1601,8 +1484,7 @@ sub username_check {
                     '<input type="hidden" name="udom" value="'.$domain.'" />'."\n".
                     '<input type="hidden" name="phase" value="username_activation" />';
         my $now = time;
-        my $ip = &Apache::lonnet::get_requestor_ip();
-        my %info = ('ip'         => $ip,
+        my %info = ('ip'         => $ENV{'REMOTE_ADDR'},
                     'time'       => $now,
                     'domain'     => $domain,
                     'username'   => $username);
@@ -1806,6 +1688,8 @@ sub invalid_state {
         $msg .= &mt('Username rules at this institution do not allow the e-mail address you provided to be used as a username.');
     } elsif ($error eq 'userformat') {
         $msg .= &mt('The e-mail address you provided may not be used as a username at this LON-CAPA institution.');
+    } elsif ($error eq 'captcha') {
+        $msg .= &mt('Validation of the code you entered failed.');
     } elsif ($error eq 'noemails') {
         $msg .= &mt('Creation of a new user account using an e-mail address as username is not permitted at this LON-CAPA institution.');
     } elsif ($error eq 'emailfail') {
@@ -1986,14 +1870,14 @@ sub sso_logout_frag {
     if (defined($r->dir_config('lonSSOUserLogoutMessageFile_'.$domain))) {
         my $msgfile = $r->dir_config('lonSSOUserLogoutMessageFile_'.$domain);
         if (-e $msgfile) {
-            open(my $fh,"<",$msgfile);
+            open(my $fh,"<$msgfile");
             $endsessionmsg = join('',<$fh>);
             close($fh);
         }
     } elsif (defined($r->dir_config('lonSSOUserLogoutMessageFile'))) {
         my $msgfile = $r->dir_config('lonSSOUserLogoutMessageFile');
         if (-e $msgfile) {     
-            open(my $fh,"<",$msgfile);
+            open(my $fh,"<$msgfile");
             $endsessionmsg = join('',<$fh>);
             close($fh);
         }
@@ -2112,7 +1996,6 @@ function checkVerification() {
             if (curr == types[j]) {
                 if (!cancreate) {
                     alert('Creation of an account via verification by e-mail unavailable for user type: "'+names[j]+'"');
-                    setElements();
                 }
                 break;
             }