--- loncom/interface/groupsort.pm	2007/07/11 23:53:59	1.56
+++ loncom/interface/groupsort.pm	2007/11/02 21:08:45	1.61
@@ -2,7 +2,7 @@
 # The LON-CAPA group sort handler
 # Allows for sorting prior to import into RAT.
 #
-# $Id: groupsort.pm,v 1.56 2007/07/11 23:53:59 albertel Exp $
+# $Id: groupsort.pm,v 1.61 2007/11/02 21:08:45 albertel Exp $
 # 
 # Copyright Michigan State University Board of Trustees
 #
@@ -37,7 +37,7 @@ use GDBM_File;
 use Apache::loncommon;
 use Apache::lonlocal;
 use Apache::lonnet;
-use LONCAPA();
+use LONCAPA;
 
 my $iconpath; # variable to be accessible to multiple subroutines
 my %hash; # variable to tie to user specific database
@@ -45,14 +45,15 @@ my %hash; # variable to tie to user spec
 
 sub update_actions_hash {
     my ($hash) = @_;
+    # be careful in here, there is also a global %hash
     my $acts=$env{'form.acts'};
     my @Acts=split(/b/,$acts);
     my %ahash;
     my %achash;
-    my $ac=0;
     # some initial hashes for working with data
+    my $ac=0;
     foreach (@Acts) {
-	my ($state,$ref)=split(/a/);
+ 	my ($state,$ref)=split(/a/);
 	$ahash{$ref}=$state;
 	$achash{$ref}=$ac;
 	$ac++;
@@ -60,15 +61,16 @@ sub update_actions_hash {
     # sorting through the actions and changing the global database hash
     foreach my $key (sort {$achash{$a}<=>$achash{$b}} (keys %ahash)) {
 	if ($ahash{$key} eq '1') {
-	    $hash->{'store_'.$hash{'pre_'.$key.'_link'}}=
+	    $hash->{'store_'.$hash->{'pre_'.$key.'_link'}}=
 		$hash->{'pre_'.$key.'_title'};
-	    $hash->{'storectr_'.$hash{'pre_'.$key.'_link'}}=
+	    $hash->{'storectr_'.$hash->{'pre_'.$key.'_link'}}=
 		$hash->{'storectr'}+0;
 	    $hash->{'storectr'}++;
 	}
 	if ($ahash{$key} eq '0') {
-	    if ($hash->{'store_'.$hash{'pre_'.$key.'_link'}}) {
-		delete($hash->{'store_'.$hash{'pre_'.$key.'_link'}});
+	    if ($hash->{'store_'.$hash->{'pre_'.$key.'_link'}}) {
+		delete($hash->{'store_'.$hash->{'pre_'.$key.'_link'}});
+		delete($hash->{'storectr_'.$hash->{'pre_'.$key.'_link'}});
 	    }
 	}
     }
@@ -82,7 +84,7 @@ sub update_actions_hash {
 }
 
 sub readfromdb {
-    my ($r,$shash,$thash)=@_;
+    my ($r,$resources)=@_;
 
     my $diropendb = 
        "/home/httpd/perl/tmp/$env{'user.domain'}_$env{'user.name'}_sel_res.db";
@@ -91,66 +93,40 @@ sub readfromdb {
     if (tie(%hash,'GDBM_File',$diropendb,&GDBM_WRCREAT(),0640)) {
 	&update_actions_hash(\%hash);
 
-	foreach (keys %hash) {
-	    if ($_ =~ /^store_/) {
-		my $key = $_;
-		$key =~ s/^store_//;
-		$$shash{$key} = $hash{'storectr_'.$key};
-		if (&Apache::lonnet::gettitle($key) eq '') {
-		    $$thash{$key} = $hash{'store_'.$key};
-		} else {
-		    $$thash{$key} = &Apache::lonnet::gettitle($key);
-		}
-	    }
+	my %temp_resources;
+	foreach my $key (keys(%hash)) {
+	    next if ($key !~ /^store_/);
+	    my ($url) = ($key =~ /^store_(.*)/);
+	    $temp_resources{$hash{'storectr_'.$url}}{'url'}=$url;
+	    $temp_resources{$hash{'storectr_'.$url}}{'title'}=
+		&Apache::lonnet::gettitle($url);
 	}
+
+	# use the temp, since there might be gaps in the counting
+	foreach my $item (sort {$a <=> $b} (keys(%temp_resources))) {
+	    push(@{ $resources },$temp_resources{$item});
+	}
+
 	if ($env{'form.oldval'}) {
-	    my $newctr = 0;
-	    my %chash;
-	    foreach (sort {$$shash{$a} <=> $$shash{$b}} (keys %{$shash})) {
-		my $key = $_;
-		$newctr++;
-		$$shash{$key} = $newctr;
-		$hash{'storectr_'.$key} = $newctr;
-		$chash{$newctr} = $key;
-	    }
-	    my $oldval = $env{'form.oldval'};
-	    my $newval = $env{'form.newval'};
-	    if ($oldval != $newval) {
-		# when newval==0, then push down and delete
-		if ($newval!=0) {
-		    $$shash{$chash{$oldval}} = $newval;
-		    $hash{'storectr_'.$chash{$oldval}} = $newval;
-		} else {
-		    $$shash{$chash{$oldval}} = $newctr;
-		    $hash{'storectr_'.$chash{$oldval}} = $newctr;
-		}
-		if ($newval==0) { # push down
-		    my $newval2=$newctr;
-		    for my $idx ($oldval..($newval2-1)) {
-			$$shash{$chash{$idx+1}} = $idx;
-			$hash{'storectr_'.$chash{$idx+1}} = $idx;
-		    }
-		    delete $$shash{$chash{$oldval}};
-		    delete $hash{'storectr_'.$chash{$oldval}};
-		    delete $hash{'store_'.$chash{$oldval}};
-		} elsif ($oldval < $newval) { # push down
-		    for my $idx ($oldval..($newval-1)) {
-			$$shash{$chash{$idx+1}} = $idx;
-			$hash{'storectr_'.$chash{$idx+1}} = $idx;
-		    }
-		} elsif ($oldval > $newval) { # push up
-		    for my $idx (reverse($newval..($oldval-1))) {
-			$$shash{$chash{$idx}} = $idx+1;
-			$hash{'storectr_'.$chash{$idx}} = $idx+1;
-		    }
-		}
+	    my $res = splice(@{$resources},$env{'form.oldval'}-1,1);
+	    if ($env{'form.newval'} == 0) {
+		# picked 'discard'
+		my $url =  $res->{'url'};
+		delete($hash{'storectr_'.$url});
+		delete($hash{'store_'.$url});
+	    } else {
+		splice(@{$resources},$env{'form.newval'}-1,0,$res);
 	    }
 	}
+	# store out new order
+	foreach my $which (0..$#$resources) {
+	    my $url =  $resources->[$which]{'url'};
+	    $hash{'storectr_'.$url} = $which;
+	}
     } else {
 	$r->print('Unable to tie hash to db file');
     }
-    untie %hash;
-    return ($shash,$thash);
+    untie(%hash);
 }
 
 
@@ -168,7 +144,7 @@ sub cleanup {
 # -------------------------------------------------------------- Read from file
 
 sub readfromfile {
-    my ($r,$shash,$thash,$nhash)=@_;
+    my ($r,$resources)=@_;
     my $cont=&Apache::lonnet::getfile
 	(&Apache::lonnet::filelocation('',$env{'form.readfile'}));
     if ($cont==-1) {
@@ -177,7 +153,6 @@ sub readfromfile {
     } else {
         my $parser = HTML::TokeParser->new(\$cont);
         my $token;
-	my $n=1;
         while ($token = $parser->get_token) {
 	    if ($token->[0] eq 'S') {
                 if ($token->[1] eq 'resource') {
@@ -187,43 +162,42 @@ sub readfromfile {
 			if ($token->[2]->{'type'} eq 'zombie') { next; }
 		    }
 
-		    my $url=$token->[2]->{'src'};
                     my $name=$token->[2]->{'title'};
 		    $name=~s/ \[\((\d+)\,($LONCAPA::username_re)\,($LONCAPA::domain_re)\)\]$//;
+		    my $note;
 		    if ($1) {
-			$$nhash{$url}='<br />'.&mt('Removed by ').
+			$note = '<br />'.&mt('Removed by ').
 			    &Apache::loncommon::plainname($2,$3).', '.
 			    &Apache::lonlocal::locallocaltime($1);
 		    }
 		    $name=~s/\&colon\;/\:/g;
-		    $$thash{$url}=$name;
-                    $$shash{$url}=$n;
-                    $n++;
+		    push(@{$resources}, {'url'   => $token->[2]->{'src'},
+					 'title' => $name,
+					 'note'  => $note,
+				         'id'    => $token->[2]->{'id'},});
 		}
 	    }
 	}
     }
-    return ($shash,$thash);
 }
 
 # --------------------------------------------------------- Read from bookmarks
 
 sub readfrombookmarks {
-    my ($r,$shash,$thash)=@_;
+    my ($r,$resources)=@_;
     my %bookmarks=&Apache::lonnet::dump('bookmarks');
 # the bookmark "hash" is just one entry
 # it's a javascript program code with arguments like ('title','url');
     my @bookmarks=($bookmarks{'bookmarks'}=~/\((?:\'([^\']+)\'\,\'([^\']+)\'|\"([^\"]+)\"\,\"([^\"]+)\")\)\;/g);
-    my $order=1;
     for (my $index=0;$index<($#bookmarks+1)/2;$index++) {
         if ($bookmarks[$index*2+1]) {
-	    $$thash{$bookmarks[$index*2+1]}=$bookmarks[$index*2];
-	    $$thash{$bookmarks[$index*2+1]}=~s/^LON\-CAPA\s+//;
-	    $$shash{$bookmarks[$index*2+1]}=$order;
-	    $order++;
+	    my $url  = $bookmarks[$index*2+1];
+	    my $name = $bookmarks[$index*2];
+	    $name =~ s/^LON\-CAPA\s+//;
+
+	    push(@{$resources},{'url' => $url, 'title' => $name});
 	}
     }
-    return ($shash,$thash);
 }
 
 # ---------------------------------------------------------------- Main Handler
@@ -255,8 +229,9 @@ function finish_import() {
     for (var num=0; num<document.forms.groupsort.fnum.value; num++) {
 	$begincondition
 	opener.document.forms.simpleedit.importdetail.value+='&'+
-              escape(eval("document.forms.groupsort.title"+num+".value"))+'='+
-	      escape(eval("document.forms.groupsort.filelink"+num+".value"));
+              eval("document.forms.groupsort.title"+num+".value")+'='+
+	      eval("document.forms.groupsort.filelink"+num+".value")+'='+
+	      eval("document.forms.groupsort.id"+num+".value");
 	$endcondition
     }
     opener.document.forms.simpleedit.submit();
@@ -273,6 +248,7 @@ function finish_import() {
 	placeResourceInLastRow(
 	       eval("document.forms.groupsort.title"+num+".value"),
  	       eval("document.forms.groupsort.filelink"+num+".value"),
+ 	       eval("document.forms.groupsort.id"+num+".value"),
 	       linkflag
 	);
         linkflag=true;
@@ -294,9 +270,9 @@ function insertRowInLastRow() {
     opener.insertrow(opener.maxrow);
     opener.addobj(opener.maxrow,'e&2');
 }
-function placeResourceInLastRow (title,url,linkflag) {
+function placeResourceInLastRow (title,url,id,linkflag) {
     opener.mostrecent=opener.newresource(opener.maxrow,2,opener.escape(title),
-		       opener.escape(url),'false','normal');
+		       opener.escape(url),'false','normal',id);
     opener.save();
     if (linkflag) {
 	opener.joinres(opener.linkmode,opener.mostrecent,0);
@@ -322,20 +298,18 @@ END
     my $domain  = $r->dir_config('lonDefDomain');
     $iconpath = $r->dir_config('lonIconsURL') . "/";
 
-    my %shash; # sort order (key is resource location, value is sort order)
-    my %thash; # title (key is resource location, value is title)
-    my %nhash; # notes (key is resource location);
+    my @resources;
 
     if ($env{'form.readfile'}) {
-	&readfromfile($r,\%shash,\%thash,\%nhash);
+	&readfromfile($r,\@resources);
     } elsif ($env{'form.bookmarks'}) {
-	&readfrombookmarks($r,\%shash,\%thash);
+	&readfrombookmarks($r,\@resources);
     } else {
-	&readfromdb($r,\%shash,\%thash);
+	&readfromdb($r,\@resources);
     }
 
     my $ctr = 0;
-    my $clen = scalar(keys %shash);
+    my $clen = scalar(@resources);
     if (($clen > 1) || ($env{'form.readfile'}) || ($env{'form.bookmarks'})) {
 	my %lt=&Apache::lonlocal::texthash(
 		'fin'=> 'Finalize order of resources',
@@ -412,10 +386,9 @@ END
         $r->print(&Apache::loncommon::inhibit_menu_check('input'));
 
     }
-    foreach (sort {$shash{$a}<=>$shash{$b}} (keys %shash)) {
-	my $key=$_;
+    foreach my $resource (@resources) {
 	$ctr++;
-	my $iconname=&Apache::loncommon::icon($key);
+	my $iconname=&Apache::loncommon::icon($resource->{'url'});
 	if (($clen > 1) || ($env{'form.readfile'}) || ($env{'form.bookmarks'})) {
 	    $r->print("<tr><td bgcolor='$fileclr'>");
             if (($env{'form.readfile'}) || ($env{'form.bookmarks'})) {
@@ -424,7 +397,8 @@ END
 		$r->print(&movers($clen,$ctr));
 	    }
 	}
-	$r->print(&hidden($ctr-1,$thash{$key},$key));
+	$r->print(&hidden($ctr-1,$resource->{'title'},$resource->{'url'},
+			  $resource->{'id'}));
 	if (($clen > 1)  || ($env{'form.readfile'}) || ($env{'form.bookmarks'})) {
 	    $r->print("</td>");
             unless (($env{'form.readfile'}) || ($env{'form.bookmarks'})) {
@@ -435,8 +409,8 @@ END
 	    $r->print("<td bgcolor='$fileclr'>");
 	    $r->print("<img src='$iconname' />");
 	    $r->print("</td><td bgcolor='$fileclr'>");
-	    $r->print("$thash{$key}$nhash{$key}</td><td bgcolor='$fileclr'>\n");
-	    $r->print("$key</td></tr>\n");
+	    $r->print($resource->{'title'}.$resource->{'notes'}."</td><td bgcolor='$fileclr'>\n");
+	    $r->print($resource->{'url'}."</td></tr>\n");
 	} 
     }
     if (($clen > 1) || ($env{'form.readfile'}) || ($env{'form.bookmarks'})) {
@@ -456,12 +430,13 @@ END
 
 # --------------------------------------- Hidden values (returns scalar string)
 sub hidden {
-    my ($sel,$title,$filelink) = @_;
-    my $string = '<input type="hidden" name="title'.$sel.'" value="'.$title.
-	'" />';
+    my ($sel,$title,$filelink,$id) = @_;
+    my $string = '<input type="hidden" name="title'.$sel.'" value="'.
+	&escape($title).'" />';
     $filelink=~s|^/ext/|http://|;
     $string .= '<input type="hidden" name="filelink'.$sel.'" value="'.
-	$filelink.'" />';
+	&escape($filelink).'" />';
+    $string .= '<input type="hidden" name="id'.$sel.'" value="'.&escape($id).'" />';
     return $string;
 }