--- loncom/interface/lonaboutme.pm	2009/05/19 10:03:37	1.134
+++ loncom/interface/lonaboutme.pm	2009/10/13 16:37:57	1.140
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Personal Information Page
 #
-# $Id: lonaboutme.pm,v 1.134 2009/05/19 10:03:37 amueller Exp $
+# $Id: lonaboutme.pm,v 1.140 2009/10/13 16:37:57 amueller Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -203,22 +203,77 @@ sub handler {
                    ($env{'user.domain'} eq $cdom));
     if ($forcestudent or $target eq 'tex') { $allowed=0; }
 
-
 # --------------------------------------- There is such a user, get environment
 
     if ($target ne 'tex') {
         my $rss_link = &Apache::lonrss::rss_link($cnum,$cdom);
-        my $args = {'function' => $forcestudent,
+        my $args = {'function' => undef,
                     'domain'   => $cdom,
-                    'force_register' => $forceregister};
+# if this page is part of course content it looses the menu line when switching from Edit Mode to Public Mode. To avoid
+#this, I take take the value of the environment Variable $env{form.register}
+#                    'force_register' => $forceregister};
+                    'force_register' => $env{'form.register'}};
+
         if ($env{'form.popup'}) {
             $args->{'no_nav_bar'} = 1;
+		#Don't show breadcrumbs twice, when this page is part of course content and you call it  
+		} elsif ($env{'form.register'}) {
+			#do nothing
         } else { # Don't show breadcrumbs in popup window
             $args->{'bread_crumbs'} = [{href=>"/adm/$cdom/$cnum/aboutme",text=>"Personal Information Page"}];
         }
         my $start_page = &Apache::loncommon::start_page('Personal Information Page',$rss_link,$args);
         $r->print($start_page);
+   }
 
+#----------------Print Functions
+    if ($target ne 'tex') {
+        my $functions=&Apache::lonhtmlcommon::start_funclist();
+        if ($allowed) {
+            my $query_string = &build_query_string(
+                                   {'forcestudent' => '1',
+                                    'popup' => $env{'form.popup'}});
+            $functions.=&Apache::lonhtmlcommon::add_item_funclist(
+                            '<a href="'.$r->uri.$query_string.'">'
+                           .&mt('Show Public View').'</a>'
+                           .&Apache::loncommon::help_open_topic(
+                                'Uploaded_Templates_PublicView'));
+        } elsif ($privleged) {
+            my $query_string = &build_query_string(
+                                   {'forceedit' => '1',
+                                    'popup' => $env{'form.popup'}});
+            $functions.=&Apache::lonhtmlcommon::add_item_funclist(
+                            '<a href="'.$r->uri.$query_string.'">'
+                            .&mt('Edit').'</a>');
+        }
+        $functions.=&Apache::lonhtmlcommon::add_item_funclist(
+                        &Apache::lontemplate::send_message($r,$cnum,$cdom));
+
+        if ($env{'request.course.id'} &&
+            &Apache::lonnet::allowed('srm',$env{'request.course.id'}) &&
+            &in_course($cdom,$cnum)) {
+            if (&Apache::lonnet::allowed('vsa', $env{'request.course.id'}) ||
+                &Apache::lonnet::allowed('vsa', $env{'request.course.id'}.'/'.$env{'request.course.sec'})) {
+                $functions.=&Apache::lonhtmlcommon::add_item_funclist(
+                     &Apache::loncommon::track_student_link(
+                         'View recent activity by this student',$cnum,$cdom));
+            }
+            if (&Apache::lonnet::allowed('vgr', $env{'request.course.id'}) ||
+                &Apache::lonnet::allowed('vgr', $env{'request.course.id'}.'/'.$env{'request.course.sec'})) {
+                $functions.=&Apache::lonhtmlcommon::add_item_funclist(
+                    &Apache::loncommon::slot_reservations_link(
+                        'Slot reservation history',$cnum,$cdom));
+            }
+            $functions.=&Apache::lonhtmlcommon::add_item_funclist(
+                           &Apache::loncommon::noteswrapper(
+                               &mt('Add Records'),$cnum,$cdom));
+        }
+        $functions.=&Apache::lonhtmlcommon::end_funclist();
+        $r->print(&Apache::loncommon::head_subbox($functions));
+    }
+
+# Print Privacy Note
+    if ($target ne 'tex') {
         #Print Privacy Note
         if ($allowed) {
             $r->print('<div class="LC_info">'
@@ -227,9 +282,11 @@ sub handler {
                 .'</div>'
             );
         }
+    }
 
 #Print last modified
 
+    if ($target ne 'tex') {
         my $lastmod;
         if (($syllabus{'uploaded.lastmodified'}) || ($allowed)) {
             $lastmod=$syllabus{'uploaded.lastmodified'};
@@ -246,42 +303,10 @@ sub handler {
         }
     }
 
-#----------------Print Functions
-    if ($target ne 'tex') {
-         $r->print(&Apache::lontemplate::start_functionslist());
-         if ($allowed) {
-             my $query_string = &build_query_string({'forcestudent' => '1','popup' => $env{'form.popup'}});
-             $r->print(&Apache::lontemplate::item_functionslist(
-                 '<a href="'.$r->uri.$query_string.'">'.&mt('Show Public View').'</a>'
-                 .&Apache::loncommon::help_open_topic('Uploaded_Templates_PublicView')));
-         } elsif ($privleged) {
-             my $query_string = &build_query_string({'forceedit' => '1','popup' => $env{'form.popup'}});
-             $r->print(&Apache::lontemplate::item_functionslist(
-                 '<a href="'.$r->uri.$query_string.'">'. &mt('Edit').'</a>'));
-         }
-         $r->print(&Apache::lontemplate::item_functionslist(
-             &Apache::lontemplate::send_message($r,$cnum,$cdom)));
-
-         if ($env{'request.course.id'} && &Apache::lonnet::allowed('srm',$env{'request.course.id'}) && &in_course($cdom,$cnum)) {
-             if (&Apache::lonnet::allowed('vsa', $env{'request.course.id'}) || &Apache::lonnet::allowed('vsa', $env{'request.course.id'}.'/'.$env{'request.course.sec'})) {
-                     $r->print(&Apache::lontemplate::item_functionslist(
-                         &Apache::loncommon::track_student_link('View recent activity by this student',$cnum,$cdom)));
-             }
-             if (&Apache::lonnet::allowed('vgr', $env{'request.course.id'}) ||
-                 &Apache::lonnet::allowed('vgr', $env{'request.course.id'}.'/'.$env{'request.course.sec'})) {
-                 $r->print(&Apache::lontemplate::item_functionslist(
-                     &Apache::loncommon::slot_reservations_link('Slot reservation history',$cnum,$cdom)));
-             }
-             $r->print(&Apache::lontemplate::item_functionslist(
-                            &Apache::loncommon::noteswrapper(&mt('Add Records'),$cnum,$cdom)));
-         }
-         $r->print(&Apache::lontemplate::end_functionslist());
-    }
 #------Print Headtitle
      if ($target ne 'tex') {
-        $r->print('<div class="LC_ContentBoxSpecial">');
+        $r->print('<div class="LC_Box">');
         $r->print('<h2 class="LC_hcell">'.&Apache::loncommon::plainname($cnum,$cdom).'</h2>');
-        $r->print('<div class="LC_BoxPadding">' );
          if ($courseenv{'nickname'}) {
                $r->print('<h2>&quot;'.$courseenv{'nickname'}.'&quot;</h2>');
         }
@@ -335,7 +360,7 @@ sub handler {
             &Apache::lonnet::resizeImage(&Apache::lonnet::filelocation('',$syllabus{'uploaded.photourl'}));
            #---End Resize---
 
-            $image=qq{<img name="userPhoto" src="$syllabus{'uploaded.photourl'} " class="LC_AboutMe_Image" />};
+            $image=qq|<img name="userPhoto" src="$syllabus{'uploaded.photourl'} " class="LC_AboutMe_Image" alt="Photo of the user" />|;
 
             if ($target eq 'tex') {
                 $image=&Apache::lonxml::xmlparse($r,'tex',$image);
@@ -345,25 +370,23 @@ sub handler {
 
         if ($allowed) {
             $r->print(
-                '<form method="post" enctype="multipart/form-data">'.
+                '<form name="UploadPhoto" method="post" enctype="multipart/form-data" action="">'.
                 '<h3>'.&mt('Upload a Photo').'</h3>'.
                 '<input type="file" name="uploaddoc" size="50" />'.
                 '<input type="submit" name="storeupl" value="'.&mt('Upload').'" />'.
                 '<input type="hidden" name="popup" value="'.$env{'form.popup'}.'" />'.
                 '</form>');
             if ($syllabus{'uploaded.photourl'}) {
-                $r->print('<form method="post"><input type="submit" name="delupl" value="'.&mt('Delete Photo').'" /> </form>')
+                $r->print('<form name="delPhoto" method="post" action="" ><input type="submit" name="delupl" value="'.&mt('Delete Photo').'" /> </form>')
             }
-            $r->print('<p>');
+            $r->print('<p></p>');
         }
 
         if($allowed) {
-            $r->print('<form method="post">');
+            $r->print('<form name="lonaboutmeFields" method="post" action="" >');
         }
 
         if ($target ne 'tex') { #print Image
-            &Apache::lontemplate::start_ContentBox($r);
-            &Apache::lontemplate::end_ContentBox($r);
             $r->print($image);
 
         } #End Print Image
@@ -375,7 +398,7 @@ sub handler {
         if ($target ne 'tex') { #Begin Print RSS and portfiles
             &print_portfiles_link($r,$is_course);
             if (&Apache::lonrss::advertisefeeds($cnum,$cdom) ne '') {
-                &Apache::lontemplate::print_start_template($r,'RSS Feeds and Blogs','LC_ContentBoxSpecial');
+                &Apache::lontemplate::print_start_template($r,'RSS Feeds and Blogs','LC_Box');
                 $r->print(&Apache::lonrss::advertisefeeds($cnum,$cdom));
                 &Apache::lontemplate::print_end_template($r);
             }
@@ -400,22 +423,20 @@ sub handler {
         && &in_course($cdom,$cnum)) {
         if ($target ne 'tex') {
             $r->print('<a name="coursecomment" />');
-            &Apache::lontemplate::print_start_template($r,&mt('User Notes, Records of Face-To-Face Discussions, and Critical Messages in Course'),'LC_ContentBoxSpecial');
+            &Apache::lontemplate::print_start_template($r,&mt('User Notes, Records of Face-To-Face Discussions, and Critical Messages in Course'),'LC_Box');
             $r->print('<span class="LC_info">');
             $r->print(&mt('Shared by course faculty and staff').&Apache::loncommon::help_open_topic("Course_Face_To_Face_Records,Course_Critical_Message"));
-            $r->print('</span> <p>');
+            $r->print('</span>');
             &Apache::lonmsgdisplay::disfacetoface($r,$cnum,$cdom);
-            $r->print('</p>');
             &Apache::lontemplate::print_end_template($r);
 
         } else {
             $r->print('\\\\\textbf{'.&mt('User Notes, Records of Face-To-Face Discussions, and Critical Messages in Course').'}\\\\'.&mt('Shared by course faculty and staff').'\\\\\\\\');
-            &Apache::lonmsgdisplay::disfacetoface($r,$cnum,$cdom);
+            &Apache::lonmsgdisplay::disfacetoface($r,$cnum,$cdom, 'tex');
         }
     }
     if ($target ne 'tex') {
         $r->print('</div>');
-        $r->print('</div>');
         if ($env{'form.popup'}) {
             $r->print('<p><a href="javascript:window.close()">'.&mt('Close window').'</a>');
         }
@@ -479,8 +500,8 @@ sub print_portfiles_link {
         'difl' => 'Display file listing',
     );
     if ($filecounts->{'both'} > 0) {
-        $output = '<div class="LC_ContentBoxSpecial"><h4 class="LC_hcell">';
-        $output .= ($is_course?$lt{'vgpf'}:$lt{'vpfi'}).'</h4><div class="LC_BoxPadding">';
+        $output = '<div class="LC_Box"><h4 class="LC_hcell">';
+        $output .= ($is_course?$lt{'vgpf'}:$lt{'vpfi'}).'</h4>';
 
        #$output = '<h4>'.($is_course?$lt{'vgpf'}:$lt{'vpfi'}).'</h4>';
         $output .= '<a href="/adm/'.$cdom.'/'.$cnum.'/aboutme/portfolio'.
@@ -506,8 +527,7 @@ sub print_portfiles_link {
             $output .= '<li>'.&mt('[quant,_1,file requires,files require] a passphrase for access.',$filecounts->{'withpass'}).'</li>';
         }
         $output .= '</ul>';
-        $output .='</p>';
-        $output .='</div></div>';
+        $output .= '</div>';
     }
     $r->print($output);
     return;