--- loncom/interface/lonaboutme.pm	2010/03/29 12:21:38	1.146
+++ loncom/interface/lonaboutme.pm	2021/01/02 21:07:36	1.160
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Personal Information Page
 #
-# $Id: lonaboutme.pm,v 1.146 2010/03/29 12:21:38 raeburn Exp $
+# $Id: lonaboutme.pm,v 1.160 2021/01/02 21:07:36 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -50,8 +50,6 @@ described at http://www.lon-capa.org.
 
 =item handler()
 
-=item in_course()
-
 =item aboutme_info()
 
 =item print_portfiles_link()
@@ -80,11 +78,12 @@ use Apache::Constants qw(:common);
 use Apache::loncommon;
 use Apache::lonnet;
 use Apache::lontexconvert;
-use Apache::lonfeedback;
+use Apache::lonhtmlgateway;
 use Apache::lonrss();
 use Apache::lonlocal;
 use Apache::lonmsgdisplay();
 use Apache::lontemplate;
+use Apache::longroup;
 use HTML::Entities();
 use Image::Magick;
 
@@ -121,7 +120,7 @@ sub handler {
                     $r->print('\noindent{\large\textbf{'.&mt('No user personal information page available').'}}\\\\\\\\');
                 } else {
                     $r->print(&Apache::loncommon::start_page("Personal Information Page"));
-                    $r->print('<h2>'.&mt('No user personal information page available') .'</h2>'.
+                    $r->print('<p class="_LC_info">'.&mt('No user personal information page available') .'</p>'.
                         &mt('This is a result of one of the following:').'<ul>'.
                         '<li>'.&mt('The administrator of this domain has disabled personal information page functionality for this specific user.').'</li>'.
                         '<li>'.&mt('The domain has been configured to disable, by default, personal information page functionality for all users in the domain.').'</li>'.
@@ -141,9 +140,8 @@ sub handler {
 
 # ------------------------------------------------------------ Get Query String
     &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'},
-                        ['forceedit','forcestudent',
-                         'register','popup']);
-
+                        ['forceedit','forcestudent','todocs',
+                         'register','popup','folderpath','title']);
 # ----------------------------------------------- Available Portfolio file display
     if (($target ne 'tex') && ($action eq 'portfolio')) {
         &display_portfolio_header($r,$is_course);
@@ -168,7 +166,7 @@ sub handler {
 
     if ($is_course) {
         if ($target ne 'tex') {
-            my $args = {'function'       => $env{'forcestudent'},
+            my $args = {'function'       => undef,
                         'domain'         => $cdom};
             if ($env{'form.register'}) {
                 $args->{'force_register'} = $env{'form.register'};
@@ -192,17 +190,24 @@ sub handler {
         return OK;
     }
 
-# --------------------------------------------------------------- Force Student
-    my $forcestudent='';
-    if ($env{'form.forcestudent'}) { $forcestudent='student'; };
-
 #------------Get rights
     my %courseenv=&Apache::lonnet::dump('environment',$cdom,$cnum);
-     my %syllabus=&Apache::lonnet::dump('aboutme',$cdom,$cnum);
-    my $allowed=0;
-      my $privleged=$allowed=(($env{'user.name'} eq $cnum) &&
-                   ($env{'user.domain'} eq $cdom));
-    if ($forcestudent or $target eq 'tex') { $allowed=0; }
+    my %syllabus=&Apache::lonnet::dump('aboutme',$cdom,$cnum);
+    my ($allowed,$coursedomain,$coursenum);
+    if ($env{'request.course.id'}) {
+        $coursedomain = $env{'course.'.$env{'request.course.id'}.'.domain'};
+        $coursenum = $env{'course.'.$env{'request.course.id'}.'.num'};
+    }
+    my ($cfile) = 
+        &Apache::lonnet::can_edit_resource($env{'request.noversionuri'},
+                                           $coursenum,$coursedomain,
+                                           $env{'request.noversionuri'},
+                                           $env{'request.symb'});
+    if ($cfile ne '') {
+        $allowed = 1;
+    }
+
+    if (!$env{'form.forceedit'} or $target eq 'tex') { $allowed=0; }
 
 # --------------------------------------- There is such a user, get environment
 
@@ -215,60 +220,40 @@ sub handler {
         if ($env{'form.popup'}) { # Don't show breadcrumbs in popup window 
             $args->{'no_nav_bar'} = 1;
         } elsif (!$env{'form.register'}) { #Don't show breadcrumbs twice, when this page is part of course content and you call it
-            $args->{'bread_crumbs'} = [{href=>"/adm/$cdom/$cnum/aboutme",
-                                        text=>"Personal Information Page"}];
+            if (($env{'request.course.id'}) &&
+                 ($env{'form.folderpath'} =~ /^supplemental/)) {
+                my $crstype = &Apache::loncommon::course_type();
+                my $title = $env{'form.title'};
+                if ($title eq '') {
+                    $title = &mt('Personal Information Page');
+                }
+                my $brcrum =
+                    &Apache::lonhtmlcommon::docs_breadcrumbs(undef,$crstype,undef,$title,1);
+                if (ref($brcrum) eq 'ARRAY') {
+                    $args->{'bread_crumbs'} = $brcrum;
+                }
+            } else {
+                $args->{'bread_crumbs'} = [{href=>"/adm/$cdom/$cnum/aboutme",
+                                            text=>"Personal Information Page"}];
+            }
         }
         my $start_page = &Apache::loncommon::start_page('Personal Information Page',$rss_link,$args);
         $r->print($start_page);
    }
+   my ($blocked,$blocktext) =
+       &Apache::loncommon::blocking_status('about',$cnum,$cdom);
+   if ($blocked) {
+       if ($target eq 'tex') {
+           $r->print('\noindent{\large\textbf{'.&mt('No user personal information page available').'}}\\\\\\\\');
+       } else {
+           $r->print($blocktext);
+       }
+       $r->print(&Apache::loncommon::end_page());
+       return OK;
+   }
 
-#----------------Print Functions
-    if ($target ne 'tex') {
-        my $functions=&Apache::lonhtmlcommon::start_funclist();
-        if ($allowed) {
-            my $query_string = &build_query_string(
-                                   {'forcestudent' => '1',
-                                    'popup' => $env{'form.popup'}});
-            $functions.=&Apache::lonhtmlcommon::add_item_funclist(
-                            '<a href="'.$r->uri.$query_string.'">'
-                           .&mt('Show Public View').'</a>'
-                           .&Apache::loncommon::help_open_topic(
-                                'Uploaded_Templates_PublicView'));
-        } elsif ($privleged) {
-            my $query_string = &build_query_string(
-                                   {'forceedit' => '1',
-                                    'popup' => $env{'form.popup'}});
-            $functions.=&Apache::lonhtmlcommon::add_item_funclist(
-                            '<a href="'.$r->uri.$query_string.'">'
-                            .&mt('Edit').'</a>');
-        }
-        $functions.=&Apache::lonhtmlcommon::add_item_funclist(
-                        &Apache::lontemplate::send_message($r,$cnum,$cdom));
-
-        if ($env{'request.course.id'} &&
-            &Apache::lonnet::allowed('srm',$env{'request.course.id'}) &&
-            &in_course($cdom,$cnum)) {
-            if (&Apache::lonnet::allowed('vsa', $env{'request.course.id'}) ||
-                &Apache::lonnet::allowed('vsa', $env{'request.course.id'}.'/'.$env{'request.course.sec'})) {
-                $functions.=&Apache::lonhtmlcommon::add_item_funclist(
-                     &Apache::loncommon::track_student_link(
-                         'View recent activity by this student',$cnum,$cdom));
-            }
-            if (&Apache::lonnet::allowed('vgr', $env{'request.course.id'}) ||
-                &Apache::lonnet::allowed('vgr', $env{'request.course.id'}.'/'.$env{'request.course.sec'})) {
-                $functions.=&Apache::lonhtmlcommon::add_item_funclist(
-                    &Apache::loncommon::slot_reservations_link(
-                        'Slot reservation history',$cnum,$cdom));
-            }
-            $functions.=&Apache::lonhtmlcommon::add_item_funclist(
-                           &Apache::loncommon::noteswrapper(
-                               &mt('Add Records'),$cnum,$cdom));
-        }
-        $functions.=&Apache::lonhtmlcommon::end_funclist();
-        $r->print(&Apache::loncommon::head_subbox($functions));
-    }
+#----------------Print Privacy note (edit mode) or last modified date. 
 
-# Print Privacy Note
     if ($target ne 'tex') {
         #Print Privacy Note
         if ($allowed) {
@@ -277,36 +262,36 @@ sub handler {
                 .&mt('The information you submit can be viewed by anybody who is logged into LON-CAPA. Do not provide information that you are not ready to share publicly.')
                 .'</div>'
             );
-        }
-    }
-
-#Print last modified
-
-    if ($target ne 'tex') {
-        my $lastmod;
-        if (($syllabus{'uploaded.lastmodified'}) || ($allowed)) {
-            $lastmod=$syllabus{'uploaded.lastmodified'};
+        } elsif ($syllabus{'uploaded.lastmodified'}) {
+        #Print last modified
+            my $lastmod=$syllabus{'uploaded.lastmodified'};
             $lastmod=($lastmod?&Apache::lonlocal::locallocaltime($lastmod):&mt('never'));
             $r->print('<div class="LC_info">');
-             $r->print(&mt('Last updated').': '.$lastmod . '');
+            $r->print(&mt('Last updated').': '.$lastmod . '');
             $r->print('</div>');
         }
     }
-#Print Help Text
-    if ($target ne 'tex') {
-        if($allowed){
-            $r->print(&Apache::loncommon::help_open_topic('Uploaded_Templates_TextBoxes',&mt('Help with filling in text boxes')));
-        }
-    }
 
 #------Print Headtitle
      if ($target ne 'tex') {
-        $r->print('<div class="LC_Box">');
-        $r->print('<h2 class="LC_hcell">'.&Apache::loncommon::plainname($cnum,$cdom).'</h2>');
-         if ($courseenv{'nickname'}) {
-               $r->print('<h2>&quot;'.$courseenv{'nickname'}.'&quot;</h2>');
-        }
-        $r->print('<h3>'.&Apache::lonnet::domain($cdom,'description').'</h3>');
+         $r->print('<div class="LC_Box">'.
+                   '<h2 class="LC_hcell">'.&Apache::loncommon::plainname($cnum,$cdom).'</h2>');
+         if ($allowed) {
+             $r->print('<div style="margin: 0; float:left;">');
+             if ($courseenv{'nickname'}) {
+                 $r->print('<h2>&quot;'.$courseenv{'nickname'}.'&quot;</h2>');
+             }
+             $r->print('<h3>'.&Apache::lonnet::domain($cdom,'description').'</h3></div>');
+             #Print Help Text
+             $r->print('<div style="margin: 0; float:right;">'.
+                       &Apache::loncommon::help_open_topic('Uploaded_Templates_TextBoxes',&mt('Help with filling in text boxes')).
+                       '</div><br clear="all" />');
+         } else {
+             if ($courseenv{'nickname'}) {
+                 $r->print('<h2>&quot;'.$courseenv{'nickname'}.'&quot;</h2>');
+             }
+             $r->print('<h3>'.&Apache::lonnet::domain($cdom,'description').'</h3>');
+         }
      } else {
         $r->print('\noindent{\large\textbf{'.&Apache::loncommon::plainname($cnum,$cdom).'}}\\\\\\\\');
         $r->print('\textbf{'.&Apache::lonnet::domain($cdom,'description').'}\\\\');
@@ -339,8 +324,9 @@ sub handler {
     if (($allowed) && ($env{'form.storesyl'})) {
         foreach my $syl_field (keys(%syllabusfields)) {
             my $field=$env{'form.'.$syl_field};
-            $field=~s/\s+$//s;
-            $field=&Apache::lonfeedback::clear_out_html($field,$env{'user.adv'});
+            chomp($field);
+            my $gateway = Apache::lonhtmlgateway->new();
+            $field = $gateway->process_incoming_html($field,1);
             $syllabus{$syl_field}=$field;
         }
         $syllabus{'uploaded.lastmodified'}=time;
@@ -409,12 +395,12 @@ sub handler {
         }
         if ($target ne 'tex') {$r->print('<br />');} else {$r->print('\\\\');}
     } else {
-        $r->print('<p>'.&mt('No personal information provided').'.</p>');
+        $r->print('<p class="LC_info">'.&mt('No personal information provided').'.</p>');
     }
 
     if ($env{'request.course.id'}
         && &Apache::lonnet::allowed('srm',$env{'request.course.id'})
-        && &in_course($cdom,$cnum)) {
+        && &Apache::lonnet::in_course($cdom,$cnum,$coursedomain,$coursenum,undef,1)) {
         if ($target ne 'tex') {
             $r->print('<a name="coursecomment" />');
             &Apache::lontemplate::print_start_template($r,&mt('User Notes, Records of Face-To-Face Discussions, and Critical Messages in Course'),'LC_Box');
@@ -426,13 +412,13 @@ sub handler {
 
         } else {
             $r->print('\\\\\textbf{'.&mt('User Notes, Records of Face-To-Face Discussions, and Critical Messages in Course').'}\\\\'.&mt('Shared by course faculty and staff').'\\\\\\\\');
-            &Apache::lonmsgdisplay::disfacetoface($r,$cnum,$cdom, 'tex');
+            &Apache::lonmsgdisplay::disfacetoface($r,$cnum,$cdom,$target);
         }
     }
     if ($target ne 'tex') {
         $r->print('</div>');
         if ($env{'form.popup'}) {
-            $r->print('<p><a href="javascript:window.close()">'.&mt('Close window').'</a>');
+            $r->print('<p><a href="javascript:window.close()">'.&mt('Close window').'</a></p>');
         }
         $r->print(&Apache::loncommon::end_page());
     } else {
@@ -444,33 +430,6 @@ sub handler {
     return OK;
 }
 
-sub in_course {
-    my ($udom,$uname,$cdom,$cnum,$type) = @_;
-    $type ||= 'any';
-    if (!defined($cdom) || !defined($cnum)) {
-        my $cid  = $env{'request.course.id'};
-        $cdom = $env{'course.'.$cid.'.domain'};
-        $cnum = $env{'course.'.$cid.'.num'};
-    }
-    my %roles = &Apache::lonnet::dump('roles',$udom,$uname);
-    my @course_roles = grep(m{^/\Q$cdom\E/\Q$cnum\E[/_]}, keys(%roles));
-    return 0 if (!@course_roles);
-    return 1 if ($type eq 'any');
-    my $now = time();
-    foreach my $role (@course_roles) {
-        my (undef,$role_end,$role_start)=split(/\_/,$roles{$role});
-        my $status = 'active';
-        if ($role_start > 0 && $now < $role_start) {
-            $status = 'future';
-        }
-        if ($role_end > 0 && $now > $role_end) {
-            $status = 'previous';
-        }
-        return 1 if ($status eq $type);
-    }
-    return 0;
-}
-
 sub aboutme_info {
     my ($r,$is_course) = @_;
     my (undef,undef,$cdom,$cnum)=split(/\//,$r->uri);
@@ -594,7 +553,7 @@ sub display_portfolio_header {
                           title => &mt('Go to personal information page for [_1]',$name),
                           no_mt => 1},
                          {href  => "/adm/$cdom/$cnum/aboutme/portfolio".$query_string,
-                          text  => 'Viewable files',
+                          text  => &mt('Viewable files'),
                           title => &mt('Viewable portfolio files for [_1]',$name),
                           no_mt => 1}
                          ];
@@ -683,9 +642,12 @@ sub portfolio_files {
     my $diroutput;
     if ($is_course) {
         my %files_by_group;
+        my %curr_groups = &Apache::longroup::coursegroups($cdom,$cnum);
         foreach my $filename (sort(keys(%access_controls))) {
             my ($group,$path) = split('/',$filename,2);
-            $files_by_group{$group}{$path} = $access_controls{$filename};
+            if (exists($curr_groups{$group})) {
+                $files_by_group{$group}{$path} = $access_controls{$filename};
+            }
         }
         foreach my $group (sort(keys(%files_by_group))) {
             my %fileshash;
@@ -720,9 +682,11 @@ sub portfolio_files {
 sub build_hierarchy {
     my ($r,$cdom,$cnum,$portaccess,$is_course,$filecounts,$mode,$access_info,
         $allfileshash,$group) = @_;
+    my $clientip = &Apache::lonnet::get_requestor_ip($r);
     foreach my $filename (sort(keys(%{$access_info}))) {
         my $access_status =
-           &Apache::lonnet::get_portfolio_access($cdom,$cnum,$filename,$group,$$access_info{$filename});
+           &Apache::lonnet::get_portfolio_access($cdom,$cnum,$filename,$group,$clientip,
+                                                 $access_info->{$filename});
         if ($portaccess eq 'both') {
             if (($access_status ne 'ok') &&
                 ($access_status !~  /^[^:]+:guest_/)) {
@@ -779,9 +743,12 @@ sub parse_directory {
     my $portfolio_root = &Apache::portfolio::get_portfolio_root($cdom,$cnum,
                                                                 $group);
     my $getpropath = 1;
-    my %dirlist = map {
-        ((split('&',$_,2))[0],1)
-    } &Apache::lonnet::dirlist($portfolio_root.$path,$cdom,$cnum,$getpropath);
+    my ($listref,$listerror) =
+        &Apache::lonnet::dirlist($portfolio_root.$path,$cdom,$cnum,$getpropath);
+    my %dirlist;
+    if (ref($listref) eq 'ARRAY') {
+        %dirlist = map { ((split('&',$_,2))[0],1) } @{$listref};
+    }
     foreach my $item (sort(keys(%{$currhash}))) {
         $output .= &Apache::loncommon::start_data_table_row();
         $output .= '<td style="padding-left: '.($depth*25).'px">';
@@ -851,7 +818,7 @@ sub aboutme_access {
     }
     if ((&Apache::lonnet::allowed('srm',$privcheck)) ||
         (&Apache::lonnet::allowed('dff',$privcheck))) {
-        if (&in_course($uname,$udom,$cnum,$cdom)) {
+        if (&Apache::lonnet::in_course($uname,$udom,$cnum,$cdom,undef,1)) {
             return 1;
         }
     }