--- loncom/interface/loncommon.pm 2004/10/29 18:40:40 1.224 +++ loncom/interface/loncommon.pm 2004/11/02 19:01:12 1.225 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # a pile of common routines # -# $Id: loncommon.pm,v 1.224 2004/10/29 18:40:40 raeburn Exp $ +# $Id: loncommon.pm,v 1.225 2004/11/02 19:01:12 matthew Exp $ # # Copyright Michigan State University Board of Trustees # @@ -3292,7 +3292,18 @@ sub DrawBarGraph { if (! @Values || ref($Values[0]) ne 'ARRAY') { return ''; } + # + my @Labels; + if (defined($labels)) { + @Labels = @$labels; + } else { + for (my $i=0;$i<@{$Values[0]};$i++) { + push (@Labels,$i+1); + } + } + # my $NumBars = scalar(@{$Values[0]}); + if ($NumBars < scalar(@Labels)) { $NumBars = scalar(@Labels); } my %ValuesHash; my $NumSets=1; foreach my $array (@Values) { @@ -3302,10 +3313,14 @@ sub DrawBarGraph { } # my ($height,$width,$xskip,$bar_width) = (200,120,1,15); - if ($NumBars < 5) { - $width = 120+$NumBars*25; + if ($NumBars < 3) { + $width = 120+$NumBars*32; $xskip = 1; - $bar_width = 25; + $bar_width = 30; + } elsif ($NumBars < 5) { + $width = 120+$NumBars*20; + $xskip = 1; + $bar_width = 20; } elsif ($NumBars < 10) { $width = 120+$NumBars*15; $xskip = 1; @@ -3324,15 +3339,6 @@ sub DrawBarGraph { $bar_width = 4; } # - my @Labels; - if (defined($labels)) { - @Labels = @$labels; - } else { - for (my $i=0;$i<@{$Values[0]};$i++) { - push (@Labels,$i+1); - } - } - # $Max = 1 if ($Max < 1); if ( int($Max) < $Max ) { $Max++;