--- loncom/interface/loncoursequeueadmin.pm 2010/03/30 16:02:27 1.24 +++ loncom/interface/loncoursequeueadmin.pm 2013/07/24 18:21:39 1.36 @@ -1,7 +1,7 @@ # The LearningOnline Network # Utilities to administer domain course requests and course self-enroll requests # -# $Id: loncoursequeueadmin.pm,v 1.24 2010/03/30 16:02:27 raeburn Exp $ +# $Id: loncoursequeueadmin.pm,v 1.36 2013/07/24 18:21:39 bisitz Exp $ # # Copyright Michigan State University Board of Trustees # @@ -70,6 +70,14 @@ described at http://www.lon-capa.org. =item process_official_reqs() +=item is_active_author() + +=item author_prompt() + +=item reqauthor_check() + +=item process_reqauthor() + =back =cut @@ -90,19 +98,28 @@ sub send_selfserve_notification { # FIXME locallocaltime needs to be able to take $sender_lh as an argument # so this can be localized to the recipients date display format/time zone $timestamp =&Apache::lonlocal::locallocaltime($timestamp); - my $msgcc; - my ($rawsubj,@rawmsg,$subject,$message,$reviewer,$msgtxt); + my ($msgcc,$rawsubj,@rawmsg,$subject,$message,$reviewer,$msgtxt); + my ($senderuname,$senderudom) = split(':',$sender); if ($context eq 'coursemanagers') { $rawsubj = 'Self-enrollment requests processed'; push(@rawmsg,{ mt => 'Enrollment requests in the following course: [_1] have been processed.', - args => ["\n $contextdesc"], + args => ["\n$contextdesc"], }); } elsif ($context eq 'domainmanagers') { $rawsubj = 'Course/Community requests reviewed'; push(@rawmsg,{ - mt => 'Course/Community creation requests in the following domain: [_1] have been reviewed.', - args => ["\n $contextdesc"], + mt => 'Course/Community creation requests in the following domain: "[_1]" have been reviewed.', + args => ["\n$contextdesc"], + }); + if (ref($textstr) eq 'ARRAY') { + push(@rawmsg,@{$textstr}); + } + } elsif ($context eq 'authormanagers') { + $rawsubj = 'Authoring space requests reviewed'; + push(@rawmsg,{ + mt => 'Authoring requests in the following domain: "[_1]" have been reviewed.', + args => ["\n$contextdesc"], }); if (ref($textstr) eq 'ARRAY') { push(@rawmsg,@{$textstr}); @@ -138,6 +155,15 @@ sub send_selfserve_notification { if (ref($textstr) eq 'ARRAY') { push(@rawmsg,@{$textstr}); } + } elsif ($context eq 'pendingrequestor') { + if ($crstype eq 'Community') { + $rawsubj = 'Community request'; + } else { + $rawsubj = 'Processed course request'; + } + if (ref($textstr) eq 'ARRAY') { + push(@rawmsg,@{$textstr}); + } } elsif ($context eq 'coursereq') { if ($crstype eq 'community') { $rawsubj = 'Community request to review'; @@ -152,14 +178,14 @@ sub send_selfserve_notification { }, { mt =>'[_1]As Domain Coordinator, use: [_2]Main Menu -> Course and community creation -> Approve or reject requests[_3]to display a list of pending requests, which you can either approve or reject.', - args => ["\n","\n\n ","\n\n"], + args => ["\n","\n\n","\n\n"], }); } elsif ($context eq 'selfenrollreq') { $rawsubj = 'Self-enrollment request'; if ($crstype eq 'community') { - $msgtxt = 'Enrollment in the following community: [_1] was requested by [_2] on [_3].' + $msgtxt = 'Enrollment in the following community: [_1]was requested by [_2] on [_3].' } else { - $msgtxt = 'Enrollment in the following course: [_1] was requested by [_2] on [_3].' + $msgtxt = 'Enrollment in the following course: [_1]was requested by [_2] on [_3].' } push(@rawmsg,{ mt => $msgtxt, @@ -176,7 +202,28 @@ sub send_selfserve_notification { mt => $directions, args => [" \n\n","\n"], }); + } elsif ($context eq 'authorreq') { + $rawsubj = 'Authoring space request to review'; + $msgtxt = 'Assignment of an author role in the [_1] domain[_2]was requested by [_3] on [_4].'; + push(@rawmsg,{ + mt => $msgtxt, + args => [$contextdesc,"\n",$textstr,$timestamp], + }, + { + mt =>'[_1]As Domain Coordinator, use: [_2]Main Menu -> Create users or modify the roles and privileges of users -> Authoring space reqests[_3]to display a list of pending requests, which you can either approve or reject.', + args => ["\n","\n\n ","\n\n"], + }); + } elsif ($context eq 'requestauthor') { + $rawsubj = 'Authoring space request'; + $msgtxt = 'Your request for an authoring space requested on [_1]has been reviewed by a Domain Coordinator.'; + push(@rawmsg,{ + mt => $msgtxt, + args => [$timestamp."\n"], + }); + if (ref($textstr) eq 'ARRAY') { + push(@rawmsg,@{$textstr}); + } } my @to_notify = split(/,/,$notifylist); my $numsent = 0; @@ -213,7 +260,7 @@ sub send_selfserve_notification { $message .= &Apache::lonlocal::mt_user($sender_lh,$item->{mt},@{$item->{args}})."\n"; } } - &Apache::lonmsg::process_sent_mail($subject,'',$numsent,$stamp,$uname,$udom,$msgcount,$cid,$$,$message,\@recusers,\@recudoms); + &Apache::lonmsg::process_sent_mail($subject,'',$numsent,$stamp,$uname,$udom,$msgcount,$cid,$$,$message,\@recusers,\@recudoms,undef,undef,undef,undef,$senderuname,$senderudom); my ($recipid,$recipstatus) = &Apache::lonmsg::store_recipients($subject,$uname,$udom,\%reciphash); my $status; foreach my $recip (sort(keys(%{$msgcc}))) { @@ -241,6 +288,13 @@ sub send_selfserve_notification { if ($rejectedlist) { $message .= "\n\n".&Apache::lonlocal::mt_user($sender_lh,'Rejected course requests:')."\n".$rejectedlist; } + } elsif ($context eq 'authormanagers') { + if ($approvedlist) { + $message .= "\n\n".&Apache::lonlocal::mt_user($sender_lh,'Approved author role requests:')."\n".$approvedlist; + } + if ($rejectedlist) { + $message .= "\n\n".&Apache::lonlocal::mt_user($sender_lh,'Rejected author role requests:')."\n".$rejectedlist; + } } $status .= &Apache::lonmsg::user_normal_msg($ccname,$ccdom,$subject,$message,undef,undef,undef,1,\%sentmessage,undef,undef,undef,1,$recipid).','; } @@ -256,6 +310,11 @@ sub display_queued_requests { $namespace = 'selfenrollrequests'; %requesthash = &Apache::lonnet::dump($namespace,$dom,$cnum); $nextelement = ''; + } elsif ($context eq 'requestauthor') { + $formaction = '/adm/createuser'; + $namespace = 'requestauthorqueue'; + %requesthash = &Apache::lonnet::dump_dom($namespace,$dom); + $nextelement = ''; } else { $formaction = '/adm/createcourse'; $namespace = 'courserequestqueue'; @@ -278,6 +337,9 @@ sub display_queued_requests { if ($context eq 'course') { ($timestamp, my $usec) = split(/:/,$requesthash{$item}); $entry = $item.':'.$usec; + } elsif ($context eq 'requestauthor') { + $timestamp = $requesthash{$item}; + ($entry) = ($item =~ /^($match_username)_approval$/); } else { $timestamp = $requesthash{$item}{'timestamp'}; if (ref($requesthash{$item}) eq 'HASH') { @@ -307,8 +369,10 @@ sub display_queued_requests { $output .= '

'.&mt('Requests for official courses queued pending validation').'

'. '

'.&mt('Requests are validated against institutional data to confirm that the requestor is an instructor of record.').'
'. &mt('Validation is attempted when the request is submitted.').' '.&mt('If unvalidated, the request will be held in a queue.').' '.&mt('Validation of pending requests is automatically repeated daily.').'

'; + } elsif ($context eq 'requestauthor') { + $output .= '

'.&mt('Requests for authoring space queued pending approval by a Domain Coordinator').'

'; } else { - $output .= '

'.&mt('Course/Community requests queued pending approval by a Domain Coordinator').'

'; + $output .= '

'.&mt('Course/Community requests queued pending approval by a Domain Coordinator').'

'; } $output .= &build_queue_display($dom,$context,\%queue_by_date). ''; @@ -318,6 +382,8 @@ sub display_queued_requests { $output .= &mt('There are currently no enrollment requests awaiting approval.'); } elsif ($context eq 'pending') { $output .= &mt('There are currently no requests for official courses awaiting validation.'); + } elsif ($context eq 'requestauthor') { + $output .= &mt('There are currently no requests for authoring space awaiting approval.'); } elsif ($context eq 'domain') { $output .= &mt('There are currently no course or community requests awaiting approval.'); } @@ -358,6 +424,8 @@ sub build_queue_display { if ($context eq 'course') { $output .= ''.&mt('Section').''. ''.&mt('Date requested').''; + } elsif ($context eq 'requestauthor') { + $output .= ''.&mt('Date requested').''; } elsif ($context eq 'pending' || $context eq 'stillpending') { $output .= ''.&mt('Institutional code').''. ''.&mt('Date requested').''. @@ -392,6 +460,14 @@ sub build_queue_display { $namelink = &Apache::loncommon::aboutmewrapper( &Apache::loncommon::plainname($puname,$pudom), $puname,$pudom); + } elsif ($context eq 'requestauthor') { + if (&Apache::lonnet::homeserver($request,$dom) ne 'no_host') { + $approve = $count.':'.$request; + $reject = $request; + $namelink = &Apache::loncommon::aboutmewrapper( + &Apache::loncommon::plainname($request,$dom), + $request,$dom); + } } else { my ($cnum,$ownername,$ownerdom,$type,$cdesc); my $queue = 'approval'; @@ -415,14 +491,19 @@ sub build_queue_display { } unless ($context eq 'pending') { $row = '
'. - '
'; + ''.&mt('Approve').''. + ''. + '
'; } $row .= ''.$namelink.''."\n"; if ($context eq 'course') { $row .= ''.$showsec.''."\n". ''.$showtime.''."\n"; + } elsif ($context eq 'requestauthor') { + $row .= ''.$showtime.''."\n"; } else { if ($context eq 'pending' || $context eq 'stillpending') { $row .= ''.$instcode.''."\n"; @@ -446,14 +527,25 @@ sub build_queue_display { sub update_request_queue { my ($context,$cdom,$cnum,$coursedesc) = @_; my ($output,$access_start,$access_end,$limit,$cap,$notifylist,$namespace, - $stucounts,$idx,$classlist,%requesthash,$cid,$hostname,$protocol, - $domdesc,$now,$sender,$approvedmsg,$rejectedmsg,$beneficiary, + $stucounts,$idx,$classlist,%requesthash,$cid,$domdesc,$now, + $sender,$approvedmsg,$rejectedmsg,$beneficiary, @existing,@missingreq,@invalidusers,@limitexceeded,@completed, @processing_errors,@warn_approves,@warn_rejects,@approvals,@warn_dels, - @rejections,@rejectionerrors,@nopermissions,%courseroles, - %communityroles,%domdefs,%approvalmsg,%rejectionmsg,$crstype,$queue); - @approvals = &Apache::loncommon::get_env_multiple('form.approvereq'); - @rejections = &Apache::loncommon::get_env_multiple('form.rejectreq'); + @rejections,@rejectionerrors,@nopermissions,%courseroles,@toremove, + %communityroles,%domdefs,%approvalmsg,%rejectionmsg,$crstype,$queue, + $firsturl); + my $count=0; + while (my @course = &Apache::loncommon::get_env_multiple('form.'.$count.'radioreq')) { + if ($course[0] =~ /^\d+:.*/) { + push(@approvals,$course[0]); + } elsif ($course[0] =~ /^later:.*/) { + #decide later + } else { + push(@rejections,$course[0]); + } + $count+=1; + } + $now = time; $sender = $env{'user.name'}.':'.$env{'user.domain'}; if ($context eq 'course') { @@ -461,10 +553,7 @@ sub update_request_queue { $beneficiary = 'enroller'; $cid = $env{'request.course.id'}; $crstype = lc(&Apache::loncommon::course_type()); - my $chome = &Apache::lonnet::homeserver($cnum,$cdom); - $hostname = &Apache::lonnet::hostname($chome); - $protocol = $Apache::lonnet::protocol{$chome}; - $protocol = 'http' if ($protocol ne 'https'); + $firsturl = &course_portal_url($cnum,$cdom); %requesthash = &Apache::lonnet::dump($namespace,$cdom,$cnum); $access_start = $env{'course.'.$cid.'.internal.selfenroll_start_access'}; $access_end = $env{'course.'.$cid.'.internal.selfenroll_end_access'}; @@ -476,12 +565,35 @@ sub update_request_queue { mt => 'Your request for enrollment has been approved.', }, { - mt => 'Visit [_1], to log-in and access the course', - args => [$protocol.'://'.$hostname], + mt => 'Visit [_1] to log-in and access the course', + args => [$firsturl], }]; $rejectedmsg = [{ mt => 'Your request for enrollment has not been approved.', }]; + } elsif ($context eq 'requestauthor') { + $namespace = 'requestauthorqueue'; + $beneficiary = 'requestauthor'; + %requesthash = &Apache::lonnet::dump_dom($namespace,$cdom); + my %domdefs = &Apache::lonnet::get_domain_defaults($cdom); + if (ref($domdefs{'requestauthor'}) eq 'HASH') { + if (ref($domdefs{'requestauthor'}{'notify'}) eq 'HASH') { + $notifylist = $domdefs{'requestauthor'}{'notify'}{'approval'}; + } + } + my $domconfiguser = &Apache::lonnet::get_domainconfiguser($cdom); + $firsturl = &course_portal_url($domconfiguser,$cdom); + $approvedmsg = [{ + mt => 'Your request for authoring space has been approved.', + }, + { + mt => 'Visit [_1] to log-in and select your author role', + args => [$firsturl], + }]; + $rejectedmsg = [{ + mt => 'Your request for authoring space has not been approved.', + }]; + $domdesc = &Apache::lonnet::domain($cdom); } else { $domdesc = &Apache::lonnet::domain($cdom); $namespace = 'courserequestqueue'; @@ -491,10 +603,6 @@ sub update_request_queue { $queue = 'pending'; } %requesthash = &Apache::lonnet::dump_dom($namespace,$cdom,'_'.$queue); - my $chome = &Apache::lonnet::domain($cdom,'primary'); - $hostname = &Apache::lonnet::hostname($chome); - $protocol = $Apache::lonnet::protocol{$chome}; - $protocol = 'http' if ($protocol ne 'https'); my %domconfig = &Apache::lonnet::get_dom('configuration',['requestcourses'],$cdom); if (ref($domconfig{'requestcourses'}) eq 'HASH') { if (ref($domconfig{'requestcourses'}{'notify'}) eq 'HASH') { @@ -506,8 +614,8 @@ sub update_request_queue { mt => 'Your course request has been approved.', }, { - mt => 'Visit [_1], to log-in and access the course', - args => [$protocol.'://'.$hostname], + mt => 'Visit [_1] to log-in and access the course', + args => [], }]; $rejectionmsg{'course'} = [{ @@ -519,8 +627,8 @@ sub update_request_queue { mt => 'Your community request has been approved.', }, { - mt => 'Visit [_1], to log-in and access the community', - args => [$protocol.'://'.$hostname], + mt => 'Visit [_1] to log-in and access the community', + args => [], }]; $rejectionmsg{'community'} = @@ -536,7 +644,6 @@ sub update_request_queue { foreach my $role (@roles) { $communityroles{$role}=&Apache::lonnet::plaintext($role,'Community'); } - } foreach my $item (sort {$a <=> $b} @approvals) { if ($context eq 'course') { @@ -576,7 +683,8 @@ sub update_request_queue { $stucounts->{'allstudents'} ++; $stucounts->{'selfenrolled'} ++; &send_selfserve_notification($uname.':'.$udom,$approvedmsg, - $cid,$coursedesc,$now,$beneficiary,$sender,undef,undef,$crstype); + $cid,$coursedesc,$now,$beneficiary,$sender, + undef,undef,$crstype); my %userrequest = ( $cdom.'_'.$cnum => { timestamp => $now, @@ -597,6 +705,50 @@ sub update_request_queue { } else { push(@invalidusers,$uname.':'.$udom); } + } elsif ($context eq 'requestauthor') { + my ($num,$uname) = split(/:/,$item); + my $uhome = &Apache::lonnet::homeserver($uname,$cdom); + if ($uhome ne 'no_host') { + my ($user_is_adv,$user_is_author) = &Apache::lonnet::is_advanced_user($cdom,$uname); + if ($user_is_author) { + push(@existing,$uname); + } elsif (&Apache::lonnet::usertools_access($uname,$cdom,'requestauthor', + undef,'requestauthor')) { + if (&Apache::lonnet::allowed('cau',$cdom)) { + if (&Apache::lonnet::assignrole($cdom,$uname,'/'.$cdom.'/','au',undef,time,undef,undef,'requestauthor') eq 'ok') { + push(@completed,$uname); + unless (&Apache::lonnet::del_dom($namespace,[$uname.'_approval'],$cdom) eq 'ok') { + push(@warn_dels,$uname); + } + &send_selfserve_notification($uname.':'.$cdom, + $approvedmsg,undef,undef,$now, + $beneficiary,$sender); + my %userrequest = ( + author => { + timestamp => $now, + adjudicator => $env{'user.name'}.':'.$env{'user.domain'}, + status => 'approved', + }, + author_status => 'approved', + ); + my $userresult = + &Apache::lonnet::put('requestauthor',\%userrequest,$cdom,$uname); + if ($userresult ne 'ok') { + push(@warn_approves,$item); + } + } else { + push(@processing_errors,$uname); + } + } else { + push(@nopermissions,$uname); + } + } else { + push(@nopermissions,$uname); + } + } else { + push(@invalidusers,$uname.':'.$cdom); + } + push(@toremove,(@invalidusers,@nopermissions)); } else { my ($num,$cnum) = split(':',$item); if (ref($requesthash{$cnum.'_'.$queue}) eq 'HASH') { @@ -641,13 +793,20 @@ sub update_request_queue { } else { $approvedmsg = $approvalmsg{'course'}; } + my $firsturl = &course_portal_url($cnum,$cdom); + if (ref($approvedmsg) eq 'ARRAY') { + if (ref($approvedmsg->[1]) eq 'HASH') { + $approvedmsg->[1]->{'args'} = [$firsturl]; + } + } push(@completed,$cnum); unless (&Apache::lonnet::del_dom($namespace,[$cnum.'_'.$queue],$cdom) eq 'ok') { push(@warn_dels,$cnum); } - &send_selfserve_notification($ownername.':'.$ownerdom,$approvedmsg, - $cid,$coursedesc,$now,$beneficiary,$sender,undef,undef,$crstype); + &send_selfserve_notification($ownername.':'.$ownerdom, + $approvedmsg,$cid,$coursedesc,$now, + $beneficiary,$sender,undef,undef,$crstype); my %reqhash = ( reqtime => $history{'reqtime'}, crstype => $history{'crstype'}, @@ -694,25 +853,40 @@ sub update_request_queue { my @changes = (@completed,@rejections); if ($context eq 'domain') { @changes = map {$_.'_'.$queue} (@changes); + } elsif ($context eq 'requestauthor') { + @changes = map {$_.'_approval'} (@changes); } if (@rejections) { foreach my $item (@rejections) { - if ($context eq 'course') { - my $user = $item; + if (($context eq 'course') || ($context eq 'requestauthor')) { + my ($user,$uname,$udom,%userrequest,$key); + if ($context eq 'requestauthor') { + $uname = $item; + $udom = $cdom; + $user = $uname.':'.$udom; + $key = 'author'; + } else { + $user = $item; + ($uname,$udom) = split(/:/,$user); + $key = $cdom.'_'.$cnum; + } &send_selfserve_notification($user,$rejectedmsg,$cid,$coursedesc, - $now,$beneficiary,$sender,undef,undef,$crstype); - my ($uname,$udom) = split(/:/,$user); - my %userrequest = ( - $cdom.'_'.$cnum => { + $now,$beneficiary,$sender,undef,undef, + $crstype); + %userrequest = ( + $key => { timestamp => $now, adjudicator => $env{'user.name'}.':'.$env{'user.domain'}, - status => 'rejected', + status => 'rejection', } ); + if ($context eq 'requestauthor') { + $userrequest{'author_status'} = 'rejection'; + } my $userresult = - &Apache::lonnet::put($namespace,\%userrequest,$udom,$uname); + &Apache::lonnet::put('requestauthor',\%userrequest,$udom,$uname); if ($userresult ne 'ok') { - push(@warn_rejects,$user); + push(@warn_rejects,$item); } } else { my $cnum = $item; @@ -775,6 +949,21 @@ sub update_request_queue { } } } + if (@toremove) { + foreach my $item (@toremove) { + my %userrequest = ( + author => { + timestamp => $now, + adjudicator => $env{'user.name'}.':'.$env{'user.domain'}, + status => 'deleted', + }, + author_status => 'deleted', + ); + &Apache::lonnet::put('requestauthor',\%userrequest,$cdom,$item); + } + @toremove = map {$_.'_approval'} (@toremove); + my $delresult = &Apache::lonnet::del_dom($namespace,\@toremove,$cdom); + } if (@changes) { my $delresult; if ($context eq 'course') { @@ -816,6 +1005,34 @@ sub update_request_queue { $now,'coursemanagers',$sender, $approvedlist,$rejectedlist,$crstype); } + } elsif ($context eq 'requestauthor') { + $chgmsg = "'Action was taken on the following authoring space requests by [_1].',$namelink"; + if (@completed) { + $approvedlist = join("\n",@completed); + $output .= '

'.&mt('The following requests were approved:').'

'; + } + if (@rejections) { + $rejectedlist = join("\n",@rejections); + $output .= '

'.&mt('The following requests were rejected:').'

'; + } + if ($notifylist ne '') { + &send_selfserve_notification($notifylist,$chgmsg,undef,$domdesc, + $now,'authormanagers',$sender, + $approvedlist,$rejectedlist); + } } else { $chgmsg = "'Action was taken on the following course and community requests by [_1].',$namelink"; if (@completed) { @@ -863,6 +1080,14 @@ sub update_request_queue { $output .= '
  • '.$user.'
  • '; } $output .= '

    '; + } elsif ($context eq 'requestauthor') { + $output .= '

    '.&mt('Authoring space requests from the following users were deleted because one already exists:').'

    '; } else { $output .= '

    '.&mt('The following course/community creation requests were deleted because the course or community has already been created:').'

    '; + } elsif ($context eq 'requestauthor') { + $output .= '

    '.&mt('The following requests were ignored because the request is no longer in the queue:').'

    '; } else { $output .= '

    '.&mt('The following course/community creation requests were ignored because the request is no longer in the queue:').'

    '; - } } if (@invalidusers) { @@ -901,6 +1133,14 @@ sub update_request_queue { $output .= '
  • '.$user.'
  • '; } $output .= '

    '; + } elsif ($context eq 'requestauthor') { + $output .= '

    '.&mt('The following authoring space requests were deleted because the requestor does not have a LON-CAPA account:').'

    '; } } if (@limitexceeded) { @@ -913,17 +1153,27 @@ sub update_request_queue { } } if (@nopermissions) { - $output .= '

    '.&mt('The following course/community creation requests could not be processed because the owner does not have rights to create this type of course:').'

    '; } if (@processing_errors) { if ($context eq 'course') { @@ -932,6 +1182,14 @@ sub update_request_queue { $output .= '
  • '.$user.'
  • '; } $output .= '

    '; + } elsif ($context eq 'requestauthor') { + $output .= '

    '.&mt('The following requests could not be processed because an error occurred:').'

    '; } else { $output .= '

    '.&mt('The following course/community creation requests could not be processed because an error occurred:').'

    '; + } elsif ($context eq 'requestauthor') { + $output .= '

    '.&mt("For the following users, an error occurred when updating the user's own author request record:").'

    '; } else { $output .= '

    '.&mt("For the following course/community requests an error occurred when updating the requestor's own requests record:").'