--- loncom/interface/loncreateuser.pm	2006/06/26 21:36:53	1.121
+++ loncom/interface/loncreateuser.pm	2006/07/02 12:18:01	1.128
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Create a user
 #
-# $Id: loncreateuser.pm,v 1.121 2006/06/26 21:36:53 foxr Exp $
+# $Id: loncreateuser.pm,v 1.128 2006/07/02 12:18:01 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -142,7 +142,7 @@ sub print_username_entry_form {
                     'nr'   => "Name of Role",
                     'cre'  => "Custom Role Editor"
 				       );
-    my $help = &Apache::loncommon::help_open_menu('',undef,undef,'',282,'Instructor Interface');
+    my $help = &Apache::loncommon::help_open_menu(undef,undef,282,'Instructor Interface');
     my $helpsiur=&Apache::loncommon::help_open_topic('Course_Change_Privileges');
     my $helpecpr=&Apache::loncommon::help_open_topic('Course_Editing_Custom_Roles');
     $r->print(<<"ENDDOCUMENT");
@@ -378,7 +378,6 @@ ENDSCRIPT
             var str = document.cu.elements[i].name;
             var checkcurr = str.match(re1);
             if (checkcurr != null) {
-                var re2 = /^currsec_[a-zA-Z0-9]+_[a-zA-Z0-9]+_(\\w+)\$/;
                 if (document.cu.elements[i-1].checked == true) {
                     var re2 = /^currsec_[a-zA-Z0-9]+_[a-zA-Z0-9]+_(\\w+)\$/;
                     match = re2.exec(str);
@@ -415,15 +414,17 @@ ENDSCRIPT
                             sections = document.cu.elements[i+1].value;
                         }
                         var newsecs = document.cu.elements[i+1].value;
+			var numsplit;
                         if (newsecs != null && newsecs != "") {
-                            var numsplit = newsecs.split(/,/g);
+                            numsplit = newsecs.split(/,/g);
                             numsec = numsec + numsplit.length;
                         }
+
                         if ((role == 'st') && (numsec > 1)) {
                             alert("In each course, each user may only have one student role at a time. You had selected "+numsec+" sections.\\nPlease modify your selections so they include no more than one section.")
                             return;
                         }
-                        else {
+                        else if (numsplit != null) {
                             for (var j=0; j<numsplit.length; j++) {
                                 if ((numsplit[j] == 'all') ||
                                     (numsplit[j] == 'none')) {
@@ -437,8 +438,8 @@ ENDSCRIPT
                                     }
                                 }
                             }
-                            document.cu.elements[i+2].value = sections;
                         }
+                        document.cu.elements[i+2].value = sections;
                     }
                 }
             }
@@ -1598,11 +1599,6 @@ sub custom_role_editor {
 ENDCCF
     foreach my $priv (sort keys %full) {
         my $privtext = &Apache::lonnet::plaintext($priv);
-        if ($env{'course.'.$env{'request.course.id'}.'.type'}) {
-            $privtext =~ s/Student/Member/;
-            $privtext =~ s/student/member/;
-            $privtext =~ s/course/group/;
-        } 
 	$r->print('<tr><td>'.$privtext.'</td><td>'.
     ($courselevel{$priv}?'<input type="checkbox" name="'.$priv.':c" '.
     ($courselevelcurrent{$priv}?'checked="1"':'').' />':'&nbsp;').
@@ -1770,10 +1766,6 @@ sub course_level_table {
 	foreach  ('st','ta','ep','in','cc') {
 	    if (&Apache::lonnet::allowed('c'.$_,$thiscourse)) {
 		my $plrole=&Apache::lonnet::plaintext($_);
-	       #  Was this left in by mistake?
-               # if ($type eq 'Group') {
-               #     $plrole = &Apache::loncommon::convert_role($plrole,$type);
-               # } 
 		$table .= <<ENDEXTENT;
 <tr bgcolor="#$bgcol">
 <td><input type="checkbox" name="act_$protectedcourse\_$_"></td>