--- loncom/interface/londocs.pm	2007/07/07 00:53:24	1.287
+++ loncom/interface/londocs.pm	2007/07/20 00:28:27	1.294
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Documents
 #
-# $Id: londocs.pm,v 1.287 2007/07/07 00:53:24 albertel Exp $
+# $Id: londocs.pm,v 1.294 2007/07/20 00:28:27 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -932,9 +932,10 @@ sub group_import {
             }
         }
 	if ($url) {
-	    if (!$residx) {
-		$residx = &LONCAPA::map::getresidx($url);
-		$LONCAPA::map::order[$#LONCAPA::map::order+1]=$residx;
+	    if (!$residx 
+		|| defined($LONCAPA::map::zombies[$residx])) {
+		$residx = &LONCAPA::map::getresidx($url,$residx);
+		push(@LONCAPA::map::order, $residx);
 	    }
 	    my $ext = 'false';
 	    if ($url=~m{^http://} || $url=~m{^https://}) { $ext = 'true'; }
@@ -1241,15 +1242,135 @@ ENDPASTE
     $r->print('</p></form>');
 }
 
+sub do_paste_from_buffer {
+    my ($coursenum,$coursedom) = @_;
+
+    return 0 if (!$env{'form.pastemarked'});
+
+# paste resource to end of list
+    my $url=&LONCAPA::map::qtescape($env{'docs.markedcopy_url'});
+    my $title=&LONCAPA::map::qtescape($env{'docs.markedcopy_title'});
+# Maps need to be copied first
+    if (($url=~/\.(page|sequence)$/) && ($url=~/^\/uploaded\//)) {
+	$title=&mt('Copy of').' '.$title;
+	my $newid=$$.time;
+	$url=~/^(.+)\.(\w+)$/;
+	my $newurl=$1.$newid.'.'.$2;
+	my $storefn=$newurl;
+	$storefn=~s{^/\w+/$match_domain/$match_username/}{};
+	&Apache::lonclonecourse::writefile($env{'request.course.id'},$storefn,
+					   &Apache::lonnet::getfile($url));
+	$url = $newurl;
+    }
+# published maps can only exists once, so remove it from paste buffer when done
+    if (($url=~/\.(page|sequence)$/) && ($url=~m {^/res/})) {
+	&Apache::lonnet::delenv('docs\\.markedcopy');
+    }
+    if ($url=~ m{/smppg$}) {
+	my $db_name = &Apache::lonsimplepage::get_db_name($url);
+	if ($db_name =~ /^smppage_/) {
+	    #simple pages, need to copy the db contents to a new one.
+	    my %contents=&Apache::lonnet::dump($db_name,$coursedom,$coursenum);
+	    my $now = time();
+	    $db_name =~ s{_\d*$ }{_$now}x;
+	    my $result=&Apache::lonnet::put($db_name,\%contents,
+					    $coursedom,$coursenum);
+	    $url =~ s{/(\d*)/smppg$ }{/$now/smppg}x; 
+	    $title=&mt('Copy of').' '.$title;
+	}
+    }
+    $title = &LONCAPA::map::qtunescape($title);
+    my $ext='false';
+    if ($url=~m{^http(|s)://}) { $ext='true'; }
+    $url       = &LONCAPA::map::qtunescape($url);
+# Now insert the URL at the bottom
+    my $newidx = &LONCAPA::map::getresidx($url);
+    $LONCAPA::map::resources[$newidx]= 	$title.':'.$url.':'.$ext.':normal:res';
+    push(@LONCAPA::map::order, $newidx);
+# Store the result
+}
+
+my %parameter_type = ( 'randompick'     => 'int_pos',
+		       'hiddenresource' => 'string_yesno',
+		       'encrypturl'     => 'string_yesno',);
+my $valid_parameters_re = join('|',keys(%parameter_type));
+# set parameters
+sub update_parameter {
+
+    return 0 if ($env{'form.changeparms'} !~ /^($valid_parameters_re)$/);
+
+    my $which = $env{'form.changeparms'};
+    my $idx = $env{'form.setparms'};
+    if ($env{'form.'.$which.'_'.$idx}) {
+	my $value = ($which eq 'randompick') ? $env{'form.'.$which.'_'.$idx}
+	                                     : 'yes';
+	&LONCAPA::map::storeparameter($idx, 'parameter_'.$which, $value,
+				      $parameter_type{$which});
+	&remember_parms($idx,$which,'set',$value);
+    } else {
+	&LONCAPA::map::delparameter($idx,'parameter_'.$which);
+	
+	&remember_parms($idx,$which,'del');
+    }
+    return 1;
+}
+
+
+sub handle_edit_cmd {
+    my ($coursenum,$coursedom) =@_;
+
+    my ($cmd,$idx)=split('_',$env{'form.cmd'});
+
+    my $ratstr = $LONCAPA::map::resources[$LONCAPA::map::order[$idx]];
+    my ($title, $url, @rrest) = split(':', $ratstr);
+
+    if ($cmd eq 'del') {
+	if (($url=~m|/+uploaded/\Q$coursedom\E/\Q$coursenum\E/|) &&
+	    ($url!~/\.(page|sequence|problem|exam|quiz|assess|survey|form|library|task)$/)) {
+	    &Apache::lonnet::removeuploadedurl($url);
+	} else {
+	    &LONCAPA::map::makezombie($LONCAPA::map::order[$idx]);
+	}
+	splice(@LONCAPA::map::order, $idx, 1);
+
+    } elsif ($cmd eq 'cut') {
+	&LONCAPA::map::makezombie($LONCAPA::map::order[$idx]);
+	splice(@LONCAPA::map::order, $idx, 1);
+
+    } elsif ($cmd eq 'up' 
+	     && ($idx) && (defined($LONCAPA::map::order[$idx-1]))) {
+	@LONCAPA::map::order[$idx-1,$idx] = @LONCAPA::map::order[$idx,$idx-1];
+
+    } elsif ($cmd eq 'down'
+	     && defined($LONCAPA::map::order[$idx+1])) {
+	@LONCAPA::map::order[$idx+1,$idx] = @LONCAPA::map::order[$idx,$idx+1];
+
+    } elsif ($cmd eq 'rename') {
+
+	my $comment = &LONCAPA::map::qtunescape($env{'form.title'});
+	if ($comment=~/\S/) {
+	    $LONCAPA::map::resources[$LONCAPA::map::order[$idx]]=
+		$comment.':'.join(':', $url, @rrest);
+	}
+# Devalidate title cache
+	my $renamed_url=&LONCAPA::map::qtescape($url);
+	&Apache::lonnet::devalidate_title_cache($renamed_url);
+    } else {
+	return 0;
+    }
+    return 1;
+}
+
 sub editor {
     my ($r,$coursenum,$coursedom,$folder,$allowed,$upload_output,$which)=@_;
-    my $errtext='';
-    my $fatal=0;
-    my $container='sequence';
-    if ($env{'form.pagepath'}) {
-        $container='page';
-    }
-    ($errtext,$fatal) = &mapread($coursenum,$coursedom,$folder.'.'.$container);
+
+    my $container= ($env{'form.pagepath'}) ? 'page'
+		                           : 'sequence';
+
+    my ($errtext,$fatal) = &mapread($coursenum,$coursedom,
+				    $folder.'.'.$container);
+    return $errtext if ($fatal);
+
     if ($#LONCAPA::map::order<1) {
 	my $idx=&LONCAPA::map::getresidx();
 	if ($idx<=0) { $idx=1; }
@@ -1257,260 +1378,109 @@ sub editor {
         $LONCAPA::map::resources[$idx]='';
     }
     
-    my ($breadcrumbtrail,$randompick,$ishidden,$isencrypted,$plain)=&breadcrumbs($folder);
+    my ($breadcrumbtrail,$randompick,$ishidden,$isencrypted,$plain)=
+	&breadcrumbs($folder);
     $r->print($breadcrumbtrail);
-    if ($fatal) {
-	   $r->print('<p><span class="LC_error">'.$errtext.'</span></p>');
-    } else {
+    
 # ------------------------------------------------------------ Process commands
 
 # ---------------- if they are for this folder and user allowed to make changes
-	if (($allowed) && ($env{'form.folder'} eq $folder)) {
+    if (($allowed) && ($env{'form.folder'} eq $folder)) {
 # set parameters and change order
-            &snapshotbefore();
-	    if ($env{'form.changeparms'}) {
-		my $idx=$env{'form.setparms'};
-# set parameters
-		if ($env{'form.changeparms'} eq 'randompick') {
-		    if ($env{'form.randpick_'.$idx}) {
-			&LONCAPA::map::storeparameter($idx,'parameter_randompick',$env{'form.randpick_'.$idx},'int_pos');
-			&remember_parms($idx,'randompick','set',$env{'form.randpick_'.$idx});
-		    } else {
-			&LONCAPA::map::delparameter($idx,'parameter_randompick');
-			&remember_parms($idx,'randompick','del');
-		    }
-		}
-		if ($env{'form.changeparms'} eq 'hiddenresource') {
-		    if ($env{'form.hidprs_'.$idx}) {
-			&LONCAPA::map::storeparameter($idx,'parameter_hiddenresource','yes','string_yesno');
-			&remember_parms($idx,'hiddenresource','set',$env{'form.hidprs_'.$idx});
-		    } else {
-			&LONCAPA::map::delparameter($idx,'parameter_hiddenresource');
-			&remember_parms($idx,'hiddenresource','del');
-		    }
-		}
-		if ($env{'form.changeparms'} eq 'encrypturl') {
-		    if ($env{'form.encprs_'.$idx}) {
-			&LONCAPA::map::storeparameter($idx,'parameter_encrypturl','yes','string_yesno');
-			&remember_parms($idx,'encrypturl','set',$env{'form.encprs_'.$idx});
-		    } else {
-			&LONCAPA::map::delparameter($idx,'parameter_encrypturl');
-			&remember_parms($idx,'encrypturl','del');
-		    }
-		}
-# store the changed version
-		($errtext,$fatal)=&storemap($coursenum,$coursedom,$folder.'.'.$container);
-		if ($fatal) {
-		    $r->print('<p><span class="LC_error">'.$errtext.'</span></p>');
-		    return;
-		}
-	    }
+	&snapshotbefore();
 
-	    if ($env{'form.newpos'}) {
+	if (&update_parameter()) {
+	    ($errtext,$fatal)=&storemap($coursenum,$coursedom,$folder.'.'.$container);
+	    return $errtext if ($fatal);
+	}
+
+	if ($env{'form.newpos'} && $env{'form.currentpos'}) {
 # change order
-		my $newpos=$env{'form.newpos'}-1;
-		my $currentpos=$env{'form.currentpos'}-1;
-		my $i;
-		my @neworder=();
-		if ($newpos>$currentpos) {
-# moving stuff up
-		    for ($i=0;$i<$currentpos;$i++) {
-			$neworder[$i]=$LONCAPA::map::order[$i];
-		    }
-		    for ($i=$currentpos;$i<$newpos;$i++) {
-			$neworder[$i]=$LONCAPA::map::order[$i+1];
-		    }
-		    $neworder[$newpos]=$LONCAPA::map::order[$currentpos];
-		    for ($i=$newpos+1;$i<=$#LONCAPA::map::order;$i++) {
-			$neworder[$i]=$LONCAPA::map::order[$i];
-		    }
-		} else {
-# moving stuff down
-		    for ($i=0;$i<$newpos;$i++) {
-			$neworder[$i]=$LONCAPA::map::order[$i];
-		    }
-		    $neworder[$newpos]=$LONCAPA::map::order[$currentpos];
-		    for ($i=$newpos+1;$i<$currentpos+1;$i++) {
-			$neworder[$i]=$LONCAPA::map::order[$i-1];
-		    }
-		    for ($i=$currentpos+1;$i<=$#LONCAPA::map::order;$i++) {
-			$neworder[$i]=$LONCAPA::map::order[$i];
-		    }
-		}
-		@LONCAPA::map::order=@neworder;
-# store the changed version
-		($errtext,$fatal)=&storemap($coursenum,$coursedom,$folder.'.'.$container);
-		if ($fatal) {
-		    $r->print('<p><span class="LC_error">'.$errtext.'</span></p>');
-		    return;
-		}
-	    }
+	    my $res = splice(@LONCAPA::map::order,$env{'form.currentpos'}-1,1);
+	    splice(@LONCAPA::map::order,$env{'form.newpos'}-1,0,$res);
+
+	    ($errtext,$fatal)=&storemap($coursenum,$coursedom,$folder.'.'.$container);
+	    return $errtext if ($fatal);
+	}
 	    
-	    if ($env{'form.pastemarked'}) {
-# paste resource to end of list
-                my $url=&LONCAPA::map::qtescape($env{'docs.markedcopy_url'});
-		my $title=&LONCAPA::map::qtescape($env{'docs.markedcopy_title'});
-# Maps need to be copied first
-		if (($url=~/\.(page|sequence)$/) || ($url=~/^\/uploaded\//)) {
-		    $title=&mt('Copy of').' '.$title;
-                    my $newid=$$.time;
-		    $url=~/^(.+)\.(\w+)$/;
-		    my $newurl=$1.$newid.'.'.$2;
-		    my $storefn=$newurl;
-                    $storefn=~s{^/\w+/$match_domain/$match_username/}{};
-		    &Apache::lonclonecourse::writefile
-			($env{'request.course.id'},$storefn,
-			 &Apache::lonnet::getfile($url));
-		    $url=$newurl;
-		}
-		$title = &LONCAPA::map::qtunescape($title);
-		my $ext='false';
-		if ($url=~m{^http(|s)://}) { $ext='true'; }
-		$url   = &LONCAPA::map::qtunescape($url);
-# Now insert the URL at the bottom
-                my $newidx=&LONCAPA::map::getresidx($url);
-		$LONCAPA::map::resources[$newidx]=
-		    $title.':'.$url.':'.$ext.':normal:res';
-		$LONCAPA::map::order[1+$#LONCAPA::map::order]=$newidx;
-# Store the result
-		($errtext,$fatal)=&storemap($coursenum,$coursedom,$folder.'.'.$container);
-		if ($fatal) {
-		    $r->print('<p><span class="LC_error">'.$errtext.'</span></p>');
-		    return;
-		}
+	if ($env{'form.pastemarked'}) {
+	    &do_paste_from_buffer($coursenum,$coursedom);
+	    ($errtext,$fatal) = &storemap($coursenum,$coursedom,$folder.'.'.$container);
+	    return $errtext if ($fatal);
+	}
 
-	    }
-            $r->print($upload_output);
-	    if ($env{'form.cmd'}) {
-                my ($cmd,$idx)=split(/\_/,$env{'form.cmd'});
-                if ($cmd eq 'del') {
-		    my (undef,$url)=split(':',$LONCAPA::map::resources[$LONCAPA::map::order[$idx]]);
-		    if (($url=~m|/+uploaded/\Q$coursedom\E/\Q$coursenum\E/|) &&
-			($url!~/\.(page|sequence|problem|exam|quiz|assess|survey|form|library|task)$/)) {
-			&Apache::lonnet::removeuploadedurl($url);
-		    } else {
-			&LONCAPA::map::makezombie($LONCAPA::map::order[$idx]);
-		    }
-		    for (my $i=$idx;$i<$#LONCAPA::map::order;$i++) {
-                        $LONCAPA::map::order[$i] = $LONCAPA::map::order[$i+1];
-                    }
-                    $#LONCAPA::map::order--;
-                } elsif ($cmd eq 'cut') {
-		    my (undef,$url)=split(':',$LONCAPA::map::resources[$LONCAPA::map::order[$idx]]);
-		    &LONCAPA::map::makezombie($LONCAPA::map::order[$idx]);
-		    for (my $i=$idx;$i<$#LONCAPA::map::order;$i++) {
-                        $LONCAPA::map::order[$i] = $LONCAPA::map::order[$i+1];
-                    }
-                    $#LONCAPA::map::order--;
-                } elsif ($cmd eq 'up') {
-		  if (($idx) && (defined($LONCAPA::map::order[$idx-1]))) {
-                    my $i=$LONCAPA::map::order[$idx-1];
-                    $LONCAPA::map::order[$idx-1] = $LONCAPA::map::order[$idx];
-                    $LONCAPA::map::order[$idx] = $i;
-		   }
-                } elsif ($cmd eq 'down') {
-		   if (defined($LONCAPA::map::order[$idx+1])) {
-                    my $i=$LONCAPA::map::order[$idx+1];
-                    $LONCAPA::map::order[$idx+1] = $LONCAPA::map::order[$idx];
-                    $LONCAPA::map::order[$idx] = $i;
-		   }
-                } elsif ($cmd eq 'rename') {
-                    my $ratstr = $LONCAPA::map::resources[$LONCAPA::map::order[$idx]];
-                    my ($rtitle,@rrest)=split(/\:/,
-                       $LONCAPA::map::resources[$LONCAPA::map::order[$idx]]);
-                    my $comment=$env{'form.title'};
-                    $comment = &LONCAPA::map::qtunescape($comment);
-		    if ($comment=~/\S/) {
-			$LONCAPA::map::resources[$LONCAPA::map::order[$idx]]=
-			    $comment.':'.join(':',@rrest);
-		    }
-# Devalidate title cache
-                    my $renamed_url=&LONCAPA::map::qtescape($rrest[0]);
-		    &Apache::lonnet::devalidate_title_cache($renamed_url);
-                }
-# Store the changed version
-		($errtext,$fatal)=&storemap($coursenum,$coursedom,
-					    $folder.'.'.$container);
-		if ($fatal) {
-		    $r->print('<p><span class="LC_error">'.$errtext.'</span></p>');
-		    return;
-		}
-            }
+	$r->print($upload_output);
+
+	if (&handle_edit_cmd()) {
+	    ($errtext,$fatal)=&storemap($coursenum,$coursedom,$folder.'.'.$container);
+	    return $errtext if ($fatal);
+	}
 # Group import/search
-	    if ($env{'form.importdetail'}) {
-		my @imports;
-		foreach (split(/\&/,$env{'form.importdetail'})) {
-		    if (defined($_)) {
-			my ($name,$url,$residx)=
-			    map {&unescape($_)} split(/\=/,$_);
-			push(@imports, [$name, $url, $residx]);
-		    }
+	if ($env{'form.importdetail'}) {
+	    my @imports;
+	    foreach (split(/\&/,$env{'form.importdetail'})) {
+		if (defined($_)) {
+		    my ($name,$url,$residx)=
+			map {&unescape($_)} split(/\=/,$_);
+		    push(@imports, [$name, $url, $residx]);
 		}
-# Store the changed version
-		($errtext,$fatal)=&group_import($coursenum, $coursedom, $folder,
-					       $container,'londocs',@imports);
-		if ($fatal) {
-		    $r->print('<p><span class="LC_error">'.$errtext.'</span></p>');
-		    return;
-		}
-            }
+	    }
+	    ($errtext,$fatal)=&group_import($coursenum, $coursedom, $folder,
+					    $container,'londocs',@imports);
+	    return $errtext if ($fatal);
+	}
 # Loading a complete map
-	   if ($env{'form.loadmap'}) {
-               if ($env{'form.importmap'}=~/\w/) {
-	          foreach (&Apache::lonsequence::attemptread(&Apache::lonnet::filelocation('',$env{'form.importmap'}))) {
-		      my ($title,$url,$ext,$type)=split(/\:/,$_);
-                      my $idx=&LONCAPA::map::getresidx($url);
-                      $LONCAPA::map::resources[$idx]=$_;
-                      $LONCAPA::map::order[$#LONCAPA::map::order+1]=$idx;
-	          }
-# Store the changed version
-  	          ($errtext,$fatal)=&storemap($coursenum,$coursedom,
-					   $folder.'.'.$container);
-	          if ($fatal) {
-		      $r->print('<p><span class="LC_error">'.$errtext.'</span></p>');
-		      return;
-	          }
-               } else {
-		    $r->print('<p><span class="LC_error">'.&mt('No map selected.').'</span></p>');
-
-               }
-           }
-           &log_differences($plain);
+	if ($env{'form.loadmap'}) {
+	    if ($env{'form.importmap'}=~/\w/) {
+		foreach my $res (&Apache::lonsequence::attemptread(&Apache::lonnet::filelocation('',$env{'form.importmap'}))) {
+		    my ($title,$url,$ext,$type)=split(/\:/,$res);
+		    my $idx=&LONCAPA::map::getresidx($url);
+		    $LONCAPA::map::resources[$idx]=$res;
+		    $LONCAPA::map::order[$#LONCAPA::map::order+1]=$idx;
+		}
+		($errtext,$fatal)=&storemap($coursenum,$coursedom,
+					    $folder.'.'.$container);
+		return $errtext if ($fatal);
+	    } else {
+		$r->print('<p><span class="LC_error">'.&mt('No map selected.').'</span></p>');
+		
+	    }
 	}
+	&log_differences($plain);
+    }
 # ---------------------------------------------------------------- End commands
 # ---------------------------------------------------------------- Print screen
-        my $idx=0;
-	my $shown=0;
-        if (($ishidden) || ($isencrypted) || ($randompick>=0)) {
-           $r->print('<p>'.&mt('Parameters').':<ul>'.
-                     ($randompick>=0?'<li>'.&mt('randomly pick [_1] resources',$randompick).'</li>':'').
-                     ($ishidden?'<li>'.&mt('contents hidden').'</li>':'').
-                     ($isencrypted?'<li>'.&mt('URLs hidden').'</li>':'').
-                     '</ul></p>');
-        }                                                                                                     
-        if ($randompick>=0) {
-           $r->print('<p>'.&mt('Caution: this folder is set to randomly pick a subset of resources. Adding or removing resources from this folder will change the set of resources that the students see, resulting in spurious or missing credit for completed problems, not limited to ones you modify. Do not modify the contents of this folder if it is in active student use.').'</p>');
-        }
-        $r->print('<table class="LC_docs_editor">');
-        foreach my $res (@LONCAPA::map::order) {
-           my ($name,$url)=split(/\:/,$LONCAPA::map::resources[$res]);
-	   $name=&LONCAPA::map::qtescape($name);
-	   $url=&LONCAPA::map::qtescape($url);
-           unless ($name) {  $name=(split(/\//,$url))[-1]; }
-           unless ($name) { $idx++; next; }
-           $r->print(&entryline($idx,$name,$url,$folder,$allowed,$res,
-				$coursenum));
-           $idx++;
-	   $shown++;
-        }
-	unless ($shown) {
-	    $r->print('<tr><td>'.&mt('Currently no documents.').'</td></tr>');
-	}
-        $r->print("\n</table>\n");
-
-	&print_paste_buffer($r,$container);
-
+    my $idx=0;
+    my $shown=0;
+    if (($ishidden) || ($isencrypted) || ($randompick>=0)) {
+	$r->print('<p>'.&mt('Parameters').':<ul>'.
+		  ($randompick>=0?'<li>'.&mt('randomly pick [_1] resources',$randompick).'</li>':'').
+		  ($ishidden?'<li>'.&mt('contents hidden').'</li>':'').
+		  ($isencrypted?'<li>'.&mt('URLs hidden').'</li>':'').
+		  '</ul></p>');
+    }                                                                                                     
+    if ($randompick>=0) {
+	$r->print('<p>'.&mt('Caution: this folder is set to randomly pick a subset of resources. Adding or removing resources from this folder will change the set of resources that the students see, resulting in spurious or missing credit for completed problems, not limited to ones you modify. Do not modify the contents of this folder if it is in active student use.').'</p>');
+    }
+    $r->print('<table class="LC_docs_editor">');
+    foreach my $res (@LONCAPA::map::order) {
+	my ($name,$url)=split(/\:/,$LONCAPA::map::resources[$res]);
+	$name=&LONCAPA::map::qtescape($name);
+	$url=&LONCAPA::map::qtescape($url);
+	unless ($name) {  $name=(split(/\//,$url))[-1]; }
+	unless ($name) { $idx++; next; }
+	$r->print(&entryline($idx,$name,$url,$folder,$allowed,$res,
+			     $coursenum));
+	$idx++;
+	$shown++;
+    }
+    unless ($shown) {
+	$r->print('<tr><td>'.&mt('Currently no documents.').'</td></tr>');
     }
+    $r->print("\n</table>\n");
+    
+    &print_paste_buffer($r,$container);
+    return;
 }
 
 sub process_file_upload {
@@ -1770,11 +1740,16 @@ sub entryline {
 	my $nocopy=0;
         my $nocut=0;
         if ($url=~/\.(page|sequence)$/) {
-	    foreach (&Apache::lonsequence::attemptread(&Apache::lonnet::filelocation('',$url))) {
-		my ($title,$url,$ext,$type)=split(/\:/,$_);
-		if (($url=~/\.(page|sequence)/) && ($type ne 'zombie')) {
-		    $nocopy=1;
-		    last;
+	    if ($url =~ m{/res/}) {
+		# no copy for published maps
+		$nocopy = 1;
+	    } else {
+		foreach (&Apache::lonsequence::attemptread(&Apache::lonnet::filelocation('',$url))) {
+		    my ($title,$url,$ext,$type)=split(/\:/,$_);
+		    if (($url=~/\.(page|sequence)/) && ($type ne 'zombie')) {
+			$nocopy=1;
+			last;
+		    }
 		}
 	    }
 	}
@@ -1785,6 +1760,18 @@ sub entryline {
         my $copylink='&nbsp;';
         my $cutlink='&nbsp;';
 	
+	my $skip_confirm = 0;
+	if ( $folder =~ /^supplemental/
+	     || ($url =~ m{( /smppg$
+			    |/syllabus$
+			    |/aboutme$
+			    |/navmaps$
+			    |/bulletinboard$
+			    |\.html$
+			    |^/adm/wrapper/ext)}x)) {
+	    $skip_confirm = 1;
+	}
+
 	if (!$nocopy) {
 	    $copylink=(<<ENDCOPY);
 <a href='javascript:markcopy("$esc_path","$index","$renametitle","$container","$symb","$folder");' class="LC_docs_copy">$lt{'cp'}</a>
@@ -1792,7 +1779,7 @@ ENDCOPY
         }
 	if (!$nocut) {
 	    $cutlink=(<<ENDCUT);
-<a href='javascript:cutres("$esc_path","$index","$renametitle","$container","$symb","$folder");' class="LC_docs_cut">$lt{'ct'}</a>
+<a href='javascript:cutres("$esc_path","$index","$renametitle","$container","$symb","$folder",$skip_confirm);' class="LC_docs_cut">$lt{'ct'}</a>
 ENDCUT
         }
 	$form_start = (<<END);
@@ -1824,7 +1811,7 @@ END
    $form_end
 </td>
 <td class="LC_docs_entry_commands">
-   <a href='javascript:removeres("$esc_path","$index","$renametitle","$container","$symb");' class="LC_docs_remove">$lt{'rm'}</a>
+   <a href='javascript:removeres("$esc_path","$index","$renametitle","$container","$symb",$skip_confirm);' class="LC_docs_remove">$lt{'rm'}</a>
 $cutlink
    <a href='javascript:changename("$esc_path","$index","$renametitle","$container","$symb");' class="LC_docs_rename">$lt{'rn'}</a>
 $copylink
@@ -1912,7 +1899,7 @@ END
                                               'parameter_encrypturl'))[0]=~/^yes$/i);
 	$url.='folderpath='.&escape($folderpath).$cpinfo;
 	$parameterset='<label>'.&mt('Randomly Pick: ').
-	    '<input type="text" size="4" onChange="this.form.changeparms.value='."'randompick'".';this.form.submit()" name="randpick_'.$orderidx.'" value="'.
+	    '<input type="text" size="4" onChange="this.form.changeparms.value='."'randompick'".';this.form.submit()" name="randompick_'.$orderidx.'" value="'.
 	    (&LONCAPA::map::getparameter($orderidx,
                                               'parameter_randompick'))[0].
                                               '" />'.
@@ -1961,12 +1948,12 @@ END
 	$line.=(<<ENDPARMS);
   <td class="LC_docs_entry_parameter">
     $form_start
-    <label><input type="checkbox" name="hidprs_$orderidx" onClick="this.form.changeparms.value='hiddenresource';this.form.submit()" $hidtext /> $lt{'hd'}</label>
+    <label><input type="checkbox" name="hiddenresource_$orderidx" onClick="this.form.changeparms.value='hiddenresource';this.form.submit()" $hidtext /> $lt{'hd'}</label>
     $form_end
   </td>
   <td class="LC_docs_entry_parameter">
     $form_start
-    <label><input type="checkbox" name="encprs_$orderidx" onClick="this.form.changeparms.value='encrypturl';this.form.submit()" $enctext /> $lt{'ec'}</label>
+    <label><input type="checkbox" name="encrypturl_$orderidx" onClick="this.form.changeparms.value='encrypturl';this.form.submit()" $enctext /> $lt{'ec'}</label>
     $form_end
   </td>
   <td class="LC_docs_entry_parameter">$form_start $parameterset $form_end</td>
@@ -2675,6 +2662,7 @@ sub handler {
                 'bull' => 'Bulletin Board',
                 'mypi' => 'My Personal Info',
                 'grpo' => 'Group Files',
+                'rost' => 'Course Roster',
 		'abou' => 'About User',
                 'imsf' => 'Import IMS package',
                 'file' =>  'File',
@@ -2745,7 +2733,8 @@ ENDCOURSEVERIFY
 		     &mt('Editing the Table of Contents for your '.$type)));
     }
 # --------------------------------------------------------- Standard documents
-    $r->print('<table class="LC_docs_documents">');#border=2 cellspacing=4 cellpadding=4>');
+    $r->print('<table class="LC_docs_documents">');
+
     if (($standard) && ($allowed) && (!$forcesupplement)) {
 	$r->print('<tr><td class="LC_docs_document">');
 #  '<h2>'.&mt('Main Course Documents').
@@ -2754,6 +2743,8 @@ ENDCOURSEVERIFY
        if ($folder eq '' || $folder eq 'supplemental') {
            $folder='default';
 	   $env{'form.folderpath'}='default&'.&escape(&mt('Main '.$type.' Documents'));
+           $uploadtag = '<input type="hidden" name="folderpath" value="'.
+	       &HTML::Entities::encode($env{'form.folderpath'},'<>&"').'" />';
        }
        my $postexec='';
        if ($folder eq 'default') {
@@ -2762,7 +2753,11 @@ ENDCOURSEVERIFY
            #$postexec='self.close();';
        }
        $hadchanges=0;
-       &editor($r,$coursenum,$coursedom,$folder,$allowed,$upload_output);
+       my $error = &editor($r,$coursenum,$coursedom,$folder,$allowed,
+			   $upload_output);
+       if ($error) {
+	   $r->print('<p><span class="LC_error">'.$error.'</span></p>');
+       }
        if ($hadchanges) {
 	   &mark_hash_old()
        }
@@ -2959,6 +2954,15 @@ value="Group Files=/adm/$coursedom/$cour
 $help{'Group Files'}
 </span>
 </form>
+<br /><form action="/adm/coursedocs" method="post" name="newroster">
+$uploadtag
+<input type="hidden" name="importdetail" 
+value="Course Roster=/adm/viewclasslist" />
+<span class="LC_nobreak">
+<input name="newroster" type="submit" value="$lt{'rost'}" />
+$help{'Course Roster'}
+</span>
+</form>
 ENDFORM
        }
        if ($env{'form.pagepath'}) {
@@ -3000,7 +3004,10 @@ ENDBLOCK
 	   $env{'form.folderpath'}='supplemental&'.
 	       &escape(&mt('Supplemental '.$type.' Documents'));
        }
-       &editor($r,$coursenum,$coursedom,$folder,$allowed);
+       my $error = &editor($r,$coursenum,$coursedom,$folder,$allowed);
+       if ($error) {
+	   $r->print('<p><span class="LC_error">'.$error.'</span></p>');
+       }
        if ($allowed) {
 	   my $folderseq=
 	       '/uploaded/'.$coursedom.'/'.$coursenum.'/supplemental_'.time.
@@ -3236,8 +3243,8 @@ function changename(folderpath,index,old
     }
 }
 
-function removeres(folderpath,index,oldtitle,container,pagesymb) {
-    if (confirm('WARNING: Removing a resource makes associated grades and scores inaccessible!\\nRemove "'+oldtitle+'"?')) {
+function removeres(folderpath,index,oldtitle,container,pagesymb,skip_confirm) {
+    if (skip_confirm || confirm('WARNING: Removing a resource makes associated grades and scores inaccessible!\\nRemove "'+oldtitle+'"?')) {
 	this.document.forms.renameform.markcopy.value=-1;
 	this.document.forms.renameform.cmd.value='del_'+index;
         if (container == 'sequence') {
@@ -3251,8 +3258,8 @@ function removeres(folderpath,index,oldt
     }
 }
 
-function cutres(folderpath,index,oldtitle,container,pagesymb,folder) {
-    if (confirm('WARNING: Cutting a resource makes associated grades and scores inaccessible!\\nGrades remain inaccessible if resource is pasted into another folder.\\nCut "'+oldtitle+'"?')) {
+function cutres(folderpath,index,oldtitle,container,pagesymb,folder,skip_confirm) {
+    if (skip_confirm || confirm('WARNING: Cutting a resource makes associated grades and scores inaccessible!\\nGrades remain inaccessible if resource is pasted into another folder.\\nCut "'+oldtitle+'"?')) {
 	this.document.forms.renameform.cmd.value='cut_'+index;
 	this.document.forms.renameform.markcopy.value=index;
 	this.document.forms.renameform.copyfolder.value=folder+'.'+container;