--- loncom/interface/lonextresedit.pm	2016/01/26 14:30:25	1.9
+++ loncom/interface/lonextresedit.pm	2016/06/06 17:40:48	1.10
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Documents
 #
-# $Id: lonextresedit.pm,v 1.9 2016/01/26 14:30:25 raeburn Exp $
+# $Id: lonextresedit.pm,v 1.10 2016/06/06 17:40:48 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -259,32 +259,44 @@ sub process_changes {
 sub update_exttool {
     my ($marker,$cdom,$cnum,$args) = @_;
     my %toolhash=&Apache::lonnet::dump('exttool_'.$marker,$cdom,$cnum);
-    my (%newhash,$changed,$errormsg);
-    ($newhash{'target'},$newhash{'width'},$newhash{'height'}) = split(/:/,$args);
+    my (%newhash,$changed,@deleted,$errormsg);
+    ($newhash{'target'},$newhash{'width'},$newhash{'height'},$newhash{'crslabel'},$newhash{'crstitle'}) = split(/:/,$args);
+    $newhash{'crslabel'} = &unescape($newhash{'crslabel'});
+    $newhash{'crstitle'} = &unescape($newhash{'crstitle'});
     my %toolhash=&Apache::lonnet::dump('exttool_'.$marker,$cdom,$cnum);
-    foreach my $item ('target','width','height') {
+    foreach my $item ('target','width','height','crslabel','crstitle') {
         $newhash{$item} =~ s/^\s+//;
         $newhash{$item} =~ s/\s+$//;
-        unless ($item eq 'target') {
+        if (($item eq 'width') || ($item eq 'height')) {
             if ($newhash{'target'} eq 'iframe') {
                 $newhash{$item} = '';
             }
         }
         if ($toolhash{$item} ne $newhash{$item}) {
             if ($newhash{$item} eq '') {
-                delete($toolhash{$item});
+                unless (($item eq 'target') ||
+                        ((($item eq 'width') || ($item eq 'height')) &&
+                         (($newhash{'target'} eq 'window') || 
+                          (($newhash{'target'} eq '') && ($toolhash{'target'} eq 'window'))))) {
+                    delete($toolhash{$item});
+                    push(@deleted,$item);
+                    $changed = 1;
+                }
             } else {
                 $toolhash{$item} = $newhash{$item};
+                $changed = 1; 
             }
-            $changed = 1;
         }
     }
     if ($changed) {
         my $putres = &Apache::lonnet::put('exttool_'.$marker,\%toolhash,$cdom,$cnum);
         unless ($putres eq 'ok') {
-             $errormsg = &mt('Failed to save updated settings.').' '.&mt('Error: [_1].',$putres);
+            $errormsg = &mt('Failed to save updated settings.').' '.&mt('Error: [_1].',$putres);
         }
     }
+    if (@deleted) {
+        &Apache::lonnet::del('exttool_'.$marker,\@deleted,$cdom,$cnum);
+    }
     return ($changed,$errormsg);
 }
 
@@ -313,14 +325,17 @@ sub extedit_form {
         $tabid = 'ee';
     }
     my ($formname,$formid,$toggle,$fieldsetid,$urlid,$dispdivstyle,$dimendivstyle,
-        $legend,$urlelem,$toolelem,%toolattr);
+        $labelstyle,$titlestyle,$legend,$urlelem,$toolelem,%toolattr);
     $formname = 'new'.$type;
     $toggle = $type;
     $fieldsetid = 'upload'.$type.'form';
     $urlid = $type.'url';
-    map { $toolattr{$_} = $type.$_; } ('dispdiv','dimendiv','dimenwidth','dimenheight');
+    map { $toolattr{$_} = $type.$_; } ('dispdiv','dimendiv','dimenwidth','dimenheight',
+                                       'crstitlediv','crslabeldiv','crstitle','crslabel');
     $dispdivstyle = 'display:none';
     $dimendivstyle = 'display:none';
+    $labelstyle = 'display:none';
+    $titlestyle = 'display:none';
     if ($supplementalflag) {
         $formname = 'newsupp'.$type;
         $toggle = 'supp'.$type;
@@ -328,7 +343,7 @@ sub extedit_form {
         $urlid = 'supp'.$type.'url';
         map { $toolattr{$_} = 'supp'.$toolattr{$_}; } (keys(%toolattr));
     }
-    my ($link,$legend,$active,$srcclass,$extsrc,$preview,$title,$save,
+    my ($link,$legend,$active,$srcclass,$extsrc,$preview,$title,$save,$crstitle,$crslabel,
         $fieldsetstyle,$action,$hiddenelem,$form,$width,$height,$tooltarget,%chkstate);
     $fieldsetstyle = 'display: none;';
     $action = '/adm/coursedocs';
@@ -404,7 +419,6 @@ sub extedit_form {
                 my $marker = $1;
                 my %toolhash=&Apache::lonnet::dump('exttool_'.$marker,$cdom,$cnum);
                 if ($toolhash{'id'}) {
-                    $dispdivstyle = 'display:block';
                     if (ref($ltitools) eq 'HASH') {
                         if (keys(%{$ltitools})) {
                             if (ref($ltitools->{$toolhash{'id'}}) eq 'HASH') {
@@ -423,6 +437,19 @@ sub extedit_form {
                                 }
                                 $width = $toolhash{'width'};
                                 $height = $toolhash{'height'};
+                                if (ref($ltitools->{$toolhash{'id'}}->{'crsconf'}) eq 'HASH') {
+                                    if ($ltitools->{$toolhash{'id'}}->{'crsconf'}->{'title'}) {
+                                        $crstitle = $toolhash{'crstitle'};
+                                        $titlestyle = 'display:inline';
+                                    }
+                                    if ($ltitools->{$toolhash{'id'}}->{'crsconf'}->{'label'}) {  
+                                        $crslabel = $toolhash{'crslabel'};
+                                        $labelstyle = 'display:inline';
+                                    }
+                                    if ($ltitools->{$toolhash{'id'}}->{'crsconf'}->{'target'}) {
+                                        $dispdivstyle = 'display:block';
+                                    }
+                                }
                                 $toolelem = '<span class="LC_nobreak">'.$image.'&nbsp;'.$tooltitle.'</span><br />';
                             }
                         }
@@ -452,7 +479,9 @@ sub extedit_form {
                     }
                 }
             }
-            $toolelem .= '</select></span>';
+            $toolelem .= '</select></span><br />';
+            $crslabel = $env{'course.'.$cdom.'_'.$cnum.'.internal.coursecode'};
+            $crstitle = $env{'course.'.$cdom.'_'.$cnum.'.description'};
         }
         $toolelem .= '<div id="'.$toolattr{'dispdiv'}.'" style="'.$dispdivstyle.'">'.
                     '<span class="'.$class.'">'.&mt('Display target:').'&nbsp;'.
@@ -464,7 +493,15 @@ sub extedit_form {
                     '<span class="'.$class.'">'.
                     &mt('Width').'<input type="text" id="'.$toolattr{'dimenwidth'}.'" name="exttoolwidth" value="'.$width.'">'.('&nbsp;'x2).
                     &mt('Height').'<input type="text" id="'.$toolattr{'dimenheight'}.'" name="exttoolheight" value="'.$height.'"></span>'."\n".
-                    '</div></div>';
+                    '</div></div>'.
+                    '<div id="'.$toolattr{'crslabeldiv'}.'" style="'.$labelstyle.'">'.
+                    '<span class="'.$class.'">'.&mt('Course label:').'&nbsp;'.
+                    '<input type="text" id="'.$toolattr{'crslabel'}.'" name="exttoollabel" value="'.$crslabel.'"><br />'.
+                    '</div>'.
+                    '<div id="'.$toolattr{'crstitlediv'}.'" style="'.$titlestyle.'">'.
+                    '<span class="'.$class.'">'.&mt('Course title:').'&nbsp;'.
+                    '<input type="text" id="'.$toolattr{'crstitle'}.'" name="exttooltitle" value="'.$crstitle.'"><br />'.
+                    '</div>';
     }
     my $chooser = $toolelem;
     if ($type eq 'ext') {
@@ -491,7 +528,7 @@ $title
 <input type="hidden" name="importdetail" value="" />
 $pathitem
 $hiddenelem
-<input type="button" value="$save" onclick="javascript:setExternal(this.form,'$residx','$type','$orig_url');" />
+<input type="button" value="$save" onclick="javascript:setExternal(this.form,'$residx','$type','$orig_url','$supplementalflag');" />
 </span>
 </div>
 </fieldset>
@@ -545,7 +582,10 @@ sub extedit_javascript {
         $toolsjs = "        var ltitools = new Array($num);\n".
                    "        var ltitoolsTarget = new Array($num);\n".
                    "        var ltitoolsWidth = new Array($num);\n".
-                   "        var ltitoolsHeight = new Array($num);\n"; 
+                   "        var ltitoolsHeight = new Array($num);\n".
+                   "        var ltitoolsDisplay = new Array($num);\n".
+                   "        var ltitoolsLabel = new Array($num);\n".
+                   "        var ltitoolsTitle = new Array($num);\n";
         my $i = 0;
         foreach my $key (sort { $a <=> $b } keys(%{$toolsref})) {
             if (ref($toolsref->{$key})) {
@@ -556,6 +596,15 @@ sub extedit_javascript {
                             '        ltitoolsTarget['.$i.'] = '."'$target';\n".
                             '        ltitoolsWidth['.$i.'] = '."'$width';\n".
                             '        ltitoolsHeight['.$i.'] = '."'$height';\n";
+                my %courseconfig;
+                if (ref($toolsref->{$key}->{'crsconf'}) eq 'HASH') {
+                    my $display = $toolsref->{$key}->{'crsconf'}->{'target'};
+                    $toolsjs .= '         ltitoolsDisplay['.$i.'] = '."'$display';\n";
+                    my $label = $toolsref->{$key}->{'crsconf'}->{'label'};
+                    $toolsjs .= '         ltitoolsLabel['.$i.'] = '."'$label';\n";
+                    my $title = $toolsref->{$key}->{'crsconf'}->{'title'};
+                    $toolsjs .= '         ltitoolsTitle['.$i.'] = '."'$title';\n";
+                }
                 $i++;
             }
         }
@@ -575,7 +624,7 @@ ENDREGEXP
 
 var regexp = $urlregexp;
 
-function setExternal(extform,residx,type,exttoolurl) {
+function setExternal(extform,residx,type,exttoolurl,supplementalflag) {
     var title=extform.exttitle.value;
     if (!String.trim) {
         String.prototype.trim = function() {return this.replace(\/^\\s+|\\s+$\/g, "");};    }
@@ -610,20 +659,56 @@ function setExternal(extform,residx,type
             }
             info += ':'+toolid;
         }
-        if (extform.exttooltarget.length) {
-            for (var i=0; i<extform.exttooltarget.length; i++) {
-                if (extform.exttooltarget[i].checked) {
-                    if (extform.exttooltarget[i].value == 'window') {
-                        var width = extform.exttoolwidth.value;
-                        width.trim();
-                        var height = extform.exttoolheight.value;
-                        height.trim();
-                        info += ':window:'+width+':'+height;  
-                    } else {
-                        info += ':iframe';
+        var prefix = '';
+        if (supplementalflag == 1) {
+           prefix = 'supp';
+        }
+        var dispdiv = prefix+'tooldispdiv';
+        if (residx > 0) {
+            dispdiv += '_'+residx;
+        }
+        if (document.getElementById(dispdiv)) {
+            if (document.getElementById(dispdiv).style.display == 'block') {
+                if (extform.exttooltarget.length) {
+                    for (var i=0; i<extform.exttooltarget.length; i++) {
+                        if (extform.exttooltarget[i].checked) {
+                            if (extform.exttooltarget[i].value == 'window') {
+                                var width = extform.exttoolwidth.value;
+                                width.trim();
+                                var height = extform.exttoolheight.value;
+                                height.trim();
+                                info += ':window:'+width+':'+height;  
+                            } else {
+                                info += ':iframe::';
+                            }
+                        }
                     }
                 }
+            } else {
+                info += ':::';
             }
+        } else {
+            info += ':::';
+        }
+        var labelinput = prefix+'toolcrslabel';
+        var titleinput = prefix+'toolcrstitle';
+        if (residx > 0) {
+            labelinput += '_'+residx;
+            titleinput += '_'+residx;
+        }
+        if (document.getElementById(labelinput)) {
+            var crslabel = document.getElementById(labelinput).value;
+            crslabel.trim();
+            info += ':'+escape(crslabel);
+        } else {
+            info += ':';
+        } 
+        if (document.getElementById(titleinput)) {
+            var crstitle = document.getElementById(titleinput).value;
+            crstitle.trim();
+            info += ':'+escape(crstitle);
+        } else {
+            info += ':';
         }
         info=escape(info);
         if (residx > 0) {
@@ -668,6 +753,10 @@ function updateExttool(caller,form,suppl
     dimendiv = prefix+'tooldimendiv';
     widthinput = prefix+'toolwidth';
     heightinput = prefix+'toolheight';
+    labeldiv = prefix+'toolcrslabeldiv';
+    titlediv = prefix+'toolcrstitlediv';
+    labelinput = prefix+'toolcrslabel';
+    titleinput = prefix+'toolcrstitle';
     if (document.getElementById(dispdiv)) {
         var toolpick = caller.options[caller.selectedIndex].value;
         $toolsjs
@@ -678,41 +767,63 @@ function updateExttool(caller,form,suppl
             if (document.getElementById(dimendiv)) {
                 document.getElementById(dimendiv).style.display = 'none';
             }
-        } else {
-            if (document.getElementById(dispdiv)) {
-                document.getElementById(dispdiv).style.display = 'block';
+            if (document.getElementById(labeldiv)) {
+                document.getElementById(labeldiv).style.display = 'none';
+            }
+            if (document.getElementById(titlediv)) {
+                document.getElementById(titlediv).style.display = 'none';
             }
+        } else {
             if (ltitools.length > 0) {
                 for (var j=0; j<ltitools.length; j++) {
                     if (ltitools[j] == toolpick) {
-                        if (form.exttooltarget.length) {
-                            for (var k=0; k<form.exttooltarget.length; k++) {
-                                if (form.exttooltarget[k].value == ltitoolsTarget[j]) {
-                                    form.exttooltarget[k].checked = true;
-                                    break;
+                        if (document.getElementById(dispdiv)) {
+                            if (ltitoolsDisplay[j]) {
+                                document.getElementById(dispdiv).style.display = 'block';
+                                if (form.exttooltarget.length) {
+                                    for (var k=0; k<form.exttooltarget.length; k++) {
+                                        if (form.exttooltarget[k].value == ltitoolsTarget[j]) {
+                                            form.exttooltarget[k].checked = true;
+                                            break;
+                                        }
+                                    }
+                                }
+                                if (ltitoolsTarget[j] == 'window') {
+                                    dimen = 'block';
+                                    dimenwidth = ltitoolsWidth[j];
+                                    dimenheight = ltitoolsHeight[j];                    
+                                } else {
+                                    dimen = 'none';
+                                    dimenwidth = '';
+                                    dimenheight = '';
+                                }
+                                if (document.getElementById(dimendiv)) {
+                                    document.getElementById(dimendiv).style.display = dimen;
+                                }
+                                if (document.getElementById(widthinput)) {
+                                    document.getElementById(widthinput).value = dimenwidth;
+                                }
+                                if (document.getElementById(heightinput)) {
+                                    document.getElementById(heightinput).value = dimenheight;
                                 }
                             }
                         }
-                        if (ltitoolsTarget[j] == 'window') {
-                            dimen = 'block';
-                            dimenwidth = ltitoolsWidth[j];
-                            dimenheight = ltitoolsHeight[j];                    
-                        } else {
-                            dimen = 'none';
-                            dimenwidth = '';
-                            dimenheight = '';
-                        }
-                        if (document.getElementById(dimendiv)) {
-                            document.getElementById(dimendiv).style.display = dimen;
-                        }
-                        if (document.getElementById(widthinput)) {
-                            document.getElementById(widthinput).value = dimenwidth;
+                        if (document.getElementById(labeldiv)) {
+                            if (ltitoolsLabel[j]) {
+                                document.getElementById(labeldiv).style.display = 'inline';
+                            } else {
+                                document.getElementById(labeldiv).style.display = 'none';
+                            } 
                         }
-                        if (document.getElementById(heightinput)) {
-                            document.getElementById(heightinput).value = dimenheight;
+                        if (document.getElementById(titlediv)) {
+                            if (ltitoolsTitle[j]) {
+                                document.getElementById(titlediv).style.display = 'inline';
+                            } else {
+                                document.getElementById(titlediv).style.display = 'none';
+                            }
                         }
+                        break;
                     }
-                    break;
                 }
             }
         }