--- loncom/interface/lonextresedit.pm	2022/09/09 14:29:45	1.8.2.4.2.3
+++ loncom/interface/lonextresedit.pm	2016/01/26 14:30:25	1.9
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Documents
 #
-# $Id: lonextresedit.pm,v 1.8.2.4.2.3 2022/09/09 14:29:45 raeburn Exp $
+# $Id: lonextresedit.pm,v 1.9 2016/01/26 14:30:25 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -60,7 +60,7 @@ sub handler {
         $symb,$type);
     if (($env{'form.folderpath'} =~ /^supplemental/) && ($env{'form.suppurl'})) {
         $supplementalflag = 1;
-        if (&unescape($env{'form.suppurl'}) =~ m{^/adm/$cdom/$cnum/\d+/ext\.tool$}) {
+        if (&unescape($env{'form.suppurl'}) =~ m{^/adm/$cdom/$cnum/\d+/exttools?$}) {
             $type = 'tool';
         }
     }
@@ -79,7 +79,7 @@ sub handler {
             if ($symb ne $env{'form.symb'}) {
                 $env{'form.symb'} = $symb;
             }
-            if ($url =~ m{/adm/$cdom/$cnum/\d+/ext\.tool$}) {
+            if ($url =~ m{/adm/$cdom/$cnum/\d+/exttools?$}) {
                 $type = 'tool';
             }
         }
@@ -98,7 +98,7 @@ sub handler {
     }
     my %ltitools;
     if ($type eq 'tool') {
-        %ltitools = &Apache::lonnet::get_domain_lti($cdom,'consumer');
+        %ltitools = &Apache::lonnet::get_domain_ltitools($cdom);
     }
     my $js = &Apache::lonhtmlcommon::scripttag(&extedit_javascript());
     my $pathitem = '<input type="hidden" name="folderpath" value="'.
@@ -146,7 +146,7 @@ sub process_changes {
         $oldtitle = &unescape($env{'form.title'});
         $container = 'sequence';
         $supplementalflag = 1;
-        if ($oldurl =~ m{^/adm/$cdom/$cnum/\d+/ext\.tool$}) {
+        if ($oldurl =~ m{^/adm/$cdom/$cnum/\d+/exttools?$}) {
             $type = 'tool';
         } else {
             $type = 'ext';
@@ -157,7 +157,7 @@ sub process_changes {
     if ($env{'form.importdetail'}) {
         ($newtitle,$newurl,$newidx) =
             map {&unescape($_)} split(/\=/,$env{'form.importdetail'});
-        if ($newurl =~ m{^(/adm/$cdom/$cnum/(\d+)/ext\.tool)\:?(.*)$}) {
+        if ($newurl =~ m{^(/adm/$cdom/$cnum/(\d+)/exttools?)\:?(.*)$}) {
             $newurl = $1;
             $marker = $2;
             $args = $3;
@@ -258,59 +258,39 @@ sub process_changes {
 
 sub update_exttool {
     my ($marker,$cdom,$cnum,$args) = @_;
-    my (%newhash,$changed,@deleted,$errormsg);
-    ($newhash{'target'},$newhash{'width'},$newhash{'height'},$newhash{'linktext'},$newhash{'explanation'},
-     $newhash{'crslabel'},$newhash{'crstitle'},$newhash{'crsappend'}) = split(/:/,$args);
-    foreach my $item ('linktext','explanation','crslabel','crstitle','crsappend') {
-        $newhash{$item} = &unescape($newhash{$item});
-    }
     my %toolhash=&Apache::lonnet::dump('exttool_'.$marker,$cdom,$cnum);
-    foreach my $item ('target','width','height','linktext','explanation','crslabel','crstitle','crsappend') {
+    my (%newhash,$changed,$errormsg);
+    ($newhash{'target'},$newhash{'width'},$newhash{'height'}) = split(/:/,$args);
+    my %toolhash=&Apache::lonnet::dump('exttool_'.$marker,$cdom,$cnum);
+    foreach my $item ('target','width','height') {
         $newhash{$item} =~ s/^\s+//;
         $newhash{$item} =~ s/\s+$//;
-        if (($item eq 'width') || ($item eq 'height') || ($item eq 'linktext') || ($item eq 'explanation')) {
+        unless ($item eq 'target') {
             if ($newhash{'target'} eq 'iframe') {
                 $newhash{$item} = '';
-            } elsif ($newhash{'target'} eq 'tab') {
-                if (($item eq 'width') || ($item eq 'height')) {
-                    $newhash{$item} = '';
-                }
             }
         }
         if ($toolhash{$item} ne $newhash{$item}) {
             if ($newhash{$item} eq '') {
-                unless (($item eq 'target') ||
-                        ((($item eq 'width') || ($item eq 'height')) &&
-                         (($newhash{'target'} eq 'window') || 
-                          (($newhash{'target'} eq '') && ($toolhash{'target'} eq 'window')))) ||
-                        ((($item eq 'linktext') || ($item eq 'explanation')) &&
-                         ((($newhash{'target'} =~ /^(window|tab)$/)) ||
-                         (($newhash{'target'} eq '') && ($toolhash{'target'} =~ /^(window|tab)$/))))) {
-                    delete($toolhash{$item});
-                    push(@deleted,$item);
-                    $changed = 1;
-                }
+                delete($toolhash{$item});
             } else {
                 $toolhash{$item} = $newhash{$item};
-                $changed = 1; 
             }
+            $changed = 1;
         }
     }
     if ($changed) {
         my $putres = &Apache::lonnet::put('exttool_'.$marker,\%toolhash,$cdom,$cnum);
         unless ($putres eq 'ok') {
-            $errormsg = &mt('Failed to save updated settings.').' '.&mt('Error: [_1].',$putres);
+             $errormsg = &mt('Failed to save updated settings.').' '.&mt('Error: [_1].',$putres);
         }
     }
-    if (@deleted) {
-        &Apache::lonnet::del('exttool_'.$marker,\@deleted,$cdom,$cnum);
-    }
     return ($changed,$errormsg);
 }
 
 sub extedit_form {
     my ($supplementalflag,$residx,$orig_url,$orig_title,$pathitem,$helpitem,$caller,
-        $symb,$type,$cdom,$cnum,$ltitools,$disabled) = @_;
+        $symb,$type,$cdom,$cnum,$ltitools) = @_;
     if ($type ne 'tool') {
         $type = 'ext';
     }
@@ -333,25 +313,14 @@ sub extedit_form {
         $tabid = 'ee';
     }
     my ($formname,$formid,$toggle,$fieldsetid,$urlid,$dispdivstyle,$dimendivstyle,
-        $windivstyle,$linktextstyle,$explanationstyle,$labelstyle,$titlestyle,
-        $appendstyle,$legend,$urlelem,$toolelem,%toolattr);
+        $legend,$urlelem,$toolelem,%toolattr);
     $formname = 'new'.$type;
     $toggle = $type;
     $fieldsetid = 'upload'.$type.'form';
     $urlid = $type.'url';
-    map { $toolattr{$_} = $type.$_; } ('dispdiv','dimendiv','dimenwidth','dimenheight',
-                                       'crstitlediv','crslabeldiv','crsappenddiv',
-                                       'crstitle','crslabel','crsappend','windiv',
-                                       'linktextdiv','explanationdiv','linktext',
-                                       'explanation','providerurl');
+    map { $toolattr{$_} = $type.$_; } ('dispdiv','dimendiv','dimenwidth','dimenheight');
     $dispdivstyle = 'display:none';
     $dimendivstyle = 'display:none';
-    $windivstyle = 'display:none';
-    $linktextstyle = 'display:none';
-    $explanationstyle = 'display:none';
-    $labelstyle = 'display:none';
-    $titlestyle = 'display:none';
-    $appendstyle = 'display:none';
     if ($supplementalflag) {
         $formname = 'newsupp'.$type;
         $toggle = 'supp'.$type;
@@ -359,24 +328,18 @@ sub extedit_form {
         $urlid = 'supp'.$type.'url';
         map { $toolattr{$_} = 'supp'.$toolattr{$_}; } (keys(%toolattr));
     }
-    my ($link,$legend,$active,$srcclass,$extsrc,$preview,$title,$save,$crstitle,$crslabel,
-        $crsappend,$fieldsetstyle,$action,$hiddenelem,$form,$width,$height,$tooltarget,
-        $linktext,$explanation,$providerurl,%chkstate);
+    my ($link,$legend,$active,$srcclass,$extsrc,$preview,$title,$save,
+        $fieldsetstyle,$action,$hiddenelem,$form,$width,$height,$tooltarget,%chkstate);
     $fieldsetstyle = 'display: none;';
     $action = '/adm/coursedocs';
-    my $protocol = ($ENV{'SERVER_PORT'} == 443?'https':'http');
-    my $rows = 2;
-    my $cols = 20;
     if ($residx) {
         if ($caller eq 'direct') {
             $fieldsetstyle = 'display: block;';
             $action = '/adm/extresedit';
-            $rows = 10;
-            $cols = 45;
             if ($type eq 'tool') {
-                $legend = $lt{'te'};
-            } else {
                 $legend = $lt{'ee'};
+            } else {
+                $legend = $lt{'te'};
             }
             $legend = '<legend>'.$legend.'</legend>';
             if ($symb) {
@@ -399,7 +362,7 @@ sub extedit_form {
         $srcclass = ' class="LC_nobreak"';
         if ($type eq 'ext') {
             $extsrc = '<span class="LC_docs_ext_edit">'.$lt{'ul'}.'&nbsp;</span>';
-            $preview = '&nbsp;<a class="LC_docs_ext_edit" href="javascript:extUrlPreview('."'$urlid','$protocol'".');">'.$lt{'pr'}.'</a>';
+            $preview = '&nbsp;<a class="LC_docs_ext_edit" href="javascript:extUrlPreview('."'$urlid'".');">'.$lt{'pr'}.'</a>';
         }
         $title = '<span class="LC_docs_ext_edit">'.$lt{'ti'}.'&nbsp;</span>';
         $save = $lt{'sv'};
@@ -421,26 +384,27 @@ sub extedit_form {
             $orig_url = 'http://';
             $orig_title = $lt{'ex'};
             $extsrc = $lt{'ul'}.':<br />';
-            $preview = '<input type="button" name="view" value="'.$lt{'pr'}.'" onclick="javascript:extUrlPreview('."'$urlid','$protocol'".');"'.$disabled.' />';
+            $preview = '<input type="button" name="view" value="'.$lt{'pr'}.'" onclick="javascript:extUrlPreview('."'$urlid'".');" />';
             $save = $lt{'al'};
         } else {
             $orig_title = $lt{'et'};
             $save = $lt{'at'};
-            $orig_url = "/adm/$cdom/$cnum/new/ext\.tool"; 
+            $orig_url = "/adm/$cdom/$cnum/new/exttool"; 
         }
         $pathitem .= '<br />';
     }
     $formid = $formname;
     if ($type eq 'ext') {
-        $urlelem = '<input type="text" size="'.$size.'" name="exturl" id="'.$urlid.'" value="'.$orig_url.'"'.$disabled.' />';
+        $urlelem = '<input type="text" size="'.$size.'" name="exturl" id="'.$urlid.'" value="'.$orig_url.'" />';
     } else {
         my $class = 'LC_nobreak';
         if ($residx) {
             $class = 'LC_docs_ext_edit LC_nobreak'; 
-            if ($orig_url =~ m{^/adm/$cdom/$cnum/(\d+)/ext\.tool$}) {
+            if ($orig_url =~ m{^/adm/$cdom/$cnum/(\d+)/exttools?$}) {
                 my $marker = $1;
                 my %toolhash=&Apache::lonnet::dump('exttool_'.$marker,$cdom,$cnum);
                 if ($toolhash{'id'}) {
+                    $dispdivstyle = 'display:block';
                     if (ref($ltitools) eq 'HASH') {
                         if (keys(%{$ltitools})) {
                             if (ref($ltitools->{$toolhash{'id'}}) eq 'HASH') {
@@ -450,49 +414,15 @@ sub extedit_form {
                                 if ($icon) {
                                     $image = '<img src="'.$icon.'" alt="'.$tooltitle.'" />';
                                 }
-                                if ($ltitools->{$toolhash{'id'}}->{'url'} =~ m{://}) {
-                                    (my $prot,my $host,$providerurl) = ($ltitools->{$toolhash{'id'}}->{'url'} =~ m{^([^/]+)://([^/]+)(|/.+)$});
-                                } else {
-                                    $providerurl = $ltitools->{$toolhash{'id'}}->{'url'};
-                                }
                                 $tooltarget = $toolhash{'target'};
                                 if ($tooltarget eq 'window') {
                                     $dimendivstyle = 'display:block';
-                                    $windivstyle = 'display:block';
                                     $chkstate{'window'} = 'checked="checked" ';
-                                } elsif ($tooltarget eq 'tab') {
-                                    $windivstyle = 'display:block';
-                                    $chkstate{'tab'} = 'checked="checked" ';
                                 } else {
                                     $chkstate{'iframe'} = 'checked="checked" ';
                                 }
                                 $width = $toolhash{'width'};
                                 $height = $toolhash{'height'};
-                                $linktext = $toolhash{'linktext'};
-                                $explanation = $toolhash{'explanation'};
-                                if (ref($ltitools->{$toolhash{'id'}}->{'crsconf'}) eq 'HASH') {
-                                    if ($ltitools->{$toolhash{'id'}}->{'crsconf'}->{'title'}) {
-                                        $crstitle = $toolhash{'crstitle'};
-                                        $titlestyle = 'display:inline';
-                                    }
-                                    if ($ltitools->{$toolhash{'id'}}->{'crsconf'}->{'label'}) {  
-                                        $crslabel = $toolhash{'crslabel'};
-                                        $labelstyle = 'display:inline';
-                                    }
-                                    if ($ltitools->{$toolhash{'id'}}->{'crsconf'}->{'append'}) {
-                                        $crsappend = $toolhash{'crsappend'};
-                                        $appendstyle = 'display:inline';
-                                    }
-                                    if ($ltitools->{$toolhash{'id'}}->{'crsconf'}->{'target'}) {
-                                        $dispdivstyle = 'display:block';
-                                    }
-                                    if ($ltitools->{$toolhash{'id'}}->{'crsconf'}->{'linktext'}) {
-                                        $linktextstyle = 'padding:0;display:inline';
-                                    }
-                                    if ($ltitools->{$toolhash{'id'}}->{'crsconf'}->{'explanation'}) {
-                                        $explanationstyle = 'padding:0;display:inline';
-                                    }
-                                }
                                 $toolelem = '<span class="LC_nobreak">'.$image.'&nbsp;'.$tooltitle.'</span><br />';
                             }
                         }
@@ -502,7 +432,7 @@ sub extedit_form {
         } else {
             $toolelem = '<span class="LC_docs_ext_edit">'."\n".
                        '<select name="exttoolid" id="LC_exttoolid" onchange="javascript:updateExttool(this,'.
-                       'this.form,'."'$supplementalflag'".');"'.$disabled.'>'."\n".
+                       'this.form,'."'$supplementalflag'".');">'."\n".
                        '<option value="" selected="selected">'.&mt('Select').'</option>';
             my %bynum;
             if (ref($ltitools) eq 'HASH') {
@@ -522,48 +452,19 @@ sub extedit_form {
                     }
                 }
             }
-            $toolelem .= '</select></span><br />';
-            $crslabel = $env{'course.'.$cdom.'_'.$cnum.'.internal.coursecode'};
-            $crstitle = $env{'course.'.$cdom.'_'.$cnum.'.description'};
-            $crsappend = '';
+            $toolelem .= '</select></span>';
         }
         $toolelem .= '<div id="'.$toolattr{'dispdiv'}.'" style="'.$dispdivstyle.'">'.
                     '<span class="'.$class.'">'.&mt('Display target:').'&nbsp;'.
                     '<label><input type="radio" name="exttooltarget" value="iframe" '.$chkstate{'iframe'}.'onclick="updateTooldim(this.form,'.
-                    "'$toolattr{dimendiv}','$toolattr{windiv}','$toolattr{dimenwidth}','$toolattr{dimenheight}',
-                    '$toolattr{linktext}','$toolattr{explanation}'".');"'.$disabled.' />'.&mt('iframe').'</label>'.('&nbsp;'x2).
-                    '<label><input type="radio" name="exttooltarget" value="tab" '.$chkstate{'tab'}.'onclick="updateTooldim(this.form,'.
-                    "'$toolattr{dimendiv}','$toolattr{windiv}','$toolattr{dimenwidth}','$toolattr{dimenheight}',
-                    '$toolattr{linktext}','$toolattr{explanation}'".');"'.$disabled.' />'.&mt('tab').'</label>'.('&nbsp;'x2).
+                    "'$toolattr{dimendiv}','$toolattr{dimenwidth}','$toolattr{dimenheight}'".');">'.&mt('iframe').'</label>'.('&nbsp;'x2).
                     '<label><input type="radio" name="exttooltarget" value="window" '.$chkstate{'window'}.'onclick="updateTooldim(this.form,'.
-                    "'$toolattr{dimendiv}','$toolattr{windiv}','$toolattr{dimenwidth}','$toolattr{dimenheight}',
-                    '$toolattr{linktext}','$toolattr{explanation}'".');"'.$disabled.' />'.&mt('window').'</label></span>'.
-                    '<div id="'.$toolattr{'dimendiv'}.'" style="'.$dimendivstyle.'"><span class="'.$class.'">'.
-                    &mt('Width').':&nbsp;<input type="text" size="4" id="'.$toolattr{'dimenwidth'}.'" name="exttoolwidth" value="'.$width.'"'.$disabled.' />'.('&nbsp;'x2).
-                    &mt('Height').':&nbsp;<input type="text" size="4" id="'.$toolattr{'dimenheight'}.'" name="exttoolheight" value="'.$height.'"'.$disabled.' /></span>'."\n".
+                    "'$toolattr{dimendiv}','$toolattr{dimenwidth}','$toolattr{dimenheight}'".');">'.&mt('window').'</label>'.
+                    '</span><div id="'.$toolattr{'dimendiv'}.'" style="'.$dimendivstyle.'">'. 
+                    '<span class="'.$class.'">'.
+                    &mt('Width').'<input type="text" id="'.$toolattr{'dimenwidth'}.'" name="exttoolwidth" value="'.$width.'">'.('&nbsp;'x2).
+                    &mt('Height').'<input type="text" id="'.$toolattr{'dimenheight'}.'" name="exttoolheight" value="'.$height.'"></span>'."\n".
                     '</div></div>';
-        $toolelem .= '<div id="'.$toolattr{'windiv'}.'" style="'.$windivstyle.'">'.
-                     '<div id="'.$toolattr{'linktextdiv'}.'" class="LC_left_float" style="'.$linktextstyle.'">'.
-                     '<span class="'.$class.'">'.&mt('Link Text').'</span><br /><input type="text" size="25" id="'.$toolattr{'linktext'}.
-                     '" name="exttoollinktext" value="'.$linktext.'"'.$disabled.' />'.
-                     '</div><div id="'.$toolattr{'explanationdiv'}.'" class="LC_left_float" style="'.$explanationstyle.'">'.
-                     '<span class="'.$class.'">'.&mt('Explanation').'</span><br />'.
-                     '<textarea rows="'.$rows.'" cols="'.$cols.'" id="'.$toolattr{'explanation'}.'" name="exttoolexplanation" '.$disabled.'>'.
-                     $explanation.'</textarea></div><div style="padding:0;clear:both;margin:0;border:0"></div>'.
-                     '</div>';
-        $toolelem .= '<div id="'.$toolattr{'crslabeldiv'}.'" style="'.$labelstyle.'">'.
-                    '<span class="'.$class.'">'.&mt('Course label:').'&nbsp;'.
-                    '<input type="text" id="'.$toolattr{'crslabel'}.'" name="exttoollabel" value="'.$crslabel.'"'.$disabled.' /></span><br />'.
-                    '</div>'.
-                    '<div id="'.$toolattr{'crstitlediv'}.'" style="'.$titlestyle.'">'.
-                    '<span class="'.$class.'">'.&mt('Course title:').'&nbsp;'.
-                    '<input type="text" id="'.$toolattr{'crstitle'}.'" name="exttooltitle" value="'.$crstitle.'"'.$disabled.' /></span><br />'.
-                    '</div>'.
-                    '<div id="'.$toolattr{'crsappenddiv'}.'" style="'.$appendstyle.'">'.
-                    '<span class="'.$class.'">'.&mt('Append to URL[_1]',
-                    '<span id="'.$toolattr{'providerurl'}.'">&nbsp;('.$providerurl.')<br /></span>').
-                    '<input type="text" id="'.$toolattr{'crsappend'}.'" size="30" name="exttoolappend" value="'.$crsappend.'"'.$disabled.' /></span><br />'.
-                    '</div>';
     }
     my $chooser = $toolelem;
     if ($type eq 'ext') {
@@ -586,11 +487,11 @@ $chooser
 <div>
 <span$srcclass>
 $title
-<input type="text" size="$size" name="exttitle" value="$orig_title" $disabled />
+<input type="text" size="$size" name="exttitle" value="$orig_title" />
 <input type="hidden" name="importdetail" value="" />
 $pathitem
 $hiddenelem
-<input type="button" value="$save" onclick="javascript:setExternal(this.form,'$residx','$type','$orig_url','$supplementalflag');" $disabled />
+<input type="button" value="$save" onclick="javascript:setExternal(this.form,'$residx','$type','$orig_url');" />
 </span>
 </div>
 </fieldset>
@@ -604,8 +505,8 @@ ENDFORM
 }
 
 sub display_editor {
-    my ($url,$folderpath,$symb,$idx,$type,$cdom,$cnum,$hostname) = @_;
-    my ($residx,$supplementalflag,$title,$pathitem,$output,$js,$navmap);
+    my ($url,$folderpath,$symb,$idx,$type,$cdom,$cnum) = @_;
+    my ($residx,$supplementalflag,$title,$pathitem,$output,$js);
     if ($folderpath =~ /^supplemental/) {
         $supplementalflag = 1;
         $residx = $idx;
@@ -615,18 +516,15 @@ sub display_editor {
         (my $map,$residx,my $res) =
             &Apache::lonnet::decode_symb($symb);
         $title = &Apache::lonnet::gettitle($symb);
-        my $path = &Apache::loncommon::symb_to_docspath($symb,\$navmap);
+        my $path = &Apache::loncommon::symb_to_docspath($symb);
         $pathitem = '<input type="hidden" name="folderpath" value="'.&HTML::Entities::encode($path,'<>&"').'" />';
     }
     my %ltitools;
     if ($type eq 'tool') {
-        %ltitools = &Apache::lonnet::get_domain_lti($cdom,'consumer');
+        %ltitools = &Apache::lonnet::get_domain_ltitools($cdom);
     }
     $js = &Apache::lonhtmlcommon::scripttag(&extedit_javascript());
     my $args = { 'force_register' => $env{'form.register'} };
-    if ($hostname) {
-        $args->{'hostname'} = $hostname;
-    }
     my $description = 'External Resource Editor';
     if ($type eq 'tool') {
         $description = 'External Tool Editor';
@@ -645,56 +543,19 @@ sub extedit_javascript {
     if (ref($toolsref) eq 'HASH') {
         my $num = scalar(keys(%{$toolsref}));
         $toolsjs = "        var ltitools = new Array($num);\n".
-                   "        var ltitoolsUrl = new Array($num);\n".
                    "        var ltitoolsTarget = new Array($num);\n".
                    "        var ltitoolsWidth = new Array($num);\n".
-                   "        var ltitoolsHeight = new Array($num);\n".
-                   "        var ltitoolsLinkDef = new Array($num);\n".
-                   "        var ltitoolsExplainDef = new Array($num);\n".
-                   "        var ltitoolsDisplay = new Array($num);\n".
-                   "        var ltitoolsLink = new Array($num);\n".
-                   "        var ltitoolsExplain = new Array($num);\n".
-                   "        var ltitoolsLabel = new Array($num);\n".
-                   "        var ltitoolsTitle = new Array($num);\n".
-                   "        var ltitoolsAppend = new Array($num);\n";
+                   "        var ltitoolsHeight = new Array($num);\n"; 
         my $i = 0;
         foreach my $key (sort { $a <=> $b } keys(%{$toolsref})) {
-            if (ref($toolsref->{$key}) eq 'HASH') {
-                if (ref($toolsref->{$key}->{'display'}) eq 'HASH') {
-                    my $target = $toolsref->{$key}->{'display'}->{'target'};
-                    my $width = $toolsref->{$key}->{'display'}->{'width'};
-                    my $height = $toolsref->{$key}->{'display'}->{'height'};
-                    my $linkdef = $toolsref->{$key}->{'display'}->{'linktext'};
-                    my $explaindef = $toolsref->{$key}->{'display'}->{'explanation'};
-                    my $providerurl;
-                    if ($toolsref->{$key}->{'url'} =~ m{://}) {
-                        (my $prot,my $host,$providerurl) = ($toolsref->{$key}->{'url'} =~ m{^([^/]+)://([^/]+)(|/.+)$});
-                    } else {
-                        $providerurl = $toolsref->{$key}->{'url'};
-                    }
-                    $providerurl = &LONCAPA::map::qtunescape($providerurl);
-                    $toolsjs .= '        ltitools['.$i.'] = '."'$key';\n".
-                                '        ltitoolsTarget['.$i.'] = '."'$target';\n".
-                                '        ltitoolsWidth['.$i.'] = '."'$width';\n".
-                                '        ltitoolsHeight['.$i.'] = '."'$height';\n".
-                                '        ltitoolsLinkDef['.$i.'] = '."'$linkdef';\n".
-                                '        ltitoolsExplainDef['.$i.'] = '."'$explaindef';\n".
-                                '        ltitoolsUrl['.$i.'] = '."'$providerurl';\n";
-                }
-                if (ref($toolsref->{$key}->{'crsconf'}) eq 'HASH') {
-                    my $display = $toolsref->{$key}->{'crsconf'}->{'target'};
-                    $toolsjs .= '         ltitoolsDisplay['.$i.'] = '."'$display';\n";
-                    my $linktext = $toolsref->{$key}->{'crsconf'}->{'linktext'};
-                    $toolsjs .= '         ltitoolsLink['.$i.'] = '."'$linktext';\n";
-                    my $explanation = $toolsref->{$key}->{'crsconf'}->{'explanation'};
-                    $toolsjs .= '         ltitoolsExplain['.$i.'] = '."'$explanation';\n";
-                    my $label = $toolsref->{$key}->{'crsconf'}->{'label'};
-                    $toolsjs .= '         ltitoolsLabel['.$i.'] = '."'$label';\n";
-                    my $title = $toolsref->{$key}->{'crsconf'}->{'title'};
-                    $toolsjs .= '         ltitoolsTitle['.$i.'] = '."'$title';\n";
-                    my $append = $toolsref->{$key}->{'crsconf'}->{'append'};
-                    $toolsjs .= '         ltitoolsAppend['.$i.'] = '."'$append';\n";
-                }
+            if (ref($toolsref->{$key})) {
+                my $target = $toolsref->{$key}->{'target'};
+                my $width = $toolsref->{$key}->{'width'};
+                my $height = $toolsref->{$key}->{'height'};
+                $toolsjs .= '        ltitools['.$i.'] = '."'$key';\n".
+                            '        ltitoolsTarget['.$i.'] = '."'$target';\n".
+                            '        ltitoolsWidth['.$i.'] = '."'$width';\n".
+                            '        ltitoolsHeight['.$i.'] = '."'$height';\n";
                 $i++;
             }
         }
@@ -702,12 +563,6 @@ sub extedit_javascript {
     my %js_lt = &Apache::lonlocal::texthash(
         invurl  => 'Invalid URL',
         titbl   => 'Title is blank',
-        mixfra  => 'Show preview in pop-up? (http in https page + no framing)',
-        mixonly => 'Show preview in pop-up? (http in https page)',
-        fraonly => 'Show preview in pop-up? (framing disallowed)',
-        nopopup => 'Pop-up blocked',
-        nopriv  => 'Insufficient privileges to use preview',
-        badurl  => 'URL is not: http://hostname/path or https://hostname/path',
         invtool => 'Please select an external tool',
     );
     &js_escape(\%js_lt);
@@ -720,7 +575,7 @@ ENDREGEXP
 
 var regexp = $urlregexp;
 
-function setExternal(extform,residx,type,exttoolurl,supplementalflag) {
+function setExternal(extform,residx,type,exttoolurl) {
     var title=extform.exttitle.value;
     if (!String.trim) {
         String.prototype.trim = function() {return this.replace(\/^\\s+|\\s+$\/g, "");};    }
@@ -755,97 +610,20 @@ function setExternal(extform,residx,type
             }
             info += ':'+toolid;
         }
-        var prefix = '';
-        if (supplementalflag == 1) {
-           prefix = 'supp';
-        }
-        var dispdiv = prefix+'tooldispdiv';
-        var windiv = prefix+'toolwindiv';
-        if (residx > 0) {
-            dispdiv += '_'+residx;
-            windiv += '_'+residx;
-        }
-        if (document.getElementById(dispdiv)) {
-            if (document.getElementById(dispdiv).style.display == 'block') {
-                if (extform.exttooltarget.length) {
-                    for (var i=0; i<extform.exttooltarget.length; i++) {
-                        if (extform.exttooltarget[i].checked) {
-                            if (extform.exttooltarget[i].value == 'window') {
-                                var width = extform.exttoolwidth.value;
-                                width.trim();
-                                var height = extform.exttoolheight.value;
-                                height.trim();
-                                info += ':window:'+width+':'+height;
-                            } else if (extform.exttooltarget[i].value == 'tab') {
-                                info += ':tab::';
-                            } else {
-                                info += ':iframe::';
-                            }
-                        }
+        if (extform.exttooltarget.length) {
+            for (var i=0; i<extform.exttooltarget.length; i++) {
+                if (extform.exttooltarget[i].checked) {
+                    if (extform.exttooltarget[i].value == 'window') {
+                        var width = extform.exttoolwidth.value;
+                        width.trim();
+                        var height = extform.exttoolheight.value;
+                        height.trim();
+                        info += ':window:'+width+':'+height;  
+                    } else {
+                        info += ':iframe';
                     }
                 }
-            } else {
-                info += ':::';
             }
-        } else {
-            info += ':::';
-        }
-        if (document.getElementById(windiv)) {
-            if (document.getElementById(windiv).style.display == 'block') {
-                var linktextdiv = prefix+'toollinktextdiv';
-                var explanationdiv = prefix+'toolexplanationdiv';
-                if (residx > 0) {
-                    linktextdiv += '_'+residx;
-                    explanationdiv += '_'+residx;
-                }
-                if (document.getElementById(linktextdiv).style.display == 'inline') {
-                    var linktext = extform.exttoollinktext.value;
-                    linktext.trim();
-                    info += ':'+escape(linktext);
-                } else {
-                    info += ':';
-                }
-                if (document.getElementById(explanationdiv).style.display == 'inline') {
-                    var explaintext = extform.exttoolexplanation.value;
-                    explaintext.trim();
-                    info += ':'+escape(explaintext);
-                } else {
-                    info += ':';
-                }
-            } else {
-                info += '::';
-            }
-        } else {
-            info += '::';
-        }
-        var labelinput = prefix+'toolcrslabel';
-        var titleinput = prefix+'toolcrstitle';
-        var appendinput = prefix+'toolcrsappend';
-        if (residx > 0) {
-            labelinput += '_'+residx;
-            titleinput += '_'+residx;
-            appendinput += '_'+residx;
-        }
-        if (document.getElementById(labelinput)) {
-            var crslabel = document.getElementById(labelinput).value;
-            crslabel.trim();
-            info += ':'+escape(crslabel);
-        } else {
-            info += ':';
-        } 
-        if (document.getElementById(titleinput)) {
-            var crstitle = document.getElementById(titleinput).value;
-            crstitle.trim();
-            info += ':'+escape(crstitle);
-        } else {
-            info += ':';
-        }
-        if (document.getElementById(appendinput)) {
-            var crsappend = document.getElementById(appendinput).value;
-            crsappend.trim();
-            info += ':'+escape(crsappend);
-        } else {
-            info += ':';
         }
         info=escape(info);
         if (residx > 0) {
@@ -870,81 +648,17 @@ function editext(residx,type) {
     return;
 }
 
-function extUrlPreview(caller,protocol) {
+function extUrlPreview(caller) {
     if (document.getElementById(caller)) {
         var url = document.getElementById(caller).value;
         if (regexp.test(url)) {
-            var http_regex = /^http\:\/\//gi;
-            var mixed = 0;
-            var noiframe = 0;
-            var nopriv = 0;
-            var badurl = 0;
-            var name = "externalpreview";
-            if ((protocol == 'https') && (http_regex.test(url))) {
-                mixed = 1;
-            }
-            var http = new XMLHttpRequest();
-            var lcurl = "/adm/exturlcheck";
-            var params = "exturl="+url;
-            http.open("POST",lcurl, true);
-            http.setRequestHeader("Content-type", "application/x-www-form-urlencoded");
-            http.onreadystatechange = function() {
-                if (http.readyState == 4) {
-                    if (http.status == 200) {
-                        if (http.responseText.length > 0) {
-                            if (http.responseText == 1) {
-                                noiframe = 1;
-                            } else if (http.responseText == -1) {
-                                nopriv = 1;
-                            } else if (http.responseText == 0) {
-                                badurl = 1;
-                            }
-                        }
-                        openPreviewWindow(url,name,noiframe,mixed,nopriv,badurl);
-                    }
-                }
-            }
-            http.send(params);
+            openMyModal(url,500,400,'yes');
         } else {
             alert("$js_lt{'invurl'}");
         }
     }
 }
 
-var previewLCWindow = null;
-function openPreviewWindow(url,name,noiframe,mixed,nopriv,badurl) {
-    if (previewLCWindow !=null) {
-        previewLCWindow.close();
-    }
-    if (badurl) {
-        alert("$js_lt{'badurl'}");
-    } else if (nopriv) {
-        alert("$js_lt{'nopriv'}");
-    } else if ((noiframe == 1) || (mixed == 1)) {
-        var encurl = encodeURI(url);
-        var msg;
-        if (mixed == 1) {
-            if (noiframe == 1) {
-                msg = "$js_lt{'mixfra'}";
-            } else {
-                msg = "$js_lt{'mixonly'}";
-            }
-        } else {
-            msg = "$js_lt{'fraonly'}";
-        }
-        if (confirm(msg)) {
-            previewLCWindow = window.open(url,name,"height=400,width=500,scrollbars=1,resizable=1,menubar=0,location=1");
-            if (previewLCWindow != null) {
-                previewLCWindow.focus();
-            } else {
-                alert("$js_lt{'nopopup'}");
-            }
-        }
-    } else {
-        openMyModal(url,500,400,'yes');
-    }
-}
-
 function updateExttool(caller,form,supplementalflag) {
     var prefix = '';
     if (supplementalflag == 1) {
@@ -952,20 +666,8 @@ function updateExttool(caller,form,suppl
     }
     dispdiv = prefix+'tooldispdiv';
     dimendiv = prefix+'tooldimendiv';
-    widthinput = prefix+'tooldimenwidth';
-    heightinput = prefix+'tooldimenheight';
-    labeldiv = prefix+'toolcrslabeldiv';
-    titlediv = prefix+'toolcrstitlediv';
-    appenddiv = prefix+'toolcrsappenddiv';
-    providerurl = prefix+'toolproviderurl';
-    labelinput = prefix+'toolcrslabel';
-    titleinput = prefix+'toolcrstitle';
-    appendinput = prefix+'toolcrsappend';
-    windiv = prefix+'toolwindiv';  
-    linktextdiv = prefix+'toollinktextdiv';
-    linktextinput = prefix+'toollinktext';
-    explanationdiv = prefix+'toolexplanationdiv';
-    explanationinput = prefix+'toolexplanation';
+    widthinput = prefix+'toolwidth';
+    heightinput = prefix+'toolheight';
     if (document.getElementById(dispdiv)) {
         var toolpick = caller.options[caller.selectedIndex].value;
         $toolsjs
@@ -976,163 +678,65 @@ function updateExttool(caller,form,suppl
             if (document.getElementById(dimendiv)) {
                 document.getElementById(dimendiv).style.display = 'none';
             }
-            if (document.getElementById(windiv)) {
-                document.getElementById(windiv).style.display = 'none';
-            }
-            if (document.getElementById(linktextdiv)) {
-                document.getElementById(linktextdiv).style.display = 'none';
-            }
-            if (document.getElementById(explanationdiv)) {
-                document.getElementById(explanationdiv).style.display = 'none';
-            }
-            if (document.getElementById(labeldiv)) {
-                document.getElementById(labeldiv).style.display = 'none';
-            }
-            if (document.getElementById(titlediv)) {
-                document.getElementById(titlediv).style.display = 'none';
-            }
-            if (document.getElementById(appenddiv)) {
-                document.getElementById(appenddiv).style.display = 'none';
-            }
         } else {
+            if (document.getElementById(dispdiv)) {
+                document.getElementById(dispdiv).style.display = 'block';
+            }
             if (ltitools.length > 0) {
                 for (var j=0; j<ltitools.length; j++) {
                     if (ltitools[j] == toolpick) {
-                        if (document.getElementById(dispdiv)) {
-                            if (ltitoolsDisplay[j]) {
-                                document.getElementById(dispdiv).style.display = 'block';
-                                if (form.exttooltarget.length) {
-                                    for (var k=0; k<form.exttooltarget.length; k++) {
-                                        if (form.exttooltarget[k].value == ltitoolsTarget[j]) {
-                                            form.exttooltarget[k].checked = true;
-                                            break;
-                                        }
-                                    }
+                        if (form.exttooltarget.length) {
+                            for (var k=0; k<form.exttooltarget.length; k++) {
+                                if (form.exttooltarget[k].value == ltitoolsTarget[j]) {
+                                    form.exttooltarget[k].checked = true;
+                                    break;
                                 }
                             }
-                            var dimen = 'none';
-                            var dimenwidth = '';
-                            var dimenheight = '';
-                            if ((ltitoolsDisplay[j]) && (ltitoolsTarget[j] == 'window')) {
-                                dimen = 'block';
-                                dimenwidth = ltitoolsWidth[j];
-                                dimenheight = ltitoolsHeight[j];                    
-                            }
-                            if (document.getElementById(dimendiv)) {
-                                document.getElementById(dimendiv).style.display = dimen;
-                            }
-                            if (document.getElementById(widthinput)) {
-                                document.getElementById(widthinput).value = dimenwidth;
-                            }
-                            if (document.getElementById(heightinput)) {
-                                document.getElementById(heightinput).value = dimenheight;
-                            }
                         }
-                        if (document.getElementById(windiv)) {
-                            if ((ltitoolsTarget[j] == 'window') || (ltitoolsTarget[j] == 'tab')) {
-                                document.getElementById(windiv).style.display = 'block';
-                            } else {
-                                document.getElementById(windiv).style.display = 'none';
-                            }
-                            if (document.getElementById(linktextdiv)) {
-                                if (ltitoolsLink[j]) {
-                                    document.getElementById(linktextdiv).style.display = 'inline';
-                                } else {
-                                    document.getElementById(linktextdiv).style.display = 'none';
-                                }
-                            }
-                            if (document.getElementById(linktextinput)) {
-                                if (ltitoolsLink[j]) {
-                                    document.getElementById(linktextinput).value = ltitoolsLinkDef[j]; 
-                                } else {
-                                    document.getElementById(linktextinput).value = '';
-                                }
-                            }
-                            if (document.getElementById(explanationdiv)) {
-                                if (ltitoolsExplain[j]) {
-                                    document.getElementById(explanationdiv).style.display = 'inline';
-                                } else {
-                                    document.getElementById(explanationdiv).style.display = 'none';
-                                }
-                            }
-                            if (document.getElementById(explanationinput)) {
-                                if (ltitoolsExplain[j]) {
-                                    document.getElementById(explanationinput).value = ltitoolsExplainDef[j];
-                                } else {
-                                    document.getElementById(explananationinput).value = '';
-                                }
-                            }
+                        if (ltitoolsTarget[j] == 'window') {
+                            dimen = 'block';
+                            dimenwidth = ltitoolsWidth[j];
+                            dimenheight = ltitoolsHeight[j];                    
+                        } else {
+                            dimen = 'none';
+                            dimenwidth = '';
+                            dimenheight = '';
                         }
-                        if (document.getElementById(labeldiv)) {
-                            if (ltitoolsLabel[j]) {
-                                document.getElementById(labeldiv).style.display = 'inline';
-                            } else {
-                                document.getElementById(labeldiv).style.display = 'none';
-                            } 
+                        if (document.getElementById(dimendiv)) {
+                            document.getElementById(dimendiv).style.display = dimen;
                         }
-                        if (document.getElementById(titlediv)) {
-                            if (ltitoolsTitle[j]) {
-                                document.getElementById(titlediv).style.display = 'inline';
-                            } else {
-                                document.getElementById(titlediv).style.display = 'none';
-                            }
+                        if (document.getElementById(widthinput)) {
+                            document.getElementById(widthinput).value = dimenwidth;
                         }
-                        if (document.getElementById(appenddiv)) {
-                            if (ltitoolsAppend[j]) {
-                                document.getElementById(appenddiv).style.display = 'inline';
-                                if (document.getElementById(providerurl)) {
-                                    if ((ltitoolsUrl[j] != '') && (ltitoolsUrl[j] != null)) {
-                                        document.getElementById(providerurl).innerHTML = '&nbsp;('+ltitoolsUrl[j]+')<br />';
-                                    }
-                                }
-                            } else {
-                                document.getElementById(appenddiv).style.display = 'none';
-                                if (document.getElementById(providerurl)) {
-                                    document.getElementById(providerurl).innerHTML = '';
-                                }
-                            }
+                        if (document.getElementById(heightinput)) {
+                            document.getElementById(heightinput).value = dimenheight;
                         }
-                        break;
                     }
+                    break;
                 }
             }
         }
     }
 }
 
-function updateTooldim(form,dimendiv,windiv,widthinput,heightinput,linkinput,explaininput) {
+function updateTooldim(form,dimendiv,widthinput,heightinput) {
     if (form.exttooltarget.length) {
         for (var i=0; i<form.exttooltarget.length; i++) {
             if (form.exttooltarget[i].checked) {
                 var dimen = 'none';
-                var linkconf = 'none';
                 if (form.exttooltarget[i].value == 'window') {
                     dimen = 'block';
-                    linkconf = 'block';
                 } else {
-                    if (form.exttooltarget[i].value == 'tab') {
-                        linkconf = 'block';
-                    } else {
-                        if (document.getElementById(widthinput)) {
-                            document.getElementById(widthinput).value = '';
-                        }
-                        if (document.getElementById(heightinput)) {
-                            document.getElementById(heightinput).value = '';
-                        }
-                        if (document.getElementById(linkinput)) {
-                            document.getElementById(linkinput).value = '';
-                        }
-                        if (document.getElementById(explaininput)) {
-                            document.getElementById(explaininput).value = '';
-                        }
+                    if (document.getElementById(widthinput)) {
+                        document.getElementById(widthinput).value = '';
+                    }
+                    if (document.getElementById(heightinput)) {
+                        document.getElementById(heightinput).value = '';
                     }
                 }
                 if (document.getElementById(dimendiv)) {
                     document.getElementById(dimendiv).style.display = dimen;
                 }
-                if (document.getElementById(windiv)) {
-                    document.getElementById(windiv).style.display = linkconf;
-                }
                 break;
             }
         }