--- loncom/interface/lonfeedback.pm	2004/11/17 16:42:39	1.139
+++ loncom/interface/lonfeedback.pm	2004/11/19 19:11:33	1.141
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Feedback
 #
-# $Id: lonfeedback.pm,v 1.139 2004/11/17 16:42:39 albertel Exp $
+# $Id: lonfeedback.pm,v 1.141 2004/11/19 19:11:33 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -74,7 +74,7 @@ sub list_discussion {
 	if($ENV{'form.export'}) {
             $outputtarget = 'export';
         }
-    }    
+    }
     if (not &discussion_visible($status)) { return ''; }
     my @bgcols = ("#cccccc","#eeeeee");
     my $discussiononly=0;
@@ -638,38 +638,38 @@ to course faculty</font><br />
 <b>Title:</b>&nbsp;<input type="text" name="subject" value="$subject" size="30" /><br /><br />
 <textarea name="comment" cols="80" rows="14" wrap="hard">$comment</textarea>
 ENDDISCUSS
-        if ($ENV{'form.origpage'}) {
-            $discussion.='<input type="hidden" name="origpage" value="'.$ENV{'form.origpage'}.'" />'."\n";
-            foreach (@currnewattach) {
-                $discussion.='<input type="hidden" name="currnewattach" value="'.$_.'" />'."\n";
-            }
-        }
-        $discussion.="</form>\n";
-        if ($outputtarget ne 'tex') {
-            $discussion.=&generate_attachments_button('',$attachnum,$ressymb,$now,\@currnewattach,\@currdelold,'',$mode);
-            if (@currnewattach > 0) {
-                $newattachmsg .= '<b>New attachments</b><br />';
-                if (@currnewattach > 1) {
-                    $newattachmsg .= '<ol>';
-                    foreach my $item (@currnewattach) {
-                        $item =~ m#.*/([^/]+)$#;
-                        $newattachmsg .= '<li><a href="'.$item.'">'.$1.'</a></li>'."\n";
+            if ($ENV{'form.origpage'}) {
+                $discussion.='<input type="hidden" name="origpage" value="'.$ENV{'form.origpage'}.'" />'."\n";
+                foreach (@currnewattach) {
+                    $discussion.='<input type="hidden" name="currnewattach" value="'.$_.'" />'."\n";
+                }
+            }
+            $discussion.="</form>\n";
+            if ($outputtarget ne 'tex') {
+                $discussion.=&generate_attachments_button('',$attachnum,$ressymb,$now,\@currnewattach,\@currdelold,'',$mode);
+                if (@currnewattach > 0) {
+                    $newattachmsg .= '<b>New attachments</b><br />';
+                    if (@currnewattach > 1) {
+                        $newattachmsg .= '<ol>';
+                        foreach my $item (@currnewattach) {
+                            $item =~ m#.*/([^/]+)$#;
+                            $newattachmsg .= '<li><a href="'.$item.'">'.$1.'</a></li>'."\n";
+                        }
+                        $newattachmsg .= '</ol>'."\n";
+                    } else {
+                        $currnewattach[0] =~ m#.*/([^/]+)$#;
+                        $newattachmsg .= '<a href="'.$currnewattach[0].'">'.$1.'</a><br />'."\n";
                     }
-                    $newattachmsg .= '</ol>'."\n";
-                } else {
-                    $currnewattach[0] =~ m#.*/([^/]+)$#;
-                    $newattachmsg .= '<a href="'.$currnewattach[0].'">'.$1.'</a><br />'."\n";
                 }
-            }
-            $discussion.=$newattachmsg;
-	    $discussion.=&generate_preview_button();
-	}
+                $discussion.=$newattachmsg;
+	        $discussion.=&generate_preview_button();
+	    }
 	}
-        } else {
-	if (&discussion_open($status) &&
-	    &Apache::lonnet::allowed('pch',
-				   $ENV{'request.course.id'}.
-	($ENV{'request.course.sec'}?'/'.$ENV{'request.course.sec'}:''))) {
+    } else {
+        if (&discussion_open($status) &&
+            &Apache::lonnet::allowed('pch',
+    	        $ENV{'request.course.id'}.
+	        ($ENV{'request.course.sec'}?'/'.$ENV{'request.course.sec'}:''))) {
 	    if ($outputtarget ne 'tex') {
 		$discussion.='<table bgcolor="#BBBBBB"><tr><td><a href="/adm/feedback?replydisc='.
 		    $ressymb.':::" '.$target.'>'.
@@ -965,7 +965,6 @@ sub build_posting_display {
                                     } else {
                                         $rolematch .= ':'.$sectionpick;
                                         $skiptest = 0;
-                                    }
                                 }
                                 if ($statusfilter) {
                                     if ($statusfilter eq 'all') {
@@ -2089,7 +2088,7 @@ ENDNOREDIRTWO
 }
 
 sub screen_header {
-    my ($feedurl) = @_;
+    my ($feedurl,$symb) = @_;
     my $msgoptions='';
     my $discussoptions='';
     unless (($ENV{'form.replydisc'}) || ($ENV{'form.editdisc'})) {
@@ -2115,7 +2114,7 @@ sub screen_header {
 	}
     }
     if ($ENV{'request.course.id'}) {
-	if (&discussion_open() &&
+	if (&discussion_open(undef,$symb) &&
 	    &Apache::lonnet::allowed('pch',
 				     $ENV{'request.course.id'}.
 				     ($ENV{'request.course.sec'}?'/'.$ENV{'request.course.sec'}:''))) {
@@ -2125,7 +2124,7 @@ sub screen_header {
 	    $discussoptions.='<br /><input type="checkbox" name="anondiscuss" onClick="this.form.discuss.checked=false;" /> '.
 		&mt('Anonymous contribution to course discussion of resource').
 		' <i>('.&mt('name only visible to course faculty').')</i>';
-      }
+        }
     }
     if ($msgoptions) { $msgoptions='<h2><img src="/adm/lonMisc/feedback.gif" />'.&mt('Sending Messages').'</h2>'.$msgoptions; }
     if ($discussoptions) { 
@@ -3102,7 +3101,7 @@ ENDREDIR
       unless ($ENV{'form.sendit'}) {
 	  &Apache::loncommon::content_type($r,'text/html');
 	  $r->send_http_header;
-	  my $options=&screen_header($feedurl);
+	  my $options=&screen_header($feedurl,$symb);
 	  if ($options) {
 	      &mail_screen($r,$feedurl,$options);
 	  } else {