--- loncom/interface/longroup.pm 2012/04/25 21:22:02 1.28 +++ loncom/interface/longroup.pm 2012/12/18 15:26:03 1.29 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # accessor routines used to provide information about course groups # -# $Id: longroup.pm,v 1.28 2012/04/25 21:22:02 raeburn Exp $ +# $Id: longroup.pm,v 1.29 2012/12/18 15:26:03 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -218,7 +218,7 @@ for the course is included amongst the u and would trigger membership in teh same group(s) If role is being added, will add any group memberships specified -for auto-group population, unless use is already a group member. +for auto-group population, unless user is already a group member. Uses default group privileges and default start and end group access times. @@ -252,9 +252,6 @@ sub group_changes { } else { $cid = $url; } - my $courseid = $cid; - $courseid =~ s|^/||; - $courseid =~ s|/|_|; my %crshash=&Apache::lonnet::coursedescription($cid); $cdom = $crshash{'domain'}; $cnum = $crshash{'num'}; @@ -292,10 +289,7 @@ sub group_changes { if (@changegroups > 0) { my %currpriv; my %roleshash = &Apache::lonnet::dump('roles',$udom,$uname,$cid); - if (my $tmp = &Apache::lonnet::error(%roleshash)) { - &Apache::lonnet::logthis('Error retrieving roles: '.$tmp. - ' for '.$uname.':'.$udom); - } else { + if (keys(%roleshash) > 0) { my $group_privs = ''; foreach my $group (@changegroups) { if ($chgtype eq 'add') {