--- loncom/interface/lonhtmlcommon.pm	2004/11/19 19:31:13	1.96
+++ loncom/interface/lonhtmlcommon.pm	2005/04/07 06:56:23	1.104
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # a pile of common html routines
 #
-# $Id: lonhtmlcommon.pm,v 1.96 2004/11/19 19:31:13 albertel Exp $
+# $Id: lonhtmlcommon.pm,v 1.104 2005/04/07 06:56:23 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -55,10 +55,11 @@ html.
 
 package Apache::lonhtmlcommon;
 
+use strict;
 use Time::Local;
 use Time::HiRes;
 use Apache::lonlocal;
-use strict;
+use Apache::lonnet;
 
 ##############################################
 ##############################################
@@ -80,7 +81,7 @@ sub authorbombs {
     foreach (keys %bombs) {
 	if ($_=~/^$udom\/$uname\//) {
 	    return '<a href="/adm/bombs/'.$url.
-		'"><img src="/adm/lonMisc/bomb.gif" border="0" /></a>'.
+		'"><img src="'.&Apache::loncommon::lonhttpdurl('/adm/lonMisc/bomb.gif').'" border="0" /></a>'.
 		&Apache::loncommon::help_open_topic('About_Bombs');
 	}
     }
@@ -141,6 +142,30 @@ sub select_recent {
     return $return;
 }
 
+sub get_recent {
+    my ($area, $n) = @_;
+    my %recent=&Apache::lonnet::dump(&recent_filename($area));
+
+# Create hash with key as time and recent as value
+    my %time_hash = ();
+    foreach (keys %recent) {
+        my $thistime=(split(/\&/,$recent{$_}))[0];
+        $time_hash{$thistime} = $_;
+    }
+
+# Sort by decreasing time and return key value pairs
+    my %return_hash = ();
+    my $idx = 1;
+    foreach (reverse sort keys %time_hash) {
+       $return_hash{$time_hash{$_}} =
+                  &Apache::lonnet::unescape((split(/\&/,$recent{$_}))[1]);
+       if ($n && ($idx++ >= $n)) {last;}
+    }
+
+    return %return_hash;
+}
+
+
 
 =pod
 
@@ -411,8 +436,8 @@ sub get_date_from_form {
     my ($dname) = @_;
     my ($sec,$min,$hour,$day,$month,$year);
     #
-    if (defined($ENV{'form.'.$dname.'_second'})) {
-        my $tmpsec = $ENV{'form.'.$dname.'_second'};
+    if (defined($env{'form.'.$dname.'_second'})) {
+        my $tmpsec = $env{'form.'.$dname.'_second'};
         if (($tmpsec =~ /^\d+$/) && ($tmpsec >= 0) && ($tmpsec < 60)) {
             $sec = $tmpsec;
         }
@@ -420,8 +445,8 @@ sub get_date_from_form {
     } else {
         $sec = 0;
     }
-    if (defined($ENV{'form.'.$dname.'_minute'})) {
-        my $tmpmin = $ENV{'form.'.$dname.'_minute'};
+    if (defined($env{'form.'.$dname.'_minute'})) {
+        my $tmpmin = $env{'form.'.$dname.'_minute'};
         if (($tmpmin =~ /^\d+$/) && ($tmpmin >= 0) && ($tmpmin < 60)) {
             $min = $tmpmin;
         }
@@ -429,28 +454,28 @@ sub get_date_from_form {
     } else {
         $min = 0;
     }
-    if (defined($ENV{'form.'.$dname.'_hour'})) {
-        my $tmphour = $ENV{'form.'.$dname.'_hour'};
+    if (defined($env{'form.'.$dname.'_hour'})) {
+        my $tmphour = $env{'form.'.$dname.'_hour'};
         if (($tmphour =~ /^\d+$/) && ($tmphour >= 0) && ($tmphour < 24)) {
             $hour = $tmphour;
         }
     } else {
         $hour = 0;
     }
-    if (defined($ENV{'form.'.$dname.'_day'})) {
-        my $tmpday = $ENV{'form.'.$dname.'_day'};
+    if (defined($env{'form.'.$dname.'_day'})) {
+        my $tmpday = $env{'form.'.$dname.'_day'};
         if (($tmpday =~ /^\d+$/) && ($tmpday > 0) && ($tmpday < 32)) {
             $day = $tmpday;
         }
     }
-    if (defined($ENV{'form.'.$dname.'_month'})) {
-        my $tmpmonth = $ENV{'form.'.$dname.'_month'};
+    if (defined($env{'form.'.$dname.'_month'})) {
+        my $tmpmonth = $env{'form.'.$dname.'_month'};
         if (($tmpmonth =~ /^\d+$/) && ($tmpmonth > 0) && ($tmpmonth < 13)) {
             $month = $tmpmonth - 1;
         }
     }
-    if (defined($ENV{'form.'.$dname.'_year'})) {
-        my $tmpyear = $ENV{'form.'.$dname.'_year'};
+    if (defined($env{'form.'.$dname.'_year'})) {
+        my $tmpyear = $env{'form.'.$dname.'_year'};
         if (($tmpyear =~ /^\d+$/) && ($tmpyear > 1900)) {
             $year = $tmpyear - 1900;
         }
@@ -512,8 +537,8 @@ sub javascript_nothing {
     my $nothing = "''";
     my $user_browser;
     my $user_os;
-    $user_browser = $ENV{'browser.type'} if (exists($ENV{'browser.type'}));
-    $user_os      = $ENV{'browser.os'}   if (exists($ENV{'browser.os'}));
+    $user_browser = $env{'browser.type'} if (exists($env{'browser.type'}));
+    $user_os      = $env{'browser.os'}   if (exists($env{'browser.os'}));
     if (! defined($user_browser) || ! defined($user_os)) {
         (undef,$user_browser,undef,undef,undef,$user_os) = 
                            &Apache::loncommon::decode_user_agent();
@@ -531,8 +556,8 @@ sub javascript_docopen {
     my $nothing = "''";
     my $user_browser;
     my $user_os;
-    $user_browser = $ENV{'browser.type'} if (exists($ENV{'browser.type'}));
-    $user_os      = $ENV{'browser.os'}   if (exists($ENV{'browser.os'}));
+    $user_browser = $env{'browser.type'} if (exists($env{'browser.type'}));
+    $user_os      = $env{'browser.os'}   if (exists($env{'browser.os'}));
     if (! defined($user_browser) || ! defined($user_os)) {
         (undef,$user_browser,undef,undef,undef,$user_os) = 
                            &Apache::loncommon::decode_user_agent();
@@ -559,7 +584,7 @@ enrollment status of students.  The sele
 Inputs:
 
 $status: the currently selected status.  If undefined the value of
-$ENV{'form.Status'} is taken.  If that is undefined, a value of 'Active'
+$env{'form.Status'} is taken.  If that is undefined, a value of 'Active'
 is used.
 
 $formname: The name of the form.  If defined the onchange attribute of
@@ -581,7 +606,7 @@ sub StatusOptions {
     $size = 1 if (!defined($size));
     if (! defined($status)) {
         $status = 'Active';
-        $status = $ENV{'form.Status'} if (exists($ENV{'form.Status'}));
+        $status = $env{'form.Status'} if (exists($env{'form.Status'}));
     }
 
     my $OpSel1 = '';
@@ -735,13 +760,14 @@ sub Create_PrgWin {
     $prog_state{'type'}=$type;
     if ($type eq 'popup') {
 	$prog_state{'window'}='popwin';
+	my $html=&Apache::lonxml::xmlbegin();
 	#the whole function called through timeout is due to issues
 	#in mozilla Read BUG #2665 if you want to know the whole story
 	&r_print($r,'<script>'.
         "var popwin;
          function openpopwin () {
          popwin=open(\'\',\'popwin\',\'width=400,height=100\');".
-        "popwin.document.writeln(\'<html><head><title>$title</title></head>".
+        "popwin.document.writeln(\'".$html."<head><title>$title</title></head>".
 	      "<body bgcolor=\"#88DDFF\">".
               "<h4>$heading</h4>".
               "<form name=popremain>".
@@ -830,8 +856,8 @@ sub Increment_PrgWin {
         $lasttime = '('.$lasttime.' '.&mt('seconds for').' '.$extraInfo.')';
     }
     #
-    my $user_browser = $ENV{'browser.type'} if (exists($ENV{'browser.type'}));
-    my $user_os      = $ENV{'browser.os'}   if (exists($ENV{'browser.os'}));
+    my $user_browser = $env{'browser.type'} if (exists($env{'browser.type'}));
+    my $user_os      = $env{'browser.os'}   if (exists($env{'browser.os'}));
     if (! defined($user_browser) || ! defined($user_os)) {
         (undef,$user_browser,undef,undef,undef,$user_os) = 
                            &Apache::loncommon::decode_user_agent();
@@ -875,23 +901,25 @@ sub crumbs {
     if (! defined($size)) {
         $size = '+2';
     }
+    if ($target) {
+        $target = ' target="'.
+                  &Apache::loncommon::escape_single($target).'"';
+    }
     my $output='';
     unless ($noformat) { $output.='<br /><tt><b>'; }
     $output.='<font size="'.$size.'">'.$prefix.'/';
-    if ($ENV{'user.adv'}) {
+    if ($env{'user.adv'}) {
 	my $path=$prefix.'/';
-	foreach (split('/',$uri)) {
-	    unless ($_) { next; }
-	    $path.=$_;
+	foreach my $dir (split('/',$uri)) {
+            if (! $dir) { next; }
+            $path .= $dir;
 	    unless ($path eq $uri) { $path.='/'; }
-	    my $linkpath=$path;
-	    if ($form) {
-		my $escaped_path = &Apache::loncommon::escape_single($path);
-		$linkpath="javascript:$form.action='$escaped_path';$form.submit();";
-	    }
-	    my $escaped_linkpath = &Apache::loncommon::escape_single($linkpath);
-	    my $escaped_target   = &Apache::loncommon::escape_single($target);
-	    $output.='<a href="'.$escaped_linkpath.'"'.($target?' target="'.$escaped_target.'"':'').'>'.$_.'</a>/';
+            my $linkpath = &Apache::loncommon::escape_single($path);
+            if ($form) {
+		$linkpath=
+                    qq{javascript:$form.action='$linkpath';$form.submit();};
+            }
+	    $output.=qq{<a href="$linkpath" $target>$dir</a>/};
 	}
     } else {
 	$output.=$uri;
@@ -903,15 +931,15 @@ sub crumbs {
 # --------------------- A function that generates a window for the spellchecker
 
 sub spellheader {
-    my $nothing = &javascript_nothing();
+    my $html=&Apache::lonxml::xmlbegin();
     return (<<ENDCHECK);
 <script type="text/javascript"> 
 //<!-- BEGIN LON-CAPA Internal
 var checkwin;
 
 function spellcheckerwindow() {
-    checkwin=window.open($nothing,'spellcheckwin','height=320,width=280,resizable=yes,scrollbars=yes,location=no,menubar=no,toolbar=no');
-    checkwin.document.writeln('<html><body bgcolor="#DDDDDD"><form name="spellcheckform" action="/adm/spellcheck" method="post"><input type="hidden" name="text" value="" /></form></body></html>');
+    checkwin=window.open('/adm/rat/empty.html','spellcheckwin','height=320,width=280,resizable=yes,scrollbars=yes,location=no,menubar=no,toolbar=no');
+    checkwin.document.writeln('$html<head></head><body bgcolor="#DDDDDD"><form name="spellcheckform" action="/adm/spellcheck" method="post"><input type="hidden" name="text" value="" /></form></body></html>');
     checkwin.document.close();
 }
 // END LON-CAPA Internal -->
@@ -1008,7 +1036,7 @@ sub htmlareaselectactive {
 # --------------------------------------------------------------------- Blocked
 
 sub htmlareablocked {
-    unless ($ENV{'environment.wysiwygeditor'} eq 'on') { return 1; }
+    unless ($env{'environment.wysiwygeditor'} eq 'on') { return 1; }
     return 0;
 }
 
@@ -1090,10 +1118,10 @@ returns: nothing
 	if (!defined($menulink)) { $menulink=1; }
         if ($menulink) {
             my $description = 'Menu';
-            if (exists($ENV{'request.course.id'}) && 
-                $ENV{'request.course.id'} ne '') {
+            if (exists($env{'request.course.id'}) && 
+                $env{'request.course.id'} ne '') {
                 $description = 
-                    $ENV{'course.'.$ENV{'request.course.id'}.'.description'};
+                    $env{'course.'.$env{'request.course.id'}.'.description'};
             }
             unshift(@Crumbs,{
                     href   =>'/adm/menu',