--- loncom/interface/lonmenu.pm	2009/10/26 21:19:22	1.295
+++ loncom/interface/lonmenu.pm	2009/11/04 16:22:24	1.300
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Routines to control the menu
 #
-# $Id: lonmenu.pm,v 1.295 2009/10/26 21:19:22 raeburn Exp $
+# $Id: lonmenu.pm,v 1.300 2009/11/04 16:22:24 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -164,6 +164,7 @@ sub primary_menu {
     # (link url, icon path, alt text, link text, condition)
     foreach my $menuitem (@primary_menu) {
         # evaluate conditions 
+        next if    ref($menuitem)       ne 'ARRAY';    #
         next if    $$menuitem[4]        eq 'nonewmsg'  # show links depending on
                 && &Apache::lonmsg::mynewmail();       # whether a new msg 
         next if    $$menuitem[4]        eq 'newmsg'    # arrived or not
@@ -183,11 +184,9 @@ sub primary_menu {
         if ($$menuitem[3] eq 'Help') { # special treatment for helplink
             $menu .= '<li>'.&Apache::loncommon::top_nav_help('Help').'</li>';
         } else {
-            if (ref($menuitem) eq 'ARRAY') { 
-                my @items = @{$menuitem};
-                $items[0] = 'javascript:'.$menuitem->[0].';';
-                $menu .= &prep_menuitem(\@items);
-            }
+            my @items = @{$menuitem};
+            $items[0] = 'javascript:'.$menuitem->[0].';';
+            $menu .= &prep_menuitem(\@items);
         }
     }
 
@@ -210,6 +209,7 @@ sub secondary_menu {
                      $env{'course.' . $env{'request.course.id'} . '.num'});
     foreach my $menuitem (@secondary_menu) {
         # evaluate conditions 
+        next if    ref($menuitem)  ne 'ARRAY';
         next if    $$menuitem[4]   ne 'always'
                 && !$env{'request.course.id'};
         next if    $$menuitem[4]   eq 'showreturn'
@@ -230,29 +230,28 @@ sub secondary_menu {
         next if $$menuitem[4] =~ /^(no|)remotenavCommunity$/ 
                 && $crstype ne 'Community';
         next if    $$menuitem[4]   =~ /showgroups$/
-                && $canviewgrps
+                && !$canviewgrps
                 && !%groups;
 
         if ($$menuitem[3] eq 'Roles' && $env{'request.course.id'}) {
             # special treatment for role selector
-            my $roles_selector = roles_selector(
+            my $roles_selector = &roles_selector(
                         $env{'course.' . $env{'request.course.id'} . '.domain'},
                         $env{'course.' . $env{'request.course.id'} . '.num'}  );
 
             $menu .= $roles_selector ? "<li>$roles_selector</li>"
                                      : '';
-        } else {
-            if ($env{'environment.remotenavmap'} eq 'on') {
-                my @items = @{$menuitem}; 
-                if ($menuitem->[4] eq 'remotenav') {
-                    $items[0] = "javascript:gonav('$menuitem->[0]');";
-                } else {
-                    $items[0] = "javascript:go('$menuitem->[0]');";
-                }
-                $menu .= &prep_menuitem(\@items);
+        } elsif ($env{'environment.remotenavmap'} eq 'on') {
+            # open link using javascript when remote navmap is activated
+            my @items = @{$menuitem}; 
+            if ($menuitem->[4] eq 'remotenav') {
+                $items[0] = "javascript:gonav('$menuitem->[0]');";
             } else {
-                $menu .= &prep_menuitem(\@$menuitem);
+                $items[0] = "javascript:go('$menuitem->[0]');";
             }
+            $menu .= &prep_menuitem(\@items);
+        } else {
+            $menu .= &prep_menuitem(\@$menuitem);
         }
     }
     if ($menu =~ /\[url\].*\[symb\]/) {
@@ -546,7 +545,13 @@ sub innerregister {
 
         my $maptitle = &Apache::lonnet::gettitle($mapurl);
         my $restitle = &Apache::lonnet::gettitle(&Apache::lonnet::symbread());
-        my @crumbs = ({text  => "Course Contents", 
+        my $contentstext;
+        if ($env{'course.'.$env{'request.course.id'}.'.type'} eq 'Community') {
+            $contentstext = &mt('Community Contents');
+        } else {
+            $contentstext = &mt('Course Contents');
+        }
+        my @crumbs = ({text  => $contentstext, 
                        href  => "Javascript:gonav('/adm/navmaps')"});
 
         if ($mapurl ne $env{'course.'.$env{'request.course.id'}.'.url'}) { 
@@ -578,7 +583,7 @@ sub innerregister {
     my $tableend   = ( $noremote ? '</table>' : '');
 # =============================================================================
 # ============================ This is for URLs that actually can be registered
-    if (($env{'request.noversionuri'}!~m|^/(res/)*adm/|) || ($forcereg)) {
+    if (($env{'request.noversionuri'}!~m{^/(res/)*adm/}) || ($forcereg)) {
 # -- This applies to homework problems for users with grading privileges
 	my $crs='/'.$env{'request.course.id'};
 	if ($env{'request.course.sec'}) {
@@ -1605,6 +1610,12 @@ function go(url) {
    }
 }
 
+function gotop(url) {
+    if (url!='' && url!= null) {
+        top.location.href = url;
+    }
+}
+
 function gopost(url,postdata) {
    if (url!='') {
       this.document.server.action=url;
@@ -1789,16 +1800,19 @@ sub hidden_button_check {
 
 sub roles_selector {
     my ($cdom,$cnum) = @_;
-    my $crstype = $env{'course.'.$env{'request.course.id'}.'.type'};
-    if ($crstype eq '') {
-        $crstype = 'Course';
-    }
+    my $crstype = &Apache::loncommon::course_type();
     my $now = time;
     my (%courseroles,%seccount);
     my $is_cc;
     my $role_selector;
-    if ($env{'user.role.cc./'.$cdom.'/'.$cnum}) {
-        my ($start,$end) = split(/\./,$env{'user.role.cc./'.$cdom.'/'.$cnum});
+    my $ccrole;
+    if ($crstype eq 'Community') {
+        $ccrole = 'co';
+    } else {
+        $ccrole = 'cc';
+    } 
+    if ($env{'user.role.'.$ccrole.'./'.$cdom.'/'.$cnum}) {
+        my ($start,$end) = split(/\./,$env{'user.role.'.$ccrole.'./'.$cdom.'/'.$cnum});
         
         if ((($start) && ($start<0)) || 
             (($end) && ($end<$now))  ||
@@ -1848,7 +1862,7 @@ sub roles_selector {
     } else {
         $switchtext = &mt('Switch course role to...')
     }
-    my @roles_order = ('cc','in','ta','ep','ad','st');
+    my @roles_order = ($ccrole,'in','ta','ep','ad','st');
     if (keys(%courseroles) > 1) {
         $role_selector = &jump_to_role($cdom,$cnum,\%seccount,\%courseroles);
         $role_selector .= '<form name="rolechooser" method="post" action="/adm/roles">
@@ -1856,7 +1870,7 @@ sub roles_selector {
         $role_selector .= '<option value="">'.$switchtext.'</option>';
         foreach my $role (@roles_order) {
             if (defined($courseroles{$role})) {
-                $role_selector .= "\n".'<option value="'.$role.'">'.&Apache::lonnet::plaintext($role).'</option>'; 
+                $role_selector .= "\n".'<option value="'.$role.'">'.&Apache::lonnet::plaintext($role,$crstype).'</option>'; 
             }
         }
         foreach my $role (sort(keys(%courseroles))) {