--- loncom/interface/lonmeta.pm	2008/12/17 18:47:08	1.212.2.4
+++ loncom/interface/lonmeta.pm	2008/12/13 21:10:14	1.221
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Metadata display handler
 #
-# $Id: lonmeta.pm,v 1.212.2.4 2008/12/17 18:47:08 raeburn Exp $
+# $Id: lonmeta.pm,v 1.221 2008/12/13 21:10:14 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -42,24 +42,6 @@ use Apache::lonmsg;
 use LONCAPA qw(:DEFAULT :match);
 
 
-############################################################
-############################################################
-##
-## &get_dynamic_metadata_from_sql($url)
-## 
-## Queries sql database for dynamic metdata
-## Returns a hash of hashes, with keys of urls which match $url
-## Returned fields are given below.
-##
-## Examples:
-## 
-## %DynamicMetadata = &Apache::lonmeta::get_dynmaic_metadata_from_sql
-##     ('/res/msu/korte/');
-##
-## $DynamicMetadata{'/res/msu/korte/example.problem'}->{$field}
-##
-############################################################
-############################################################
 sub get_dynamic_metadata_from_sql {
     my ($url) = shift();
     my ($authordom,$author)=($url=~m{^/res/($match_domain)/($match_username)/});
@@ -574,9 +556,9 @@ sub selectbox {
     }
     my $selout='<select name="'.$name.'">';
     foreach my $id (@idlist) {
-        $selout.='<option value="'.$id.'"';
+        $selout.='<option value=\''.$id.'\'';
         if ($id eq $value) {
-	    $selout.=' selected>'.&{$functionref}($_).'</option>';
+	    $selout.=' selected>'.&{$functionref}($id).'</option>';
         } else {
             $selout.='>'.&{$functionref}($id).'</option>';
         }
@@ -812,7 +794,7 @@ sub handler {
 						 {'domain' => $resdomain,}));
         &present_editable_metadata($r,$uri);
     } else {
-        $r->print(&Apache::loncommon::start_page('Catalog Information',
+        $r->print(&Apache::loncommon::start_page('Metadata',
 						 undef,
 						 {'domain' => $resdomain,}));
         &present_uneditable_metadata($r,$uri);
@@ -945,26 +927,22 @@ sub present_uneditable_metadata {
 		   'obsolete', 
 		   'obsoletereplacement');
     }
-    my $rownum = 0;
     foreach my $field (@fields) {
-        my $lastrow = '';
-        $rownum ++;
-        $lastrow = 1 if ($rownum == @fields);
         $table.=&Apache::lonhtmlcommon::row_title($lt{$field})
-                .&prettyprint($field,$content{$field})
-                .&Apache::lonhtmlcommon::row_closure($lastrow);
+               .&prettyprint($field,$content{$field})
+               .&Apache::lonhtmlcommon::row_closure();
         delete($content{$field});
     }
     #
     $r->print("<h2>$title</h2>"
-              .'<p>'
-              .$disuri.'<br />'
-              .$obsoletewarning
-              .$versiondisplay
-              .'</p>'
-              .&Apache::lonhtmlcommon::start_pick_box()
-              .$table
-              .&Apache::lonhtmlcommon::end_pick_box()
+             .'<p>'
+             .$disuri.'<br />'
+             .$obsoletewarning
+             .$versiondisplay
+             .'</p>'
+             .&Apache::lonhtmlcommon::start_pick_box()
+             .$table
+             .&Apache::lonhtmlcommon::end_pick_box()
     );
     if (!$uploaded && $env{'user.adv'}) {
         &print_dynamic_metadata($r,$uri,\%content);
@@ -993,17 +971,14 @@ sub print_dynamic_metadata {
         exists($dynmeta{'course'})) {
         $r->print('<h4>'.&mt('Access and Usage Statistics').'</h4>'.
                   &Apache::lonhtmlcommon::start_pick_box());
-        my @counts = ('count','sequsage','sequsage_list',
-                      'comefrom','comefrom_list','goto',
-                      'goto_list','course','course_list');
-        my $rownum = 0;
-        foreach my $item (@counts) {
-            my $lastrow = '';
-            $rownum ++;
-            $lastrow = 1 if ($rownum == @counts);
+        foreach my $item ('count',
+                          'sequsage','sequsage_list',
+                          'comefrom','comefrom_list',
+                          'goto','goto_list',
+                          'course','course_list') {
             $r->print(&Apache::lonhtmlcommon::row_title($lt{$item})
-                      .&prettyprint($item,$dynmeta{$item})
-                      .&Apache::lonhtmlcommon::row_closure($lastrow)
+                     .&prettyprint($item,$dynmeta{$item})
+                     .&Apache::lonhtmlcommon::row_closure()
             );
         }
         $r->print(&Apache::lonhtmlcommon::end_pick_box());
@@ -1023,21 +998,16 @@ sub print_dynamic_metadata {
                       '</h4>'.
                       &Apache::lonhtmlcommon::start_pick_box());
             $r->print(&Apache::lonhtmlcommon::row_title($lt{'stdno'})
-                      .&prettyprint('stdno',$dynmeta{'stdno'})
-                      .&Apache::lonhtmlcommon::row_closure()
+                     .&prettyprint('stdno',$dynmeta{'stdno'})
+                     .&Apache::lonhtmlcommon::row_closure()
             );
-            my @stats = ('avetries','difficulty','disc');
-            my $rownum = 0;
-            foreach my $item (@stats) {
-                my $lastrow = '';
-                $rownum ++;
-                $lastrow = 1 if ($rownum == @stats);
+            foreach my $item ('avetries','difficulty','disc') {
                 $r->print(&Apache::lonhtmlcommon::row_title($lt{$item})
-                          .&prettyprint($item,sprintf('%5.2f',$dynmeta{$item}))
-                          .&Apache::lonhtmlcommon::row_closure($lastrow)
+                         .&prettyprint($item,sprintf('%5.2f',$dynmeta{$item}))
+                         .&Apache::lonhtmlcommon::row_closure()
                 );
             }
-            $r->print(&Apache::lonhtmlcommon::end_pick_box());    
+            $r->print(&Apache::lonhtmlcommon::end_pick_box());
         }
         if (exists($dynmeta{'stats'})) {
             #
@@ -1046,15 +1016,15 @@ sub print_dynamic_metadata {
                       &mt('Recent Detailed Assessment Statistical Data').
                       '</h4>');
             my $table=&Apache::loncommon::start_data_table()
-                      .&Apache::loncommon::start_data_table_header_row()
-                      .'<th>'.&mt('Course').'</th>'
-                      .'<th>'.&mt('Section(s)').'</th>'
-                      .'<th>'.&mt('Num Student').'s</th>'
-                      .'<th>'.&mt('Mean Tries').'</th>'
-                      .'<th>'.&mt('Degree of Difficulty').'</th>'
-                      .'<th>'.&mt('Degree of Discrimination').'</th>'
-                      .'<th>'.&mt('Time of computation').'</th>'
-                      .&Apache::loncommon::end_data_table_header_row().$/;
+                     .&Apache::loncommon::start_data_table_header_row()
+                     .'<th>'.&mt('Course').'</th>'
+                     .'<th>'.&mt('Section(s)').'</th>'
+                     .'<th>'.&mt('Num Students').'</th>'
+                     .'<th>'.&mt('Mean Tries').'</th>'
+                     .'<th>'.&mt('Degree of Difficulty').'</th>'
+                     .'<th>'.&mt('Degree of Discrimination').'</th>'
+                     .'<th>'.&mt('Time of computation').'</th>'
+                     .&Apache::loncommon::end_data_table_header_row().$/;
             foreach my $identifier (sort(keys(%{$dynmeta{'stats'}}))) {
                 my $data = $dynmeta{'stats'}->{$identifier};
                 my $course = $data->{'course'};
@@ -1107,15 +1077,10 @@ sub print_dynamic_metadata {
         exists($dynmeta{'technical'})){ 
         $r->print('<h4>'.&mt('Evaluation Data').'</h4>'.
                   &Apache::lonhtmlcommon::start_pick_box());
-        my @criteria = ('clear','depth','helpful','correct','technical');
-        my $rownum = 0;
-        foreach my $item (@criteria) {
-            my $lastrow = '';
-            $rownum ++;
-            $lastrow = 1 if ($rownum == @criteria);
+        foreach my $item ('clear','depth','helpful','correct','technical') {
             $r->print(&Apache::lonhtmlcommon::row_title($lt{$item})
-                      .&prettyprint($item,$dynmeta{$item})
-                      .&Apache::lonhtmlcommon::row_closure($lastrow)
+                     .&prettyprint($item,$dynmeta{$item})
+                     .&Apache::lonhtmlcommon::row_closure()
             );
         }
         $r->print(&Apache::lonhtmlcommon::end_pick_box());
@@ -1148,19 +1113,8 @@ sub print_dynamic_metadata {
               &mt('Additional Metadata (non-standard, parameters, exports)').
               '</h3>');
     $r->print(&Apache::lonhtmlcommon::start_pick_box());
-    my @names;
-    foreach my $key (sort(keys(%content))) {
-        if ($key!~/\.display$/) {
-            push(@names,$key);
-        }
-    }
-    if (@names > 0) {
-        my $rownum = 0;
-        foreach my $name (@names) {
-            my $lastrow = '';
-            $rownum ++;
-            $lastrow = 1 if ($rownum == @names);
-
+    foreach my $name (sort(keys(%content))) {
+        if ($name!~/\.display$/) {
             my $display=&Apache::lonnet::metadata($uri,
                                                   $name.'.display');
             if (! $display) { 
@@ -1176,11 +1130,12 @@ sub print_dynamic_metadata {
                 }
             }
             $r->print(&Apache::lonhtmlcommon::row_title($display)
-                      .$content{$name});
+                     .$content{$name}
+            );
             if ($otherinfo) {
                 $r->print(' ('.$otherinfo.')');
             }
-            $r->print(&Apache::lonhtmlcommon::row_closure($lastrow));
+            $r->print(&Apache::lonhtmlcommon::row_closure());
         }
     }
     $r->print(&Apache::lonhtmlcommon::end_pick_box());
@@ -1255,11 +1210,11 @@ ENDDEL
 	}
 	$r->print('<br />'.$bombs);
     } else {
-        my $displayfile=&mt('Catalog Information for [_1]',$disuri);
+        my $displayfile=&mt('Metadata for [_1]',$disuri);
         if ($disuri=~/\/default$/) {
             my $dir=$disuri;
             $dir=~s/default$//;
-            $displayfile=&mt('Default Cataloging Information for Directory [_1]',$dir);
+            $displayfile=&mt('Default Metadata for Directory [_1]',$dir);
         }
         %Apache::lonpublisher::metadatafields=();
         %Apache::lonpublisher::metadatakeys=();
@@ -1422,8 +1377,8 @@ ENDEDIT
             my ($outcome,$result) = &store_metadata($fn,$uri,'store');
             $r->print($result);
 	}
-	$r->print($output.'<br /><input type="submit" name="store" value="'.
-                  &mt('Save Catalog Information').'" />');
+	$r->print($output.'<br /><input type="submit" title="'.&mt('Save Metadata').'" name="store" value="'.
+                  &mt('Save').'" />');
 
 	if ($file_type eq 'portfolio' || $file_type eq 'groups') {
 	    my ($port_path,$group) = &get_port_path_and_group($uri);
@@ -1588,3 +1543,95 @@ sub update_metadata_table {
 1;
 __END__
 
+
+=head1 NAME
+
+Apache::lonmeta - display meta data
+
+=head1 SYNOPSIS
+
+Handler to display meta data
+
+This is part of the LearningOnline Network with CAPA project
+described at http://www.lon-capa.org.
+
+=head1 SUBROUTINES
+
+=over
+
+=item &get_dynamic_metadata_from_sql($url) :
+
+Queries sql database for dynamic metdata
+Returns a hash of hashes, with keys of urls which match $url
+Returned fields are given below.
+
+Examples:
+
+    %DynamicMetadata = &Apache::lonmeta::get_dynmaic_metadata_from_sql
+    ('/res/msu/korte/');
+
+    $DynamicMetadata{'/res/msu/korte/example.problem'}->{$field}
+
+=item dynamicmeta()
+
+Fetch and evaluate dynamic metadata
+
+=item access_count()
+
+=item alttag()
+
+Try to make an alt tag if there is none
+
+=item authordisplay()
+
+Author display
+
+=item evalgraph()
+
+Pretty display
+
+=item diffgraph()
+
+=item fieldnames()
+
+=item portfolio_linked_path()
+
+=item get_port_path_and_group()
+
+=item portfolio_display_uri()
+
+=item pre_select_course()
+
+=item select_course()
+
+=item prettyprint()
+
+Pretty printing of metadata field
+
+=item direct()
+
+Pretty input of metadata field
+
+=item selectbox()
+
+=item relatedfield()
+
+=item prettyinput()
+
+=item report_bombs()
+
+=item present_uneditable_metadata()
+
+=item present_editable_metadata()
+
+=item store_metadata()
+
+=item store_transferred_addedfields()
+
+=item store_portfolio_metadata()
+
+=item update_metadata_table()
+
+=back
+
+=cut